Skip to content

Revert "[flutter_test] Adds method to mock EventChannels" - #124401

Merged
zanderso merged 1 commit into
masterfrom
revert-123726-mock-event-channel
Apr 7, 2023
Merged

Revert "[flutter_test] Adds method to mock EventChannels"#124401
zanderso merged 1 commit into
masterfrom
revert-123726-mock-event-channel

Conversation

@zanderso

@zanderso zanderso commented Apr 7, 2023

Copy link
Copy Markdown
Member

@flutter-dashboard flutter-dashboard Bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Apr 7, 2023
@zanderso

zanderso commented Apr 7, 2023

Copy link
Copy Markdown
Member Author

cc @Rexios80

goderbauer
goderbauer approved these changes Apr 7, 2023
View reviewed changes

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer

goderbauer commented Apr 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@Rexios80 Looks like your branch may have been outdated and didn't have these deprecations yet.

   info • 'handlePlatformMessage' is deprecated and shouldn't be used. Instead of calling this method, use ServicesBinding.instance.channelBuffers.push. In tests, consider using tester.binding.defaultBinaryMessenger.handlePlatformMessage or TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger.handlePlatformMessage. This feature was deprecated after v3.9.0-19.0.pre • packages/flutter_test/lib/src/test_default_binary_messenger.dart:365:46 • deprecated_member_use
   info • 'handlePlatformMessage' is deprecated and shouldn't be used. Instead of calling this method, use ServicesBinding.instance.channelBuffers.push. In tests, consider using tester.binding.defaultBinaryMessenger.handlePlatformMessage or TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger.handlePlatformMessage. This feature was deprecated after v3.9.0-19.0.pre • packages/flutter_test/lib/src/test_default_binary_messenger.dart:376:31 • deprecated_member_use
   info • 'handlePlatformMessage' is deprecated and shouldn't be used. Instead of calling this method, use ServicesBinding.instance.channelBuffers.push. In tests, consider using tester.binding.defaultBinaryMessenger.handlePlatformMessage or TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger.handlePlatformMessage. This feature was deprecated after v3.9.0-19.0.pre • packages/flutter_test/lib/src/test_default_binary_messenger.dart:386:46 • deprecated_member_use

@Rexios80

Rexios80 commented Apr 7, 2023

Copy link
Copy Markdown
Member

I thought I avoided the deprecated methods. How do we continue? Do I need to make a new PR?

@pdblasi-google

pdblasi-google commented Apr 7, 2023

Copy link
Copy Markdown
Contributor

@Rexios80

It was likely an indirect conflict with a different recent merge that only became apparent after merging. You'll have to make a new PR that avoids the method mentioned in the analyzer.

Relands typically move a lot faster though as the main code usually doesn't need to change much to resolve the issue.

@zanderso
zanderso merged commit 2f4a6af into master Apr 7, 2023
@zanderso
zanderso deleted the revert-123726-mock-event-channel branch April 7, 2023 17:10
@Rexios80 Rexios80 mentioned this pull request Apr 7, 2023
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2023
@engine-flutter-autoroll
2f4a6af Revert "[flutter_test] Adds method to mock EventChannels" (fl…
23d5c40 
…utter/flutter#124401)
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@zanderso @exaby73
Revert "[flutter_test] Adds method to mock EventChannels" (flutter#12…
e78290a 
…4401)

Reverts flutter#123726

Analysis failures on CI
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20analyze/12890/overview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes
@pdblasi-google pdblasi-google Awaiting requested review from pdblasi-google

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zanderso @goderbauer @Rexios80 @pdblasi-google