[InputDatePickerFormField] adds acceptEmptyDate to InputDatePickerFormField Widget by piedcipher · Pull Request #124143 · flutter/flutter

piedcipher · 2023-04-04T19:08:24Z

Adds acceptEmptyDate property to InputDatePickerFormField.

`acceptEmptyDate` is false	`acceptEmptyDate` is true

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

HansMuller

LGTM. I will land this when it's green again.

auto-submit · 2023-04-17T23:22:13Z

auto label is removed for flutter/flutter, pr: 124143, due to This PR has not met approval requirements for merging. You have project association CONTRIBUTOR and need 1 more review(s) in order to merge this PR.

Merge guidelines: You need at least one approved review if you are already a MEMBER or two member reviews if you are not a MEMBER before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2023-04-17T23:22:13Z

auto label is removed for flutter/flutter, pr: 124143, due to Validations Fail.

piedcipher · 2023-04-18T04:37:03Z

auto label is removed for flutter/flutter, pr: 124143, due to This PR has not met approval requirements for merging. You have project association CONTRIBUTOR and need 1 more review(s) in order to merge this PR.

Merge guidelines: You need at least one approved review if you are already a MEMBER or two member reviews if you are not a MEMBER before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

This pr needs one more approval. Can I please get one?

werainkhatri

LGTM. thanks for the contribution!

piedcipher · 2023-04-18T05:50:59Z

Thank you Viren 💙

….dart

…ickerFormField Widget (flutter/flutter#124143)

flutter/flutter@15cb1f8...42fb0b2 2023-04-18 [email protected] Fix text theme dart fix cases (flutter/flutter#125052) 2023-04-18 [email protected] Update the copy icon in snippets and samples to use the standard one (flutter/flutter#123651) 2023-04-18 [email protected] Remove unused context parameter (flutter/flutter#124254) 2023-04-18 [email protected] iOS spell check cursor placement (flutter/flutter#124875) 2023-04-18 [email protected] Roll Flutter Engine from d2973619074e to 55bb065c607b (1 revision) (flutter/flutter#125047) 2023-04-18 [email protected] Stop running "_impeller_" benchmark variants (flutter/flutter#125044) 2023-04-18 [email protected] Roll Packages from 0277f2a to faf53fb (7 revisions) (flutter/flutter#125040) 2023-04-18 [email protected] Roll Flutter Engine from c4396f9f602f to d2973619074e (6 revisions) (flutter/flutter#125039) 2023-04-18 [email protected] Roll pub packages (flutter/flutter#125005) 2023-04-18 [email protected] [InputDatePickerFormField] adds acceptEmptyDate to InputDatePickerFormField Widget (flutter/flutter#124143) 2023-04-18 [email protected] relayout active ListWheelScrollView children every performLayout (flutter/flutter#124476) 2023-04-18 [email protected] Roll Flutter Engine from 4a603aaff32e to c4396f9f602f (2 revisions) (flutter/flutter#125007) 2023-04-18 [email protected] Roll Flutter Engine from 20034a8d62c4 to 4a603aaff32e (2 revisions) (flutter/flutter#125004) 2023-04-18 [email protected] Add optional axis specifier to static scrollable methods (flutter/flutter#124894) 2023-04-17 [email protected] Update usage of standalone`pub` executable in flutter_tools testing docs (flutter/flutter#124898) 2023-04-17 [email protected] Add Harish Anbalagan to AUTHORS (flutter/flutter#124684) 2023-04-17 [email protected] Roll Flutter Engine from b2d07388ceb6 to 20034a8d62c4 (7 revisions) (flutter/flutter#125001) 2023-04-17 [email protected] Add an example for SearchBar (flutter/flutter#124992) 2023-04-17 [email protected] SelectionContainer's listeners can remove itself during listener callâ�¦ (flutter/flutter#124624) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/flutter@15cb1f8...42fb0b2 2023-04-18 [email protected] Fix text theme dart fix cases (flutter/flutter#125052) 2023-04-18 [email protected] Update the copy icon in snippets and samples to use the standard one (flutter/flutter#123651) 2023-04-18 [email protected] Remove unused context parameter (flutter/flutter#124254) 2023-04-18 [email protected] iOS spell check cursor placement (flutter/flutter#124875) 2023-04-18 [email protected] Roll Flutter Engine from d2973619074e to 55bb065c607b (1 revision) (flutter/flutter#125047) 2023-04-18 [email protected] Stop running "_impeller_" benchmark variants (flutter/flutter#125044) 2023-04-18 [email protected] Roll Packages from 0300012 to 2f145e4 (7 revisions) (flutter/flutter#125040) 2023-04-18 [email protected] Roll Flutter Engine from c4396f9f602f to d2973619074e (6 revisions) (flutter/flutter#125039) 2023-04-18 [email protected] Roll pub packages (flutter/flutter#125005) 2023-04-18 [email protected] [InputDatePickerFormField] adds acceptEmptyDate to InputDatePickerFormField Widget (flutter/flutter#124143) 2023-04-18 [email protected] relayout active ListWheelScrollView children every performLayout (flutter/flutter#124476) 2023-04-18 [email protected] Roll Flutter Engine from 4a603aaff32e to c4396f9f602f (2 revisions) (flutter/flutter#125007) 2023-04-18 [email protected] Roll Flutter Engine from 20034a8d62c4 to 4a603aaff32e (2 revisions) (flutter/flutter#125004) 2023-04-18 [email protected] Add optional axis specifier to static scrollable methods (flutter/flutter#124894) 2023-04-17 [email protected] Update usage of standalone`pub` executable in flutter_tools testing docs (flutter/flutter#124898) 2023-04-17 [email protected] Add Harish Anbalagan to AUTHORS (flutter/flutter#124684) 2023-04-17 [email protected] Roll Flutter Engine from b2d07388ceb6 to 20034a8d62c4 (7 revisions) (flutter/flutter#125001) 2023-04-17 [email protected] Add an example for SearchBar (flutter/flutter#124992) 2023-04-17 [email protected] SelectionContainer's listeners can remove itself during listener callâ�¦ (flutter/flutter#124624) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Apr 4, 2023

HansMuller self-requested a review April 7, 2023 21:43

HansMuller reviewed Apr 17, 2023

View reviewed changes

Comment thread packages/flutter/lib/src/material/input_date_picker_form_field.dart Outdated

HansMuller approved these changes Apr 17, 2023

View reviewed changes

HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2023

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2023

werainkhatri approved these changes Apr 18, 2023

View reviewed changes

werainkhatri added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2023

piedcipher and others added 4 commits April 18, 2023 13:23

add a new property acceptEmptyDate

17dec89

add widget-tests for acceptEmptyDate

aa6181b

correct the doc comment

be6021e

Update packages/flutter/lib/src/material/input_date_picker_form_field…

2f95b9c

….dart

auto-submit Bot merged commit 5de716f into flutter:master Apr 18, 2023

piedcipher deleted the enhancement/input_date_picker_form_field branch April 18, 2023 09:48

engine-flutter-autoroll mentioned this pull request Apr 18, 2023

Roll Flutter from 15cb1f84d726 to b0346b295347 (11 revisions) flutter/packages#3754

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2023

5de716f [InputDatePickerFormField] adds acceptEmptyDate to InputDateP…

7819e96

…ickerFormField Widget (flutter/flutter#124143)

engine-flutter-autoroll mentioned this pull request Apr 18, 2023

Roll Flutter from 15cb1f84d726 to ec02eb35ad12 (12 revisions) flutter/packages#3755

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2023

5de716f [InputDatePickerFormField] adds acceptEmptyDate to InputDateP…

7a276be

…ickerFormField Widget (flutter/flutter#124143)

engine-flutter-autoroll mentioned this pull request Apr 18, 2023

Roll Flutter from 15cb1f84d726 to 42fb0b23139c (19 revisions) flutter/packages#3756

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2023

5de716f [InputDatePickerFormField] adds acceptEmptyDate to InputDateP…

c3ae6e4

…ickerFormField Widget (flutter/flutter#124143)

This was referenced Apr 20, 2023

i123636 android embedding v2 agp gradle kotlin update #125256

Closed

[integration_test] add support for agp8.0 #125310

Closed

HansMuller mentioned this pull request Apr 21, 2023

Flutter Framework Team: Notable Commits #121415

Closed

reidbaker mentioned this pull request Apr 21, 2023

Test AGP 8.0 using java 17 #125323

Merged

8 tasks done

Navigation Menu

Repository navigation

[InputDatePickerFormField] adds acceptEmptyDate to InputDatePickerFormField Widget - #124143

[InputDatePickerFormField] adds acceptEmptyDate to InputDatePickerFormField Widget#124143
auto-submit[bot] merged 4 commits into
flutter:masterfrom
piedcipher:enhancement/input_date_picker_form_field

piedcipher commented Apr 4, 2023

Uh oh!

Uh oh!

HansMuller left a comment

Uh oh!

auto-submit Bot commented Apr 17, 2023

Uh oh!

auto-submit Bot commented Apr 17, 2023

Uh oh!

piedcipher commented Apr 18, 2023 •

edited

Loading

Uh oh!

werainkhatri left a comment •

edited

Loading

Uh oh!

piedcipher commented Apr 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

piedcipher commented Apr 4, 2023

Pre-launch Checklist

Uh oh!

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Apr 17, 2023

Uh oh!

auto-submit Bot commented Apr 17, 2023

Uh oh!

piedcipher commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

werainkhatri left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

piedcipher commented Apr 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

piedcipher commented Apr 18, 2023 •

edited

Loading

werainkhatri left a comment •

edited

Loading