iOS spell check cursor placement by justinmc · Pull Request #124875 · flutter/flutter

justinmc · 2023-04-14T17:36:39Z

Previously, the cursor might be put in the wrong place after choosing a spell check replacement on iOS. Now, it will always but put at the end of the new word.

Old	New

Fixes #124405

camsim99

Nice fix! Just left a question

camsim99 · 2023-04-17T23:46:21Z

      }
    });
    editableTextState.hideToolbar();
-    editableTextState.renderEditable.selectWordEdge(cause: SelectionChangedCause.toolbar);


I'm wondering why this didn't work as expected?

This call was operating on the previous frame's TextEditingValue, so it didn't consider the userUpdateTextEditingValue call above. It was selecting the edge of the old word before that change.

flutter/flutter@15cb1f8...42fb0b2 2023-04-18 [email protected] Fix text theme dart fix cases (flutter/flutter#125052) 2023-04-18 [email protected] Update the copy icon in snippets and samples to use the standard one (flutter/flutter#123651) 2023-04-18 [email protected] Remove unused context parameter (flutter/flutter#124254) 2023-04-18 [email protected] iOS spell check cursor placement (flutter/flutter#124875) 2023-04-18 [email protected] Roll Flutter Engine from d2973619074e to 55bb065c607b (1 revision) (flutter/flutter#125047) 2023-04-18 [email protected] Stop running "_impeller_" benchmark variants (flutter/flutter#125044) 2023-04-18 [email protected] Roll Packages from 0277f2a to faf53fb (7 revisions) (flutter/flutter#125040) 2023-04-18 [email protected] Roll Flutter Engine from c4396f9f602f to d2973619074e (6 revisions) (flutter/flutter#125039) 2023-04-18 [email protected] Roll pub packages (flutter/flutter#125005) 2023-04-18 [email protected] [InputDatePickerFormField] adds acceptEmptyDate to InputDatePickerFormField Widget (flutter/flutter#124143) 2023-04-18 [email protected] relayout active ListWheelScrollView children every performLayout (flutter/flutter#124476) 2023-04-18 [email protected] Roll Flutter Engine from 4a603aaff32e to c4396f9f602f (2 revisions) (flutter/flutter#125007) 2023-04-18 [email protected] Roll Flutter Engine from 20034a8d62c4 to 4a603aaff32e (2 revisions) (flutter/flutter#125004) 2023-04-18 [email protected] Add optional axis specifier to static scrollable methods (flutter/flutter#124894) 2023-04-17 [email protected] Update usage of standalone`pub` executable in flutter_tools testing docs (flutter/flutter#124898) 2023-04-17 [email protected] Add Harish Anbalagan to AUTHORS (flutter/flutter#124684) 2023-04-17 [email protected] Roll Flutter Engine from b2d07388ceb6 to 20034a8d62c4 (7 revisions) (flutter/flutter#125001) 2023-04-17 [email protected] Add an example for SearchBar (flutter/flutter#124992) 2023-04-17 [email protected] SelectionContainer's listeners can remove itself during listener callâ�¦ (flutter/flutter#124624) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fixes the cursor location after selecting a spell check result on iOS.

@itsjustkevin

This is a cherry pick of 8 of my recent spell check bug fixes into the beta branch. 1. #124259 2. #124875 3. #124254 4. #124899 5. #124895 6. #125162 7. #124897 8. #125432 This is the behavior of spell check with these changes: | Screenshot | Video | | --- | --- | | <img src="https://user-images.githubusercontent.com/389558/234087650-bcd62c89-03e7-427d-afc5-0fe8f96a5f80.png" /> | <video src="https://user-images.githubusercontent.com/389558/234087667-651b0fde-348c-467e-ba00-27b6b3966a27.mov" /> | CC @itsjustkevin @leighajarett

flutter/flutter@15cb1f8...42fb0b2 2023-04-18 [email protected] Fix text theme dart fix cases (flutter/flutter#125052) 2023-04-18 [email protected] Update the copy icon in snippets and samples to use the standard one (flutter/flutter#123651) 2023-04-18 [email protected] Remove unused context parameter (flutter/flutter#124254) 2023-04-18 [email protected] iOS spell check cursor placement (flutter/flutter#124875) 2023-04-18 [email protected] Roll Flutter Engine from d2973619074e to 55bb065c607b (1 revision) (flutter/flutter#125047) 2023-04-18 [email protected] Stop running "_impeller_" benchmark variants (flutter/flutter#125044) 2023-04-18 [email protected] Roll Packages from 0277f2a to faf53fb (7 revisions) (flutter/flutter#125040) 2023-04-18 [email protected] Roll Flutter Engine from c4396f9f602f to d2973619074e (6 revisions) (flutter/flutter#125039) 2023-04-18 [email protected] Roll pub packages (flutter/flutter#125005) 2023-04-18 [email protected] [InputDatePickerFormField] adds acceptEmptyDate to InputDatePickerFormField Widget (flutter/flutter#124143) 2023-04-18 [email protected] relayout active ListWheelScrollView children every performLayout (flutter/flutter#124476) 2023-04-18 [email protected] Roll Flutter Engine from 4a603aaff32e to c4396f9f602f (2 revisions) (flutter/flutter#125007) 2023-04-18 [email protected] Roll Flutter Engine from 20034a8d62c4 to 4a603aaff32e (2 revisions) (flutter/flutter#125004) 2023-04-18 [email protected] Add optional axis specifier to static scrollable methods (flutter/flutter#124894) 2023-04-17 [email protected] Update usage of standalone`pub` executable in flutter_tools testing docs (flutter/flutter#124898) 2023-04-17 [email protected] Add Harish Anbalagan to AUTHORS (flutter/flutter#124684) 2023-04-17 [email protected] Roll Flutter Engine from b2d07388ceb6 to 20034a8d62c4 (7 revisions) (flutter/flutter#125001) 2023-04-17 [email protected] Add an example for SearchBar (flutter/flutter#124992) 2023-04-17 [email protected] SelectionContainer's listeners can remove itself during listener callâ�¦ (flutter/flutter#124624) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/flutter@15cb1f8...42fb0b2 2023-04-18 [email protected] Fix text theme dart fix cases (flutter/flutter#125052) 2023-04-18 [email protected] Update the copy icon in snippets and samples to use the standard one (flutter/flutter#123651) 2023-04-18 [email protected] Remove unused context parameter (flutter/flutter#124254) 2023-04-18 [email protected] iOS spell check cursor placement (flutter/flutter#124875) 2023-04-18 [email protected] Roll Flutter Engine from d2973619074e to 55bb065c607b (1 revision) (flutter/flutter#125047) 2023-04-18 [email protected] Stop running "_impeller_" benchmark variants (flutter/flutter#125044) 2023-04-18 [email protected] Roll Packages from 0300012 to 2f145e4 (7 revisions) (flutter/flutter#125040) 2023-04-18 [email protected] Roll Flutter Engine from c4396f9f602f to d2973619074e (6 revisions) (flutter/flutter#125039) 2023-04-18 [email protected] Roll pub packages (flutter/flutter#125005) 2023-04-18 [email protected] [InputDatePickerFormField] adds acceptEmptyDate to InputDatePickerFormField Widget (flutter/flutter#124143) 2023-04-18 [email protected] relayout active ListWheelScrollView children every performLayout (flutter/flutter#124476) 2023-04-18 [email protected] Roll Flutter Engine from 4a603aaff32e to c4396f9f602f (2 revisions) (flutter/flutter#125007) 2023-04-18 [email protected] Roll Flutter Engine from 20034a8d62c4 to 4a603aaff32e (2 revisions) (flutter/flutter#125004) 2023-04-18 [email protected] Add optional axis specifier to static scrollable methods (flutter/flutter#124894) 2023-04-17 [email protected] Update usage of standalone`pub` executable in flutter_tools testing docs (flutter/flutter#124898) 2023-04-17 [email protected] Add Harish Anbalagan to AUTHORS (flutter/flutter#124684) 2023-04-17 [email protected] Roll Flutter Engine from b2d07388ceb6 to 20034a8d62c4 (7 revisions) (flutter/flutter#125001) 2023-04-17 [email protected] Add an example for SearchBar (flutter/flutter#124992) 2023-04-17 [email protected] SelectionContainer's listeners can remove itself during listener callâ�¦ (flutter/flutter#124624) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Place the cursor after a replacement

e63d92e

justinmc requested a review from camsim99 April 14, 2023 17:36

justinmc self-assigned this Apr 14, 2023

flutter-dashboard Bot added p: cupertino_ui cupertino_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Apr 14, 2023

Test

f1d00a5

justinmc marked this pull request as ready for review April 14, 2023 18:16

camsim99 approved these changes Apr 17, 2023

View reviewed changes

Merge branch 'master' into spell-check-cupertino-edge

fc9f354

justinmc merged commit 39becb7 into flutter:master Apr 18, 2023

justinmc deleted the spell-check-cupertino-edge branch April 18, 2023 17:18

engine-flutter-autoroll mentioned this pull request Apr 18, 2023

Roll Flutter from 15cb1f84d726 to 42fb0b23139c (19 revisions) flutter/packages#3756

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2023

39becb7 iOS spell check cursor placement (flutter/flutter#124875)

9348f44

This was referenced Apr 20, 2023

i123636 android embedding v2 agp gradle kotlin update #125256

Closed

[integration_test] add support for agp8.0 #125310

Closed

HansMuller mentioned this pull request Apr 21, 2023

Flutter Framework Team: Notable Commits #121415

Closed

reidbaker mentioned this pull request Apr 21, 2023

Test AGP 8.0 using java 17 #125323

Merged

8 tasks done

justinmc added a commit to justinmc/flutter that referenced this pull request Apr 25, 2023

iOS spell check cursor placement (flutter#124875)

295d867

Fixes the cursor location after selecting a spell check result on iOS.

justinmc mentioned this pull request Apr 25, 2023

Cherry Pick Spell Check Fixes #125517

Merged

Navigation Menu

Repository navigation

iOS spell check cursor placement - #124875

iOS spell check cursor placement#124875
justinmc merged 3 commits into
flutter:masterfrom
justinmc:spell-check-cupertino-edge

justinmc commented Apr 14, 2023 •

edited

Loading

Uh oh!

camsim99 left a comment

Uh oh!

camsim99 Apr 17, 2023

Uh oh!

justinmc Apr 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

justinmc commented Apr 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

camsim99 Apr 17, 2023

Choose a reason for hiding this comment

Uh oh!

justinmc Apr 18, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

justinmc commented Apr 14, 2023 •

edited

Loading