Repository navigation
Added CupertinoDatepicker monthYear mode (flutter#93508) - #125603
Merged
auto-submit[bot] merged 39 commits intoMay 5, 2023
Merged
Conversation
…/flutter into date_picker_month_year
flutter-dashboard
Bot
added
the
p: cupertino_ui
Contributor
Author
|
Thank you Mitchell! I updated the dateOrder documentation, noting that there are multiple DatePickerDateOrder options that result in the same column order. |
MitchellGoodwin
approved these changes
Apr 28, 2023
MitchellGoodwin
left a comment
MitchellGoodwin
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you for taking the time to do this!
justinmc
approved these changes
May 1, 2023
justinmc
left a comment
justinmc
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍. Thanks for the solid PR and all of the tests!
The Google testing failure seems like it might be unrelated... Could you push a merge commit @lindsaypj?
…/flutter into date_picker_month_year
Contributor
|
@lindsaypj it looks like the google testing is stuck. Would you mind rebasing in order to restart it? That's normally the most reliable method. |
Contributor
Author
|
I'm not sure how, but I added commits from master. I created another branch from commit 4f8a45d. Should I just create another PR, or is there a way to easily remove all the additional commits I created in my failed rebase attempt? Edit: Actually I managed to revert back to before the rebase. If the google test still doesn't resolve, I will try the rebase again. I was shown the correct way to do it. |
lindsaypj
force-pushed
the
date_picker_month_year
branch
from
May 5, 2023 19:02
b308c76 to
4f8a45d
Compare
MitchellGoodwin
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 6, 2023
tarrinneal
pushed a commit
to flutter/packages
that referenced
this pull request
May 6, 2023
Manual roll Flutter from 0b65723 to 43ac23b (30 revisions) Manual roll requested by [email protected] flutter/flutter@0b65723...43ac23b 2023-05-05 [email protected] targets/web.dart - fix typo (flutter/flutter#126114) 2023-05-05 [email protected] Roll Flutter Engine from 6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175) 2023-05-05 [email protected] add tests for dominant bottom sheet in scaffold (flutter/flutter#124472) 2023-05-05 [email protected] Added CupertinoDatepicker monthYear mode (flutter#93508) (flutter/flutter#125603) 2023-05-05 [email protected] Add `Switch.trackOutlineWidth` property (flutter/flutter#125848) 2023-05-05 [email protected] Rename iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173) 2023-05-05 [email protected] Roll Flutter Engine from f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174) 2023-05-05 [email protected] improvement : removed required kotlin dependency (flutter/flutter#125002) 2023-05-05 [email protected] Fix incorrect assert hint in flutter.groovy (flutter/flutter#125283) 2023-05-05 [email protected] Update .cirrus.yml (flutter/flutter#126166) 2023-05-05 [email protected] tool: replace top-level functions with enum properties (flutter/flutter#126167) 2023-05-05 [email protected] Use direct dart API from `dart:ui_web` rather than JS shim. (flutter/flutter#123443) 2023-05-05 [email protected] Add sample code for SliverAppBar (flutter/flutter#125785) 2023-05-05 [email protected] Roll Flutter Engine from cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163) 2023-05-05 [email protected] Add a ReorderableListView example with cards + cleanup existing tests (flutter/flutter#126155) 2023-05-05 [email protected] Roll Packages from 6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161) 2023-05-05 [email protected] Bring back the failing build_test's (flutter/flutter#126014) 2023-05-05 [email protected] [web] Use plain platform views in benchmarks (flutter/flutter#126080) 2023-05-05 [email protected] Fix Material 3 tab indicator weight and position (flutter/flutter#125883) 2023-05-05 [email protected] Roll Flutter Engine from b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150) 2023-05-05 [email protected] Roll Flutter Engine from 6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148) 2023-05-05 [email protected] Roll Flutter Engine from 764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141) 2023-05-05 [email protected] Roll Flutter Engine from e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137) 2023-05-05 [email protected] Roll Flutter Engine from a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135) 2023-05-05 [email protected] Roll Flutter Engine from c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129) 2023-05-05 [email protected] [NavigationDrawer] adds padding property in NavigationDrawer Widget (flutter/flutter#123961) 2023-05-05 [email protected] Roll Flutter Engine from 269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124) 2023-05-05 [email protected] Roll Flutter Engine from 4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115) 2023-05-05 [email protected] Minor fixes found while working on blankcanvas (flutter/flutter#125751) 2023-05-05 [email protected] tool-web: use ProcessUtil.run to invoke child processes (flutter/flutter#126109) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
) Manual roll Flutter from 0b65723 to 43ac23b (30 revisions) Manual roll requested by [email protected] flutter/flutter@0b65723...43ac23b 2023-05-05 [email protected] targets/web.dart - fix typo (flutter/flutter#126114) 2023-05-05 [email protected] Roll Flutter Engine from 6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175) 2023-05-05 [email protected] add tests for dominant bottom sheet in scaffold (flutter/flutter#124472) 2023-05-05 [email protected] Added CupertinoDatepicker monthYear mode (flutter#93508) (flutter/flutter#125603) 2023-05-05 [email protected] Add `Switch.trackOutlineWidth` property (flutter/flutter#125848) 2023-05-05 [email protected] Rename iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173) 2023-05-05 [email protected] Roll Flutter Engine from f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174) 2023-05-05 [email protected] improvement : removed required kotlin dependency (flutter/flutter#125002) 2023-05-05 [email protected] Fix incorrect assert hint in flutter.groovy (flutter/flutter#125283) 2023-05-05 [email protected] Update .cirrus.yml (flutter/flutter#126166) 2023-05-05 [email protected] tool: replace top-level functions with enum properties (flutter/flutter#126167) 2023-05-05 [email protected] Use direct dart API from `dart:ui_web` rather than JS shim. (flutter/flutter#123443) 2023-05-05 [email protected] Add sample code for SliverAppBar (flutter/flutter#125785) 2023-05-05 [email protected] Roll Flutter Engine from cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163) 2023-05-05 [email protected] Add a ReorderableListView example with cards + cleanup existing tests (flutter/flutter#126155) 2023-05-05 [email protected] Roll Packages from 6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161) 2023-05-05 [email protected] Bring back the failing build_test's (flutter/flutter#126014) 2023-05-05 [email protected] [web] Use plain platform views in benchmarks (flutter/flutter#126080) 2023-05-05 [email protected] Fix Material 3 tab indicator weight and position (flutter/flutter#125883) 2023-05-05 [email protected] Roll Flutter Engine from b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150) 2023-05-05 [email protected] Roll Flutter Engine from 6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148) 2023-05-05 [email protected] Roll Flutter Engine from 764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141) 2023-05-05 [email protected] Roll Flutter Engine from e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137) 2023-05-05 [email protected] Roll Flutter Engine from a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135) 2023-05-05 [email protected] Roll Flutter Engine from c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129) 2023-05-05 [email protected] [NavigationDrawer] adds padding property in NavigationDrawer Widget (flutter/flutter#123961) 2023-05-05 [email protected] Roll Flutter Engine from 269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124) 2023-05-05 [email protected] Roll Flutter Engine from 4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115) 2023-05-05 [email protected] Minor fixes found while working on blankcanvas (flutter/flutter#125751) 2023-05-05 [email protected] tool-web: use ProcessUtil.run to invoke child processes (flutter/flutter#126109) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
) Manual roll Flutter from 0b65723 to 43ac23b (30 revisions) Manual roll requested by [email protected] flutter/flutter@0b65723...43ac23b 2023-05-05 [email protected] targets/web.dart - fix typo (flutter/flutter#126114) 2023-05-05 [email protected] Roll Flutter Engine from 6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175) 2023-05-05 [email protected] add tests for dominant bottom sheet in scaffold (flutter/flutter#124472) 2023-05-05 [email protected] Added CupertinoDatepicker monthYear mode (flutter#93508) (flutter/flutter#125603) 2023-05-05 [email protected] Add `Switch.trackOutlineWidth` property (flutter/flutter#125848) 2023-05-05 [email protected] Rename iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173) 2023-05-05 [email protected] Roll Flutter Engine from f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174) 2023-05-05 [email protected] improvement : removed required kotlin dependency (flutter/flutter#125002) 2023-05-05 [email protected] Fix incorrect assert hint in flutter.groovy (flutter/flutter#125283) 2023-05-05 [email protected] Update .cirrus.yml (flutter/flutter#126166) 2023-05-05 [email protected] tool: replace top-level functions with enum properties (flutter/flutter#126167) 2023-05-05 [email protected] Use direct dart API from `dart:ui_web` rather than JS shim. (flutter/flutter#123443) 2023-05-05 [email protected] Add sample code for SliverAppBar (flutter/flutter#125785) 2023-05-05 [email protected] Roll Flutter Engine from cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163) 2023-05-05 [email protected] Add a ReorderableListView example with cards + cleanup existing tests (flutter/flutter#126155) 2023-05-05 [email protected] Roll Packages from 6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161) 2023-05-05 [email protected] Bring back the failing build_test's (flutter/flutter#126014) 2023-05-05 [email protected] [web] Use plain platform views in benchmarks (flutter/flutter#126080) 2023-05-05 [email protected] Fix Material 3 tab indicator weight and position (flutter/flutter#125883) 2023-05-05 [email protected] Roll Flutter Engine from b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150) 2023-05-05 [email protected] Roll Flutter Engine from 6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148) 2023-05-05 [email protected] Roll Flutter Engine from 764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141) 2023-05-05 [email protected] Roll Flutter Engine from e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137) 2023-05-05 [email protected] Roll Flutter Engine from a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135) 2023-05-05 [email protected] Roll Flutter Engine from c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129) 2023-05-05 [email protected] [NavigationDrawer] adds padding property in NavigationDrawer Widget (flutter/flutter#123961) 2023-05-05 [email protected] Roll Flutter Engine from 269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124) 2023-05-05 [email protected] Roll Flutter Engine from 4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115) 2023-05-05 [email protected] Minor fixes found while working on blankcanvas (flutter/flutter#125751) 2023-05-05 [email protected] tool-web: use ProcessUtil.run to invoke child processes (flutter/flutter#126109) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
) Manual roll Flutter from 0b65723 to 43ac23b (30 revisions) Manual roll requested by [email protected] flutter/flutter@0b65723...43ac23b 2023-05-05 [email protected] targets/web.dart - fix typo (flutter/flutter#126114) 2023-05-05 [email protected] Roll Flutter Engine from 6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175) 2023-05-05 [email protected] add tests for dominant bottom sheet in scaffold (flutter/flutter#124472) 2023-05-05 [email protected] Added CupertinoDatepicker monthYear mode (flutter#93508) (flutter/flutter#125603) 2023-05-05 [email protected] Add `Switch.trackOutlineWidth` property (flutter/flutter#125848) 2023-05-05 [email protected] Rename iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173) 2023-05-05 [email protected] Roll Flutter Engine from f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174) 2023-05-05 [email protected] improvement : removed required kotlin dependency (flutter/flutter#125002) 2023-05-05 [email protected] Fix incorrect assert hint in flutter.groovy (flutter/flutter#125283) 2023-05-05 [email protected] Update .cirrus.yml (flutter/flutter#126166) 2023-05-05 [email protected] tool: replace top-level functions with enum properties (flutter/flutter#126167) 2023-05-05 [email protected] Use direct dart API from `dart:ui_web` rather than JS shim. (flutter/flutter#123443) 2023-05-05 [email protected] Add sample code for SliverAppBar (flutter/flutter#125785) 2023-05-05 [email protected] Roll Flutter Engine from cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163) 2023-05-05 [email protected] Add a ReorderableListView example with cards + cleanup existing tests (flutter/flutter#126155) 2023-05-05 [email protected] Roll Packages from 7db59d8 to 7bce9f6 (4 revisions) (flutter/flutter#126161) 2023-05-05 [email protected] Bring back the failing build_test's (flutter/flutter#126014) 2023-05-05 [email protected] [web] Use plain platform views in benchmarks (flutter/flutter#126080) 2023-05-05 [email protected] Fix Material 3 tab indicator weight and position (flutter/flutter#125883) 2023-05-05 [email protected] Roll Flutter Engine from b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150) 2023-05-05 [email protected] Roll Flutter Engine from 6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148) 2023-05-05 [email protected] Roll Flutter Engine from 764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141) 2023-05-05 [email protected] Roll Flutter Engine from e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137) 2023-05-05 [email protected] Roll Flutter Engine from a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135) 2023-05-05 [email protected] Roll Flutter Engine from c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129) 2023-05-05 [email protected] [NavigationDrawer] adds padding property in NavigationDrawer Widget (flutter/flutter#123961) 2023-05-05 [email protected] Roll Flutter Engine from 269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124) 2023-05-05 [email protected] Roll Flutter Engine from 4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115) 2023-05-05 [email protected] Minor fixes found while working on blankcanvas (flutter/flutter#125751) 2023-05-05 [email protected] tool-web: use ProcessUtil.run to invoke child processes (flutter/flutter#126109) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a month and year mode to the CupertinoDatePicker. The monthYear mode is the date mode without the day of the month.
This feature was added at the request of:
[Proposal] CupertinoDatePicker with month and year. #93508
One thing that I was unsure of was the use of the DatePickerDateOrder to determine the monthYear order. It could be considered a workaround since the DatePickerDateOrder is intended to order day, month, and year. This means that a developer could use the DatePickerDateOrder.dmy (day, month, year) or DatePickerDateOrder.mdy (month, day, year) to get the same result.
At first I intended to add a DatePickerMonthYearOrder enum to the localizations, in addition to a new parameter for the CupertinoDatePicker for monthYearOrder, but I ended up reverting these changes (1c61f10) because I had not considered the effects of adding values to the localizations.
I decided it may be better to not add an additional parameter (monthYearOrder) that would go mostly unused. I am very open to feedback or ideas on this matter.
Pre-launch Checklist
///).