Skip to content

Add a ReorderableListView example with cards + cleanup existing tests - #126155

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
NevercodeHQ:add_one_reorderable_list_view_example
May 5, 2023
Merged

auto-submit[bot] merged 1 commit into
flutter:masterfrom
NevercodeHQ:add_one_reorderable_list_view_example

Conversation

@bleroux

@bleroux bleroux commented May 5, 2023

Copy link
Copy Markdown
Contributor

Description

This PR adds one ReorderableListView example to demonstrate how proxyDecorator can be used to animate cards elevation.

Capture.video.du.2023-05-05.15-12-36.mp4

For motivation, see #124729 (comment).

Related Issue

Fixes #124729

Tests

Adds 1 tests.

This PR also moves some misplaced example tests from examples/api/test/reorderable_list to examples/api/test/material/reorderable_list (and replaces two existing ones).

@flutter-dashboard flutter-dashboard Bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 5, 2023
@bleroux
bleroux requested a review from HansMuller May 5, 2023 14:44

@HansMuller HansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice example! LGTM

@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label May 5, 2023
@auto-submit
auto-submit Bot merged commit de26154 into flutter:master May 5, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023
@bleroux
bleroux deleted the add_one_reorderable_list_view_example branch May 5, 2023 18:12
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 5, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 6, 2023
tarrinneal pushed a commit to flutter/packages that referenced this pull request May 6, 2023
Manual roll Flutter from 0b65723 to 43ac23b (30 revisions)

Manual roll requested by [email protected]

flutter/flutter@0b65723...43ac23b

2023-05-05 [email protected] targets/web.dart - fix typo
(flutter/flutter#126114)
2023-05-05 [email protected] Roll Flutter Engine from
6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175)
2023-05-05 [email protected] add tests for
dominant bottom sheet in scaffold (flutter/flutter#124472)
2023-05-05 [email protected] Added
CupertinoDatepicker monthYear mode (flutter#93508)
(flutter/flutter#125603)
2023-05-05 [email protected] Add
`Switch.trackOutlineWidth` property (flutter/flutter#125848)
2023-05-05 [email protected] Rename
iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173)
2023-05-05 [email protected] Roll Flutter Engine from
f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174)
2023-05-05 [email protected] improvement :
removed required kotlin dependency (flutter/flutter#125002)
2023-05-05 [email protected] Fix incorrect assert hint in flutter.groovy
(flutter/flutter#125283)
2023-05-05 [email protected] Update
.cirrus.yml (flutter/flutter#126166)
2023-05-05 [email protected] tool: replace top-level
functions with enum properties (flutter/flutter#126167)
2023-05-05 [email protected] Use direct dart API from
`dart:ui_web` rather than JS shim. (flutter/flutter#123443)
2023-05-05 [email protected] Add sample
code for SliverAppBar (flutter/flutter#125785)
2023-05-05 [email protected] Roll Flutter Engine from
cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163)
2023-05-05 [email protected] Add a ReorderableListView example with
cards + cleanup existing tests (flutter/flutter#126155)
2023-05-05 [email protected] Roll Packages from
6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161)
2023-05-05 [email protected] Bring back
the failing build_test's (flutter/flutter#126014)
2023-05-05 [email protected] [web] Use plain platform views in
benchmarks (flutter/flutter#126080)
2023-05-05 [email protected] Fix Material 3 tab indicator weight and
position (flutter/flutter#125883)
2023-05-05 [email protected] Roll Flutter Engine from
b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150)
2023-05-05 [email protected] Roll Flutter Engine from
6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148)
2023-05-05 [email protected] Roll Flutter Engine from
764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141)
2023-05-05 [email protected] Roll Flutter Engine from
e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137)
2023-05-05 [email protected] Roll Flutter Engine from
a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135)
2023-05-05 [email protected] Roll Flutter Engine from
c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129)
2023-05-05 [email protected] [NavigationDrawer] adds padding
property in NavigationDrawer Widget (flutter/flutter#123961)
2023-05-05 [email protected] Roll Flutter Engine from
269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124)
2023-05-05 [email protected] Roll Flutter Engine from
4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115)
2023-05-05 [email protected] Minor fixes found while working on blankcanvas
(flutter/flutter#125751)
2023-05-05 [email protected] tool-web: use ProcessUtil.run
to invoke child processes (flutter/flutter#126109)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
...
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
)

Manual roll Flutter from 0b65723 to 43ac23b (30 revisions)

Manual roll requested by [email protected]

flutter/flutter@0b65723...43ac23b

2023-05-05 [email protected] targets/web.dart - fix typo
(flutter/flutter#126114)
2023-05-05 [email protected] Roll Flutter Engine from
6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175)
2023-05-05 [email protected] add tests for
dominant bottom sheet in scaffold (flutter/flutter#124472)
2023-05-05 [email protected] Added
CupertinoDatepicker monthYear mode (flutter#93508)
(flutter/flutter#125603)
2023-05-05 [email protected] Add
`Switch.trackOutlineWidth` property (flutter/flutter#125848)
2023-05-05 [email protected] Rename
iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173)
2023-05-05 [email protected] Roll Flutter Engine from
f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174)
2023-05-05 [email protected] improvement :
removed required kotlin dependency (flutter/flutter#125002)
2023-05-05 [email protected] Fix incorrect assert hint in flutter.groovy
(flutter/flutter#125283)
2023-05-05 [email protected] Update
.cirrus.yml (flutter/flutter#126166)
2023-05-05 [email protected] tool: replace top-level
functions with enum properties (flutter/flutter#126167)
2023-05-05 [email protected] Use direct dart API from
`dart:ui_web` rather than JS shim. (flutter/flutter#123443)
2023-05-05 [email protected] Add sample
code for SliverAppBar (flutter/flutter#125785)
2023-05-05 [email protected] Roll Flutter Engine from
cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163)
2023-05-05 [email protected] Add a ReorderableListView example with
cards + cleanup existing tests (flutter/flutter#126155)
2023-05-05 [email protected] Roll Packages from
6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161)
2023-05-05 [email protected] Bring back
the failing build_test's (flutter/flutter#126014)
2023-05-05 [email protected] [web] Use plain platform views in
benchmarks (flutter/flutter#126080)
2023-05-05 [email protected] Fix Material 3 tab indicator weight and
position (flutter/flutter#125883)
2023-05-05 [email protected] Roll Flutter Engine from
b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150)
2023-05-05 [email protected] Roll Flutter Engine from
6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148)
2023-05-05 [email protected] Roll Flutter Engine from
764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141)
2023-05-05 [email protected] Roll Flutter Engine from
e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137)
2023-05-05 [email protected] Roll Flutter Engine from
a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135)
2023-05-05 [email protected] Roll Flutter Engine from
c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129)
2023-05-05 [email protected] [NavigationDrawer] adds padding
property in NavigationDrawer Widget (flutter/flutter#123961)
2023-05-05 [email protected] Roll Flutter Engine from
269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124)
2023-05-05 [email protected] Roll Flutter Engine from
4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115)
2023-05-05 [email protected] Minor fixes found while working on blankcanvas
(flutter/flutter#125751)
2023-05-05 [email protected] tool-web: use ProcessUtil.run
to invoke child processes (flutter/flutter#126109)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
)

Manual roll Flutter from 0b65723 to 43ac23b (30 revisions)

Manual roll requested by [email protected]

flutter/flutter@0b65723...43ac23b

2023-05-05 [email protected] targets/web.dart - fix typo
(flutter/flutter#126114)
2023-05-05 [email protected] Roll Flutter Engine from
6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175)
2023-05-05 [email protected] add tests for
dominant bottom sheet in scaffold (flutter/flutter#124472)
2023-05-05 [email protected] Added
CupertinoDatepicker monthYear mode (flutter#93508)
(flutter/flutter#125603)
2023-05-05 [email protected] Add
`Switch.trackOutlineWidth` property (flutter/flutter#125848)
2023-05-05 [email protected] Rename
iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173)
2023-05-05 [email protected] Roll Flutter Engine from
f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174)
2023-05-05 [email protected] improvement :
removed required kotlin dependency (flutter/flutter#125002)
2023-05-05 [email protected] Fix incorrect assert hint in flutter.groovy
(flutter/flutter#125283)
2023-05-05 [email protected] Update
.cirrus.yml (flutter/flutter#126166)
2023-05-05 [email protected] tool: replace top-level
functions with enum properties (flutter/flutter#126167)
2023-05-05 [email protected] Use direct dart API from
`dart:ui_web` rather than JS shim. (flutter/flutter#123443)
2023-05-05 [email protected] Add sample
code for SliverAppBar (flutter/flutter#125785)
2023-05-05 [email protected] Roll Flutter Engine from
cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163)
2023-05-05 [email protected] Add a ReorderableListView example with
cards + cleanup existing tests (flutter/flutter#126155)
2023-05-05 [email protected] Roll Packages from
6bd59cd to a0f8fd8 (4 revisions) (flutter/flutter#126161)
2023-05-05 [email protected] Bring back
the failing build_test's (flutter/flutter#126014)
2023-05-05 [email protected] [web] Use plain platform views in
benchmarks (flutter/flutter#126080)
2023-05-05 [email protected] Fix Material 3 tab indicator weight and
position (flutter/flutter#125883)
2023-05-05 [email protected] Roll Flutter Engine from
b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150)
2023-05-05 [email protected] Roll Flutter Engine from
6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148)
2023-05-05 [email protected] Roll Flutter Engine from
764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141)
2023-05-05 [email protected] Roll Flutter Engine from
e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137)
2023-05-05 [email protected] Roll Flutter Engine from
a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135)
2023-05-05 [email protected] Roll Flutter Engine from
c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129)
2023-05-05 [email protected] [NavigationDrawer] adds padding
property in NavigationDrawer Widget (flutter/flutter#123961)
2023-05-05 [email protected] Roll Flutter Engine from
269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124)
2023-05-05 [email protected] Roll Flutter Engine from
4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115)
2023-05-05 [email protected] Minor fixes found while working on blankcanvas
(flutter/flutter#125751)
2023-05-05 [email protected] tool-web: use ProcessUtil.run
to invoke child processes (flutter/flutter#126109)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
...
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
)

Manual roll Flutter from 0b65723 to 43ac23b (30 revisions)

Manual roll requested by [email protected]

flutter/flutter@0b65723...43ac23b

2023-05-05 [email protected] targets/web.dart - fix typo
(flutter/flutter#126114)
2023-05-05 [email protected] Roll Flutter Engine from
6b467df16e11 to 758cbadfac1f (2 revisions) (flutter/flutter#126175)
2023-05-05 [email protected] add tests for
dominant bottom sheet in scaffold (flutter/flutter#124472)
2023-05-05 [email protected] Added
CupertinoDatepicker monthYear mode (flutter#93508)
(flutter/flutter#125603)
2023-05-05 [email protected] Add
`Switch.trackOutlineWidth` property (flutter/flutter#125848)
2023-05-05 [email protected] Rename
iosdeeplinksettings to iosuniversallinksettings (flutter/flutter#126173)
2023-05-05 [email protected] Roll Flutter Engine from
f3efe11f4449 to 6b467df16e11 (3 revisions) (flutter/flutter#126174)
2023-05-05 [email protected] improvement :
removed required kotlin dependency (flutter/flutter#125002)
2023-05-05 [email protected] Fix incorrect assert hint in flutter.groovy
(flutter/flutter#125283)
2023-05-05 [email protected] Update
.cirrus.yml (flutter/flutter#126166)
2023-05-05 [email protected] tool: replace top-level
functions with enum properties (flutter/flutter#126167)
2023-05-05 [email protected] Use direct dart API from
`dart:ui_web` rather than JS shim. (flutter/flutter#123443)
2023-05-05 [email protected] Add sample
code for SliverAppBar (flutter/flutter#125785)
2023-05-05 [email protected] Roll Flutter Engine from
cef0e9d1a94f to f3efe11f4449 (3 revisions) (flutter/flutter#126163)
2023-05-05 [email protected] Add a ReorderableListView example with
cards + cleanup existing tests (flutter/flutter#126155)
2023-05-05 [email protected] Roll Packages from
7db59d8 to 7bce9f6 (4 revisions) (flutter/flutter#126161)
2023-05-05 [email protected] Bring back
the failing build_test's (flutter/flutter#126014)
2023-05-05 [email protected] [web] Use plain platform views in
benchmarks (flutter/flutter#126080)
2023-05-05 [email protected] Fix Material 3 tab indicator weight and
position (flutter/flutter#125883)
2023-05-05 [email protected] Roll Flutter Engine from
b0f53e7751ad to cef0e9d1a94f (1 revision) (flutter/flutter#126150)
2023-05-05 [email protected] Roll Flutter Engine from
6f26066144fb to b0f53e7751ad (2 revisions) (flutter/flutter#126148)
2023-05-05 [email protected] Roll Flutter Engine from
764991e046c6 to 6f26066144fb (1 revision) (flutter/flutter#126141)
2023-05-05 [email protected] Roll Flutter Engine from
e7cd29153aa9 to 764991e046c6 (1 revision) (flutter/flutter#126137)
2023-05-05 [email protected] Roll Flutter Engine from
a885ed472eea to e7cd29153aa9 (1 revision) (flutter/flutter#126135)
2023-05-05 [email protected] Roll Flutter Engine from
c97a0deccbc1 to a885ed472eea (1 revision) (flutter/flutter#126129)
2023-05-05 [email protected] [NavigationDrawer] adds padding
property in NavigationDrawer Widget (flutter/flutter#123961)
2023-05-05 [email protected] Roll Flutter Engine from
269ce2deebeb to c97a0deccbc1 (1 revision) (flutter/flutter#126124)
2023-05-05 [email protected] Roll Flutter Engine from
4d5070672859 to 269ce2deebeb (16 revisions) (flutter/flutter#126115)
2023-05-05 [email protected] Minor fixes found while working on blankcanvas
(flutter/flutter#125751)
2023-05-05 [email protected] tool-web: use ProcessUtil.run
to invoke child processes (flutter/flutter#126109)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReorderableListView of Cards doesn't work as it should

2 participants