Update to valid build tools variant and update lockfiles by reidbaker · Pull Request #125825 · flutter/flutter

reidbaker · 2023-05-01T18:47:21Z

#125331

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

camsim99

LGTM :) optional suggestion is modifying ci.yaml temporarily to verify you get a successful run

reidbaker · 2023-05-08T20:03:18Z

LGTM :) optional suggestion is modifying ci.yaml temporarily to verify you get a successful run

Good idea, Updated in 1b02013

…break the tree

reidbaker · 2023-05-08T21:51:15Z

Well damn https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8781629673726734545/+/u/test_execution/Build_appbundle/stdout

flutter-dashboard · 2023-05-08T21:57:20Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

gmackall

LGTM again (looks like the web test timed out)

…tter/flutter#125825)

Manual roll requested by [email protected] flutter/flutter@f842ed9...6f09064 2023-07-17 [email protected] Stand-alone widget tree with multiple render trees to enable multi-view rendering (flutter/flutter#125003) 2023-07-17 [email protected] Update to valid build tools variant and update lockfiles (flutter/flutter#125825) 2023-07-17 [email protected] Roll Packages from 369ee7e to 6889cca (5 revisions) (flutter/flutter#130721) 2023-07-17 [email protected] [Reland] - Update `DialogTheme` tests for M2/M3 (flutter/flutter#130711) 2023-07-17 [email protected] Roll Flutter Engine from 683087731feb to e4cae43c9c7a (9 revisions) (flutter/flutter#130716) 2023-07-17 [email protected] [flutter_tools] Support coverage collection for dependencies (flutter/flutter#129513) 2023-07-17 [email protected] Fix `DatePicker` uses incorrect overlay color from `DatePickerTheme` and add missing tests (flutter/flutter#130584) 2023-07-17 [email protected] Update `DropdownMenu`, `SnackBarTheme` and `Stepper` tests for M2/M3 (flutter/flutter#130464) 2023-07-17 [email protected] Clarify the whole "CustomPainters default to Size.zero" thing. (flutter/flutter#130624) 2023-07-16 [email protected] Update list of CoC contacts. (flutter/flutter#130630) 2023-07-15 [email protected] Manual roll Flutter Engine from 403866d16137 to 683087731feb (16 revisions) (flutter/flutter#130666) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

) flutter#125331

) Manual roll requested by [email protected] flutter/flutter@f842ed9...6f09064 2023-07-17 [email protected] Stand-alone widget tree with multiple render trees to enable multi-view rendering (flutter/flutter#125003) 2023-07-17 [email protected] Update to valid build tools variant and update lockfiles (flutter/flutter#125825) 2023-07-17 [email protected] Roll Packages from 369ee7e to 6889cca (5 revisions) (flutter/flutter#130721) 2023-07-17 [email protected] [Reland] - Update `DialogTheme` tests for M2/M3 (flutter/flutter#130711) 2023-07-17 [email protected] Roll Flutter Engine from 683087731feb to e4cae43c9c7a (9 revisions) (flutter/flutter#130716) 2023-07-17 [email protected] [flutter_tools] Support coverage collection for dependencies (flutter/flutter#129513) 2023-07-17 [email protected] Fix `DatePicker` uses incorrect overlay color from `DatePickerTheme` and add missing tests (flutter/flutter#130584) 2023-07-17 [email protected] Update `DropdownMenu`, `SnackBarTheme` and `Stepper` tests for M2/M3 (flutter/flutter#130464) 2023-07-17 [email protected] Clarify the whole "CustomPainters default to Size.zero" thing. (flutter/flutter#130624) 2023-07-16 [email protected] Update list of CoC contacts. (flutter/flutter#130630) 2023-07-15 [email protected] Manual roll Flutter Engine from 403866d16137 to 683087731feb (16 revisions) (flutter/flutter#130666) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

) Manual roll requested by [email protected] flutter/flutter@f842ed9...6f09064 2023-07-17 [email protected] Stand-alone widget tree with multiple render trees to enable multi-view rendering (flutter/flutter#125003) 2023-07-17 [email protected] Update to valid build tools variant and update lockfiles (flutter/flutter#125825) 2023-07-17 [email protected] Roll Packages from 0e25800 to 4345b56 (5 revisions) (flutter/flutter#130721) 2023-07-17 [email protected] [Reland] - Update `DialogTheme` tests for M2/M3 (flutter/flutter#130711) 2023-07-17 [email protected] Roll Flutter Engine from 683087731feb to e4cae43c9c7a (9 revisions) (flutter/flutter#130716) 2023-07-17 [email protected] [flutter_tools] Support coverage collection for dependencies (flutter/flutter#129513) 2023-07-17 [email protected] Fix `DatePicker` uses incorrect overlay color from `DatePickerTheme` and add missing tests (flutter/flutter#130584) 2023-07-17 [email protected] Update `DropdownMenu`, `SnackBarTheme` and `Stepper` tests for M2/M3 (flutter/flutter#130464) 2023-07-17 [email protected] Clarify the whole "CustomPainters default to Size.zero" thing. (flutter/flutter#130624) 2023-07-16 [email protected] Update list of CoC contacts. (flutter/flutter#130630) 2023-07-15 [email protected] Manual roll Flutter Engine from 403866d16137 to 683087731feb (16 revisions) (flutter/flutter#130666) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Update to valid build tools variante and update lockfiles

668932c

flutter-dashboard Bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 1, 2023

Merge branch 'master' into i125331-fix-failing-smoke-test

be2ab7f

reidbaker changed the title ~~Update to valid build tools variante and update lockfiles~~ Update to valid build tools variant and update lockfiles May 1, 2023

reidbaker requested review from camsim99 and gmackall May 1, 2023 19:12

reidbaker added 2 commits May 1, 2023 18:55

Merge branch 'master' into i125331-fix-failing-smoke-test

6a534b9

Merge branch 'master' into i125331-fix-failing-smoke-test

8e4b3a8

camsim99 approved these changes May 8, 2023

View reviewed changes

reidbaker changed the title ~~Update to valid build tools variant and update lockfiles~~ Revert changed that broke firebase_abstract_method_smoke_test May 8, 2023

reidbaker changed the title ~~Revert changed that broke firebase_abstract_method_smoke_test~~ Update to valid build tools variante and update lockfiles May 8, 2023

reidbaker added 2 commits May 8, 2023 17:44

Temporarly modify abstract_method_smoke_test to run on presubmit and …

0525f45

…break the tree

Merge branch 'master' into i125331-fix-failing-smoke-test

1fb6b1f

reidbaker marked this pull request as draft May 8, 2023 21:51

reidbaker changed the title ~~Update to valid build tools variante and update lockfiles~~ Update to valid build tools variant and update lockfiles May 8, 2023

gmackall mentioned this pull request May 11, 2023

Many Android build tests flaking on reading debug keystore #126557

Closed

reidbaker added 2 commits July 14, 2023 08:36

Merge branch 'master' into i125331-fix-failing-smoke-test

a115eef

Merge branch 'master' into i125331-fix-failing-smoke-test

31907ab

reidbaker marked this pull request as ready for review July 14, 2023 17:06

gmackall approved these changes Jul 14, 2023

View reviewed changes

reidbaker and others added 3 commits July 14, 2023 13:32

Update .ci.yaml to remove "Do not merge.

2665075

Merge branch 'master' into i125331-fix-failing-smoke-test

c5257a0

Update gradle and re run write locks

cc45f67

reidbaker requested review from camsim99 and gmackall July 14, 2023 18:24

gmackall approved these changes Jul 14, 2023

View reviewed changes

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

7a42ed7 Update to valid build tools variant and update lockfiles (flu…

675ebbb

…tter/flutter#125825)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 7937b1d51f7b (80 revisions) flutter/packages#4498

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

7a42ed7 Update to valid build tools variant and update lockfiles (flu…

d4ac4be

…tter/flutter#125825)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to b2e22d3558e8 (85 revisions) flutter/packages#4499

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

7a42ed7 Update to valid build tools variant and update lockfiles (flu…

e11b995

…tter/flutter#125825)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 0df4496cdb50 (87 revisions) flutter/packages#4500

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

7a42ed7 Update to valid build tools variant and update lockfiles (flu…

9eae81f

…tter/flutter#125825)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 203ef6f7a32f (111 revisions) flutter/packages#4503

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

7a42ed7 Update to valid build tools variant and update lockfiles (flu…

6224b0a

…tter/flutter#125825)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 3b0b8348fd3e (112 revisions) flutter/packages#4505

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

7a42ed7 Update to valid build tools variant and update lockfiles (flu…

ced07c2

…tter/flutter#125825)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 8b768de18f29 (113 revisions) flutter/packages#4506

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

7a42ed7 Update to valid build tools variant and update lockfiles (flu…

f61dbcc

…tter/flutter#125825)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 86385dce684e (114 revisions) flutter/packages#4507

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

7a42ed7 Update to valid build tools variant and update lockfiles (flu…

227c6d6

…tter/flutter#125825)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to b460d49199e5 (115 revisions) flutter/packages#4508

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

7a42ed7 Update to valid build tools variant and update lockfiles (flu…

08b9096

…tter/flutter#125825)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Manual roll Flutter from c40173f114fa to 86385dce684e (114 revisions) flutter/packages#4509

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

7a42ed7 Update to valid build tools variant and update lockfiles (flu…

d6fe51f

…tter/flutter#125825)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 94179a8e3fd3 (116 revisions) flutter/packages#4510

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

7a42ed7 Update to valid build tools variant and update lockfiles (flu…

f1b6a7c

…tter/flutter#125825)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to fc2626a790ae (117 revisions) flutter/packages#4512

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

7a42ed7 Update to valid build tools variant and update lockfiles (flu…

954ab70

…tter/flutter#125825)

engine-flutter-autoroll mentioned this pull request Jul 19, 2023

Manual roll Flutter from f842ed916514 to 6f09064e785b (11 revisions) flutter/packages#4518

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2023

7a42ed7 Update to valid build tools variant and update lockfiles (flu…

6104919

…tter/flutter#125825)

LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023

Update to valid build tools variant and update lockfiles (flutter#125825

b1098f4

) flutter#125331

Navigation Menu

Repository navigation

Update to valid build tools variant and update lockfiles - #125825

Update to valid build tools variant and update lockfiles#125825
auto-submit[bot] merged 11 commits into
flutter:masterfrom
reidbaker:i125331-fix-failing-smoke-test

reidbaker commented May 1, 2023 •

edited

Loading

Uh oh!

camsim99 left a comment

Uh oh!

reidbaker commented May 8, 2023

Uh oh!

reidbaker commented May 8, 2023

Uh oh!

flutter-dashboard Bot commented May 8, 2023

Uh oh!

gmackall left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

reidbaker commented May 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

reidbaker commented May 8, 2023

Uh oh!

reidbaker commented May 8, 2023

Uh oh!

flutter-dashboard Bot commented May 8, 2023

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

reidbaker commented May 1, 2023 •

edited

Loading