Fix `DatePicker` uses incorrect overlay color from `DatePickerTheme` and add missing tests by TahaTesser · Pull Request #130584 · flutter/flutter

TahaTesser · 2023-07-14T15:35:07Z

fixes YearPickerState in calendar_date_picker is using dayOverlayColor instead of yearOverlayColor

Description

Fix year selection uses incorrect overlay color from DatePickerTheme
Update defaults tests to check for overlay color for different modes
Add tests to check overlay color is resolved.

Code sample

expand to view the code sample

import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(
        datePickerTheme: const DatePickerThemeData(
          yearOverlayColor: MaterialStatePropertyAll<Color>(Colors.green),
          dayOverlayColor: MaterialStatePropertyAll<Color>(Colors.amber),
        ),
        useMaterial3: true,
      ),
      home: Directionality(
        textDirection: TextDirection.ltr,
        child: Material(
          child: Center(
            child: DatePickerDialog(
              initialDate: DateTime(2023, DateTime.january, 25),
              firstDate: DateTime(2022),
              lastDate: DateTime(2024, DateTime.december, 31),
              currentDate: DateTime(2023, DateTime.january, 24),
            ),
          ),
        ),
      ),
    );
  }
}

          yearOverlayColor: MaterialStatePropertyAll<Color>(Colors.green),
          dayOverlayColor: MaterialStatePropertyAll<Color>(Colors.red),

Before

After

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…and add missing tests

HansMuller

Nice fix. LGTM

HansMuller · 2023-07-14T15:53:06Z

CC @QuncCccccc - this may break golden image tests.

TahaTesser · 2023-07-14T19:40:05Z

It looks like there is an extra circle drawn on the web in the pressed state. 🤔

…rTheme` and add missing tests (flutter/flutter#130584)

Manual roll requested by [email protected] flutter/flutter@f842ed9...6f09064 2023-07-17 [email protected] Stand-alone widget tree with multiple render trees to enable multi-view rendering (flutter/flutter#125003) 2023-07-17 [email protected] Update to valid build tools variant and update lockfiles (flutter/flutter#125825) 2023-07-17 [email protected] Roll Packages from 369ee7e to 6889cca (5 revisions) (flutter/flutter#130721) 2023-07-17 [email protected] [Reland] - Update `DialogTheme` tests for M2/M3 (flutter/flutter#130711) 2023-07-17 [email protected] Roll Flutter Engine from 683087731feb to e4cae43c9c7a (9 revisions) (flutter/flutter#130716) 2023-07-17 [email protected] [flutter_tools] Support coverage collection for dependencies (flutter/flutter#129513) 2023-07-17 [email protected] Fix `DatePicker` uses incorrect overlay color from `DatePickerTheme` and add missing tests (flutter/flutter#130584) 2023-07-17 [email protected] Update `DropdownMenu`, `SnackBarTheme` and `Stepper` tests for M2/M3 (flutter/flutter#130464) 2023-07-17 [email protected] Clarify the whole "CustomPainters default to Size.zero" thing. (flutter/flutter#130624) 2023-07-16 [email protected] Update list of CoC contacts. (flutter/flutter#130630) 2023-07-15 [email protected] Manual roll Flutter Engine from 403866d16137 to 683087731feb (16 revisions) (flutter/flutter#130666) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@OverRide

…and add missing tests (flutter#130584) fixes [YearPickerState in calendar_date_picker is using dayOverlayColor instead of yearOverlayColor](flutter#130051) ### Description - Fix year selection uses incorrect overlay color from `DatePickerTheme` - Update defaults tests to check for overlay color for different modes - Add tests to check overlay color is resolved. ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @OverRide Widget build(BuildContext context) { return MaterialApp( theme: ThemeData( datePickerTheme: const DatePickerThemeData( yearOverlayColor: MaterialStatePropertyAll<Color>(Colors.green), dayOverlayColor: MaterialStatePropertyAll<Color>(Colors.amber), ), useMaterial3: true, ), home: Directionality( textDirection: TextDirection.ltr, child: Material( child: Center( child: DatePickerDialog( initialDate: DateTime(2023, DateTime.january, 25), firstDate: DateTime(2022), lastDate: DateTime(2024, DateTime.december, 31), currentDate: DateTime(2023, DateTime.january, 24), ), ), ), ), ); } } ``` </details> ```dart yearOverlayColor: MaterialStatePropertyAll<Color>(Colors.green), dayOverlayColor: MaterialStatePropertyAll<Color>(Colors.red), ``` ### Before ![Screenshot 2023-07-14 at 18 39 51](https://github.com/flutter/flutter/assets/48603081/52ec5096-bad6-4753-9e9a-15b6d5ce767e) ### After ![Screenshot 2023-07-14 at 18 38 32](https://github.com/flutter/flutter/assets/48603081/a51aeca8-a5c2-42b4-8c05-b55f9955e860)

) Manual roll requested by [email protected] flutter/flutter@f842ed9...6f09064 2023-07-17 [email protected] Stand-alone widget tree with multiple render trees to enable multi-view rendering (flutter/flutter#125003) 2023-07-17 [email protected] Update to valid build tools variant and update lockfiles (flutter/flutter#125825) 2023-07-17 [email protected] Roll Packages from 369ee7e to 6889cca (5 revisions) (flutter/flutter#130721) 2023-07-17 [email protected] [Reland] - Update `DialogTheme` tests for M2/M3 (flutter/flutter#130711) 2023-07-17 [email protected] Roll Flutter Engine from 683087731feb to e4cae43c9c7a (9 revisions) (flutter/flutter#130716) 2023-07-17 [email protected] [flutter_tools] Support coverage collection for dependencies (flutter/flutter#129513) 2023-07-17 [email protected] Fix `DatePicker` uses incorrect overlay color from `DatePickerTheme` and add missing tests (flutter/flutter#130584) 2023-07-17 [email protected] Update `DropdownMenu`, `SnackBarTheme` and `Stepper` tests for M2/M3 (flutter/flutter#130464) 2023-07-17 [email protected] Clarify the whole "CustomPainters default to Size.zero" thing. (flutter/flutter#130624) 2023-07-16 [email protected] Update list of CoC contacts. (flutter/flutter#130630) 2023-07-15 [email protected] Manual roll Flutter Engine from 403866d16137 to 683087731feb (16 revisions) (flutter/flutter#130666) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

) Manual roll requested by [email protected] flutter/flutter@f842ed9...6f09064 2023-07-17 [email protected] Stand-alone widget tree with multiple render trees to enable multi-view rendering (flutter/flutter#125003) 2023-07-17 [email protected] Update to valid build tools variant and update lockfiles (flutter/flutter#125825) 2023-07-17 [email protected] Roll Packages from 0e25800 to 4345b56 (5 revisions) (flutter/flutter#130721) 2023-07-17 [email protected] [Reland] - Update `DialogTheme` tests for M2/M3 (flutter/flutter#130711) 2023-07-17 [email protected] Roll Flutter Engine from 683087731feb to e4cae43c9c7a (9 revisions) (flutter/flutter#130716) 2023-07-17 [email protected] [flutter_tools] Support coverage collection for dependencies (flutter/flutter#129513) 2023-07-17 [email protected] Fix `DatePicker` uses incorrect overlay color from `DatePickerTheme` and add missing tests (flutter/flutter#130584) 2023-07-17 [email protected] Update `DropdownMenu`, `SnackBarTheme` and `Stepper` tests for M2/M3 (flutter/flutter#130464) 2023-07-17 [email protected] Clarify the whole "CustomPainters default to Size.zero" thing. (flutter/flutter#130624) 2023-07-16 [email protected] Update list of CoC contacts. (flutter/flutter#130630) 2023-07-15 [email protected] Manual roll Flutter Engine from 403866d16137 to 683087731feb (16 revisions) (flutter/flutter#130666) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fix DatePicker uses incorrect overlay color from DatePickerTheme …

88ea4a9

…and add missing tests

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Jul 14, 2023

TahaTesser requested a review from HansMuller July 14, 2023 15:41

HansMuller approved these changes Jul 14, 2023

View reviewed changes

Fix tests for extra circle drawn on web

c13d95a

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023

auto-submit Bot merged commit a6187d9 into flutter:master Jul 17, 2023

TahaTesser deleted the fix_datepicker_theme_overlay branch July 17, 2023 08:09

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 3a1190a5a85c (72 revisions) flutter/packages#4492

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

a6187d9 Fix DatePicker uses incorrect overlay color from `DatePicke…

d8d665e

…rTheme` and add missing tests (flutter/flutter#130584)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 526522d9e5c7 (74 revisions) flutter/packages#4493

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

a6187d9 Fix DatePicker uses incorrect overlay color from `DatePicke…

32f2daf

…rTheme` and add missing tests (flutter/flutter#130584)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 7a42ed7ef6ed (76 revisions) flutter/packages#4495

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

a6187d9 Fix DatePicker uses incorrect overlay color from `DatePicke…

841fb4e

…rTheme` and add missing tests (flutter/flutter#130584)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 6f09064e785b (77 revisions) flutter/packages#4496

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

a6187d9 Fix DatePicker uses incorrect overlay color from `DatePicke…

2fc80ad

…rTheme` and add missing tests (flutter/flutter#130584)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 083d18e83f8f (78 revisions) flutter/packages#4497

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

a6187d9 Fix DatePicker uses incorrect overlay color from `DatePicke…

47124bb

…rTheme` and add missing tests (flutter/flutter#130584)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 7937b1d51f7b (80 revisions) flutter/packages#4498

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

a6187d9 Fix DatePicker uses incorrect overlay color from `DatePicke…

f6fc01b

…rTheme` and add missing tests (flutter/flutter#130584)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to b2e22d3558e8 (85 revisions) flutter/packages#4499

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

a6187d9 Fix DatePicker uses incorrect overlay color from `DatePicke…

7a029de

…rTheme` and add missing tests (flutter/flutter#130584)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 0df4496cdb50 (87 revisions) flutter/packages#4500

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

a6187d9 Fix DatePicker uses incorrect overlay color from `DatePicke…

4657da5

…rTheme` and add missing tests (flutter/flutter#130584)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 203ef6f7a32f (111 revisions) flutter/packages#4503

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

a6187d9 Fix DatePicker uses incorrect overlay color from `DatePicke…

3e2c1a0

…rTheme` and add missing tests (flutter/flutter#130584)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 3b0b8348fd3e (112 revisions) flutter/packages#4505

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

a6187d9 Fix DatePicker uses incorrect overlay color from `DatePicke…

c6004ca

…rTheme` and add missing tests (flutter/flutter#130584)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 8b768de18f29 (113 revisions) flutter/packages#4506

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

a6187d9 Fix DatePicker uses incorrect overlay color from `DatePicke…

193487f

…rTheme` and add missing tests (flutter/flutter#130584)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 86385dce684e (114 revisions) flutter/packages#4507

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

a6187d9 Fix DatePicker uses incorrect overlay color from `DatePicke…

3ee65cd

…rTheme` and add missing tests (flutter/flutter#130584)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to b460d49199e5 (115 revisions) flutter/packages#4508

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

a6187d9 Fix DatePicker uses incorrect overlay color from `DatePicke…

9646fbb

…rTheme` and add missing tests (flutter/flutter#130584)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Manual roll Flutter from c40173f114fa to 86385dce684e (114 revisions) flutter/packages#4509

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

a6187d9 Fix DatePicker uses incorrect overlay color from `DatePicke…

a22b79f

…rTheme` and add missing tests (flutter/flutter#130584)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 94179a8e3fd3 (116 revisions) flutter/packages#4510

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

a6187d9 Fix DatePicker uses incorrect overlay color from `DatePicke…

a61d3f6

…rTheme` and add missing tests (flutter/flutter#130584)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

a6187d9 Fix DatePicker uses incorrect overlay color from `DatePicke…

f23008a

…rTheme` and add missing tests (flutter/flutter#130584)

engine-flutter-autoroll mentioned this pull request Jul 19, 2023

Manual roll Flutter from f842ed916514 to 6f09064e785b (11 revisions) flutter/packages#4518

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2023

a6187d9 Fix DatePicker uses incorrect overlay color from `DatePicke…

a5555e4

…rTheme` and add missing tests (flutter/flutter#130584)

HansMuller mentioned this pull request Jul 21, 2023

Flutter Framework Team: Notable Commits #121415

Closed

Navigation Menu

Repository navigation

Fix `DatePicker` uses incorrect overlay color from `DatePickerTheme` and add missing tests - #130584

Fix `DatePicker` uses incorrect overlay color from `DatePickerTheme` and add missing tests#130584
auto-submit[bot] merged 2 commits into
flutter:masterfrom
TahaTesser:fix_datepicker_theme_overlay

TahaTesser commented Jul 14, 2023 •

edited

Loading

Uh oh!

HansMuller left a comment

Uh oh!

HansMuller commented Jul 14, 2023

Uh oh!

TahaTesser commented Jul 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

TahaTesser commented Jul 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Code sample

Before

After

Pre-launch Checklist

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

HansMuller commented Jul 14, 2023

Uh oh!

TahaTesser commented Jul 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TahaTesser commented Jul 14, 2023 •

edited

Loading