Repository navigation
Add a custom semantics sample - #12742
Merged
Merged
Conversation
gspencergoog
approved these changes
Oct 31, 2017
| /// intuitive way of switching values compared to exposing the content of the | ||
| /// drop down menu as a screen overlay from which the user can select. | ||
| /// | ||
| /// Users, that do not use a screen reader, will just see a regular dropdown |
Contributor
There was a problem hiding this comment.
"Users that do not use a screen reader will just see a regular dropdown"
Contributor
|
|
Contributor
|
Is this something we should just offer out of the box? |
Member
Author
|
I am hesitant. This is not the default behavior for OEM drop downs on the platforms and it's not appropriate for all kinds of drop downs. |
goderbauer
added
the
a: accessibility
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
* Add a custom semantics sample * typo * Review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change requires #12741 to be submitted first.