Add .env file support for option `--dart-define-from-file` by PiotrFLEURY · Pull Request #128668 · flutter/flutter

PiotrFLEURY · 2023-06-11T18:49:59Z

Proposal

I suggest to make possible to specify .env files to the --dart-define-from-file in addition to the Json format.

Issue

Close #128667

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

andrewkolos

I haven't done a complete review of this, but I did add some comments to start out with.

andrewkolos

Thanks for your continued work on this PR!

I think this is getting really close to a good state. Most of my remaining comments are nitpicks.

PiotrFLEURY · 2023-06-29T12:01:17Z

I think every of your suggestion has been applied to the code @andrewkolos.

One step closer to the good state.

andrewkolos

LGTM

🚀

christopherfujino

RSLGTM

zanderso · 2023-07-05T16:48:27Z

+  ///
+  /// Returns a record of key and value as strings.
+  MapEntry<String, String> _parseProperty(String line) {
+    final RegExp blockRegExp = RegExp(r'^\s*([a-zA-Z_]+[a-zA-Z0-9_]*)\s*=\s*"""\s*(.*)$');


All of these regular expressions are constants. They should be pulled out of this function so that they will not be reallocated on each iteration of the loop in convertEnvFileToJsonRaw.

…lutter/flutter#128668)

flutter/flutter@35085c3...bc49cd1 2023-07-06 [email protected] Allow long-press gestures to continue even if buttons change. (flutter/flutter#127877) 2023-07-06 [email protected] Enable unreachable_from_main lint - it is stable now!!1 (flutter/flutter#129854) 2023-07-06 [email protected] Update labeler to new label names (flutter/flutter#130040) 2023-07-05 [email protected] MergeableMaterial: Fix adding a slice and separating it (flutter/flutter#128804) 2023-07-05 [email protected] Update infrastructure issue template for new priority scheme (flutter/flutter#129741) 2023-07-05 [email protected] Fix typo in canvas example (flutter/flutter#129879) 2023-07-05 [email protected] Reland Fix AnimatedList & AnimatedGrid doesn't apply MediaQuery padding #129556 (flutter/flutter#129860) 2023-07-05 [email protected] Change from "created via performance template" to "from: performance template" (flutter/flutter#130035) 2023-07-05 [email protected] Removes deprecated APIs from v2.6 in `binding.dart` and `widget_tester.dart` (flutter/flutter#129663) 2023-07-05 [email protected] Add new hot reload case string (flutter/flutter#130008) 2023-07-05 [email protected] Manual roll Flutter Engine from 987b621eac4e to bd2e42b203e1 (32 revisions) (flutter/flutter#130023) 2023-07-05 [email protected] Add simple unit tests for annotations.dart file (flutter/flutter#128902) 2023-07-05 [email protected] fix a bug when android uses CupertinoPageTransitionsBuilder... (flutter/flutter#114303) 2023-07-05 [email protected] Add .env file support for option `--dart-define-from-file` (flutter/flutter#128668) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

debkanchan · 2023-07-06T17:07:50Z

This pr should get a lot of attention. This is huge.

Set `.env` regex list as constants. This pull request fixes the nit related in this comment: #128668 (comment)

Set `.env` regex list as constants. This pull request fixes the nit related in this comment: flutter#128668 (comment)

…lutter/flutter#128668)

flutter/flutter@35085c3...bc49cd1 2023-07-06 [email protected] Allow long-press gestures to continue even if buttons change. (flutter/flutter#127877) 2023-07-06 [email protected] Enable unreachable_from_main lint - it is stable now!!1 (flutter/flutter#129854) 2023-07-06 [email protected] Update labeler to new label names (flutter/flutter#130040) 2023-07-05 [email protected] MergeableMaterial: Fix adding a slice and separating it (flutter/flutter#128804) 2023-07-05 [email protected] Update infrastructure issue template for new priority scheme (flutter/flutter#129741) 2023-07-05 [email protected] Fix typo in canvas example (flutter/flutter#129879) 2023-07-05 [email protected] Reland Fix AnimatedList & AnimatedGrid doesn't apply MediaQuery padding #129556 (flutter/flutter#129860) 2023-07-05 [email protected] Change from "created via performance template" to "from: performance template" (flutter/flutter#130035) 2023-07-05 [email protected] Removes deprecated APIs from v2.6 in `binding.dart` and `widget_tester.dart` (flutter/flutter#129663) 2023-07-05 [email protected] Add new hot reload case string (flutter/flutter#130008) 2023-07-05 [email protected] Manual roll Flutter Engine from 987b621eac4e to bd2e42b203e1 (32 revisions) (flutter/flutter#130023) 2023-07-05 [email protected] Add simple unit tests for annotations.dart file (flutter/flutter#128902) 2023-07-05 [email protected] fix a bug when android uses CupertinoPageTransitionsBuilder... (flutter/flutter#114303) 2023-07-05 [email protected] Add .env file support for option `--dart-define-from-file` (flutter/flutter#128668) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 11, 2023

PiotrFLEURY changed the title ~~Add .env file support for option~~ Add .env file support for option --dart-define-from-file Jun 11, 2023

PiotrFLEURY force-pushed the flutter_tools/dot-env-dart-define-from-file-proposal branch 2 times, most recently from fc63a11 to 04300d7 Compare June 17, 2023 15:35

eliasyishak reviewed Jun 20, 2023

View reviewed changes

Comment thread packages/flutter_tools/lib/src/runner/flutter_command.dart Outdated

PiotrFLEURY force-pushed the flutter_tools/dot-env-dart-define-from-file-proposal branch from 04300d7 to bd1a6f6 Compare June 20, 2023 17:19

andrewkolos requested changes Jun 20, 2023

View reviewed changes

PiotrFLEURY force-pushed the flutter_tools/dot-env-dart-define-from-file-proposal branch 3 times, most recently from 8d1d979 to 7b0a822 Compare June 21, 2023 14:58

andrewkolos requested changes Jun 21, 2023

View reviewed changes

PiotrFLEURY force-pushed the flutter_tools/dot-env-dart-define-from-file-proposal branch 6 times, most recently from 2ee2118 to bded33e Compare June 28, 2023 15:22

github-actions Bot removed the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 28, 2023

PiotrFLEURY force-pushed the flutter_tools/dot-env-dart-define-from-file-proposal branch from bded33e to bbaa46e Compare June 28, 2023 16:43

andrewkolos requested changes Jun 28, 2023

View reviewed changes

darshankawar mentioned this pull request Jun 29, 2023

Pass app version, name, and description as Dart environment constants #129715

Open

2 tasks done

PiotrFLEURY force-pushed the flutter_tools/dot-env-dart-define-from-file-proposal branch from bbaa46e to 46cf071 Compare June 29, 2023 11:51

PiotrFLEURY force-pushed the flutter_tools/dot-env-dart-define-from-file-proposal branch from 46cf071 to 95030fd Compare June 29, 2023 15:58

andrewkolos approved these changes Jun 29, 2023

View reviewed changes

andrewkolos requested a review from eliasyishak June 29, 2023 19:15

andrewkolos added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 29, 2023

christopherfujino approved these changes Jun 29, 2023

View reviewed changes

Add .env file support for option --dart-define-from-file

89ebd18

PiotrFLEURY force-pushed the flutter_tools/dot-env-dart-define-from-file-proposal branch from 95030fd to 89ebd18 Compare July 5, 2023 11:58

christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 5, 2023

auto-submit Bot merged commit 168d807 into flutter:master Jul 5, 2023

zanderso reviewed Jul 5, 2023

View reviewed changes

PiotrFLEURY mentioned this pull request Jul 6, 2023

Fix .env regex constants #130072

Merged

8 tasks done

engine-flutter-autoroll mentioned this pull request Jul 6, 2023

Roll Flutter from 35085c394dda to bc49cd1bcab5 (14 revisions) flutter/packages#4387

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2023

168d807 Add .env file support for option --dart-define-from-file (f…

b98ca70

…lutter/flutter#128668)

auto-submit Bot pushed a commit that referenced this pull request Jul 13, 2023

Fix .env regex constants (#130072)

99efd1b

Set `.env` regex list as constants. This pull request fixes the nit related in this comment: #128668 (comment)

bartekpacia mentioned this pull request Jul 14, 2023

Add dart defines from file leancodepl/patrol#1477

Closed

LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023

Fix .env regex constants (flutter#130072)

d6ec899

Set `.env` regex list as constants. This pull request fixes the nit related in this comment: flutter#128668 (comment)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

168d807 Add .env file support for option --dart-define-from-file (f…

7336762

…lutter/flutter#128668)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

168d807 Add .env file support for option --dart-define-from-file (f…

b38b02c

…lutter/flutter#128668)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

168d807 Add .env file support for option --dart-define-from-file (f…

8e6e248

…lutter/flutter#128668)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

168d807 Add .env file support for option --dart-define-from-file (f…

950aedc

…lutter/flutter#128668)

epou mentioned this pull request Feb 5, 2024

Generate environment specific configuration Mosquito-Alert/mosquito_alert_mobile_app#81

Merged

Conversation

PiotrFLEURY commented Jun 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposal

Issue

Pre-launch Checklist

Uh oh!

Uh oh!

andrewkolos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andrewkolos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PiotrFLEURY commented Jun 29, 2023

Uh oh!

andrewkolos left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

zanderso Jul 5, 2023

Choose a reason for hiding this comment

Uh oh!

debkanchan commented Jul 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

PiotrFLEURY commented Jun 11, 2023 •

edited

Loading

andrewkolos left a comment •

edited

Loading