Enable unreachable_from_main lint - it is stable now!!1 by goderbauer · Pull Request #129854 · flutter/flutter

goderbauer · 2023-06-30T20:57:30Z

PLUS: clean-up of all the unreachable stuff.

christopherfujino · 2023-06-30T22:57:00Z

can you link some more references to this black magic? how does it know which main() to start from? or does it just evaluate every function named main() in a library in the package?

goderbauer · 2023-06-30T22:59:19Z

It only considers files that have a main function. And for those files its checks if everything in that file is reachable from that main. Its mostly targeted towards tests, which always have a main function and where people often declare everything as public. Then, when they refactor the test and no longer need the public thing, they forget to delete it.

christopherfujino · 2023-06-30T23:04:00Z

It only considers files that have a main function. And for those files its checks if everything in that file is reachable from that main. Its mostly targeted towards tests, which always have a main function and where people often declare everything as public. Then, when they refactor the test and no longer need the public thing, they forget to delete it.

Ahh, ok, that's much less magical than I thought. Nice cleanup.

christopherfujino

Tools LGTM

srawlins

Wow, if I'm reading this right, no ignores were required except in samples, that's great news!

chunhtai

LGTM

chunhtai · 2023-07-05T22:56:40Z

-    _maxUndoLevels = value;
-    _pruneActions();
-  }
+  int get maxUndoLevels => _defaultMaxUndoLevels;


hardcode this to 1000 or use _defaultMaxUndoLevels directly in code?

…ter/flutter#129854)

flutter/flutter@35085c3...bc49cd1 2023-07-06 [email protected] Allow long-press gestures to continue even if buttons change. (flutter/flutter#127877) 2023-07-06 [email protected] Enable unreachable_from_main lint - it is stable now!!1 (flutter/flutter#129854) 2023-07-06 [email protected] Update labeler to new label names (flutter/flutter#130040) 2023-07-05 [email protected] MergeableMaterial: Fix adding a slice and separating it (flutter/flutter#128804) 2023-07-05 [email protected] Update infrastructure issue template for new priority scheme (flutter/flutter#129741) 2023-07-05 [email protected] Fix typo in canvas example (flutter/flutter#129879) 2023-07-05 [email protected] Reland Fix AnimatedList & AnimatedGrid doesn't apply MediaQuery padding #129556 (flutter/flutter#129860) 2023-07-05 [email protected] Change from "created via performance template" to "from: performance template" (flutter/flutter#130035) 2023-07-05 [email protected] Removes deprecated APIs from v2.6 in `binding.dart` and `widget_tester.dart` (flutter/flutter#129663) 2023-07-05 [email protected] Add new hot reload case string (flutter/flutter#130008) 2023-07-05 [email protected] Manual roll Flutter Engine from 987b621eac4e to bd2e42b203e1 (32 revisions) (flutter/flutter#130023) 2023-07-05 [email protected] Add simple unit tests for annotations.dart file (flutter/flutter#128902) 2023-07-05 [email protected] fix a bug when android uses CupertinoPageTransitionsBuilder... (flutter/flutter#114303) 2023-07-05 [email protected] Add .env file support for option `--dart-define-from-file` (flutter/flutter#128668) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…ter/flutter#129854)

flutter/flutter@35085c3...bc49cd1 2023-07-06 [email protected] Allow long-press gestures to continue even if buttons change. (flutter/flutter#127877) 2023-07-06 [email protected] Enable unreachable_from_main lint - it is stable now!!1 (flutter/flutter#129854) 2023-07-06 [email protected] Update labeler to new label names (flutter/flutter#130040) 2023-07-05 [email protected] MergeableMaterial: Fix adding a slice and separating it (flutter/flutter#128804) 2023-07-05 [email protected] Update infrastructure issue template for new priority scheme (flutter/flutter#129741) 2023-07-05 [email protected] Fix typo in canvas example (flutter/flutter#129879) 2023-07-05 [email protected] Reland Fix AnimatedList & AnimatedGrid doesn't apply MediaQuery padding #129556 (flutter/flutter#129860) 2023-07-05 [email protected] Change from "created via performance template" to "from: performance template" (flutter/flutter#130035) 2023-07-05 [email protected] Removes deprecated APIs from v2.6 in `binding.dart` and `widget_tester.dart` (flutter/flutter#129663) 2023-07-05 [email protected] Add new hot reload case string (flutter/flutter#130008) 2023-07-05 [email protected] Manual roll Flutter Engine from 987b621eac4e to bd2e42b203e1 (32 revisions) (flutter/flutter#130023) 2023-07-05 [email protected] Add simple unit tests for annotations.dart file (flutter/flutter#128902) 2023-07-05 [email protected] fix a bug when android uses CupertinoPageTransitionsBuilder... (flutter/flutter#114303) 2023-07-05 [email protected] Add .env file support for option `--dart-define-from-file` (flutter/flutter#128668) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

goderbauer force-pushed the unreachable_from_main branch 2 times, most recently from 4a0bbc3 to 3c10976 Compare June 30, 2023 21:52

goderbauer requested review from christopherfujino, justinmc and srawlins June 30, 2023 22:37

christopherfujino approved these changes Jun 30, 2023

View reviewed changes

srawlins approved these changes Jul 3, 2023

View reviewed changes

Hixie removed the documentation label Jul 5, 2023

chunhtai self-requested a review July 5, 2023 22:48

Enable unreachable_from_main lint - it is stable now!!1

4e40a87

goderbauer force-pushed the unreachable_from_main branch from 3c10976 to 4e40a87 Compare July 5, 2023 22:53

github-actions Bot added the documentation label Jul 5, 2023

chunhtai approved these changes Jul 5, 2023

View reviewed changes

review

e04c70a

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 5, 2023

Hixie removed the documentation label Jul 6, 2023

auto-submit Bot merged commit 55b6f04 into flutter:master Jul 6, 2023

engine-flutter-autoroll mentioned this pull request Jul 6, 2023

Roll Flutter from 35085c394dda to bc49cd1bcab5 (14 revisions) flutter/packages#4387

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2023

55b6f04 Enable unreachable_from_main lint - it is stable now!!1 (flut…

0e13e92

…ter/flutter#129854)

HansMuller mentioned this pull request Jul 7, 2023

Flutter Framework Team: Notable Commits #121415

Closed

goderbauer deleted the unreachable_from_main branch July 13, 2023 18:15

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

55b6f04 Enable unreachable_from_main lint - it is stable now!!1 (flut…

4f55909

…ter/flutter#129854)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

55b6f04 Enable unreachable_from_main lint - it is stable now!!1 (flut…

ecd631c

…ter/flutter#129854)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

55b6f04 Enable unreachable_from_main lint - it is stable now!!1 (flut…

d9f30a8

…ter/flutter#129854)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

55b6f04 Enable unreachable_from_main lint - it is stable now!!1 (flut…

05bf9cc

…ter/flutter#129854)

goderbauer mentioned this pull request Jul 19, 2024

Consider removing the unreachable_from_main lint dart-lang/ecosystem#281

Closed

Navigation Menu

Repository navigation

Enable unreachable_from_main lint - it is stable now!!1 - #129854

Enable unreachable_from_main lint - it is stable now!!1#129854
auto-submit[bot] merged 2 commits into
flutter:masterfrom
goderbauer:unreachable_from_main

goderbauer commented Jun 30, 2023 •

edited

Loading

Uh oh!

christopherfujino commented Jun 30, 2023

Uh oh!

goderbauer commented Jun 30, 2023

Uh oh!

christopherfujino commented Jun 30, 2023

Uh oh!

christopherfujino left a comment

Uh oh!

srawlins left a comment

Uh oh!

chunhtai left a comment

Uh oh!

chunhtai Jul 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

goderbauer commented Jun 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christopherfujino commented Jun 30, 2023

Uh oh!

goderbauer commented Jun 30, 2023

Uh oh!

christopherfujino commented Jun 30, 2023

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

srawlins left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai Jul 5, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

goderbauer commented Jun 30, 2023 •

edited

Loading