TreeSliver & associated classes by Piinks · Pull Request #147171 · flutter/flutter

Piinks · 2024-04-22T16:07:41Z

FYI for Reviewers: Much of the API surface matches that of the 2D TreeView in flutter/packages#6592. If it changes here, it should change there, and vice versa.

📜 Design Document

This adds classes and associated callbacks and controllers for TreeSliver. Core components:

TreeSliver
RenderTreeSliver
TreeSliverNode
TreeSliverController
TreeSliverStateMixin
TreeSliverIndentationType

Fixes #114299

sliver_0.mov

sliver_1.mov

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Piinks · 2024-04-22T23:52:07Z

For tomorrow:

Move SliverTree back to widgets from material once Update icon tree shaker to allow system font fallback #147202 lands
More name collisions, see Google testing

bleroux

LGTM for the examples!

Spotted minor typos in the non-examples files.

auto-submit · 2024-06-05T17:14:46Z

A reason for requesting a revert of flutter/flutter/147171 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

QuncCccccc · 2024-06-05T17:15:50Z

Reason for revert: tree is red due to a test in this PR

This reverts commit b50eb97.

Reverts: #147171 Initiated by: QuncCccccc Reason for reverting: tree is red due to a test in this PR Original PR Author: Piinks Reviewed By: {QuncCccccc, TahaTesser, bleroux} This change reverts the following previous change: **FYI for Reviewers:** Much of the API surface matches that of the 2D TreeView in flutter/packages#6592. If it changes here, it should change there, and vice versa. 📜 [Design Document](https://docs.google.com/document/d/1-aFI7VjkF9yMkWpP94J8T_JREDS-M3bOak26PVehUYg/edit?usp=sharing) This adds classes and associated callbacks and controllers for TreeSliver. Core components: - TreeSliver - RenderTreeSliver - TreeSliverNode - TreeSliverController - TreeSliverStateMixin - TreeSliverIndentationType Fixes #114299 https://github.com/flutter/flutter/assets/16964204/3facd095-7262-4068-aa33-d713e2deca99 https://github.com/flutter/flutter/assets/16964204/f851ae30-8e71-45c7-82a4-9606986a5872

flutter/flutter@c246ecd...27e0656 2024-06-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "TreeSliver & associated classes (#147171)" (flutter/flutter#149754) 2024-06-05 [email protected] Feature: Add AnimatedList with separators (flutter/flutter#144899) 2024-06-05 [email protected] make output of flutter run web tests verbose (flutter/flutter#149694) 2024-06-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Request focus if `SemanticsAction.focus` is sent to a focusable widget (#142942)" (flutter/flutter#149741) 2024-06-05 [email protected] Roll Flutter Engine from e88469090fed to 11a32d43e3f6 (2 revisions) (flutter/flutter#149699) 2024-06-05 [email protected] Request focus if `SemanticsAction.focus` is sent to a focusable widget (flutter/flutter#142942) 2024-06-04 [email protected] Roll Flutter Engine from 3dd40156afb6 to e88469090fed (2 revisions) (flutter/flutter#149695) 2024-06-04 [email protected] TreeSliver & associated classes (flutter/flutter#147171) 2024-06-04 [email protected] Roll Flutter Engine from fe00f023666c to 3dd40156afb6 (3 revisions) (flutter/flutter#149692) 2024-06-04 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.7 to 3.25.8 (flutter/flutter#149691) 2024-06-04 [email protected] Prepares semantics_update_test for upcoming heading level changes (flutter/flutter#149671) 2024-06-04 [email protected] Identify and re-throw our dependency checking errors in `flutter.groovy` (flutter/flutter#149609) 2024-06-04 [email protected] Scrollbar thumb drag gestures now produce one start and one end scroll notification (flutter/flutter#146654) 2024-06-04 [email protected] Disable sandboxing for macOS apps and tests in CI (flutter/flutter#149618) 2024-06-04 [email protected] Roll Flutter Engine from e211c43f3dc1 to fe00f023666c (3 revisions) (flutter/flutter#149680) 2024-06-04 [email protected] Allow `find.byTooltip` to use a RegEx (flutter/flutter#149348) 2024-06-04 [email protected] Roll Flutter Engine from a6aa5d826649 to e211c43f3dc1 (8 revisions) (flutter/flutter#149658) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Reland of #147171 It was reverted for a failing unit test that had passed in presubmit. Hopefully this sticks better. Also fixed leaks in 37b10ad

flutter/flutter@c246ecd...27e0656 2024-06-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "TreeSliver & associated classes (#147171)" (flutter/flutter#149754) 2024-06-05 [email protected] Feature: Add AnimatedList with separators (flutter/flutter#144899) 2024-06-05 [email protected] make output of flutter run web tests verbose (flutter/flutter#149694) 2024-06-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Request focus if `SemanticsAction.focus` is sent to a focusable widget (#142942)" (flutter/flutter#149741) 2024-06-05 [email protected] Roll Flutter Engine from e88469090fed to 11a32d43e3f6 (2 revisions) (flutter/flutter#149699) 2024-06-05 [email protected] Request focus if `SemanticsAction.focus` is sent to a focusable widget (flutter/flutter#142942) 2024-06-04 [email protected] Roll Flutter Engine from 3dd40156afb6 to e88469090fed (2 revisions) (flutter/flutter#149695) 2024-06-04 [email protected] TreeSliver & associated classes (flutter/flutter#147171) 2024-06-04 [email protected] Roll Flutter Engine from fe00f023666c to 3dd40156afb6 (3 revisions) (flutter/flutter#149692) 2024-06-04 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.7 to 3.25.8 (flutter/flutter#149691) 2024-06-04 [email protected] Prepares semantics_update_test for upcoming heading level changes (flutter/flutter#149671) 2024-06-04 [email protected] Identify and re-throw our dependency checking errors in `flutter.groovy` (flutter/flutter#149609) 2024-06-04 [email protected] Scrollbar thumb drag gestures now produce one start and one end scroll notification (flutter/flutter#146654) 2024-06-04 [email protected] Disable sandboxing for macOS apps and tests in CI (flutter/flutter#149618) 2024-06-04 [email protected] Roll Flutter Engine from e211c43f3dc1 to fe00f023666c (3 revisions) (flutter/flutter#149680) 2024-06-04 [email protected] Allow `find.byTooltip` to use a RegEx (flutter/flutter#149348) 2024-06-04 [email protected] Roll Flutter Engine from a6aa5d826649 to e211c43f3dc1 (8 revisions) (flutter/flutter#149658) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Piinks added c: new feature Nothing broken; request for a new capability framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Apr 22, 2024

github-actions Bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Apr 22, 2024

Piinks changed the title ~~Sliver tree 2~~ SliverTree Apr 22, 2024

Piinks force-pushed the sliverTree-2 branch from 86051c1 to 5defdf3 Compare April 22, 2024 17:29

github-actions Bot added the p: material_ui material_ui package in flutter/packages label Apr 22, 2024

Piinks mentioned this pull request Apr 22, 2024

[two_dimensional_scrollables] TreeView flutter/packages#6592

Merged

11 tasks done

navaronbracke reviewed Apr 22, 2024

View reviewed changes

Comment thread packages/flutter/lib/src/widgets/sliver_tree.dart Outdated

Comment thread examples/api/lib/widgets/sliver/sliver_tree.0.dart Outdated

Piinks commented Apr 22, 2024

View reviewed changes

Comment thread packages/flutter/lib/src/material/sliver_tree.dart Outdated

Piinks force-pushed the sliverTree-2 branch from 80f7f5e to 9a5c1f4 Compare April 23, 2024 16:25

github-actions Bot removed the p: material_ui material_ui package in flutter/packages label Apr 23, 2024

Piinks changed the title ~~SliverTree~~ SliverTreeList Apr 23, 2024

Piinks force-pushed the sliverTree-2 branch from 9a5c1f4 to c35db71 Compare April 23, 2024 17:22

Piinks marked this pull request as ready for review April 24, 2024 22:36

Piinks requested review from HansMuller, QuncCccccc, TahaTesser, bleroux and goderbauer April 24, 2024 22:37

Piinks commented Apr 24, 2024

View reviewed changes

Comment thread packages/flutter/lib/src/widgets/sliver_tree.dart Outdated

TahaTesser suggested changes Apr 25, 2024

View reviewed changes

Comment thread packages/flutter/lib/src/widgets/sliver_tree.dart Outdated

bleroux approved these changes Apr 25, 2024

View reviewed changes

Comment thread packages/flutter/lib/src/widgets/sliver_tree.dart Outdated

Comment thread packages/flutter/lib/src/rendering/sliver_multi_box_adaptor.dart Outdated

bleroux reviewed Apr 25, 2024

View reviewed changes

Comment thread packages/flutter/lib/src/widgets/sliver_tree.dart Outdated

TahaTesser reviewed Apr 25, 2024

View reviewed changes

Comment thread examples/api/lib/widgets/sliver/sliver_tree.0.dart Outdated

Comment thread examples/api/lib/widgets/sliver/sliver_tree.0.dart Outdated

TahaTesser previously requested changes Apr 25, 2024

View reviewed changes

This was referenced May 14, 2024

TreeSliver & TreeView alternate focus traversal options #148357

Open

TreeSliver & TreeView support for lazy tree nodes #148358

Open

auto-submit Bot merged commit b50eb97 into flutter:master Jun 4, 2024

engine-flutter-autoroll mentioned this pull request Jun 4, 2024

Manual roll Flutter from c246ecdf8e8d to b50eb97b7d9e (10 revisions) flutter/packages#6867

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2024

b50eb97 TreeSliver & associated classes (flutter/flutter#147171)

f76fa44

polina-c mentioned this pull request Jun 5, 2024

_TreeSliverState is leaking CurvedAnimation. #149711

Closed

engine-flutter-autoroll mentioned this pull request Jun 5, 2024

Roll Flutter from c246ecdf8e8d to ec9965bd89e6 (14 revisions) flutter/packages#6870

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2024

b50eb97 TreeSliver & associated classes (flutter/flutter#147171)

0ddf424

engine-flutter-autoroll mentioned this pull request Jun 5, 2024

Roll Flutter from c246ecdf8e8d to cd8e84f46511 (15 revisions) flutter/packages#6872

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2024

b50eb97 TreeSliver & associated classes (flutter/flutter#147171)

6e9c70e

engine-flutter-autoroll mentioned this pull request Jun 5, 2024

Roll Flutter from c246ecdf8e8d to 39472d9b6193 (16 revisions) flutter/packages#6873

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2024

b50eb97 TreeSliver & associated classes (flutter/flutter#147171)

82da26d

QuncCccccc added the revert Autorevert PR (with "Reason for revert:" comment) label Jun 5, 2024

auto-submit Bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jun 5, 2024

QuncCccccc added the revert Autorevert PR (with "Reason for revert:" comment) label Jun 5, 2024

auto-submit Bot pushed a commit that referenced this pull request Jun 5, 2024

Revert "TreeSliver & associated classes (#147171)"

d24971a

This reverts commit b50eb97.

auto-submit Bot mentioned this pull request Jun 5, 2024

Reverts "TreeSliver & associated classes (#147171)" #149754

Merged

9 tasks done

auto-submit Bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jun 5, 2024

engine-flutter-autoroll mentioned this pull request Jun 5, 2024

Roll Flutter from c246ecdf8e8d to 27e06569a157 (17 revisions) flutter/packages#6875

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2024

b50eb97 TreeSliver & associated classes (flutter/flutter#147171)

add5cb2

This was referenced Jun 6, 2024

Reland TreeSliver #149839

Merged

Presubmit builds may check out the wrong commit #149851

Closed

auto-submit Bot pushed a commit that referenced this pull request Jun 17, 2024

Reland TreeSliver (#149839)

9b6813f

Reland of #147171 It was reverted for a failing unit test that had passed in presubmit. Hopefully this sticks better. Also fixed leaks in 37b10ad

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

b50eb97 TreeSliver & associated classes (flutter/flutter#147171)

5865d16

Navigation Menu

Repository navigation

TreeSliver & associated classes - #147171

TreeSliver & associated classes#147171
auto-submit[bot] merged 34 commits into
flutter:masterfrom
Piinks:sliverTree-2

Piinks commented Apr 22, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Piinks commented Apr 22, 2024

Uh oh!

Uh oh!

Uh oh!

bleroux left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

auto-submit Bot commented Jun 5, 2024

Uh oh!

QuncCccccc commented Jun 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

Piinks commented Apr 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Piinks commented Apr 22, 2024

Uh oh!

Uh oh!

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

auto-submit Bot commented Jun 5, 2024

Uh oh!

QuncCccccc commented Jun 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Piinks commented Apr 22, 2024 •

edited

Loading