Reland TreeSliver by Piinks · Pull Request #149839 · flutter/flutter

Piinks · 2024-06-06T19:50:13Z

It was reverted for a failing unit test that had passed in presubmit. Hopefully this sticks better.
Also fixed leaks in 37b10ad

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Piinks · 2024-06-06T20:01:20Z

Fixed leaks identified in #149711 in 37b10ad

QuncCccccc

LGTM!

Piinks · 2024-06-06T21:21:23Z

Going to wait to reland this until we confirm #149851 is fixed

auto-submit · 2024-06-17T16:38:23Z

auto label is removed for flutter/flutter/149839, due to - The status or check suite Windows build_tests_1_7 has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2024-06-17T19:32:11Z

auto label is removed for flutter/flutter/149839, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

Manual roll requested by [email protected] flutter/flutter@ccf3abe...6c06abb 2024-06-18 [email protected] Add test for engine artifact framework permissions (flutter/flutter#148786) 2024-06-18 [email protected] Add test for icon_button.3.dart (flutter/flutter#149988) 2024-06-18 [email protected] Roll Flutter Engine from 78fdd06af541 to 74f42ca3544c (6 revisions) (flutter/flutter#150421) 2024-06-18 [email protected] Fix transparent `dividerColor` breaks `TabBar.tabAlignment` (flutter/flutter#150350) 2024-06-18 [email protected] Fix scrollable `TabBar` jittering (flutter/flutter#150041) 2024-06-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland 3: [CupertinoActionSheet] Match colors to native (#150386)" (flutter/flutter#150413) 2024-06-18 [email protected] Extend the Windows web_tool_tests_1_2 shard timeout to 45 minutes (flutter/flutter#150393) 2024-06-18 [email protected] Roll Flutter Engine from 1c4e5e230ecb to 78fdd06af541 (3 revisions) (flutter/flutter#150403) 2024-06-18 [email protected] Roll Flutter Engine from a4f266f7eb1a to 1c4e5e230ecb (8 revisions) (flutter/flutter#150399) 2024-06-18 [email protected] Rename doc file to use standard hyphens (flutter/flutter#150314) 2024-06-17 [email protected] Fix typo in `SliverLayoutDimensions.hashCode` where not all properties are used in the hash code. (flutter/flutter#150306) 2024-06-17 [email protected] Fix doc comment references to 'this' (flutter/flutter#150379) 2024-06-17 [email protected] Add 'fail-fast' argument to flutter test (flutter/flutter#149587) 2024-06-17 [email protected] Update matchesGoldenFile documentation reference to goldenFileComparator (flutter/flutter#150343) 2024-06-17 [email protected] Reland 3: [CupertinoActionSheet] Match colors to native (flutter/flutter#150386) 2024-06-17 [email protected] [a11y] Add semantics: button to bottom navigation bar items and dropdown menu items (flutter/flutter#149375) 2024-06-17 [email protected] Reland "sliverGridDelegate mainAxisExtent add assert (#148470)" (flutter/flutter#149720) 2024-06-17 [email protected] `ScaffoldBackgroundColor` should default to `ColorScheme.surface` (flutter/flutter#149772) 2024-06-17 [email protected] Reland TreeSliver (flutter/flutter#149839) 2024-06-17 [email protected] Reland: [CupertinoActionSheet] Add sliding tap gesture (flutter/flutter#150219) 2024-06-17 [email protected] Roll Flutter Engine from 5989f0215fed to a4f266f7eb1a (1 revision) (flutter/flutter#150377) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

) Manual roll requested by [email protected] flutter/flutter@ccf3abe...6c06abb 2024-06-18 [email protected] Add test for engine artifact framework permissions (flutter/flutter#148786) 2024-06-18 [email protected] Add test for icon_button.3.dart (flutter/flutter#149988) 2024-06-18 [email protected] Roll Flutter Engine from 78fdd06af541 to 74f42ca3544c (6 revisions) (flutter/flutter#150421) 2024-06-18 [email protected] Fix transparent `dividerColor` breaks `TabBar.tabAlignment` (flutter/flutter#150350) 2024-06-18 [email protected] Fix scrollable `TabBar` jittering (flutter/flutter#150041) 2024-06-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland 3: [CupertinoActionSheet] Match colors to native (#150386)" (flutter/flutter#150413) 2024-06-18 [email protected] Extend the Windows web_tool_tests_1_2 shard timeout to 45 minutes (flutter/flutter#150393) 2024-06-18 [email protected] Roll Flutter Engine from 1c4e5e230ecb to 78fdd06af541 (3 revisions) (flutter/flutter#150403) 2024-06-18 [email protected] Roll Flutter Engine from a4f266f7eb1a to 1c4e5e230ecb (8 revisions) (flutter/flutter#150399) 2024-06-18 [email protected] Rename doc file to use standard hyphens (flutter/flutter#150314) 2024-06-17 [email protected] Fix typo in `SliverLayoutDimensions.hashCode` where not all properties are used in the hash code. (flutter/flutter#150306) 2024-06-17 [email protected] Fix doc comment references to 'this' (flutter/flutter#150379) 2024-06-17 [email protected] Add 'fail-fast' argument to flutter test (flutter/flutter#149587) 2024-06-17 [email protected] Update matchesGoldenFile documentation reference to goldenFileComparator (flutter/flutter#150343) 2024-06-17 [email protected] Reland 3: [CupertinoActionSheet] Match colors to native (flutter/flutter#150386) 2024-06-17 [email protected] [a11y] Add semantics: button to bottom navigation bar items and dropdown menu items (flutter/flutter#149375) 2024-06-17 [email protected] Reland "sliverGridDelegate mainAxisExtent add assert (#148470)" (flutter/flutter#149720) 2024-06-17 [email protected] `ScaffoldBackgroundColor` should default to `ColorScheme.surface` (flutter/flutter#149772) 2024-06-17 [email protected] Reland TreeSliver (flutter/flutter#149839) 2024-06-17 [email protected] Reland: [CupertinoActionSheet] Add sliding tap gesture (flutter/flutter#150219) 2024-06-17 [email protected] Roll Flutter Engine from 5989f0215fed to a4f266f7eb1a (1 revision) (flutter/flutter#150377) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Jun 6, 2024

Piinks changed the title ~~Sliver tree 3~~ Reland TreeSliver Jun 6, 2024

Piinks requested a review from QuncCccccc June 6, 2024 20:01

QuncCccccc approved these changes Jun 6, 2024

View reviewed changes

Piinks added 21 commits June 17, 2024 11:15

Copy over sans custom render object

3fc764f

Updates

bab7d22

++

a4152c9

Switching branches

d8314e0

Progress

df67f27

Stopping, stuck on clip issue

5bde093

Updates

23180bb

Tweaks, going off to make premliminary changes

3a7c3f5

++

41fb073

Tweaks

ebd3063

Nits

f93cab2

Tweaks to align better with 2D

79d7664

Test progress

19f0a8f

++

72e38d2

Progress

af42207

More progress

53b96be

More tests

d7cd983

Nits

546c17e

Fix doc references

89a4cb9

Move sliver_tree to material for stinkin icon

8884655

++

72a2283

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 17, 2024

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 17, 2024

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 17, 2024

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 17, 2024

auto-submit Bot merged commit 9b6813f into flutter:master Jun 17, 2024

engine-flutter-autoroll mentioned this pull request Jun 18, 2024

Roll Flutter from ccf3abe94047 to b44c67e2e893 (19 revisions) flutter/packages#6944

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2024

9b6813f Reland TreeSliver (flutter/flutter#149839)

badded2

engine-flutter-autoroll mentioned this pull request Jun 18, 2024

Roll Flutter from ccf3abe94047 to f2c48afbb1cf (20 revisions) flutter/packages#6945

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2024

9b6813f Reland TreeSliver (flutter/flutter#149839)

13840e7

engine-flutter-autoroll mentioned this pull request Jun 18, 2024

Roll Flutter from ccf3abe94047 to 6c06abbb5576 (21 revisions) flutter/packages#6947

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2024

9b6813f Reland TreeSliver (flutter/flutter#149839)

5ae735e

engine-flutter-autoroll mentioned this pull request Jun 18, 2024

Roll Flutter from ccf3abe94047 to f54dfcd27db8 (22 revisions) flutter/packages#6948

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2024

9b6813f Reland TreeSliver (flutter/flutter#149839)

255f622

engine-flutter-autoroll mentioned this pull request Jun 19, 2024

Roll Flutter from ccf3abe94047 to 71ac7f55b3dd (29 revisions) flutter/packages#6950

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2024

9b6813f Reland TreeSliver (flutter/flutter#149839)

5c1b8d4

engine-flutter-autoroll mentioned this pull request Jun 19, 2024

Roll Flutter from ccf3abe94047 to 71ac7f55b3dd (29 revisions) flutter/packages#6951

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2024

9b6813f Reland TreeSliver (flutter/flutter#149839)

e0e8dec

engine-flutter-autoroll mentioned this pull request Jun 20, 2024

Manual roll Flutter from ccf3abe94047 to 6c06abbb5576 (21 revisions) flutter/packages#6954

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 20, 2024

9b6813f Reland TreeSliver (flutter/flutter#149839)

49a9c0c

engine-flutter-autoroll mentioned this pull request Jun 20, 2024

Roll Flutter from ccf3abe94047 to bfdcb51643b3 (32 revisions) flutter/packages#6955

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 20, 2024

9b6813f Reland TreeSliver (flutter/flutter#149839)

18e7f46

engine-flutter-autoroll mentioned this pull request Jun 20, 2024

Roll Flutter from ccf3abe94047 to 0674f46e9fde (33 revisions) flutter/packages#6956

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 20, 2024

9b6813f Reland TreeSliver (flutter/flutter#149839)

ccda3ca

Piinks mentioned this pull request Jun 28, 2024

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

9b6813f Reland TreeSliver (flutter/flutter#149839)

e58287d

Navigation Menu

Repository navigation

Reland TreeSliver - #149839

Reland TreeSliver #149839
auto-submit[bot] merged 34 commits into
flutter:masterfrom
Piinks:sliverTree-3

Piinks commented Jun 6, 2024 •

edited

Loading

Uh oh!

Piinks commented Jun 6, 2024

Uh oh!

QuncCccccc left a comment

Uh oh!

Piinks commented Jun 6, 2024

Uh oh!

auto-submit Bot commented Jun 17, 2024

Uh oh!

auto-submit Bot commented Jun 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Piinks commented Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Piinks commented Jun 6, 2024

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks commented Jun 6, 2024

Uh oh!

auto-submit Bot commented Jun 17, 2024

Uh oh!

auto-submit Bot commented Jun 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Piinks commented Jun 6, 2024 •

edited

Loading