Add button semantics in list tile by hannah-hyj · Pull Request #151599 · flutter/flutter

hannah-hyj · 2024-07-11T17:39:03Z

fixes: #111960

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

chunhtai · 2024-07-11T18:55:53Z

      autofocus: autofocus,
      enableFeedback: enableFeedback ?? tileTheme.enableFeedback ?? true,
      child: Semantics(
+        button: onTap != null || onLongPress != null,


does this need to take enabled into account?

if enable is false and onTap is not null, I think it's still a button just a disabled button

chunhtai

LGTM

chingjun · 2024-07-27T04:38:58Z

Reason for revert: broke an internal test.

This reverts commit 37dff27.

Reverts: #151599 Initiated by: chingjun Reason for reverting: broke an internal test. Original PR Author: hangyujin Reviewed By: {chunhtai} This change reverts the following previous change: fixes: #111960

…ntrol behavior. (#152526) #151599 was reverted because it was a breaking change to g3 Will reland 151599 in 5 steps 1. Make changes with an additional parameter ( bool internalAddSemanticForOnTap = false) 2. Send regular CLs in google3 to pass internalAddSemanticForOnTap: true, and update the tests / text goldens accordingly. 3. Send a PR to flip the default value to true. 4. Send CLs internally to remove internalAddSemanticForOnTap: true. 5. Send another PR to remove the now-redundant internalAddSemanticForOnTap flag. (<----This PR is step 1)

Manual roll requested by [email protected] flutter/flutter@4d12197...f817e51 2024-07-27 [email protected] Roll Flutter Engine from 38fddb289f18 to add1b784b80a (3 revisions) (flutter/flutter#152436) 2024-07-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add button semantics in list tile (#151599)" (flutter/flutter#152425) 2024-07-27 [email protected] Roll Flutter Engine from 739ae15e8bf2 to 38fddb289f18 (2 revisions) (flutter/flutter#152424) 2024-07-27 [email protected] Document that `flutter drive --test-arguments` can opt-in to `dart test` (flutter/flutter#152410) 2024-07-27 [email protected] Roll Flutter Engine from 0c5504e15e15 to 739ae15e8bf2 (4 revisions) (flutter/flutter#152417) 2024-07-27 [email protected] Roll Flutter Engine from e28f8755e25b to 0c5504e15e15 (5 revisions) (flutter/flutter#152414) 2024-07-26 [email protected] Add button semantics in list tile (flutter/flutter#151599) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fixes: flutter#111960 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…#152425) Reverts: flutter#151599 Initiated by: chingjun Reason for reverting: broke an internal test. Original PR Author: hangyujin Reviewed By: {chunhtai} This change reverts the following previous change: fixes: flutter#111960

…g to control behavior. (flutter#152526) flutter#151599 was reverted because it was a breaking change to g3 Will reland 151599 in 5 steps 1. Make changes with an additional parameter ( bool internalAddSemanticForOnTap = false) 2. Send regular CLs in google3 to pass internalAddSemanticForOnTap: true, and update the tests / text goldens accordingly. 3. Send a PR to flip the default value to true. 4. Send CLs internally to remove internalAddSemanticForOnTap: true. 5. Send another PR to remove the now-redundant internalAddSemanticForOnTap flag. (<----This PR is step 1)

fixes: flutter#111960 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…#152425) Reverts: flutter#151599 Initiated by: chingjun Reason for reverting: broke an internal test. Original PR Author: hangyujin Reviewed By: {chunhtai} This change reverts the following previous change: fixes: flutter#111960

…g to control behavior. (flutter#152526) flutter#151599 was reverted because it was a breaking change to g3 Will reland 151599 in 5 steps 1. Make changes with an additional parameter ( bool internalAddSemanticForOnTap = false) 2. Send regular CLs in google3 to pass internalAddSemanticForOnTap: true, and update the tests / text goldens accordingly. 3. Send a PR to flip the default value to true. 4. Send CLs internally to remove internalAddSemanticForOnTap: true. 5. Send another PR to remove the now-redundant internalAddSemanticForOnTap flag. (<----This PR is step 1)

Manual roll requested by [email protected] flutter/flutter@4d12197...f817e51 2024-07-27 [email protected] Roll Flutter Engine from 38fddb289f18 to add1b784b80a (3 revisions) (flutter/flutter#152436) 2024-07-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add button semantics in list tile (#151599)" (flutter/flutter#152425) 2024-07-27 [email protected] Roll Flutter Engine from 739ae15e8bf2 to 38fddb289f18 (2 revisions) (flutter/flutter#152424) 2024-07-27 [email protected] Document that `flutter drive --test-arguments` can opt-in to `dart test` (flutter/flutter#152410) 2024-07-27 [email protected] Roll Flutter Engine from 0c5504e15e15 to 739ae15e8bf2 (4 revisions) (flutter/flutter#152417) 2024-07-27 [email protected] Roll Flutter Engine from e28f8755e25b to 0c5504e15e15 (5 revisions) (flutter/flutter#152414) 2024-07-26 [email protected] Add button semantics in list tile (flutter/flutter#151599) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Reverts: flutter/flutter#151599 Initiated by: chingjun Reason for reverting: broke an internal test. Original PR Author: hangyujin Reviewed By: {chunhtai} This change reverts the following previous change: fixes: flutter/flutter#111960

…ntrol behavior. (#152526) flutter/flutter#151599 was reverted because it was a breaking change to g3 Will reland 151599 in 5 steps 1. Make changes with an additional parameter ( bool internalAddSemanticForOnTap = false) 2. Send regular CLs in google3 to pass internalAddSemanticForOnTap: true, and update the tests / text goldens accordingly. 3. Send a PR to flip the default value to true. 4. Send CLs internally to remove internalAddSemanticForOnTap: true. 5. Send another PR to remove the now-redundant internalAddSemanticForOnTap flag. (<----This PR is step 1)

Manual roll requested by [email protected] flutter/flutter@4d12197...f817e51 2024-07-27 [email protected] Roll Flutter Engine from 38fddb289f18 to add1b784b80a (3 revisions) (flutter/flutter#152436) 2024-07-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add button semantics in list tile (#151599)" (flutter/flutter#152425) 2024-07-27 [email protected] Roll Flutter Engine from 739ae15e8bf2 to 38fddb289f18 (2 revisions) (flutter/flutter#152424) 2024-07-27 [email protected] Document that `flutter drive --test-arguments` can opt-in to `dart test` (flutter/flutter#152410) 2024-07-27 [email protected] Roll Flutter Engine from 0c5504e15e15 to 739ae15e8bf2 (4 revisions) (flutter/flutter#152417) 2024-07-27 [email protected] Roll Flutter Engine from e28f8755e25b to 0c5504e15e15 (5 revisions) (flutter/flutter#152414) 2024-07-26 [email protected] Add button semantics in list tile (flutter/flutter#151599) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Jul 11, 2024

hannah-hyj requested a review from chunhtai July 11, 2024 17:39

chunhtai reviewed Jul 11, 2024

View reviewed changes

hannah-hyj requested a review from chunhtai July 11, 2024 20:12

chunhtai approved these changes Jul 16, 2024

View reviewed changes

hannah-hyj force-pushed the list-tile-semantics-button branch from 629f128 to 8cd4a52 Compare July 25, 2024 18:47

hannah-hyj added 3 commits July 26, 2024 15:47

add button

66353be

Update expansion_tile_test.dart

2a0f086

Update checkbox_list_tile_test.dart

ece02e3

hannah-hyj force-pushed the list-tile-semantics-button branch from 8cd4a52 to ece02e3 Compare July 26, 2024 22:47

hannah-hyj merged commit 37dff27 into flutter:master Jul 26, 2024

chingjun added the revert Autorevert PR (with "Reason for revert:" comment) label Jul 27, 2024

auto-submit Bot pushed a commit that referenced this pull request Jul 27, 2024

Revert "Add button semantics in list tile (#151599)"

7843500

This reverts commit 37dff27.

auto-submit Bot mentioned this pull request Jul 27, 2024

Reverts "Add button semantics in list tile (#151599)" #152425

Merged

9 tasks

auto-submit Bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jul 27, 2024

engine-flutter-autoroll mentioned this pull request Jul 27, 2024

Roll Flutter from 7d5c1c04fb56 to e8d4c98b07f8 (115 revisions) flutter/packages#7227

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2024

37dff27 Add button semantics in list tile (flutter/flutter#151599)

91dd1a1

engine-flutter-autoroll mentioned this pull request Jul 27, 2024

Roll Flutter from 7d5c1c04fb56 to f817e51a3a34 (116 revisions) flutter/packages#7228

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2024

37dff27 Add button semantics in list tile (flutter/flutter#151599)

6fa10a7

engine-flutter-autoroll mentioned this pull request Jul 28, 2024

Roll Flutter from 7d5c1c04fb56 to 5efbde1a18ad (119 revisions) flutter/packages#7230

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2024

37dff27 Add button semantics in list tile (flutter/flutter#151599)

e7b1c24

engine-flutter-autoroll mentioned this pull request Jul 28, 2024

Roll Flutter from 7d5c1c04fb56 to 5efbde1a18ad (119 revisions) flutter/packages#7231

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2024

37dff27 Add button semantics in list tile (flutter/flutter#151599)

1479dd1

engine-flutter-autoroll mentioned this pull request Jul 29, 2024

Roll Flutter from 031dc3d156b9 to a7bd806fc7f3 (29 revisions) flutter/packages#7247

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 29, 2024

37dff27 Add button semantics in list tile (flutter/flutter#151599)

7a710fe

engine-flutter-autoroll mentioned this pull request Jul 29, 2024

Roll Flutter from 031dc3d156b9 to 771650ca16aa (30 revisions) flutter/packages#7248

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 29, 2024

37dff27 Add button semantics in list tile (flutter/flutter#151599)

38849de

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 29, 2024

37dff27 Add button semantics in list tile (flutter/flutter#151599)

0704276

hannah-hyj mentioned this pull request Jul 30, 2024

Reland #151599 (Add button semantics in list tile ) with a flag to control behavior. #152526

Merged

9 tasks

engine-flutter-autoroll mentioned this pull request Jul 30, 2024

Roll Flutter from 031dc3d156b9 to 85960d24b9d2 (49 revisions) flutter/packages#7254

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 30, 2024

37dff27 Add button semantics in list tile (flutter/flutter#151599)

f3d1e00

engine-flutter-autoroll mentioned this pull request Jul 30, 2024

Roll Flutter from 031dc3d156b9 to 61848a448b08 (50 revisions) flutter/packages#7255

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 30, 2024

37dff27 Add button semantics in list tile (flutter/flutter#151599)

3e6ea11

engine-flutter-autoroll mentioned this pull request Jul 30, 2024

Roll Flutter from 031dc3d156b9 to cd60efc618eb (51 revisions) flutter/packages#7256

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 30, 2024

37dff27 Add button semantics in list tile (flutter/flutter#151599)

5e79c59

engine-flutter-autoroll mentioned this pull request Jul 30, 2024

Roll Flutter from 031dc3d156b9 to 5a47cfb3b04a (52 revisions) flutter/packages#7257

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 30, 2024

37dff27 Add button semantics in list tile (flutter/flutter#151599)

f3984bf

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2024

37dff27 Add button semantics in list tile (flutter/flutter#151599)

7d2518a

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2024

37dff27 Add button semantics in list tile (flutter/flutter#151599)

1dd896f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2024

37dff27 Add button semantics in list tile (flutter/flutter#151599)

c34cd13

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2024

37dff27 Add button semantics in list tile (flutter/flutter#151599)

2e9c0e2

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2024

37dff27 Add button semantics in list tile (flutter/flutter#151599)

efca023

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2024

37dff27 Add button semantics in list tile (flutter/flutter#151599)

62efc84

engine-flutter-autoroll mentioned this pull request Aug 1, 2024

Manual roll Flutter from 4d12197ca68d to f817e51a3a34 (7 revisions) flutter/packages#7270

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2024

37dff27 Add button semantics in list tile (flutter/flutter#151599)

70378a5

Navigation Menu

Repository navigation

Add button semantics in list tile - #151599

Add button semantics in list tile#151599
hannah-hyj merged 3 commits into
flutter:masterfrom
hannah-hyj:list-tile-semantics-button

hannah-hyj commented Jul 11, 2024

Uh oh!

chunhtai Jul 11, 2024

Uh oh!

hannah-hyj Jul 11, 2024

Uh oh!

chunhtai left a comment

Uh oh!

chingjun commented Jul 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

hannah-hyj commented Jul 11, 2024

Pre-launch Checklist

Uh oh!

chunhtai Jul 11, 2024

Choose a reason for hiding this comment

Uh oh!

hannah-hyj Jul 11, 2024

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

chingjun commented Jul 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants