Skip to content

Reland #151599 (Add button semantics in list tile ) with a flag to control behavior. - #152526

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
hannah-hyj:reland-151599
Jul 30, 2024
Merged

Reland #151599 (Add button semantics in list tile ) with a flag to control behavior. #152526
auto-submit[bot] merged 3 commits into
flutter:masterfrom
hannah-hyj:reland-151599

Conversation

@hannah-hyj

@hannah-hyj hannah-hyj commented Jul 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

#151599 was reverted because it was a breaking change to g3
fixes: #111960

Will reland 151599 in 5 steps

  1. Make changes with an additional parameter ( bool internalAddSemanticForOnTap = false)
  2. Send regular CLs in google3 to pass internalAddSemanticForOnTap: true, and update the tests / text goldens accordingly.
  3. Send a PR to flip the default value to true.
  4. Send CLs internally to remove internalAddSemanticForOnTap: true.
  5. Send another PR to remove the now-redundant internalAddSemanticForOnTap flag.

(<----This PR is step 1)

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Jul 30, 2024
@hannah-hyj
hannah-hyj requested a review from chingjun July 30, 2024 00:36
chingjun
chingjun approved these changes Jul 30, 2024
View reviewed changes

@chingjun chingjun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this :)

@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 30, 2024
@auto-submit
auto-submit Bot merged commit dc6a159 into flutter:master Jul 30, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2024
@engine-flutter-autoroll
dc6a159 Reland #151599 (Add button semantics in list tile ) with a fl…
8fdb263 
…ag to control behavior. (flutter/flutter#152526)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2024
@engine-flutter-autoroll
dc6a159 Reland #151599 (Add button semantics in list tile ) with a fl…
c143292 
…ag to control behavior. (flutter/flutter#152526)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2024
@engine-flutter-autoroll
dc6a159 Reland #151599 (Add button semantics in list tile ) with a fl…
9aee518 
…ag to control behavior. (flutter/flutter#152526)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2024
@engine-flutter-autoroll
dc6a159 Reland #151599 (Add button semantics in list tile ) with a fl…
65e98c0 
…ag to control behavior. (flutter/flutter#152526)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2024
@engine-flutter-autoroll
dc6a159 Reland #151599 (Add button semantics in list tile ) with a fl…
b2fdc2e 
…ag to control behavior. (flutter/flutter#152526)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2024
@engine-flutter-autoroll
dc6a159 Reland #151599 (Add button semantics in list tile ) with a fl…
ac34586 
…ag to control behavior. (flutter/flutter#152526)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 1, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2024
@engine-flutter-autoroll
dc6a159 Reland #151599 (Add button semantics in list tile ) with a fl…
3e56c45 
…ag to control behavior. (flutter/flutter#152526)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 1, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2024
@engine-flutter-autoroll
dc6a159 Reland #151599 (Add button semantics in list tile ) with a fl…
c7c63f0 
…ag to control behavior. (flutter/flutter#152526)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 1, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2024
@engine-flutter-autoroll
dc6a159 Reland #151599 (Add button semantics in list tile ) with a fl…
02c6bb3 
…ag to control behavior. (flutter/flutter#152526)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 1, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2024
@engine-flutter-autoroll
dc6a159 Reland #151599 (Add button semantics in list tile ) with a fl…
1ab1eac 
…ag to control behavior. (flutter/flutter#152526)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 1, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2024
@engine-flutter-autoroll
dc6a159 Reland #151599 (Add button semantics in list tile ) with a fl…
e5ab391 
…ag to control behavior. (flutter/flutter#152526)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2024
@engine-flutter-autoroll
dc6a159 Reland #151599 (Add button semantics in list tile ) with a fl…
490e59e 
…ag to control behavior. (flutter/flutter#152526)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2024
@engine-flutter-autoroll
dc6a159 Reland #151599 (Add button semantics in list tile ) with a fl…
f2ad17a 
…ag to control behavior. (flutter/flutter#152526)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2024
@engine-flutter-autoroll
dc6a159 Reland #151599 (Add button semantics in list tile ) with a fl…
c854346 
…ag to control behavior. (flutter/flutter#152526)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2024
@engine-flutter-autoroll
dc6a159 Reland #151599 (Add button semantics in list tile ) with a fl…
33f6302 
…ag to control behavior. (flutter/flutter#152526)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 3, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 3, 2024
@engine-flutter-autoroll
dc6a159 Reland #151599 (Add button semantics in list tile ) with a fl…
c126f2f 
…ag to control behavior. (flutter/flutter#152526)
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Aug 3, 2024
@engine-flutter-autoroll
Manual roll Flutter from 85960d2 to 4ff9462 (45 revisions) (#7296)
8456049 
Manual roll Flutter from 85960d2 to 4ff9462 (45 revisions)

Manual roll requested by [email protected]

flutter/flutter@85960d2...4ff9462

2024-08-01 [email protected] Fix local testing, gradle XML errors, and enable on CI. (flutter/flutter#152383)
2024-08-01 [email protected] Fix formatting issues in `search_anchor.0_test.dart` (flutter/flutter#152669)
2024-08-01 [email protected] Add tests for search anchor examples (flutter/flutter#152659)
2024-08-01 [email protected] Roll Flutter Engine from 4dc94d6f88ba to 7c4a44611abe (1 revision) (flutter/flutter#152665)
2024-08-01 [email protected] Roll Flutter Engine from f546fef7d7cd to 4dc94d6f88ba (1 revision) (flutter/flutter#152663)
2024-08-01 [email protected] Roll Flutter Engine from 0fbff219c498 to f546fef7d7cd (2 revisions) (flutter/flutter#152661)
2024-08-01 [email protected] Roll Flutter Engine from 32f788823f43 to 0fbff219c498 (5 revisions) (flutter/flutter#152658)
2024-08-01 [email protected] Manual roll Flutter Engine from 32f788823f43 to ed95b491f260 (3 revisions) (flutter/flutter#152654)
2024-08-01 [email protected] Manual roll Flutter Engine from 16332725788c to 32f788823f43 (11 revisions) (flutter/flutter#152648)
2024-07-31 [email protected] [CupertinoActionSheet] Make `_ActionSheetButtonBackground` stateless (flutter/flutter#152283)
2024-07-31 [email protected] Implementing null-aware logic in `/packages/flutter/` (flutter/flutter#152294)
2024-07-31 [email protected] Reintroduce verbose logging for hot reload flake (flutter/flutter#152639)
2024-07-31 [email protected] [material/menu_anchor.dart] Remove unused early key event listener (flutter/flutter#150915)
2024-07-31 [email protected] Improve `CupertinoCheckbox` fidelity (flutter/flutter#151441)
2024-07-31 [email protected] Update docs to support new Android version (flutter/flutter#152503)
2024-07-31 [email protected] [Android] Update integration test AVD dependency to use Android 35 emulators (flutter/flutter#152498)
2024-07-31 [email protected] Shift + click gesture support for SelectionArea on desktop platforms (flutter/flutter#148574)
2024-07-31 [email protected] Add ability to clip `Stepper` step content (flutter/flutter#152370)
2024-07-31 [email protected] Calendar font factor (flutter/flutter#152341)
2024-07-31 [email protected] Remove redundant usages of zones in skia_client.dart (flutter/flutter#149366)
2024-07-31 [email protected] Set up tests that verify we can build a fresh counter app across our Gradle/AGP/Kotlin support range (flutter/flutter#151568)
2024-07-31 [email protected] remove bringup from Windows tool_integration_tests_* (flutter/flutter#152599)
2024-07-31 [email protected] â�¨ : Animation controller now has ability to repeat animation 'n' no. of times. (flutter/flutter#150764)
2024-07-31 [email protected] Roll Flutter Engine from 3b31b21599d1 to 16332725788c (1 revision) (flutter/flutter#152631)
2024-07-31 [email protected] Roll Flutter Engine from b73367a30e9b to 3b31b21599d1 (8 revisions) (flutter/flutter#152625)
2024-07-31 [email protected] Roll Packages from 99e8606 to 46a712f (8 revisions) (flutter/flutter#152622)
2024-07-31 [email protected] Add tests for scaffold messenger examples (flutter/flutter#152536)
2024-07-31 [email protected] Add test for search_anchor.0.dart (flutter/flutter#152371)
2024-07-31 [email protected] Use decoration hint text as the default value for dropdown button hints (flutter/flutter#152474)
2024-07-31 [email protected] Deprecate invalid InputDecoration.collapsed parameters (flutter/flutter#152486)
2024-07-31 [email protected] increase sharding on Windows tool_integration_tests (flutter/flutter#152582)
2024-07-31 [email protected] Roll Flutter Engine from e2ece7e58480 to b73367a30e9b (4 revisions) (flutter/flutter#152592)
2024-07-31 [email protected] Roll Flutter Engine from 0b42657a184e to e2ece7e58480 (2 revisions) (flutter/flutter#152589)
2024-07-31 [email protected] Roll Flutter Engine from 08f9be3ab284 to 0b42657a184e (2 revisions) (flutter/flutter#152586)
2024-07-30 [email protected] Clarify and cleanup the test-exemption wording in tree-hygiene. (flutter/flutter#152402)
2024-07-30 [email protected] [web] Set COEP:credentialless on flutter run/drive. (flutter/flutter#152413)
2024-07-30 [email protected] Roll Flutter Engine from a4b88a37d511 to 08f9be3ab284 (5 revisions) (flutter/flutter#152583)
2024-07-30 [email protected] Marks Mac platform_channel_sample_test_macos to be flaky (flutter/flutter#151884)
2024-07-30 [email protected] Roll Flutter Engine from a6c5ff26c266 to a4b88a37d511 (2 revisions) (flutter/flutter#152575)
2024-07-30 [email protected] Reland #151599 (Add button semantics in list tile ) with a flag to control behavior.  (flutter/flutter#152526)
2024-07-30 [email protected] Shift macOS/Android tests from Pixel 7 to mokey in staging (flutter/flutter#152571)
2024-07-30 [email protected] Roll Flutter Engine from 31bb9f98472a to a6c5ff26c266 (5 revisions) (flutter/flutter#152573)
2024-07-30 [email protected] Roll Packages from 247fb5f to 99e8606 (5 revisions) (flutter/flutter#152567)
2024-07-30 [email protected] Fix default avatar icon theme size for Material 2 (flutter/flutter#152307)
...
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
@hannah-hyj @TytaniumDev
Reland flutter#151599 (Add button semantics in list tile ) with a fla…
f2ad535 
…g to control behavior. (flutter#152526)

flutter#151599 was reverted because it was a breaking change to g3

Will reland 151599 in 5 steps 
1. Make changes with an additional parameter ( bool internalAddSemanticForOnTap = false)  
2. Send regular CLs in google3 to pass internalAddSemanticForOnTap: true, and update the tests / text goldens accordingly.
3. Send a PR to flip the default value to true.
4. Send CLs internally to remove internalAddSemanticForOnTap: true.
5. Send another PR to remove the now-redundant internalAddSemanticForOnTap flag.

 (<----This PR is step 1)
@hannah-hyj hannah-hyj mentioned this pull request Aug 9, 2024
Merged
9 tasks
auto-submit Bot pushed a commit that referenced this pull request Aug 28, 2024
@hannah-hyj
Change flag internalAddSemanticForOnTap default value to true (#153193)
4056639 
This is a follow up on #152526 

1. Make changes with an additional parameter ( bool internalAddSemanticForOnTap = false) (#152526 )
2. Send regular CLs in google3 to pass internalAddSemanticForOnTap: true, and update the tests / text goldens 3. accordingly.  g3 fix sent:  cl/661353802
3. Send a PR to flip the default value to true. (This PR)
4. Send CLs internally to remove internalAddSemanticForOnTap: true.
5. Send another PR to remove the now-redundant internalAddSemanticForOnTap flag.
(<----This PR is step 3)
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@hannah-hyj @Buchimi
Reland flutter#151599 (Add button semantics in list tile ) with a fla…
4212e68 
…g to control behavior. (flutter#152526)

flutter#151599 was reverted because it was a breaking change to g3

Will reland 151599 in 5 steps 
1. Make changes with an additional parameter ( bool internalAddSemanticForOnTap = false)  
2. Send regular CLs in google3 to pass internalAddSemanticForOnTap: true, and update the tests / text goldens accordingly.
3. Send a PR to flip the default value to true.
4. Send CLs internally to remove internalAddSemanticForOnTap: true.
5. Send another PR to remove the now-redundant internalAddSemanticForOnTap flag.

 (<----This PR is step 1)
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@hannah-hyj @Buchimi
Change flag internalAddSemanticForOnTap default value to true (flutte…
47e3612 
…r#153193)

This is a follow up on flutter#152526 

1. Make changes with an additional parameter ( bool internalAddSemanticForOnTap = false) (flutter#152526 )
2. Send regular CLs in google3 to pass internalAddSemanticForOnTap: true, and update the tests / text goldens 3. accordingly.  g3 fix sent:  cl/661353802
3. Send a PR to flip the default value to true. (This PR)
4. Send CLs internally to remove internalAddSemanticForOnTap: true.
5. Send another PR to remove the now-redundant internalAddSemanticForOnTap flag.
(<----This PR is step 3)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
dc6a159 Reland #151599 (Add button semantics in list tile ) with a fl…
fea8ba5 
…ag to control behavior. (flutter/flutter#152526)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
dc6a159 Reland #151599 (Add button semantics in list tile ) with a fl…
97dfe1b 
…ag to control behavior. (flutter/flutter#152526)
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Manual roll Flutter from 85960d2 to 4ff9462 (45 revisions) (flutter#7296
0ded50b 
)

Manual roll Flutter from 85960d2 to 4ff9462 (45 revisions)

Manual roll requested by [email protected]

flutter/flutter@85960d2...4ff9462

2024-08-01 [email protected] Fix local testing, gradle XML errors, and enable on CI. (flutter/flutter#152383)
2024-08-01 [email protected] Fix formatting issues in `search_anchor.0_test.dart` (flutter/flutter#152669)
2024-08-01 [email protected] Add tests for search anchor examples (flutter/flutter#152659)
2024-08-01 [email protected] Roll Flutter Engine from 4dc94d6f88ba to 7c4a44611abe (1 revision) (flutter/flutter#152665)
2024-08-01 [email protected] Roll Flutter Engine from f546fef7d7cd to 4dc94d6f88ba (1 revision) (flutter/flutter#152663)
2024-08-01 [email protected] Roll Flutter Engine from 0fbff219c498 to f546fef7d7cd (2 revisions) (flutter/flutter#152661)
2024-08-01 [email protected] Roll Flutter Engine from 32f788823f43 to 0fbff219c498 (5 revisions) (flutter/flutter#152658)
2024-08-01 [email protected] Manual roll Flutter Engine from 32f788823f43 to ed95b491f260 (3 revisions) (flutter/flutter#152654)
2024-08-01 [email protected] Manual roll Flutter Engine from 16332725788c to 32f788823f43 (11 revisions) (flutter/flutter#152648)
2024-07-31 [email protected] [CupertinoActionSheet] Make `_ActionSheetButtonBackground` stateless (flutter/flutter#152283)
2024-07-31 [email protected] Implementing null-aware logic in `/packages/flutter/` (flutter/flutter#152294)
2024-07-31 [email protected] Reintroduce verbose logging for hot reload flake (flutter/flutter#152639)
2024-07-31 [email protected] [material/menu_anchor.dart] Remove unused early key event listener (flutter/flutter#150915)
2024-07-31 [email protected] Improve `CupertinoCheckbox` fidelity (flutter/flutter#151441)
2024-07-31 [email protected] Update docs to support new Android version (flutter/flutter#152503)
2024-07-31 [email protected] [Android] Update integration test AVD dependency to use Android 35 emulators (flutter/flutter#152498)
2024-07-31 [email protected] Shift + click gesture support for SelectionArea on desktop platforms (flutter/flutter#148574)
2024-07-31 [email protected] Add ability to clip `Stepper` step content (flutter/flutter#152370)
2024-07-31 [email protected] Calendar font factor (flutter/flutter#152341)
2024-07-31 [email protected] Remove redundant usages of zones in skia_client.dart (flutter/flutter#149366)
2024-07-31 [email protected] Set up tests that verify we can build a fresh counter app across our Gradle/AGP/Kotlin support range (flutter/flutter#151568)
2024-07-31 [email protected] remove bringup from Windows tool_integration_tests_* (flutter/flutter#152599)
2024-07-31 [email protected] â�¨ : Animation controller now has ability to repeat animation 'n' no. of times. (flutter/flutter#150764)
2024-07-31 [email protected] Roll Flutter Engine from 3b31b21599d1 to 16332725788c (1 revision) (flutter/flutter#152631)
2024-07-31 [email protected] Roll Flutter Engine from b73367a30e9b to 3b31b21599d1 (8 revisions) (flutter/flutter#152625)
2024-07-31 [email protected] Roll Packages from 99e8606 to 46a712f (8 revisions) (flutter/flutter#152622)
2024-07-31 [email protected] Add tests for scaffold messenger examples (flutter/flutter#152536)
2024-07-31 [email protected] Add test for search_anchor.0.dart (flutter/flutter#152371)
2024-07-31 [email protected] Use decoration hint text as the default value for dropdown button hints (flutter/flutter#152474)
2024-07-31 [email protected] Deprecate invalid InputDecoration.collapsed parameters (flutter/flutter#152486)
2024-07-31 [email protected] increase sharding on Windows tool_integration_tests (flutter/flutter#152582)
2024-07-31 [email protected] Roll Flutter Engine from e2ece7e58480 to b73367a30e9b (4 revisions) (flutter/flutter#152592)
2024-07-31 [email protected] Roll Flutter Engine from 0b42657a184e to e2ece7e58480 (2 revisions) (flutter/flutter#152589)
2024-07-31 [email protected] Roll Flutter Engine from 08f9be3ab284 to 0b42657a184e (2 revisions) (flutter/flutter#152586)
2024-07-30 [email protected] Clarify and cleanup the test-exemption wording in tree-hygiene. (flutter/flutter#152402)
2024-07-30 [email protected] [web] Set COEP:credentialless on flutter run/drive. (flutter/flutter#152413)
2024-07-30 [email protected] Roll Flutter Engine from a4b88a37d511 to 08f9be3ab284 (5 revisions) (flutter/flutter#152583)
2024-07-30 [email protected] Marks Mac platform_channel_sample_test_macos to be flaky (flutter/flutter#151884)
2024-07-30 [email protected] Roll Flutter Engine from a6c5ff26c266 to a4b88a37d511 (2 revisions) (flutter/flutter#152575)
2024-07-30 [email protected] Reland #151599 (Add button semantics in list tile ) with a flag to control behavior.  (flutter/flutter#152526)
2024-07-30 [email protected] Shift macOS/Android tests from Pixel 7 to mokey in staging (flutter/flutter#152571)
2024-07-30 [email protected] Roll Flutter Engine from 31bb9f98472a to a6c5ff26c266 (5 revisions) (flutter/flutter#152573)
2024-07-30 [email protected] Roll Packages from 247fb5f to 99e8606 (5 revisions) (flutter/flutter#152567)
2024-07-30 [email protected] Fix default avatar icon theme size for Material 2 (flutter/flutter#152307)
...
chunhtai pushed a commit to chunhtai/packages that referenced this pull request Jun 12, 2026
@hannah-hyj
Change flag internalAddSemanticForOnTap default value to true (#153193)
cdb4bee 
This is a follow up on flutter/flutter#152526 

1. Make changes with an additional parameter ( bool internalAddSemanticForOnTap = false) (flutter/flutter#152526 )
2. Send regular CLs in google3 to pass internalAddSemanticForOnTap: true, and update the tests / text goldens 3. accordingly.  g3 fix sent:  cl/661353802
3. Send a PR to flip the default value to true. (This PR)
4. Send CLs internally to remove internalAddSemanticForOnTap: true.
5. Send another PR to remove the now-redundant internalAddSemanticForOnTap flag.
(<----This PR is step 3)
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@engine-flutter-autoroll
Manual roll Flutter from 85960d2 to 4ff9462 (45 revisions) (flutter#7296
0bc6075 
)

Manual roll Flutter from 85960d2 to 4ff9462 (45 revisions)

Manual roll requested by [email protected]

flutter/flutter@85960d2...4ff9462

2024-08-01 [email protected] Fix local testing, gradle XML errors, and enable on CI. (flutter/flutter#152383)
2024-08-01 [email protected] Fix formatting issues in `search_anchor.0_test.dart` (flutter/flutter#152669)
2024-08-01 [email protected] Add tests for search anchor examples (flutter/flutter#152659)
2024-08-01 [email protected] Roll Flutter Engine from 4dc94d6f88ba to 7c4a44611abe (1 revision) (flutter/flutter#152665)
2024-08-01 [email protected] Roll Flutter Engine from f546fef7d7cd to 4dc94d6f88ba (1 revision) (flutter/flutter#152663)
2024-08-01 [email protected] Roll Flutter Engine from 0fbff219c498 to f546fef7d7cd (2 revisions) (flutter/flutter#152661)
2024-08-01 [email protected] Roll Flutter Engine from 32f788823f43 to 0fbff219c498 (5 revisions) (flutter/flutter#152658)
2024-08-01 [email protected] Manual roll Flutter Engine from 32f788823f43 to ed95b491f260 (3 revisions) (flutter/flutter#152654)
2024-08-01 [email protected] Manual roll Flutter Engine from 16332725788c to 32f788823f43 (11 revisions) (flutter/flutter#152648)
2024-07-31 [email protected] [CupertinoActionSheet] Make `_ActionSheetButtonBackground` stateless (flutter/flutter#152283)
2024-07-31 [email protected] Implementing null-aware logic in `/packages/flutter/` (flutter/flutter#152294)
2024-07-31 [email protected] Reintroduce verbose logging for hot reload flake (flutter/flutter#152639)
2024-07-31 [email protected] [material/menu_anchor.dart] Remove unused early key event listener (flutter/flutter#150915)
2024-07-31 [email protected] Improve `CupertinoCheckbox` fidelity (flutter/flutter#151441)
2024-07-31 [email protected] Update docs to support new Android version (flutter/flutter#152503)
2024-07-31 [email protected] [Android] Update integration test AVD dependency to use Android 35 emulators (flutter/flutter#152498)
2024-07-31 [email protected] Shift + click gesture support for SelectionArea on desktop platforms (flutter/flutter#148574)
2024-07-31 [email protected] Add ability to clip `Stepper` step content (flutter/flutter#152370)
2024-07-31 [email protected] Calendar font factor (flutter/flutter#152341)
2024-07-31 [email protected] Remove redundant usages of zones in skia_client.dart (flutter/flutter#149366)
2024-07-31 [email protected] Set up tests that verify we can build a fresh counter app across our Gradle/AGP/Kotlin support range (flutter/flutter#151568)
2024-07-31 [email protected] remove bringup from Windows tool_integration_tests_* (flutter/flutter#152599)
2024-07-31 [email protected] â�¨ : Animation controller now has ability to repeat animation 'n' no. of times. (flutter/flutter#150764)
2024-07-31 [email protected] Roll Flutter Engine from 3b31b21599d1 to 16332725788c (1 revision) (flutter/flutter#152631)
2024-07-31 [email protected] Roll Flutter Engine from b73367a30e9b to 3b31b21599d1 (8 revisions) (flutter/flutter#152625)
2024-07-31 [email protected] Roll Packages from 95dc6de to 44324a4 (8 revisions) (flutter/flutter#152622)
2024-07-31 [email protected] Add tests for scaffold messenger examples (flutter/flutter#152536)
2024-07-31 [email protected] Add test for search_anchor.0.dart (flutter/flutter#152371)
2024-07-31 [email protected] Use decoration hint text as the default value for dropdown button hints (flutter/flutter#152474)
2024-07-31 [email protected] Deprecate invalid InputDecoration.collapsed parameters (flutter/flutter#152486)
2024-07-31 [email protected] increase sharding on Windows tool_integration_tests (flutter/flutter#152582)
2024-07-31 [email protected] Roll Flutter Engine from e2ece7e58480 to b73367a30e9b (4 revisions) (flutter/flutter#152592)
2024-07-31 [email protected] Roll Flutter Engine from 0b42657a184e to e2ece7e58480 (2 revisions) (flutter/flutter#152589)
2024-07-31 [email protected] Roll Flutter Engine from 08f9be3ab284 to 0b42657a184e (2 revisions) (flutter/flutter#152586)
2024-07-30 [email protected] Clarify and cleanup the test-exemption wording in tree-hygiene. (flutter/flutter#152402)
2024-07-30 [email protected] [web] Set COEP:credentialless on flutter run/drive. (flutter/flutter#152413)
2024-07-30 [email protected] Roll Flutter Engine from a4b88a37d511 to 08f9be3ab284 (5 revisions) (flutter/flutter#152583)
2024-07-30 [email protected] Marks Mac platform_channel_sample_test_macos to be flaky (flutter/flutter#151884)
2024-07-30 [email protected] Roll Flutter Engine from a6c5ff26c266 to a4b88a37d511 (2 revisions) (flutter/flutter#152575)
2024-07-30 [email protected] Reland #151599 (Add button semantics in list tile ) with a flag to control behavior.  (flutter/flutter#152526)
2024-07-30 [email protected] Shift macOS/Android tests from Pixel 7 to mokey in staging (flutter/flutter#152571)
2024-07-30 [email protected] Roll Flutter Engine from 31bb9f98472a to a6c5ff26c266 (5 revisions) (flutter/flutter#152573)
2024-07-30 [email protected] Roll Packages from baff13b to 95dc6de (5 revisions) (flutter/flutter#152567)
2024-07-30 [email protected] Fix default avatar icon theme size for Material 2 (flutter/flutter#152307)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingjun chingjun chingjun approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ListTile should be able to set SemanticProperties.button: true if it has an enabled onTap

2 participants

@hannah-hyj @chingjun