Skip to content

Ignore cxx folders for all of flutter/flutter - #160381

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
reidbaker:i160372-cxx-folders-flutter
Dec 16, 2024
Merged

Ignore cxx folders for all of flutter/flutter#160381
auto-submit[bot] merged 1 commit into
flutter:masterfrom
reidbaker:i160372-cxx-folders-flutter

Conversation

@reidbaker

@reidbaker reidbaker commented Dec 16, 2024

Copy link
Copy Markdown
Contributor

Related to #160372

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@reidbaker
reidbaker requested a review from matanlurey December 16, 2024 20:52
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 16, 2024
@auto-submit
auto-submit Bot added this pull request to the merge queue Dec 16, 2024
Merged via the queue into flutter:master with commit 17960e7 Dec 16, 2024
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 16, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
416d4d6 
…r#160381)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
cfe3751 
…r#160381)
@reidbaker
reidbaker deleted the i160372-cxx-folders-flutter branch December 17, 2024 16:19
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
a04b254 
…r#160381)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2024
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
2f14a55 
…r#160381)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
20f3eca 
…r#160381)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
37d80b6 
…r#160381)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
f1d08b0 
…r#160381)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
218a5fa 
…r#160381)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
09fc2a4 
…r#160381)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
0c31406 
…r#160381)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
062358d 
…r#160381)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
1def2f6 
…r#160381)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
672dae6 
…r#160381)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
6b71423 
…r#160381)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
95a68f9 
…r#160381)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
5ede684 
…r#160381)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
59c3835 
…r#160381)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
76c4d17 
…r#160381)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
1bcf8d7 
…r#160381)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
b9e5985 
…r#160381)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
790d49a 
…r#160381)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
2203e77 
…r#160381)
@huycozy huycozy mentioned this pull request Feb 14, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
24f86dc 
…r#160381)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
17960e7 Ignore cxx folders for all of flutter/flutter (flutter/flutte…
40aef9e 
…r#160381)
@bartvanandel

bartvanandel commented Mar 24, 2025

Copy link
Copy Markdown

@reidbaker I'm afraid this change has been undone by 721b47e, I guess this was unintentional?

@reidbaker

reidbaker commented Mar 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@reidbaker I'm afraid this change has been undone by 721b47e, I guess this was unintentional?

Yes putting up a patch now. I didnt see this because I also added it to my global gitignore.

reidbaker added a commit that referenced this pull request Mar 24, 2025
@reidbaker
Update .gitignore to reinclude **/.cxx/
4f4d0be 
See #160381 (comment) 
and 721b47e
@reidbaker reidbaker mentioned this pull request Mar 24, 2025
Merged
9 tasks done
github-merge-queue Bot pushed a commit that referenced this pull request Mar 24, 2025
@reidbaker
Update .gitignore to reinclude **/.cxx/ (#165793)
5db3c88 
See
#160381 (comment)
and
721b47e

Related to #160381 


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@reidbaker yuuangzhang
Update .gitignore to reinclude **/.cxx/ (flutter#165793)
5335739 
See
flutter#160381 (comment)
and
flutter@721b47e

Related to flutter#160381 


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@reidbaker @romanejaquez
Update .gitignore to reinclude **/.cxx/ (flutter#165793)
56f8315 
See
flutter#160381 (comment)
and
flutter@721b47e

Related to flutter#160381 


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@matanlurey matanlurey matanlurey approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reidbaker @bartvanandel @matanlurey