Skip to content

Update .gitignore to reinclude **/.cxx/ - #165793

Merged
auto-submit[bot] merged 1 commit into
masterfrom
i160381-undo-accidental-revert-cxx
Mar 24, 2025
Merged

Update .gitignore to reinclude **/.cxx/#165793
auto-submit[bot] merged 1 commit into
masterfrom
i160381-undo-accidental-revert-cxx

Conversation

@reidbaker

@reidbaker reidbaker commented Mar 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

See #160381 (comment) and 721b47e

Related to #160381

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@reidbaker reidbaker added c: regression It was better in the past than it is now platform-android Android applications specifically team-android Owned by Android platform team labels Mar 24, 2025
@reidbaker
reidbaker requested review from a team and jtmcdole March 24, 2025 13:42
@github-actions github-actions Bot removed platform-android Android applications specifically team-android Owned by Android platform team labels Mar 24, 2025
@bartvanandel

bartvanandel commented Mar 24, 2025

Copy link
Copy Markdown

Thanks for picking this up!

Looking at (most of) the rest of the Android-specific ignore entries, would it make sense to make this more specific and target **/android/**/.cxx/ instead of **/.cxx/?

@reidbaker

reidbaker commented Mar 24, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for picking this up!

Looking at (most of) the rest of the Android-specific ignore entries, would it make sense to make this more specific and target **/android/**/.cxx/ instead of **/.cxx/?

IIRC I had that in an initial version but there were some cases where it didnt catch what we wanted. Maybe the add to app integration tests or the custom named sub directory tests.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2025
@auto-submit
auto-submit Bot added this pull request to the merge queue Mar 24, 2025
Merged via the queue into master with commit 5db3c88 Mar 24, 2025
@auto-submit
auto-submit Bot deleted the i160381-undo-accidental-revert-cxx branch March 24, 2025 19:08
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
1357bde
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
5da0849
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
8648d96
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
86afcf8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
ad94af2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
b32f1d2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
ad24cea
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
8563ecd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
bb110cd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
cdd52ad
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
c9df6bf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
1c73d3b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
44c7e46
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
e3b6727
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
2d3dff8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
194536f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
8892c3d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
f040212
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
ea61ca1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
c63405c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
5fdde0d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
92f9124
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
a2fed72
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
901e2fe
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
e182ca0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
b34a229
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
de60ab8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
6f7e550
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
e1b53da
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
9ebcc39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
899e84c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
4fab30a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
a7c3384
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
140dda4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
7423115
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
8c422e3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
869b9c3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
5db3c88 Update .gitignore to reinclude **/.cxx/ (flutter/flutter#165793)
18b313f
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@reidbaker yuuangzhang
Update .gitignore to reinclude **/.cxx/ (flutter#165793)
5335739 
See
flutter#160381 (comment)
and
flutter@721b47e

Related to flutter#160381 


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@reidbaker @romanejaquez
Update .gitignore to reinclude **/.cxx/ (flutter#165793)
56f8315 
See
flutter#160381 (comment)
and
flutter@721b47e

Related to flutter#160381 


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtmcdole jtmcdole jtmcdole approved these changes
@gmackall gmackall gmackall approved these changes

Assignees

No one assigned

Labels

c: regression It was better in the past than it is now

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@reidbaker @bartvanandel @jtmcdole @gmackall