Do not block vertical drag gestures in CupertinoSheetRoute body by MitchellGoodwin · Pull Request #161696 · flutter/flutter

MitchellGoodwin · 2025-01-15T22:08:38Z

Changes how the VerticalGestureRecognizer watches the sheet body. Before it stacked over the sheet and won all gesture arenas with vertical drags, so it didn't allow scrolling in the sheet. Now it has the sheet content as its child, so it will defer to child vertical gestures. This PR will allow scrolling to work in the sheet, but further work needs to be done to improve scrolling and drag to dismiss working together, see #161687.

Screen.Recording.2025-01-15.at.2.07.19.PM.mov

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

justinmc

LGTM 👍

For posterity and my own future memory, this PR allows the Scrollable to scroll, but on native it has the additional feature that when you reach the end of the Scrollable and continue dragging, the sheet gets dragged. That's not yet implemented here.

justinmc · 2025-01-16T00:26:38Z

+
+      await gesture.down(const Offset(100, 100));
+
+      // Need 2 events to form a valid drag


Super nit: Period at the end.

justinmc · 2025-01-16T00:28:58Z

+      final double endPosition = tester.getTopLeft(find.text('Middle of Scroll')).dy;
+
+      // Final position should be higher.
+      expect(endPosition, lessThan(startPosition));


Do tests that create a TestGesture need to end with gesture.up and pumpAndSettle? I'm thinking of this PR #136136 CC @polina-c

Oh, very likely we do. I'll put that in.

…dy (flutter/flutter#161696)

flutter/flutter@5517cc9...b9e86a5 2025-01-18 [email protected] Fix link to Linux custom embedder artifacts (flutter/flutter#161699) 2025-01-18 [email protected] Remove tests, GLFW examples, and non-artifact builds from `linux_host_engine`. (flutter/flutter#161786) 2025-01-18 [email protected] [Impeller] when mips are disabled, also disable from sampler options. (flutter/flutter#161765) 2025-01-18 [email protected] revert removing Twitter, retain BlueSky (flutter/flutter#161803) 2025-01-17 [email protected] fix reorderable_list_test.dart (flutter/flutter#161836) 2025-01-17 [email protected] [Release] Update the cherry-pick process. (flutter/flutter#161771) 2025-01-17 [email protected] Reland "#143249 Autocomplete options width" (flutter/flutter#161695) 2025-01-17 [email protected] Roll Dart to Version 3.8.0-1.0.dev (flutter/flutter#161781) 2025-01-17 [email protected] [Impeller] use 3 fences to synchronize AHB swapchains (like we do for KHR). (flutter/flutter#161767) 2025-01-17 [email protected] [Impeller] remove Adreno denylist entries. (flutter/flutter#161740) 2025-01-17 [email protected] Refactor event redispatching (flutter/flutter#161701) 2025-01-17 [email protected] [Impellerc] correctly pad arrays of vec3s in reflector. (flutter/flutter#161697) 2025-01-17 [email protected] Initialize dartLoader.rootDirectories so the Web stack trace mapper can convert package source paths (flutter/flutter#160383) 2025-01-16 [email protected] Make fl_keyboard_manager_handle_event async (flutter/flutter#161637) 2025-01-16 [email protected] Update social links in readme (flutter/flutter#161778) 2025-01-16 [email protected] Remove some stray printf debugging (flutter/flutter#161706) 2025-01-16 [email protected] Set meta tag in default index (flutter/flutter#161493) 2025-01-16 [email protected] remove usage of `Usage` from build system (flutter/flutter#160663) 2025-01-16 [email protected] route CLI command usage information through the logger instead of using `print` (flutter/flutter#161533) 2025-01-16 [email protected] Enable duplicate `linux_host_engine_test`. (flutter/flutter#161613) 2025-01-16 [email protected] Do not block vertical drag gestures in CupertinoSheetRoute body (flutter/flutter#161696) 2025-01-16 [email protected] [Impeller] Update partial repaint to use a fullsize onscreen. (flutter/flutter#161626) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutteractionsbot · 2025-02-03T20:50:58Z

Failed to create CP due to merge conflicts.
You will need to create the PR manually. See the cherrypick wiki for more info.

) CupertinoSheetRoute is a new widget added in 3.29 as a part of #157568. #161696 fixes #161623, which was an issue where you could not put scrollable content in the sheet, which is expected behavior. CupertinoSheetRoute has been a highly requested widget so is expected to get a lot of use. Impacted users: anyone using the CupertinoSheetRoute with scrollable content, which should be a common use case. Impact description: not being able to scroll within the sheet would create a very bad first impression and leave the sheet unusable for a lot of apps. Workaround: None. Risk: This is a brand new widget, so none. Test Coverage (Are you confident that your fix is well-tested by automated tests?): Yes, the fix has regression tests. Validation Steps (What are the steps to validate that this fix works?): Create a CupertinoSheetRoute with scrollable content that expands past the size of the sheet. #161623 has a code sample.

…dy (flutter/flutter#161696)

flutter/flutter@5517cc9...b9e86a5 2025-01-18 [email protected] Fix link to Linux custom embedder artifacts (flutter/flutter#161699) 2025-01-18 [email protected] Remove tests, GLFW examples, and non-artifact builds from `linux_host_engine`. (flutter/flutter#161786) 2025-01-18 [email protected] [Impeller] when mips are disabled, also disable from sampler options. (flutter/flutter#161765) 2025-01-18 [email protected] revert removing Twitter, retain BlueSky (flutter/flutter#161803) 2025-01-17 [email protected] fix reorderable_list_test.dart (flutter/flutter#161836) 2025-01-17 [email protected] [Release] Update the cherry-pick process. (flutter/flutter#161771) 2025-01-17 [email protected] Reland "#143249 Autocomplete options width" (flutter/flutter#161695) 2025-01-17 [email protected] Roll Dart to Version 3.8.0-1.0.dev (flutter/flutter#161781) 2025-01-17 [email protected] [Impeller] use 3 fences to synchronize AHB swapchains (like we do for KHR). (flutter/flutter#161767) 2025-01-17 [email protected] [Impeller] remove Adreno denylist entries. (flutter/flutter#161740) 2025-01-17 [email protected] Refactor event redispatching (flutter/flutter#161701) 2025-01-17 [email protected] [Impellerc] correctly pad arrays of vec3s in reflector. (flutter/flutter#161697) 2025-01-17 [email protected] Initialize dartLoader.rootDirectories so the Web stack trace mapper can convert package source paths (flutter/flutter#160383) 2025-01-16 [email protected] Make fl_keyboard_manager_handle_event async (flutter/flutter#161637) 2025-01-16 [email protected] Update social links in readme (flutter/flutter#161778) 2025-01-16 [email protected] Remove some stray printf debugging (flutter/flutter#161706) 2025-01-16 [email protected] Set meta tag in default index (flutter/flutter#161493) 2025-01-16 [email protected] remove usage of `Usage` from build system (flutter/flutter#160663) 2025-01-16 [email protected] route CLI command usage information through the logger instead of using `print` (flutter/flutter#161533) 2025-01-16 [email protected] Enable duplicate `linux_host_engine_test`. (flutter/flutter#161613) 2025-01-16 [email protected] Do not block vertical drag gestures in CupertinoSheetRoute body (flutter/flutter#161696) 2025-01-16 [email protected] [Impeller] Update partial repaint to use a fullsize onscreen. (flutter/flutter#161626) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Do not block vertical drag gestures in sheet

86d64a4

MitchellGoodwin requested a review from justinmc January 15, 2025 22:08

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages labels Jan 15, 2025

MitchellGoodwin added the team-design Owned by Design Languages team label Jan 15, 2025

justinmc approved these changes Jan 16, 2025

View reviewed changes

Address comments

29eed4b

MitchellGoodwin added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 16, 2025

auto-submit Bot added this pull request to the merge queue Jan 16, 2025

Merged via the queue into flutter:master with commit 3f2b7d9 Jan 16, 2025

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 16, 2025

engine-flutter-autoroll mentioned this pull request Jan 17, 2025

Roll Flutter from 5517cc9b3b3b to 329745473284 (16 revisions) flutter/packages#8454

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2025

3f2b7d9 Do not block vertical drag gestures in CupertinoSheetRoute bo…

8a9f6f6

…dy (flutter/flutter#161696)

engine-flutter-autoroll mentioned this pull request Jan 17, 2025

Roll Flutter from 5517cc9b3b3b to bb2d34126cc8 (17 revisions) flutter/packages#8455

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 17, 2025

3f2b7d9 Do not block vertical drag gestures in CupertinoSheetRoute bo…

6e02dfa

…dy (flutter/flutter#161696)

Piinks mentioned this pull request Jan 17, 2025

Flutter Notable Commits - 2025 #161460

Closed

engine-flutter-autoroll mentioned this pull request Jan 18, 2025

Roll Flutter from 5517cc9b3b3b to b9e86a565f92 (22 revisions) flutter/packages#8457

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2025

3f2b7d9 Do not block vertical drag gestures in CupertinoSheetRoute bo…

66035d9

…dy (flutter/flutter#161696)

engine-flutter-autoroll mentioned this pull request Jan 18, 2025

Roll Flutter from 5517cc9b3b3b to b9e86a565f92 (22 revisions) flutter/packages#8458

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 18, 2025

3f2b7d9 Do not block vertical drag gestures in CupertinoSheetRoute bo…

a4de34c

…dy (flutter/flutter#161696)

engine-flutter-autoroll mentioned this pull request Jan 19, 2025

Roll Flutter from 5517cc9b3b3b to b9e86a565f92 (22 revisions) flutter/packages#8459

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 19, 2025

3f2b7d9 Do not block vertical drag gestures in CupertinoSheetRoute bo…

a97bbff

…dy (flutter/flutter#161696)

MitchellGoodwin added the cp: beta cherry pick this pull request to beta release candidate branch label Feb 3, 2025

MitchellGoodwin mentioned this pull request Feb 3, 2025

[CP][Beta] Unblock drag gestures in CupertinoSheetRoute content #162629

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

3f2b7d9 Do not block vertical drag gestures in CupertinoSheetRoute bo…

c90c606

…dy (flutter/flutter#161696)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

3f2b7d9 Do not block vertical drag gestures in CupertinoSheetRoute bo…

482f5ac

…dy (flutter/flutter#161696)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

3f2b7d9 Do not block vertical drag gestures in CupertinoSheetRoute bo…

7b3772f

…dy (flutter/flutter#161696)

Navigation Menu

Repository navigation

Do not block vertical drag gestures in CupertinoSheetRoute body - #161696

Do not block vertical drag gestures in CupertinoSheetRoute body#161696
auto-submit[bot] merged 2 commits into
flutter:masterfrom
MitchellGoodwin:sheet-nested-scroll

MitchellGoodwin commented Jan 15, 2025

Uh oh!

justinmc left a comment

Uh oh!

justinmc Jan 16, 2025

Uh oh!

justinmc Jan 16, 2025

Uh oh!

MitchellGoodwin Jan 16, 2025

Uh oh!

flutteractionsbot commented Feb 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		await gesture.down(const Offset(100, 100));

		// Need 2 events to form a valid drag

Conversation

MitchellGoodwin commented Jan 15, 2025

Pre-launch Checklist

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

MitchellGoodwin Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

flutteractionsbot commented Feb 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants