[Android] add HC++ platform view class. by jonahwilliams · Pull Request #161829 · flutter/flutter

jonahwilliams · 2025-01-17T20:00:46Z

Part of the HC++ project for Android. This adds a current unused and unusable separate manager class for the new platform view strategy. Subsequent PRs will fill in the engine implementation as well as adding a mechanism to detect if support is available and provide a framework opt in.

johnmccutchan · 2025-01-30T17:26:57Z


    this.platformViewsController = platformViewsController;
    this.platformViewsController.onAttachedToJNI();
+    this.platformViewsController2 = platformViewsController2;


missing call to onAttachedToJNI() here?

This method was a no-op so I didn't implement this for pvc2. To make this less confusing I went ahead and deleted the method on pvc1

auto-submit · 2025-01-30T18:42:56Z

autosubmit label was removed for flutter/flutter/161829, because - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter-dashboard · 2025-01-30T19:54:19Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #161829 at sha 41c992d

Roll Flutter from b007899 to 8e2a6fc (61 revisions) flutter/flutter@b007899...8e2a6fc 2025-02-03 [email protected] Implement hot reload using the DDC library bundle format (flutter/flutter#162498) 2025-02-01 [email protected] [Android] add lint ignores to Flutter JNI. (flutter/flutter#162527) 2025-02-01 [email protected] Fix `Linux docs_publish` running at head (flutter/flutter#162557) 2025-02-01 [email protected] [Flutter GPU] Breaking: Use exceptions for resource creation errors. (flutter/flutter#162104) 2025-02-01 [email protected] [Impeller] Increase conical gradient precision. (flutter/flutter#162543) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162542) 2025-01-31 [email protected] [web] Gracefully handle empty ui.Vertices (flutter/flutter#162461) 2025-01-31 [email protected] [web] Remove HTML build artifacts (flutter/flutter#162528) 2025-01-31 [email protected] [ Tool ] Remove use of globals from widget-preview commands (flutter/flutter#162522) 2025-01-31 [email protected] Add a special case for the Fuchsia SDK ftl.fidl file in the license script (flutter/flutter#162423) 2025-01-31 [email protected] [Impeller] Remove some unused methods from EntityPassClipStack (flutter/flutter#162478) 2025-01-31 [email protected] Reenable linux_web_engine mac tests on Mac-14 (flutter/flutter#162409) 2025-01-31 [email protected] Fix NavigationRail examples overflow alignment (flutter/flutter#159937) 2025-01-31 [email protected] Roll Skia from c1dc5033e7c9 to 4bdf90faf708 (1 revision) (flutter/flutter#162511) 2025-01-31 [email protected] Roll Skia from e0941791b86e to c1dc5033e7c9 (1 revision) (flutter/flutter#162504) 2025-01-31 [email protected] [Reland] Fix `Tab` linear and elastic animation blink (#162315) (flutter/flutter#162450) 2025-01-31 [email protected] fix syntax error in comment pseudocode (flutter/flutter#162453) 2025-01-31 [email protected] Roll Skia from ec8c632b8c7f to e0941791b86e (1 revision) (flutter/flutter#162502) 2025-01-31 [email protected] Roll Skia from a9af2a74c5ab to ec8c632b8c7f (2 revisions) (flutter/flutter#162496) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162476) 2025-01-31 [email protected] Document flutter/package deps version policy (flutter/flutter#162492) 2025-01-31 [email protected] Add iOS tool codeowner (flutter/flutter#162167) 2025-01-31 [email protected] Fixed the text aspect ratio (flutter/flutter#162415) 2025-01-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Delete `FlutterCommand.usageValues` (#162468)" (flutter/flutter#162494) 2025-01-31 [email protected] Add new web contributors to web triage doc. (flutter/flutter#162420) 2025-01-30 [email protected] Fix the build borked in flutter/flutter#162475. (flutter/flutter#162484) 2025-01-30 [email protected] Roll Skia from e6daf687b558 to a9af2a74c5ab (5 revisions) (flutter/flutter#162474) 2025-01-30 [email protected] Bump `Linux mac_clang_tidy" to 120m timeout (flutter/flutter#162475) 2025-01-30 [email protected] Delete `FlutterCommand.usageValues` (flutter/flutter#162468) 2025-01-30 [email protected] Fixed some floating point inaccuracies in TextContents (flutter/flutter#162351) 2025-01-30 [email protected] Limit number of retries when downloading the Dart SDK on Windows (flutter/flutter#162411) 2025-01-30 [email protected] Add FormField.errorBuilder (flutter/flutter#162255) 2025-01-30 [email protected] Fix `Checkbox` default visual density to meet Material 3 guidelines (flutter/flutter#159081) 2025-01-30 [email protected] [Android] add HC++ platform view class. (flutter/flutter#161829) 2025-01-30 [email protected] Add tests to confirm CupertinoSliverNavigationBar snaps when partially scrolled in .always bottom mode (flutter/flutter#162425) 2025-01-30 [email protected] [Impeller] Disable Vulkan on Emulators. (flutter/flutter#162454) 2025-01-30 [email protected] [FGP Kotlin conversion] Convert `Deeplink` and `IntentFilterCheck` (flutter/flutter#161835) 2025-01-30 [email protected] fix slider semantic label (flutter/flutter#162304) 2025-01-30 [email protected] Roll Skia from f22419dbed05 to e6daf687b558 (37 revisions) (flutter/flutter#162447) 2025-01-30 [email protected] Fix `flutter doctor` instructions displayed when `cmdline-tools` (Android SDK) cannot be found (flutter/flutter#162281) 2025-01-30 [email protected] remove more (simple) usage of package:usage (flutter/flutter#162354) 2025-01-30 [email protected] [Android] HC++ plumbing. (flutter/flutter#162407) 2025-01-30 [email protected] Removes dev dependencies from generated plugin registrant for non-Android platforms (flutter/flutter#161828) 2025-01-30 [email protected] Fix unexpected shown of Scrollbar (flutter/flutter#159386) 2025-01-30 [email protected] Roll package:vm_service to 15.0.0 and package:leak_tracker to 10.0.9 (flutter/flutter#162325) 2025-01-30 [email protected] Roll Fuchsia Test Scripts from r9Dc5VRF6sE3pJH20... to g6IlaYL1_wNmk3zNj... (flutter/flutter#162427) ...

[Android] add HC++ platform view class.

ab5eb6b

github-actions Bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. labels Jan 17, 2025

gmackall requested review from gmackall, johnmccutchan and reidbaker and removed request for gmackall January 21, 2025 19:19

Jonah Williams added 3 commits January 22, 2025 13:01

Merge branch 'master' into hcpp_platform_view_class

19b6389

++

776b26c

Merge branch 'master' into hcpp_platform_view_class

0c1b8b3

johnmccutchan reviewed Jan 30, 2025

View reviewed changes

remove onAttachJNI method.

dce3b29

jonahwilliams requested a review from johnmccutchan January 30, 2025 17:50

johnmccutchan approved these changes Jan 30, 2025

View reviewed changes

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

fix test.

41c992d

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

flutter-dashboard Bot added the will affect goldens Changes to golden files label Jan 30, 2025

auto-submit Bot added this pull request to the merge queue Jan 30, 2025

Merged via the queue into flutter:master with commit a492766 Jan 30, 2025

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2025

a492766 [Android] add HC++ platform view class. (flutter/flutter#161829)

bd093fb

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2025

a492766 [Android] add HC++ platform view class. (flutter/flutter#161829)

c098320

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025

a492766 [Android] add HC++ platform view class. (flutter/flutter#161829)

965e857

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025

a492766 [Android] add HC++ platform view class. (flutter/flutter#161829)

b1f779b

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025

a492766 [Android] add HC++ platform view class. (flutter/flutter#161829)

42bfcfa

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025

a492766 [Android] add HC++ platform view class. (flutter/flutter#161829)

9a33007

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025

a492766 [Android] add HC++ platform view class. (flutter/flutter#161829)

391d156

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025

a492766 [Android] add HC++ platform view class. (flutter/flutter#161829)

91022f8

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

a492766 [Android] add HC++ platform view class. (flutter/flutter#161829)

90954df

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

a492766 [Android] add HC++ platform view class. (flutter/flutter#161829)

8a62300

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

a492766 [Android] add HC++ platform view class. (flutter/flutter#161829)

043973f

Navigation Menu

Repository navigation

[Android] add HC++ platform view class. - #161829

[Android] add HC++ platform view class.#161829
auto-submit[bot] merged 6 commits into
flutter:masterfrom
jonahwilliams:hcpp_platform_view_class

jonahwilliams commented Jan 17, 2025

Uh oh!

johnmccutchan Jan 30, 2025

Uh oh!

jonahwilliams Jan 30, 2025

Uh oh!

auto-submit Bot commented Jan 30, 2025

Uh oh!

flutter-dashboard Bot commented Jan 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jonahwilliams commented Jan 17, 2025

Uh oh!

johnmccutchan Jan 30, 2025

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Jan 30, 2025

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Jan 30, 2025

Uh oh!

flutter-dashboard Bot commented Jan 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants