fix slider semantic label by ChrisCRCB · Pull Request #162304 · flutter/flutter

ChrisCRCB · 2025-01-28T09:40:45Z

Added a label argument to the Semantics widget which the Slider widget creates. This exposes the Sliders label to assistive technologies so they can stop speaking "Slider".

Fixes [A11y]: Slider labels not included in the Semantics widget #162067

flutter-dashboard · 2025-01-28T09:40:49Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

google-cla · 2025-01-28T09:40:51Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

kevmoo · 2025-01-29T21:46:13Z

@ChrisCRCB – we'll need a test for this. Please see semantic tests for other widgets for inspiration!

hannah-hyj · 2025-01-30T00:16:04Z

I agree we should semantically announce the slider labels to provide more context to the user whether the label is visible or not. Good fix, Thank you for contributing to flutter!

hannah-hyj

LGTM

kevmoo · 2025-01-30T00:24:08Z

Agree this is a great fix. @hannah-hyj – any notes on how to test this?

hannah-hyj · 2025-01-30T00:28:02Z

@kevmoo they already added a semantic test in slider_test.dart

kevmoo · 2025-01-30T00:29:11Z

@kevmoo they already added a semantic test in slider_test.dart

Oh! Cool! I was confused. TIL. Sorry! Thanks! 🙏

kevmoo · 2025-01-30T01:05:40Z

@hannah-hyj – should we add auto-submit here?

hannah-hyj · 2025-01-30T01:20:22Z

@kevmoo looks like some google testing is failing, i will take a look

ChrisCRCB · 2025-01-30T15:28:06Z

Hey all,
Thanks for reviewing the PR. I'm happy to contribute. I love Flutter, so anything I can do to make it better (by which I mainly mean "more accessible") I'm happy to do. 💯

Roll Flutter from b007899 to 8e2a6fc (61 revisions) flutter/flutter@b007899...8e2a6fc 2025-02-03 [email protected] Implement hot reload using the DDC library bundle format (flutter/flutter#162498) 2025-02-01 [email protected] [Android] add lint ignores to Flutter JNI. (flutter/flutter#162527) 2025-02-01 [email protected] Fix `Linux docs_publish` running at head (flutter/flutter#162557) 2025-02-01 [email protected] [Flutter GPU] Breaking: Use exceptions for resource creation errors. (flutter/flutter#162104) 2025-02-01 [email protected] [Impeller] Increase conical gradient precision. (flutter/flutter#162543) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162542) 2025-01-31 [email protected] [web] Gracefully handle empty ui.Vertices (flutter/flutter#162461) 2025-01-31 [email protected] [web] Remove HTML build artifacts (flutter/flutter#162528) 2025-01-31 [email protected] [ Tool ] Remove use of globals from widget-preview commands (flutter/flutter#162522) 2025-01-31 [email protected] Add a special case for the Fuchsia SDK ftl.fidl file in the license script (flutter/flutter#162423) 2025-01-31 [email protected] [Impeller] Remove some unused methods from EntityPassClipStack (flutter/flutter#162478) 2025-01-31 [email protected] Reenable linux_web_engine mac tests on Mac-14 (flutter/flutter#162409) 2025-01-31 [email protected] Fix NavigationRail examples overflow alignment (flutter/flutter#159937) 2025-01-31 [email protected] Roll Skia from c1dc5033e7c9 to 4bdf90faf708 (1 revision) (flutter/flutter#162511) 2025-01-31 [email protected] Roll Skia from e0941791b86e to c1dc5033e7c9 (1 revision) (flutter/flutter#162504) 2025-01-31 [email protected] [Reland] Fix `Tab` linear and elastic animation blink (#162315) (flutter/flutter#162450) 2025-01-31 [email protected] fix syntax error in comment pseudocode (flutter/flutter#162453) 2025-01-31 [email protected] Roll Skia from ec8c632b8c7f to e0941791b86e (1 revision) (flutter/flutter#162502) 2025-01-31 [email protected] Roll Skia from a9af2a74c5ab to ec8c632b8c7f (2 revisions) (flutter/flutter#162496) 2025-01-31 [email protected] Roll pub packages (flutter/flutter#162476) 2025-01-31 [email protected] Document flutter/package deps version policy (flutter/flutter#162492) 2025-01-31 [email protected] Add iOS tool codeowner (flutter/flutter#162167) 2025-01-31 [email protected] Fixed the text aspect ratio (flutter/flutter#162415) 2025-01-31 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Delete `FlutterCommand.usageValues` (#162468)" (flutter/flutter#162494) 2025-01-31 [email protected] Add new web contributors to web triage doc. (flutter/flutter#162420) 2025-01-30 [email protected] Fix the build borked in flutter/flutter#162475. (flutter/flutter#162484) 2025-01-30 [email protected] Roll Skia from e6daf687b558 to a9af2a74c5ab (5 revisions) (flutter/flutter#162474) 2025-01-30 [email protected] Bump `Linux mac_clang_tidy" to 120m timeout (flutter/flutter#162475) 2025-01-30 [email protected] Delete `FlutterCommand.usageValues` (flutter/flutter#162468) 2025-01-30 [email protected] Fixed some floating point inaccuracies in TextContents (flutter/flutter#162351) 2025-01-30 [email protected] Limit number of retries when downloading the Dart SDK on Windows (flutter/flutter#162411) 2025-01-30 [email protected] Add FormField.errorBuilder (flutter/flutter#162255) 2025-01-30 [email protected] Fix `Checkbox` default visual density to meet Material 3 guidelines (flutter/flutter#159081) 2025-01-30 [email protected] [Android] add HC++ platform view class. (flutter/flutter#161829) 2025-01-30 [email protected] Add tests to confirm CupertinoSliverNavigationBar snaps when partially scrolled in .always bottom mode (flutter/flutter#162425) 2025-01-30 [email protected] [Impeller] Disable Vulkan on Emulators. (flutter/flutter#162454) 2025-01-30 [email protected] [FGP Kotlin conversion] Convert `Deeplink` and `IntentFilterCheck` (flutter/flutter#161835) 2025-01-30 [email protected] fix slider semantic label (flutter/flutter#162304) 2025-01-30 [email protected] Roll Skia from f22419dbed05 to e6daf687b558 (37 revisions) (flutter/flutter#162447) 2025-01-30 [email protected] Fix `flutter doctor` instructions displayed when `cmdline-tools` (Android SDK) cannot be found (flutter/flutter#162281) 2025-01-30 [email protected] remove more (simple) usage of package:usage (flutter/flutter#162354) 2025-01-30 [email protected] [Android] HC++ plumbing. (flutter/flutter#162407) 2025-01-30 [email protected] Removes dev dependencies from generated plugin registrant for non-Android platforms (flutter/flutter#161828) 2025-01-30 [email protected] Fix unexpected shown of Scrollbar (flutter/flutter#159386) 2025-01-30 [email protected] Roll package:vm_service to 15.0.0 and package:leak_tracker to 10.0.9 (flutter/flutter#162325) 2025-01-30 [email protected] Roll Fuchsia Test Scripts from r9Dc5VRF6sE3pJH20... to g6IlaYL1_wNmk3zNj... (flutter/flutter#162427) ...

Added semantic label.

14e5176

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Jan 28, 2025

Add label to test.

98a330c

Piinks requested a review from hannah-hyj January 29, 2025 19:04

Piinks added the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Jan 29, 2025

hannah-hyj approved these changes Jan 30, 2025

View reviewed changes

Merge branch 'master' into fix-slider-semantic-label

a39addb

github-actions Bot removed the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Jan 30, 2025

hannah-hyj added the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Jan 30, 2025

hannah-hyj added this pull request to the merge queue Jan 30, 2025

Merged via the queue into flutter:master with commit 4619574 Jan 30, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2025

4619574 fix slider semantic label (flutter/flutter#162304)

0ae6dd2

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 31, 2025

4619574 fix slider semantic label (flutter/flutter#162304)

ac83315

Piinks mentioned this pull request Jan 31, 2025

Flutter Notable Commits - 2025 #161460

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025

4619574 fix slider semantic label (flutter/flutter#162304)

acfbff8

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2025

4619574 fix slider semantic label (flutter/flutter#162304)

94f55b6

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025

4619574 fix slider semantic label (flutter/flutter#162304)

bfe8f6e

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2025

4619574 fix slider semantic label (flutter/flutter#162304)

b73c0cd

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025

4619574 fix slider semantic label (flutter/flutter#162304)

a413a7e

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2025

4619574 fix slider semantic label (flutter/flutter#162304)

8eb7075

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

4619574 fix slider semantic label (flutter/flutter#162304)

09677c9

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

4619574 fix slider semantic label (flutter/flutter#162304)

900366d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

4619574 fix slider semantic label (flutter/flutter#162304)

a019ead

huycozy mentioned this pull request Sep 5, 2025

[VPAT][A11y][a11y-app] slide a11y assessment must have a visible label #173008

Closed

Navigation Menu

Repository navigation

fix slider semantic label - #162304

fix slider semantic label#162304
hannah-hyj merged 3 commits into
flutter:masterfrom
ChrisCRCB:fix-slider-semantic-label

ChrisCRCB commented Jan 28, 2025

Uh oh!

flutter-dashboard Bot commented Jan 28, 2025

Uh oh!

google-cla Bot commented Jan 28, 2025

Uh oh!

kevmoo commented Jan 29, 2025

Uh oh!

hannah-hyj commented Jan 30, 2025 •

edited

Loading

Uh oh!

hannah-hyj left a comment

Uh oh!

kevmoo commented Jan 30, 2025

Uh oh!

hannah-hyj commented Jan 30, 2025

Uh oh!

kevmoo commented Jan 30, 2025

Uh oh!

kevmoo commented Jan 30, 2025

Uh oh!

hannah-hyj commented Jan 30, 2025

Uh oh!

ChrisCRCB commented Jan 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ChrisCRCB commented Jan 28, 2025

Uh oh!

flutter-dashboard Bot commented Jan 28, 2025

Uh oh!

google-cla Bot commented Jan 28, 2025

Uh oh!

kevmoo commented Jan 29, 2025

Uh oh!

hannah-hyj commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hannah-hyj left a comment

Choose a reason for hiding this comment

Uh oh!

kevmoo commented Jan 30, 2025

Uh oh!

hannah-hyj commented Jan 30, 2025

Uh oh!

kevmoo commented Jan 30, 2025

Uh oh!

kevmoo commented Jan 30, 2025

Uh oh!

hannah-hyj commented Jan 30, 2025

Uh oh!

ChrisCRCB commented Jan 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hannah-hyj commented Jan 30, 2025 •

edited

Loading