flutter_tools: flutter_tester is a host artifact by cbracken · Pull Request #162047 · flutter/flutter

cbracken · 2025-01-23T00:02:59Z

This resolves the case where a flutter test run is invoked on a target iOS/Android device, as in flutter test -d iOS-device.

Previously CachedLocalEngineArtifacts was returning flutter_tester from the local target build directory. flutter_tester is a host build artifact and thus should be returned from the local host engine directory, not the local target build directory.

Some history: A long time ago, desktop artifacts were produced as part of the host builds; and in fact, they still are, but ideally shouldn't be. At some point we added target builds for macOS, Windows, and Linux embedders, but failed to clean the target artifacts out of the host builds. Similarly, the desktop target builds should ideally not produce host artifacts, but that's less problematic. The conflation of the two is likely why the existing code was working until now.

Related issue: #38935

Closes: #162045

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

matanlurey

LGTM! Thanks for the cleanup!

auto-submit · 2025-01-23T00:56:19Z

auto label is removed for flutter/flutter/162047, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

This resolves the case where a `flutter test` run is invoked on a target iOS/Android device, as in `flutter test -d iOS-device`. Previously `CachedLocalEngineArtifacts` was returning `flutter_tester` from the local target build directory. `flutter_tester` is a host build artifact and thus should be returned from the local host engine directory, not the local target build directory. Some history: A long time ago, desktop artifacts were produced as part of the host builds; and in fact, they still are, but ideally shouldn't be ([issue][1]). At some point we added target builds for macOS, Windows, and Linux embedders, but failed to clean the target artifacts out of the host builds. Similarly, the desktop target builds should ideally not produce host artifacts, but that's less problematic. The conflation of the two is likely why the existing code was working until now. Related issue: flutter#38935 Issue: flutter#162045

auto-submit · 2025-01-23T03:00:11Z

auto label is removed for flutter/flutter/162047, due to - The status or check suite Mac tool_integration_tests_5_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

…tter#162047)

This resolves the case where a `flutter test` run is invoked on a target iOS/Android device, as in `flutter test -d iOS-device`. Previously `CachedLocalEngineArtifacts` was returning `flutter_tester` from the local target build directory. `flutter_tester` is a host build artifact and thus should be returned from the local host engine directory, not the local target build directory. Some history: A long time ago, desktop artifacts were produced as part of the host builds; and in fact, they still are, but ideally shouldn't be. At some point we added target builds for macOS, Windows, and Linux embedders, but failed to clean the target artifacts out of the host builds. Similarly, the desktop target builds should ideally not produce host artifacts, but that's less problematic. The conflation of the two is likely why the existing code was working until now. Related issue: flutter#38935 Closes: flutter#162045 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…tter#162047)

Manual roll requested by [email protected] flutter/flutter@c1561a4...c1ffaa9 2025-01-24 [email protected] Fix link to hotfix documentation best practices (flutter/flutter#162116) 2025-01-24 [email protected] Add integration test for cutout rotation evaluation (flutter/flutter#160354) 2025-01-24 [email protected] Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146) 2025-01-24 [email protected] Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235) 2025-01-24 [email protected] When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455) 2025-01-24 [email protected] [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052) 2025-01-24 [email protected] Add to Setup Path Example to Engine README (flutter/flutter#162115) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122) 2025-01-23 [email protected] feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424) 2025-01-23 [email protected] Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100) 2025-01-23 [email protected] Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493) 2025-01-23 [email protected] Unskip test. (flutter/flutter#162106) 2025-01-23 [email protected] Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076) 2025-01-23 [email protected] Roll pub packages (flutter/flutter#162095) 2025-01-23 [email protected] Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050) 2025-01-23 [email protected] Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974) 2025-01-23 [email protected] flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047) 2025-01-23 [email protected] [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082) 2025-01-23 [email protected] Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459) 2025-01-23 [email protected] Show error on macOS if missing Local Network permissions (flutter/flutter#161846) 2025-01-23 [email protected] Autocomplete keyboard navigation (flutter/flutter#159455) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…tter#162047)

) Manual roll requested by [email protected] flutter/flutter@c1561a4...c1ffaa9 2025-01-24 [email protected] Fix link to hotfix documentation best practices (flutter/flutter#162116) 2025-01-24 [email protected] Add integration test for cutout rotation evaluation (flutter/flutter#160354) 2025-01-24 [email protected] Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146) 2025-01-24 [email protected] Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235) 2025-01-24 [email protected] When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455) 2025-01-24 [email protected] [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052) 2025-01-24 [email protected] Add to Setup Path Example to Engine README (flutter/flutter#162115) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122) 2025-01-23 [email protected] feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424) 2025-01-23 [email protected] Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100) 2025-01-23 [email protected] Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493) 2025-01-23 [email protected] Unskip test. (flutter/flutter#162106) 2025-01-23 [email protected] Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076) 2025-01-23 [email protected] Roll pub packages (flutter/flutter#162095) 2025-01-23 [email protected] Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050) 2025-01-23 [email protected] Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974) 2025-01-23 [email protected] flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047) 2025-01-23 [email protected] [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082) 2025-01-23 [email protected] Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459) 2025-01-23 [email protected] Show error on macOS if missing Local Network permissions (flutter/flutter#161846) 2025-01-23 [email protected] Autocomplete keyboard navigation (flutter/flutter#159455) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cbracken requested a review from matanlurey January 23, 2025 00:02

github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 23, 2025

matanlurey approved these changes Jan 23, 2025

View reviewed changes

cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

cbracken force-pushed the local-engine-flutter_tester branch from 727fbfd to cecb2c3 Compare January 23, 2025 01:42

Merge branch 'master' into local-engine-flutter_tester

11da4c4

cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

auto-submit Bot added this pull request to the merge queue Jan 23, 2025

Merged via the queue into flutter:master with commit 1daa755 Jan 23, 2025

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

cbracken deleted the local-engine-flutter_tester branch January 24, 2025 01:37

engine-flutter-autoroll mentioned this pull request Jan 24, 2025

Roll Flutter from c1561a41c530 to bf7daf22a51e (19 revisions) flutter/packages#8495

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025

1daa755 flutter_tools: flutter_tester is a host artifact (flutter/flu…

41270a4

…tter#162047)

engine-flutter-autoroll mentioned this pull request Jan 24, 2025

Roll Flutter from c1561a41c530 to 02e11f95a18a (20 revisions) flutter/packages#8496

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025

1daa755 flutter_tools: flutter_tester is a host artifact (flutter/flu…

307bd48

…tter#162047)

engine-flutter-autoroll mentioned this pull request Jan 24, 2025

Roll Flutter from c1561a41c530 to c1ffaa9d9deb (21 revisions) flutter/packages#8497

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025

1daa755 flutter_tools: flutter_tester is a host artifact (flutter/flu…

4e88b96

…tter#162047)

engine-flutter-autoroll mentioned this pull request Jan 24, 2025

Manual roll Flutter from c1561a41c530 to c1ffaa9d9deb (21 revisions) flutter/packages#8498

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025

1daa755 flutter_tools: flutter_tester is a host artifact (flutter/flu…

fe75eff

…tter#162047)

engine-flutter-autoroll mentioned this pull request Jan 24, 2025

Roll Flutter from c1561a41c530 to c1ffaa9d9deb (21 revisions) flutter/packages#8500

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025

1daa755 flutter_tools: flutter_tester is a host artifact (flutter/flu…

78b7461

…tter#162047)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

1daa755 flutter_tools: flutter_tester is a host artifact (flutter/flu…

ee72071

…tter#162047)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

1daa755 flutter_tools: flutter_tester is a host artifact (flutter/flu…

e7177db

…tter#162047)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

1daa755 flutter_tools: flutter_tester is a host artifact (flutter/flu…

6e86fda

…tter#162047)

Navigation Menu

Repository navigation

flutter_tools: flutter_tester is a host artifact - #162047

flutter_tools: flutter_tester is a host artifact#162047
auto-submit[bot] merged 2 commits into
flutter:masterfrom
cbracken:local-engine-flutter_tester

cbracken commented Jan 23, 2025 •

edited

Loading

Uh oh!

matanlurey left a comment

Uh oh!

auto-submit Bot commented Jan 23, 2025

Uh oh!

auto-submit Bot commented Jan 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

cbracken commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

matanlurey left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Jan 23, 2025

Uh oh!

auto-submit Bot commented Jan 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cbracken commented Jan 23, 2025 •

edited

Loading