[Impeller] Fix source offset in PathBuilder::AddPath by flar · Pull Request #162052 · flutter/flutter

flar · 2025-01-23T01:29:09Z

An error in bookkeeping in PathBuilder::AddPath caused crashes in recent unit tests (see #162046)

jonahwilliams

LGTM

auto-submit · 2025-01-23T02:30:42Z

auto label is removed for flutter/flutter/162052, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-01-23T04:09:38Z

auto label is removed for flutter/flutter/162052, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

…/flutter#162052)

An error in bookkeeping in `PathBuilder::AddPath` caused crashes in recent unit tests (see flutter#162046)

…/flutter#162052)

Manual roll requested by [email protected] flutter/flutter@c1561a4...c1ffaa9 2025-01-24 [email protected] Fix link to hotfix documentation best practices (flutter/flutter#162116) 2025-01-24 [email protected] Add integration test for cutout rotation evaluation (flutter/flutter#160354) 2025-01-24 [email protected] Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146) 2025-01-24 [email protected] Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235) 2025-01-24 [email protected] When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455) 2025-01-24 [email protected] [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052) 2025-01-24 [email protected] Add to Setup Path Example to Engine README (flutter/flutter#162115) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122) 2025-01-23 [email protected] feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424) 2025-01-23 [email protected] Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100) 2025-01-23 [email protected] Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493) 2025-01-23 [email protected] Unskip test. (flutter/flutter#162106) 2025-01-23 [email protected] Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076) 2025-01-23 [email protected] Roll pub packages (flutter/flutter#162095) 2025-01-23 [email protected] Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050) 2025-01-23 [email protected] Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974) 2025-01-23 [email protected] flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047) 2025-01-23 [email protected] [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082) 2025-01-23 [email protected] Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459) 2025-01-23 [email protected] Show error on macOS if missing Local Network permissions (flutter/flutter#161846) 2025-01-23 [email protected] Autocomplete keyboard navigation (flutter/flutter#159455) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…/flutter#162052)

) Manual roll requested by [email protected] flutter/flutter@c1561a4...c1ffaa9 2025-01-24 [email protected] Fix link to hotfix documentation best practices (flutter/flutter#162116) 2025-01-24 [email protected] Add integration test for cutout rotation evaluation (flutter/flutter#160354) 2025-01-24 [email protected] Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146) 2025-01-24 [email protected] Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235) 2025-01-24 [email protected] When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455) 2025-01-24 [email protected] [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052) 2025-01-24 [email protected] Add to Setup Path Example to Engine README (flutter/flutter#162115) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122) 2025-01-23 [email protected] feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424) 2025-01-23 [email protected] Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100) 2025-01-23 [email protected] Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493) 2025-01-23 [email protected] Unskip test. (flutter/flutter#162106) 2025-01-23 [email protected] Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076) 2025-01-23 [email protected] Roll pub packages (flutter/flutter#162095) 2025-01-23 [email protected] Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050) 2025-01-23 [email protected] Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974) 2025-01-23 [email protected] flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047) 2025-01-23 [email protected] [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082) 2025-01-23 [email protected] Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459) 2025-01-23 [email protected] Show error on macOS if missing Local Network permissions (flutter/flutter#161846) 2025-01-23 [email protected] Autocomplete keyboard navigation (flutter/flutter#159455) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions Bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jan 23, 2025

flar requested review from jason-simmons and jonahwilliams January 23, 2025 01:29

[Impeller] Fix source offset in PathBuilder::AddPath

c260aac

flar force-pushed the fix-addpath-source-offset branch from ae49d92 to c260aac Compare January 23, 2025 01:30

jonahwilliams approved these changes Jan 23, 2025

View reviewed changes

jason-simmons approved these changes Jan 23, 2025

View reviewed changes

flar added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

flar added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

flar added 2 commits January 22, 2025 21:58

Merge branch 'master' into fix-addpath-source-offset

d2c9bf2

Merge branch 'master' into fix-addpath-source-offset

f754013

flar added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

auto-submit Bot added this pull request to the merge queue Jan 23, 2025

github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jan 24, 2025

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2025

flar added this pull request to the merge queue Jan 24, 2025

Merged via the queue into flutter:master with commit 83bac34 Jan 24, 2025

flar deleted the fix-addpath-source-offset branch January 24, 2025 06:41

engine-flutter-autoroll mentioned this pull request Jan 24, 2025

Roll Flutter from c1561a41c530 to bf7daf22a51e (19 revisions) flutter/packages#8495

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025

83bac34 [Impeller] Fix source offset in PathBuilder::AddPath (flutter…

9a966b3

…/flutter#162052)

engine-flutter-autoroll mentioned this pull request Jan 24, 2025

Roll Flutter from c1561a41c530 to 02e11f95a18a (20 revisions) flutter/packages#8496

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025

83bac34 [Impeller] Fix source offset in PathBuilder::AddPath (flutter…

be50894

…/flutter#162052)

Wasmund1 pushed a commit to Wasmund1/flutter that referenced this pull request Jan 24, 2025

[Impeller] Fix source offset in PathBuilder::AddPath (flutter#162052)

55702b5

An error in bookkeeping in `PathBuilder::AddPath` caused crashes in recent unit tests (see flutter#162046)

engine-flutter-autoroll mentioned this pull request Jan 24, 2025

Roll Flutter from c1561a41c530 to c1ffaa9d9deb (21 revisions) flutter/packages#8497

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025

83bac34 [Impeller] Fix source offset in PathBuilder::AddPath (flutter…

27c2750

…/flutter#162052)

engine-flutter-autoroll mentioned this pull request Jan 24, 2025

Manual roll Flutter from c1561a41c530 to c1ffaa9d9deb (21 revisions) flutter/packages#8498

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025

83bac34 [Impeller] Fix source offset in PathBuilder::AddPath (flutter…

ae71360

…/flutter#162052)

engine-flutter-autoroll mentioned this pull request Jan 24, 2025

Roll Flutter from c1561a41c530 to c1ffaa9d9deb (21 revisions) flutter/packages#8500

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025

83bac34 [Impeller] Fix source offset in PathBuilder::AddPath (flutter…

bee7060

…/flutter#162052)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

83bac34 [Impeller] Fix source offset in PathBuilder::AddPath (flutter…

68e2d52

…/flutter#162052)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

83bac34 [Impeller] Fix source offset in PathBuilder::AddPath (flutter…

891c9ef

…/flutter#162052)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

83bac34 [Impeller] Fix source offset in PathBuilder::AddPath (flutter…

721bc97

…/flutter#162052)

Navigation Menu

Repository navigation

[Impeller] Fix source offset in PathBuilder::AddPath - #162052

[Impeller] Fix source offset in PathBuilder::AddPath#162052
flar merged 3 commits into
flutter:masterfrom
flar:fix-addpath-source-offset

flar commented Jan 23, 2025

Uh oh!

jonahwilliams left a comment

Uh oh!

auto-submit Bot commented Jan 23, 2025

Uh oh!

auto-submit Bot commented Jan 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

flar commented Jan 23, 2025

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit Bot commented Jan 23, 2025

Uh oh!

auto-submit Bot commented Jan 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants