Skip to content

Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" - #162046

Merged
auto-submit[bot] merged 1 commit into
masterfrom
revert_e0392194d3f8d345da8ea163ff94cf11b9aae6da
Jan 23, 2025
Merged

Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)"#162046
auto-submit[bot] merged 1 commit into
masterfrom
revert_e0392194d3f8d345da8ea163ff94cf11b9aae6da

Conversation

@auto-submit

@auto-submit auto-submit Bot commented Jan 23, 2025

Copy link
Copy Markdown
Contributor

Reverts: #161855

Initiated by: harryterkelsen

Reason for reverting: causing test failures on linux_unopt shard

https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Production%20Engine%20Drone/1044163/infra

Original PR Author: flar

Reviewed By: {jonahwilliams}

This change reverts the following previous change:
Handles the impeller unittests line in #161456

This PR is focused on the unit tests in Impeller. There are still some uses in other non-test areas which will be handled in a separate PR.

@auto-submit auto-submit Bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Jan 23, 2025
@github-actions github-actions Bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jan 23, 2025
@auto-submit
auto-submit Bot added this pull request to the merge queue Jan 23, 2025
Merged via the queue into master with commit c75d799 Jan 23, 2025
@auto-submit
auto-submit Bot deleted the revert_e0392194d3f8d345da8ea163ff94cf11b9aae6da branch January 23, 2025 01:03
@flar flar mentioned this pull request Jan 23, 2025
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 23, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
@engine-flutter-autoroll
c75d799 Reverts "[Impeller] Migrate unit tests off of Skia geometry c…
a04fddc 
…lasses (#161855)" (flutter/flutter#162046)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 23, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
@engine-flutter-autoroll
c75d799 Reverts "[Impeller] Migrate unit tests off of Skia geometry c…
af8a538 
…lasses (#161855)" (flutter/flutter#162046)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 23, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
@engine-flutter-autoroll
c75d799 Reverts "[Impeller] Migrate unit tests off of Skia geometry c…
d123bbb 
…lasses (#161855)" (flutter/flutter#162046)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 23, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
@engine-flutter-autoroll
c75d799 Reverts "[Impeller] Migrate unit tests off of Skia geometry c…
357ec60 
…lasses (#161855)" (flutter/flutter#162046)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 23, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
@engine-flutter-autoroll
c75d799 Reverts "[Impeller] Migrate unit tests off of Skia geometry c…
4713ce8 
…lasses (#161855)" (flutter/flutter#162046)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 23, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
@engine-flutter-autoroll
c75d799 Reverts "[Impeller] Migrate unit tests off of Skia geometry c…
7edd238 
…lasses (#161855)" (flutter/flutter#162046)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 23, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025
@engine-flutter-autoroll
c75d799 Reverts "[Impeller] Migrate unit tests off of Skia geometry c…
4975c2d 
…lasses (#161855)" (flutter/flutter#162046)
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jan 23, 2025
@engine-flutter-autoroll
Manual roll Flutter from b2f515f to c1561a4 (18 revisions) (#8491)
913c949 
Manual roll requested by [email protected]

flutter/flutter@b2f515f...c1561a4

2025-01-23 [email protected] Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032)
2025-01-23 [email protected] Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042)
2025-01-23 [email protected] [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043)
2025-01-23 [email protected] [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834)
2025-01-23 [email protected] Keyboard tidy ups (flutter/flutter#162054)
2025-01-23 [email protected] fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131)
2025-01-23 [email protected] fix: Call codec.dispose in `dev/` (flutter/flutter#161112)
2025-01-23 [email protected] Replace hacky code creating fake devices (flutter/flutter#162056)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162068)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162017)
2025-01-23 [email protected] Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975)
2025-01-23 [email protected] Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023)
2025-01-23 [email protected] Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822)
2025-01-23 [email protected] [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838)
2025-01-23 [email protected] Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queue Bot pushed a commit that referenced this pull request Jan 24, 2025
@flar
[Impeller] Fix source offset in PathBuilder::AddPath (#162052)
83bac34 
An error in bookkeeping in `PathBuilder::AddPath` caused crashes in
recent unit tests (see #162046)
@flar flar mentioned this pull request Jan 24, 2025
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Jan 24, 2025
@flar
Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#…
bf7daf2 
…161855)" (#162146)

Reverts #162046

The root cause of the test failures seen in the original PR have been
fixed.
Wasmund1 pushed a commit to Wasmund1/flutter that referenced this pull request Jan 24, 2025
@auto-submit auto-submit[bot] philip wasmund
Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (f…
8ed9a1e 
…lutter#161855)" (flutter#162046)

<!-- start_original_pr_link -->
Reverts: flutter#161855
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: harryterkelsen
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: causing test failures on `linux_unopt` shard


https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Production%20Engine%20Drone/1044163/infra
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: flar
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jonahwilliams}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Handles the impeller unittests line in
flutter#161456

This PR is focused on the unit tests in Impeller. There are still some
uses in other non-test areas which will be handled in a separate PR.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <[email protected]>
Wasmund1 pushed a commit to Wasmund1/flutter that referenced this pull request Jan 24, 2025
@flar philip wasmund
[Impeller] Fix source offset in PathBuilder::AddPath (flutter#162052)
55702b5 
An error in bookkeeping in `PathBuilder::AddPath` caused crashes in
recent unit tests (see flutter#162046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
c75d799 Reverts "[Impeller] Migrate unit tests off of Skia geometry c…
339454e 
…lasses (#161855)" (flutter/flutter#162046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
c75d799 Reverts "[Impeller] Migrate unit tests off of Skia geometry c…
4547781 
…lasses (#161855)" (flutter/flutter#162046)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
c75d799 Reverts "[Impeller] Migrate unit tests off of Skia geometry c…
6a2db72 
…lasses (#161855)" (flutter/flutter#162046)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from b2f515f to c1561a4 (18 revisions) (flutter#8491
9277996 
)

Manual roll requested by [email protected]

flutter/flutter@b2f515f...c1561a4

2025-01-23 [email protected] Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032)
2025-01-23 [email protected] Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042)
2025-01-23 [email protected] [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043)
2025-01-23 [email protected] [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834)
2025-01-23 [email protected] Keyboard tidy ups (flutter/flutter#162054)
2025-01-23 [email protected] fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131)
2025-01-23 [email protected] fix: Call codec.dispose in `dev/` (flutter/flutter#161112)
2025-01-23 [email protected] Replace hacky code creating fake devices (flutter/flutter#162056)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162068)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162017)
2025-01-23 [email protected] Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975)
2025-01-23 [email protected] Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023)
2025-01-23 [email protected] Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822)
2025-01-23 [email protected] [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838)
2025-01-23 [email protected] Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from b2f515f to c1561a4 (18 revisions) (flutter#8491
04dea25 
)

Manual roll requested by [email protected]

flutter/flutter@b2f515f...c1561a4

2025-01-23 [email protected] Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032)
2025-01-23 [email protected] Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042)
2025-01-23 [email protected] [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043)
2025-01-23 [email protected] [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834)
2025-01-23 [email protected] Keyboard tidy ups (flutter/flutter#162054)
2025-01-23 [email protected] fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131)
2025-01-23 [email protected] fix: Call codec.dispose in `dev/` (flutter/flutter#161112)
2025-01-23 [email protected] Replace hacky code creating fake devices (flutter/flutter#162056)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162068)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162017)
2025-01-23 [email protected] Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975)
2025-01-23 [email protected] Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023)
2025-01-23 [email protected] Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822)
2025-01-23 [email protected] [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838)
2025-01-23 [email protected] Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Manual roll Flutter from b2f515f to c1561a4 (18 revisions) (flutter#8491
14a3fe2 
)

Manual roll requested by [email protected]

flutter/flutter@b2f515f...c1561a4

2025-01-23 [email protected] Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032)
2025-01-23 [email protected] Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042)
2025-01-23 [email protected] [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043)
2025-01-23 [email protected] [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834)
2025-01-23 [email protected] Keyboard tidy ups (flutter/flutter#162054)
2025-01-23 [email protected] fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131)
2025-01-23 [email protected] fix: Call codec.dispose in `dev/` (flutter/flutter#161112)
2025-01-23 [email protected] Replace hacky code creating fake devices (flutter/flutter#162056)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162068)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162017)
2025-01-23 [email protected] Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975)
2025-01-23 [email protected] Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023)
2025-01-23 [email protected] Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822)
2025-01-23 [email protected] [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838)
2025-01-23 [email protected] Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@engine-flutter-autoroll
Manual roll Flutter from b2f515f to c1561a4 (18 revisions) (flutter#8491
218240a 
)

Manual roll requested by [email protected]

flutter/flutter@b2f515f...c1561a4

2025-01-23 [email protected] Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032)
2025-01-23 [email protected] Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042)
2025-01-23 [email protected] [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043)
2025-01-23 [email protected] [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834)
2025-01-23 [email protected] Keyboard tidy ups (flutter/flutter#162054)
2025-01-23 [email protected] fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127)
2025-01-23 [email protected] fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131)
2025-01-23 [email protected] fix: Call codec.dispose in `dev/` (flutter/flutter#161112)
2025-01-23 [email protected] Replace hacky code creating fake devices (flutter/flutter#162056)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162068)
2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162017)
2025-01-23 [email protected] Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975)
2025-01-23 [email protected] Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023)
2025-01-23 [email protected] Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822)
2025-01-23 [email protected] [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838)
2025-01-23 [email protected] Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

@harryterkelsen harryterkelsen

Labels

a: text input Entering text in a text field or keyboard related problems e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels. revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fluttergithubbot @harryterkelsen