Add a README with instructions for editing and running tests for the FGP by gmackall · Pull Request #161830 · flutter/flutter

gmackall · 2025-01-17T20:41:36Z

Add a readme with some info.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

reidbaker · 2025-01-21T15:04:24Z

+### Testing
+
+Tests can be run in Android Studio, or directly with Gradle: `./gradle test` 
+(note that this directory does not contain a version controlled Gradle file. You can find one in 


Should this file contain a version controlled gradle file? what version do we use in ci?

I think the answer according to Gradle is yes:
https://docs.gradle.org/current/dsl/org.gradle.api.tasks.wrapper.Wrapper.html

The scripts generated by this task are intended to be committed to your version control system.

But we have a policy of not committing binaries

flutter/dev/bots/analyze.dart

Lines 1695 to 1700 in bd1ebf2

// DO NOT ADD ANY ENTRIES TO THIS LIST.

// We have a policy of not checking in binaries into this repository.

// If you are adding/changing template images, use the flutter_template_images

// package and a .img.tmpl placeholder instead.

// If you have other binaries to add, please consult Hixie for advice.

final Set<Hash256> _legacyBinaries = <Hash256>{

(this is essentially the same discussion as this issue: #161480)

In CI, I'm using some code that the tool uses within flutter build apk --config only to create a Gradle wrapper.

I lean towards saying we should commit it? But we will need to cc Hixie I suppose

I think the gradlew files are actually just scripts, so trying at #161969

I think the gradlew files are actually just scripts, so trying at #161969

This does not work, we need to include the gradle/wrapper/gradle-wrapper.jar unfortunately.

cc @Hixie I see the analyze documentation says to consult you. I imagine the question of including gradle in version control has come up at some point in the past, but I don't know that anyone on the current Android team was involved in those discussions. I'm assuming you would still be opposed to including it?

For size reference,

mackall-macbookpro:replica mackall$ du -sh android/gradle 60K android/gradle

(but also this isn't blocking, so I'm going to land this in the meantime)

Co-authored-by: Reid Baker <[email protected]>

…for the FGP (flutter/flutter#161830)

Manual roll requested by [email protected] flutter/flutter@b2f515f...c1561a4 2025-01-23 [email protected] Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032) 2025-01-23 [email protected] Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042) 2025-01-23 [email protected] [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043) 2025-01-23 [email protected] [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834) 2025-01-23 [email protected] Keyboard tidy ups (flutter/flutter#162054) 2025-01-23 [email protected] fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115) 2025-01-23 [email protected] fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127) 2025-01-23 [email protected] fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131) 2025-01-23 [email protected] fix: Call codec.dispose in `dev/` (flutter/flutter#161112) 2025-01-23 [email protected] Replace hacky code creating fake devices (flutter/flutter#162056) 2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162068) 2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162017) 2025-01-23 [email protected] Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975) 2025-01-23 [email protected] Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023) 2025-01-23 [email protected] Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822) 2025-01-23 [email protected] [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838) 2025-01-23 [email protected] Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…FGP (flutter#161830) Add a readme with some info. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <[email protected]> Co-authored-by: Reid Baker <[email protected]>

…for the FGP (flutter/flutter#161830)

) Manual roll requested by [email protected] flutter/flutter@b2f515f...c1561a4 2025-01-23 [email protected] Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032) 2025-01-23 [email protected] Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042) 2025-01-23 [email protected] [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043) 2025-01-23 [email protected] [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834) 2025-01-23 [email protected] Keyboard tidy ups (flutter/flutter#162054) 2025-01-23 [email protected] fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115) 2025-01-23 [email protected] fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127) 2025-01-23 [email protected] fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131) 2025-01-23 [email protected] fix: Call codec.dispose in `dev/` (flutter/flutter#161112) 2025-01-23 [email protected] Replace hacky code creating fake devices (flutter/flutter#162056) 2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162068) 2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162017) 2025-01-23 [email protected] Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975) 2025-01-23 [email protected] Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023) 2025-01-23 [email protected] Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822) 2025-01-23 [email protected] [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838) 2025-01-23 [email protected] Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

add a README with instructions for editing and running tests

c3ff643

github-actions Bot added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 17, 2025

mackall-work added 3 commits January 17, 2025 12:42

subheaders

4b277f4

try this instead

1541e84

update with instructions for tests in one file/one method

e162d75

gmackall marked this pull request as ready for review January 17, 2025 22:36

more info

b0e3e4a

gmackall requested a review from a team January 17, 2025 22:39

reidbaker approved these changes Jan 21, 2025

View reviewed changes

gmackall and others added 5 commits January 21, 2025 10:28

Update packages/flutter_tools/gradle/README.md

278a10b

Co-authored-by: Reid Baker <[email protected]>

Update packages/flutter_tools/gradle/README.md

a2ce882

Co-authored-by: Reid Baker <[email protected]>

Update packages/flutter_tools/gradle/README.md

7e41d39

Co-authored-by: Reid Baker <[email protected]>

add hyperlink to bug

5be9b3c

Merge branch 'master' into fgp_readme

6243bde

gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 22, 2025

auto-submit Bot added this pull request to the merge queue Jan 23, 2025

Merged via the queue into flutter:master with commit 64c808b Jan 23, 2025

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Roll Flutter from b2f515f45ef5 to 663d02078813 (8 revisions) flutter/packages#8484

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

64c808b Add a README with instructions for editing and running tests …

bfa7656

…for the FGP (flutter/flutter#161830)

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Roll Flutter from b2f515f45ef5 to 6e9b863e6d29 (9 revisions) flutter/packages#8486

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

64c808b Add a README with instructions for editing and running tests …

1d8e5a6

…for the FGP (flutter/flutter#161830)

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Roll Flutter from b2f515f45ef5 to d59995bac316 (12 revisions) flutter/packages#8488

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

64c808b Add a README with instructions for editing and running tests …

629b60b

…for the FGP (flutter/flutter#161830)

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Roll Flutter from b2f515f45ef5 to b46479c6a00d (16 revisions) flutter/packages#8489

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

64c808b Add a README with instructions for editing and running tests …

9d6a387

…for the FGP (flutter/flutter#161830)

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Roll Flutter from b2f515f45ef5 to 211b46fcb102 (17 revisions) flutter/packages#8490

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

64c808b Add a README with instructions for editing and running tests …

2fa9bc5

…for the FGP (flutter/flutter#161830)

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Manual roll Flutter from b2f515f45ef5 to c1561a41c530 (18 revisions) flutter/packages#8491

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

64c808b Add a README with instructions for editing and running tests …

7e25eb0

…for the FGP (flutter/flutter#161830)

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Roll Flutter from b2f515f45ef5 to c1561a41c530 (18 revisions) flutter/packages#8492

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

64c808b Add a README with instructions for editing and running tests …

394d4c1

…for the FGP (flutter/flutter#161830)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

64c808b Add a README with instructions for editing and running tests …

5102b01

…for the FGP (flutter/flutter#161830)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

64c808b Add a README with instructions for editing and running tests …

75f275c

…for the FGP (flutter/flutter#161830)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

64c808b Add a README with instructions for editing and running tests …

a717d1d

…for the FGP (flutter/flutter#161830)

Navigation Menu

Repository navigation

Add a README with instructions for editing and running tests for the FGP - #161830

Add a README with instructions for editing and running tests for the FGP#161830
auto-submit[bot] merged 10 commits into
flutter:masterfrom
gmackall:fgp_readme

gmackall commented Jan 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reidbaker Jan 21, 2025

Uh oh!

gmackall Jan 21, 2025

Uh oh!

gmackall Jan 21, 2025

Uh oh!

gmackall Jan 21, 2025

Uh oh!

gmackall Jan 22, 2025

Uh oh!

gmackall Jan 22, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	// DO NOT ADD ANY ENTRIES TO THIS LIST.
	// We have a policy of not checking in binaries into this repository.
	// If you are adding/changing template images, use the flutter_template_images
	// package and a .img.tmpl placeholder instead.
	// If you have other binaries to add, please consult Hixie for advice.
	final Set<Hash256> _legacyBinaries = <Hash256>{

Conversation

gmackall commented Jan 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reidbaker Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

gmackall Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

gmackall Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

gmackall Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

gmackall Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

gmackall Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gmackall commented Jan 17, 2025 •

edited

Loading