[Impeller] check both linear sampling props for AHBs. by jonahwilliams · Pull Request #162043 · flutter/flutter

jonahwilliams · 2025-01-22T23:06:45Z

According to KhronosGroup/Vulkan-ValidationLayers#5806 , both eSampledImageYcbcrConversionLinearFilter and eSampledImageFilterLinear properties are required to use a linear chromaFilter.

flutter-dashboard · 2025-01-22T23:06:48Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

auto-submit · 2025-01-23T05:18:19Z

auto label is removed for flutter/flutter/162043, due to - The status or check suite Linux mac_android_aot_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

The status or check suite Merge Queue Guard has failed. Please fix the issues identified (or deflake) before re-applying this label.

…r/flutter#162043)

Manual roll requested by [email protected] flutter/flutter@b2f515f...c1561a4 2025-01-23 [email protected] Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032) 2025-01-23 [email protected] Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042) 2025-01-23 [email protected] [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043) 2025-01-23 [email protected] [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834) 2025-01-23 [email protected] Keyboard tidy ups (flutter/flutter#162054) 2025-01-23 [email protected] fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115) 2025-01-23 [email protected] fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127) 2025-01-23 [email protected] fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131) 2025-01-23 [email protected] fix: Call codec.dispose in `dev/` (flutter/flutter#161112) 2025-01-23 [email protected] Replace hacky code creating fake devices (flutter/flutter#162056) 2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162068) 2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162017) 2025-01-23 [email protected] Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975) 2025-01-23 [email protected] Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023) 2025-01-23 [email protected] Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822) 2025-01-23 [email protected] [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838) 2025-01-23 [email protected] Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

According to KhronosGroup/Vulkan-ValidationLayers#5806 , both eSampledImageYcbcrConversionLinearFilter and eSampledImageFilterLinear properties are required to use a linear chromaFilter.

flutteractionsbot · 2025-01-24T20:22:11Z

Failed to create CP due to merge conflicts.
You will need to create the PR manually. See the cherrypick wiki for more info.

According to KhronosGroup/Vulkan-ValidationLayers#5806 , both eSampledImageYcbcrConversionLinearFilter and eSampledImageFilterLinear properties are required to use a linear chromaFilter.

…162187) According to KhronosGroup/Vulkan-ValidationLayers#5806 , both eSampledImageYcbcrConversionLinearFilter and eSampledImageFilterLinear properties are required to use a linear chromaFilter.

…r/flutter#162043)

) Manual roll requested by [email protected] flutter/flutter@b2f515f...c1561a4 2025-01-23 [email protected] Add `windows_host_engine_test` to presubmit, remove lint exceptions. (flutter/flutter#162032) 2025-01-23 [email protected] Shift `mac_clang_tidy` to a Linux orchestrator. (flutter/flutter#162042) 2025-01-23 [email protected] [Impeller] check both linear sampling props for AHBs. (flutter/flutter#162043) 2025-01-23 [email protected] [Impeller] Implement inherited opacity for ColorFilterContents (flutter/flutter#161834) 2025-01-23 [email protected] Keyboard tidy ups (flutter/flutter#162054) 2025-01-23 [email protected] fix: Call codec.dispose in tests of `engine/src/flutter` (flutter/flutter#161115) 2025-01-23 [email protected] fix: Call codec.dispose in `flutter/test` (flutter/flutter#161127) 2025-01-23 [email protected] fix: Call codec.dispose in `flutter_test` (flutter/flutter#161131) 2025-01-23 [email protected] fix: Call codec.dispose in `dev/` (flutter/flutter#161112) 2025-01-23 [email protected] Replace hacky code creating fake devices (flutter/flutter#162056) 2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162068) 2025-01-23 [email protected] [native assets] Roll dependencies (flutter/flutter#162017) 2025-01-23 [email protected] Fix DropdownButtonFormField clips text when large text scale is used (flutter/flutter#159975) 2025-01-23 [email protected] Add a better error message when `flutter drive --target` is used incorrectly. (flutter/flutter#162023) 2025-01-23 [email protected] Revert "Move the analyzer_benchmark to Mac arm64 devicelab bots" (flutter/flutter#161822) 2025-01-23 [email protected] [Impeller] adjust coverage origin when rounding out SaveLayer bounds. (flutter/flutter#161838) 2025-01-23 [email protected] Add a README with instructions for editing and running tests for the FGP (flutter/flutter#161830) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162046) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

[Impeller] check both linear sampling props for AHBs.

68f3b88

github-actions Bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jan 22, 2025

jonahwilliams requested a review from chinmaygarde January 22, 2025 23:09

chinmaygarde approved these changes Jan 22, 2025

View reviewed changes

Merge branch 'master' into both_props_ahb

c9f2a17

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

auto-submit Bot added this pull request to the merge queue Jan 23, 2025

Merged via the queue into flutter:master with commit b46479c Jan 23, 2025

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025

jonahwilliams deleted the both_props_ahb branch January 23, 2025 16:56

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Roll Flutter from b2f515f45ef5 to b46479c6a00d (16 revisions) flutter/packages#8489

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

b46479c [Impeller] check both linear sampling props for AHBs. (flutte…

9516f69

…r/flutter#162043)

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Roll Flutter from b2f515f45ef5 to 211b46fcb102 (17 revisions) flutter/packages#8490

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

b46479c [Impeller] check both linear sampling props for AHBs. (flutte…

e6264a4

…r/flutter#162043)

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Manual roll Flutter from b2f515f45ef5 to c1561a41c530 (18 revisions) flutter/packages#8491

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

b46479c [Impeller] check both linear sampling props for AHBs. (flutte…

14c00ef

…r/flutter#162043)

engine-flutter-autoroll mentioned this pull request Jan 23, 2025

Roll Flutter from b2f515f45ef5 to c1561a41c530 (18 revisions) flutter/packages#8492

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 23, 2025

b46479c [Impeller] check both linear sampling props for AHBs. (flutte…

b68743e

…r/flutter#162043)

jonahwilliams added the cp: beta cherry pick this pull request to beta release candidate branch label Jan 24, 2025

reidbaker mentioned this pull request Jan 30, 2025

3.29 engine bump and dart rev #162471

Merged

7 of 9 tasks

WyvernPirate mentioned this pull request Apr 3, 2025

Updates Flutter to 3.29.2 stable release WyvernPirate/flutter#1

Merged

reidbaker mentioned this pull request Apr 4, 2025

Unbreak presubmit for stable #166594

Merged

7 of 9 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

b46479c [Impeller] check both linear sampling props for AHBs. (flutte…

9144927

…r/flutter#162043)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

b46479c [Impeller] check both linear sampling props for AHBs. (flutte…

4214c9a

…r/flutter#162043)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

b46479c [Impeller] check both linear sampling props for AHBs. (flutte…

75bdc0c

…r/flutter#162043)

Navigation Menu

Repository navigation

[Impeller] check both linear sampling props for AHBs. - #162043

[Impeller] check both linear sampling props for AHBs.#162043
auto-submit[bot] merged 2 commits into
flutter:masterfrom
jonahwilliams:both_props_ahb

jonahwilliams commented Jan 22, 2025

Uh oh!

flutter-dashboard Bot commented Jan 22, 2025

Uh oh!

auto-submit Bot commented Jan 23, 2025

Uh oh!

flutteractionsbot commented Jan 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jonahwilliams commented Jan 22, 2025

Uh oh!

flutter-dashboard Bot commented Jan 22, 2025

Uh oh!

auto-submit Bot commented Jan 23, 2025

Uh oh!

flutteractionsbot commented Jan 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants