[ios][pv]fix platform view crash due to screenScale=0 by hellohuanlin · Pull Request #165525 · flutter/flutter

hellohuanlin · 2025-03-19T22:54:37Z

This is a regression introduced by: https://github.com/flutter/flutter/pull/162785/files#diff-b08b98ecaa5bd434f8b4181793f2dad9389c32c5b8cdedb52b01a2d3355f51a9R26

It's reported by one of the customers. We are not able to reproduce it.

It's likely that flutterView itself is nil (rather than flutterView.screen being nil), because we reset flutterView when backgrounding the app

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

b/403598670

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

cbracken · 2025-03-20T21:32:13Z

+  FlutterEngine* engine = [[FlutterEngine alloc] initWithName:@"foobar"];
+  [engine run];
+  XCTAssertTrue(engine.platformView != nullptr);
+  auto ios_context = engine.platformView->GetIosContext();


Consider specifying the type explicitly here.

cbracken · 2025-03-20T21:33:25Z

+  XCTAssertTrue(engine.platformView != nullptr);
+  auto ios_context = engine.platformView->GetIosContext();
+
+  auto pool = flutter::OverlayLayerPool{};


Suggested change

auto pool = flutter::OverlayLayerPool{};

flutter::OverlayLayerPool pool;

cbracken · 2025-03-20T21:42:55Z

+  pool.CreateLayer(ios_context, MTLPixelFormatBGRA8Unorm, 1);
+  XCTAssertEqual(pool.size(), 1u);
+
+  auto layer = pool.GetNextLayer();


Unless this is a C++ smart pointer with a super complex type, use the explicit type here. If it is a super long complicated type, you can do:

using SomeType = LongComplex<Type<Foo, Bar>, Baz>; SomeType layer = ...;

cbracken

LGTM modulo nits.

…r/flutter#165525)

This is a regression introduced by: https://github.com/flutter/flutter/pull/162785/files#diff-b08b98ecaa5bd434f8b4181793f2dad9389c32c5b8cdedb52b01a2d3355f51a9R26 It's reported by one of the customers. We are not able to reproduce it. It's likely that `flutterView` itself is `nil` (rather than `flutterView.screen` being `nil`), because we reset `flutterView` when backgrounding the app *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* b/403598670 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…r/flutter#165525)

This is a regression introduced by: https://github.com/flutter/flutter/pull/162785/files#diff-b08b98ecaa5bd434f8b4181793f2dad9389c32c5b8cdedb52b01a2d3355f51a9R26 It's reported by one of the customers. We are not able to reproduce it. It's likely that `flutterView` itself is `nil` (rather than `flutterView.screen` being `nil`), because we reset `flutterView` when backgrounding the app *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* b/403598670 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…all (flutter#166024) A follow up to flutter#165525 This checks against: 1. flutterView being nil 2. flutterView's screen being nil 3. flutterView's screen's scale being 0 Again, since we can't repro, I am justing guessing here. *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* Internal only (See previous PR linked above) *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…r/flutter#165525)

This is a regression introduced by: https://github.com/flutter/flutter/pull/162785/files#diff-b08b98ecaa5bd434f8b4181793f2dad9389c32c5b8cdedb52b01a2d3355f51a9R26 It's reported by one of the customers. We are not able to reproduce it. It's likely that `flutterView` itself is `nil` (rather than `flutterView.screen` being `nil`), because we reset `flutterView` when backgrounding the app *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* b/403598670 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…all (flutter#166024) A follow up to flutter#165525 This checks against: 1. flutterView being nil 2. flutterView's screen being nil 3. flutterView's screen's scale being 0 Again, since we can't repro, I am justing guessing here. *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* Internal only (See previous PR linked above) *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

This is a regression introduced by: https://github.com/flutter/flutter/pull/162785/files#diff-b08b98ecaa5bd434f8b4181793f2dad9389c32c5b8cdedb52b01a2d3355f51a9R26 It's reported by one of the customers. We are not able to reproduce it. It's likely that `flutterView` itself is `nil` (rather than `flutterView.screen` being `nil`), because we reset `flutterView` when backgrounding the app *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* b/403598670 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…all (flutter#166024) A follow up to flutter#165525 This checks against: 1. flutterView being nil 2. flutterView's screen being nil 3. flutterView's screen's scale being 0 Again, since we can't repro, I am justing guessing here. *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* Internal only (See previous PR linked above) *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

github-actions Bot added platform-ios iOS applications specifically engine flutter/engine related. See also e: labels. team-ios Owned by iOS platform team labels Mar 19, 2025

hellohuanlin requested a review from cbracken March 19, 2025 22:55

hellohuanlin force-pushed the pv_regression_on_screen_scale branch from fd4be40 to 13b75bf Compare March 19, 2025 23:08

cbracken reviewed Mar 20, 2025

View reviewed changes

cbracken approved these changes Mar 20, 2025

View reviewed changes

hellohuanlin force-pushed the pv_regression_on_screen_scale branch 2 times, most recently from 7608c19 to 0d8ccc1 Compare March 21, 2025 05:16

hellohuanlin added 2 commits March 21, 2025 16:54

[ios][pv]fix platform view crash due to screenScale=0

011a371

nit

c70794a

hellohuanlin force-pushed the pv_regression_on_screen_scale branch from 0d8ccc1 to c70794a Compare March 21, 2025 23:54

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2025

auto-submit Bot added this pull request to the merge queue Mar 24, 2025

Merged via the queue into flutter:master with commit 4cb18b3 Mar 24, 2025

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2025

jmagman mentioned this pull request Mar 25, 2025

[Google3 Bug]: Fatal Exception: CALayer position contains NaN: [nan inf]. Layer: <CALayer:0x#; position = CGPoint (# #)…-ad8a0f16 #165648

Closed

1 of 4 tasks

engine-flutter-autoroll mentioned this pull request Mar 25, 2025

Roll Flutter from b16430b2fd57 to 8893670e1596 (245 revisions) flutter/packages#8898

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

0583e13

…r/flutter#165525)

hellohuanlin added the cp: beta cherry pick this pull request to beta release candidate branch label Mar 25, 2025

engine-flutter-autoroll mentioned this pull request Mar 25, 2025

Roll Flutter from b16430b2fd57 to bf6481104dc2 (246 revisions) flutter/packages#8899

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

52512ab

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

3a6c5d4

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

a5fb9af

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

c7a2f4f

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

63d24b7

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

f221420

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

08e6260

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

87b3e30

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

55a4c3c

…r/flutter#165525)

hellohuanlin removed the cp: beta cherry pick this pull request to beta release candidate branch label Mar 28, 2025

hellohuanlin mentioned this pull request Mar 28, 2025

[beta][ios] Revert UIScreen.shared deprecation PR #166172

Closed

8 of 9 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

7b45e11

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

b0c5bd8

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

fe9337b

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

d4cb7ea

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

fdbc810

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

a610975

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

d1f6ce1

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

23995ee

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

32dfc97

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

e20c7e0

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

0b01ca1

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

789e023

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

b8ee8db

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

8eeb660

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

5c17de4

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

a600413

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

6f9a972

…r/flutter#165525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

4cb18b3 [ios][pv]fix platform view crash due to screenScale=0 (flutte…

f3753e2

…r/flutter#165525)

Navigation Menu

Repository navigation

[ios][pv]fix platform view crash due to screenScale=0 - #165525

[ios][pv]fix platform view crash due to screenScale=0#165525
auto-submit[bot] merged 2 commits into
flutter:masterfrom
hellohuanlin:pv_regression_on_screen_scale

hellohuanlin commented Mar 19, 2025 •

edited by jmagman

Loading

Uh oh!

cbracken Mar 20, 2025

Uh oh!

cbracken Mar 20, 2025

Uh oh!

cbracken Mar 20, 2025 •

edited

Loading

Uh oh!

cbracken left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	auto pool = flutter::OverlayLayerPool{};
	flutter::OverlayLayerPool pool;

Conversation

hellohuanlin commented Mar 19, 2025 • edited by jmagman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

cbracken Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

cbracken Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

cbracken Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cbracken left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hellohuanlin commented Mar 19, 2025 •

edited by jmagman

Loading

cbracken Mar 20, 2025 •

edited

Loading