[ios][pv]check UIScreen to be nil in platform view overlay setState call by hellohuanlin · Pull Request #166024 · flutter/flutter

hellohuanlin · 2025-03-26T21:54:59Z

A follow up to #165525

This checks against:

flutterView being nil
flutterView's screen being nil
flutterView's screen's scale being 0

Again, since we can't repro, I am justing guessing here.

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

Internal only (See previous PR linked above)

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman · 2025-03-26T21:59:11Z

+  // There can be a race where UpdateViewState() is called when flutter_view or flutter_view's
+  // screen is nil when app is backgrounded.
+  FlutterView* flutterView = (FlutterView*)flutter_view;
+  if (!flutterView || !flutterView.screen || flutterView.screen.scale == 0.0f) {


The scale is actually 0.0 when it's backgrounded?

I don't think scale can be 0, but just wanna be extra safe here.

Yeah given this can result in a divide-by-zero, seems reasonable to check. Agreed it would seem like a definite UIKit bug to me if they ever returned a scale of 0, but checking for it seems fair.

You could consider a comment that we know flutterView and flutterView.screen may be nil, but given scale is used in a scaling calculation division below, we're being paranoid.

cbracken

jmagman · 2025-03-27T00:33:29Z

Test failure in testLayerUpdateViewStateWithNilFlutterViewShouldNotCrash

…tState call (flutter/flutter#166024)

…all (flutter#166024) A follow up to flutter#165525 This checks against: 1. flutterView being nil 2. flutterView's screen being nil 3. flutterView's screen's scale being 0 Again, since we can't repro, I am justing guessing here. *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* Internal only (See previous PR linked above) *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…tState call (flutter/flutter#166024)

…all (flutter#166024) A follow up to flutter#165525 This checks against: 1. flutterView being nil 2. flutterView's screen being nil 3. flutterView's screen's scale being 0 Again, since we can't repro, I am justing guessing here. *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* Internal only (See previous PR linked above) *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

hellohuanlin added 2 commits March 26, 2025 14:45

[ios][pv]check UIScreen to be nil in platform view overlay setState call

494888c

nit

af34b06

hellohuanlin requested a review from cbracken March 26, 2025 21:55

github-actions Bot added platform-ios iOS applications specifically engine flutter/engine related. See also e: labels. team-ios Owned by iOS platform team labels Mar 26, 2025

jmagman reviewed Mar 26, 2025

View reviewed changes

cbracken approved these changes Mar 26, 2025

View reviewed changes

cbracken reviewed Mar 26, 2025

View reviewed changes

Comment thread engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsTest.mm Outdated

hellohuanlin added 2 commits March 26, 2025 15:11

add comment

c45c55f

pass in fliutter view

a497d98

jmagman approved these changes Mar 27, 2025

View reviewed changes

hellohuanlin added 2 commits March 26, 2025 17:45

fix test

a4c0272

import engine internal header

b21ae80

hellohuanlin added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2025

jmagman added this pull request to the merge queue Mar 27, 2025

This was referenced Mar 27, 2025

"Windows_mokey flutter_gallery_win__compile" failing due to resource exhaustion, timeout; all bots are idle #166042

Open

[DO NOT LAND][LAST RESORT] [ios][pv] regression on screen scale revert to deprecated api #166036

Closed

Merged via the queue into flutter:master with commit 1eae5e7 Mar 27, 2025

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 27, 2025

engine-flutter-autoroll mentioned this pull request Mar 27, 2025

Roll Flutter from b16430b2fd57 to 2befeb9e0485 (298 revisions) flutter/packages#8913

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

381938c

…tState call (flutter/flutter#166024)

engine-flutter-autoroll mentioned this pull request Mar 27, 2025

Roll Flutter from b16430b2fd57 to 7cb926a33d8e (299 revisions) flutter/packages#8914

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

e6dd5a0

…tState call (flutter/flutter#166024)

engine-flutter-autoroll mentioned this pull request Mar 27, 2025

Roll Flutter from b16430b2fd57 to 31ed3b7b83b4 (300 revisions) flutter/packages#8915

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

10e6e72

…tState call (flutter/flutter#166024)

engine-flutter-autoroll mentioned this pull request Mar 27, 2025

Roll Flutter from b16430b2fd57 to e17287da31b1 (301 revisions) flutter/packages#8916

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

4929273

…tState call (flutter/flutter#166024)

engine-flutter-autoroll mentioned this pull request Mar 28, 2025

Roll Flutter from b16430b2fd57 to 228a01170724 (317 revisions) flutter/packages#8925

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

49b26d8

…tState call (flutter/flutter#166024)

engine-flutter-autoroll mentioned this pull request Mar 28, 2025

Roll Flutter from 1d954f4e96bd to ffcc383848a0 (204 revisions) flutter/packages#8926

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

90496a1

…tState call (flutter/flutter#166024)

engine-flutter-autoroll mentioned this pull request Mar 28, 2025

Roll Flutter from 1d954f4e96bd to 943dd30bfd27 (208 revisions) flutter/packages#8927

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

5bde137

…tState call (flutter/flutter#166024)

engine-flutter-autoroll mentioned this pull request Mar 28, 2025

Roll Flutter from 1d954f4e96bd to 7cfaf04fa978 (209 revisions) flutter/packages#8929

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

4eeacb6

…tState call (flutter/flutter#166024)

hellohuanlin mentioned this pull request Mar 28, 2025

[beta][ios] Revert UIScreen.shared deprecation PR #166172

Closed

8 of 9 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

b420293

…tState call (flutter/flutter#166024)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

638a6f8

…tState call (flutter/flutter#166024)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

42e7924

…tState call (flutter/flutter#166024)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

dfb6b29

…tState call (flutter/flutter#166024)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

e7e61ab

…tState call (flutter/flutter#166024)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

bd647a4

…tState call (flutter/flutter#166024)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

0ddee9d

…tState call (flutter/flutter#166024)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

bf14c56

…tState call (flutter/flutter#166024)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

6b0bd62

…tState call (flutter/flutter#166024)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

d09408c

…tState call (flutter/flutter#166024)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

c718bd7

…tState call (flutter/flutter#166024)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

acb0854

…tState call (flutter/flutter#166024)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

e8b65fa

…tState call (flutter/flutter#166024)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

5880ed6

…tState call (flutter/flutter#166024)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

6976050

…tState call (flutter/flutter#166024)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

18d85b2

…tState call (flutter/flutter#166024)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

c2a381c

…tState call (flutter/flutter#166024)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

1eae5e7 [ios][pv]check UIScreen to be nil in platform view overlay se…

c96842d

…tState call (flutter/flutter#166024)

Navigation Menu

Repository navigation

[ios][pv]check UIScreen to be nil in platform view overlay setState call - #166024

[ios][pv]check UIScreen to be nil in platform view overlay setState call#166024
jmagman merged 6 commits into
flutter:masterfrom
hellohuanlin:pv_regression_on_screen_scale_again

hellohuanlin commented Mar 26, 2025 •

edited

Loading

Uh oh!

jmagman Mar 26, 2025

Uh oh!

hellohuanlin Mar 26, 2025

Uh oh!

cbracken Mar 26, 2025

Uh oh!

cbracken left a comment

Uh oh!

Uh oh!

jmagman commented Mar 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

hellohuanlin commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

jmagman Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

hellohuanlin Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

cbracken Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

cbracken left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jmagman commented Mar 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hellohuanlin commented Mar 26, 2025 •

edited

Loading