Skip to content

Add CupertinoPicker ticking sound - #170641

Merged
auto-submit[bot] merged 6 commits into
flutter:masterfrom
alex-medinsh:picker_sound
Jun 30, 2025
Merged

Add CupertinoPicker ticking sound#170641
auto-submit[bot] merged 6 commits into
flutter:masterfrom
alex-medinsh:picker_sound

Conversation

@alex-medinsh

@alex-medinsh alex-medinsh commented Jun 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds a ticking sound to the CupertinoPicker on iOS.

Fixes #37329

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions Bot added platform-ios iOS applications specifically framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. p: cupertino_ui cupertino_ui package in flutter/packages platform-linux Building on or for Linux specifically a: desktop Running on desktop team-ios Owned by iOS platform team labels Jun 15, 2025
@alex-medinsh

alex-medinsh commented Jun 15, 2025

Copy link
Copy Markdown
Contributor Author

I am not sure about tests on the platform side, I haven't found any existing sound or haptic tests for iOS for instance. Maybe I haven't looked hard enough :)

@github-actions github-actions Bot added a: text input Entering text in a text field or keyboard related problems platform-android Android applications specifically e: impeller Impeller rendering backend issues and features requests labels Jun 16, 2025
@github-actions github-actions Bot removed a: text input Entering text in a text field or keyboard related problems platform-android Android applications specifically e: impeller Impeller rendering backend issues and features requests labels Jun 16, 2025
@alex-medinsh
alex-medinsh marked this pull request as ready for review June 16, 2025 09:25
@alex-medinsh
alex-medinsh requested a review from a team as a code owner June 16, 2025 09:25
@alex-medinsh

alex-medinsh commented Jun 16, 2025

Copy link
Copy Markdown
Contributor Author

Compiling the engine was an adventure :)

victorsanni
victorsanni reviewed Jun 16, 2025
View reviewed changes
Comment thread packages/flutter/lib/src/services/system_sound.dart
@github-actions github-actions Bot added the platform-android Android applications specifically label Jun 16, 2025
camsim99
camsim99 reviewed Jun 17, 2025
View reviewed changes

@camsim99 camsim99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on Android since this is a no-op

@dkwingsmt
dkwingsmt self-requested a review June 25, 2025 18:22
@alex-medinsh

alex-medinsh commented Jun 25, 2025

Copy link
Copy Markdown
Contributor Author

Hi @dcq01! Maybe the reviewers of this PR will have different opinions, but I usually don't feel that reviewing individual commits is particularly useful, since a commit (at least in my workflow) is not a self-contained piece of work. I usually expect reviews to work over the whole PR to see all changes in context of other changes.

As for the actual comments, I feel like for such a small change all the suggested tests are a bit overkill. Some of them (like 2 and 5) are strange, since I have never seen a test that tests if a member of an enum is in the enum. Overall, in my opinion, not that useful.

dkwingsmt
dkwingsmt reviewed Jun 25, 2025
View reviewed changes

@dkwingsmt dkwingsmt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM with some minor comments. Thank you for working on this!

Comment thread packages/flutter/lib/src/services/system_sound.dart
Comment thread engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPlatformPlugin.mm Outdated
Comment thread packages/flutter/test/cupertino/picker_test.dart Outdated
Comment thread packages/flutter/test/cupertino/picker_test.dart Outdated
loic-sharma
loic-sharma reviewed Jun 26, 2025
View reviewed changes
Comment thread packages/flutter/lib/src/services/system_sound.dart
@alex-medinsh
alex-medinsh requested a review from a team as a code owner June 26, 2025 21:22
@github-actions github-actions Bot added the platform-windows Building on or for Windows specifically label Jun 26, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
94ad70e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
bb7d11a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
b34fd4c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 2, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
780fce2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
3a47e90
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
054d5b8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
6e5a1c4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
472be9f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
f1de0fd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
ff98a9b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
ca2d6bb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
fec8889
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
0437cf0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
d1b22dc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
5ee9346
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
5283e09
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
009ef85
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
8f25d66
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
8f8d38c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
5239d7b
@Piinks Piinks mentioned this pull request Jul 19, 2025
Closed
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@alex-medinsh @mboetger
Add CupertinoPicker ticking sound (flutter#170641)
cbfd958 
This PR adds a ticking sound to the `CupertinoPicker` on iOS.

Fixes flutter#37329

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
957b77e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
ffbc156
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
ee23d89 Add CupertinoPicker ticking sound (flutter/flutter#170641)
7479065
@victorsanni victorsanni mentioned this pull request Sep 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camsim99 camsim99 camsim99 left review comments
@victorsanni victorsanni victorsanni left review comments
@loic-sharma loic-sharma loic-sharma approved these changes
@dkwingsmt dkwingsmt dkwingsmt approved these changes
@MitchellGoodwin MitchellGoodwin Awaiting requested review from MitchellGoodwin

Assignees

No one assigned

Labels

a: desktop Running on desktop engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages platform-android Android applications specifically platform-ios iOS applications specifically platform-linux Building on or for Linux specifically platform-windows Building on or for Windows specifically team-android Owned by Android platform team team-ios Owned by iOS platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CupertinoPicker and CupertinoDatePicker don't play the ticker sound

5 participants

@alex-medinsh @loic-sharma @dkwingsmt @camsim99 @victorsanni