Focused search field hides prefix in higher accessibility text scale modes by victorsanni · Pull Request #171406 · flutter/flutter

victorsanni · 2025-06-30T21:54:02Z

Flutter

flutter.hide.prefix.mov

Native

native.hide.prefix.mov

Fixes Focused CupertinoSearchTextField does not hide prefix in higher accessibility text scale modes

…modes

MitchellGoodwin

LGTM with one very minor nit

MitchellGoodwin · 2025-07-01T17:25:11Z

    if (widget.controller == null) {
      _controller?.dispose();
    }
+    super.dispose();


I took a look because I was curious, but it doesn't look like there wasn't a particular reason why super.dispose wasn't at the end before. #136615

Yeah and @chunhtai mentioned how it's safest to have dispose in reverse order of initState.

chunhtai

LGTM

chunhtai · 2025-07-01T18:34:13Z

      _controller!.dispose();
      _controller = null;
    }
+    if (widget.focusNode == null && oldWidget.focusNode != null) {


Thing can be a lot easier if you do this

FocusNode get _effectiveFocusNode => widget.focusNode ?? (_focusNode ?? = FocusNode());

and don't need to recreate and proactively dispose in didUpdateWidget, just do a _focusNode?.dispose at the dispose.

This although we may have a dangling internal focus node if widget rebuild with a non null widget.focusNode, but I think this is a rare case that people swap in and out of their focus node between each rebuild

I missed this but it makes sense 👍

…t scale modes (flutter/flutter#171406)

…modes (flutter#171406) ### Flutter https://github.com/user-attachments/assets/231a2e93-5fa8-4d67-933b-5d5585d05fb5 ### Native https://github.com/user-attachments/assets/94cbc0c1-1326-47db-a902-d91e8009318b Fixes [Focused CupertinoSearchTextField does not hide prefix in higher accessibility text scale modes](flutter#168255)

…t scale modes (flutter/flutter#171406)

…modes (flutter#171406) ### Flutter https://github.com/user-attachments/assets/231a2e93-5fa8-4d67-933b-5d5585d05fb5 ### Native https://github.com/user-attachments/assets/94cbc0c1-1326-47db-a902-d91e8009318b Fixes [Focused CupertinoSearchTextField does not hide prefix in higher accessibility text scale modes](flutter#168255)

Focused search field hides prefix in higher accessibility text scale …

fd9e750

…modes

victorsanni requested review from MitchellGoodwin and justinmc June 30, 2025 21:54

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages labels Jun 30, 2025

victorsanni added 2 commits June 30, 2025 14:54

Merge branch 'master' into remove-search-prefix

3db2863

Remove valuelistenablebuilder

6d864c8

MitchellGoodwin approved these changes Jul 1, 2025

View reviewed changes

victorsanni commented Jul 1, 2025

View reviewed changes

Comment thread packages/flutter/lib/src/cupertino/search_field.dart

victorsanni added 2 commits July 1, 2025 10:38

Update packages/flutter/lib/src/cupertino/search_field.dart

89b02f2

Merge branch 'master' into remove-search-prefix

4172f1b

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2025

auto-submit Bot added this pull request to the merge queue Jul 1, 2025

chunhtai approved these changes Jul 1, 2025

View reviewed changes

Merged via the queue into flutter:master with commit a58caa3 Jul 1, 2025

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 1, 2025

engine-flutter-autoroll mentioned this pull request Jul 1, 2025

Roll Flutter from 2773c0c8e15e to a58caa334609 (96 revisions) flutter/packages#9544

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

8349114

…t scale modes (flutter/flutter#171406)

victorsanni deleted the remove-search-prefix branch July 1, 2025 19:41

engine-flutter-autoroll mentioned this pull request Jul 2, 2025

Roll Flutter from 2773c0c8e15e to 1dfb59d2811c (115 revisions) flutter/packages#9546

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

fb29fff

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll mentioned this pull request Jul 2, 2025

Roll Flutter from 2773c0c8e15e to 17848992dc09 (116 revisions) flutter/packages#9547

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

0feb5af

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll mentioned this pull request Jul 2, 2025

Roll Flutter from 2773c0c8e15e to a69ba5da50db (117 revisions) flutter/packages#9548

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

7af33ec

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll mentioned this pull request Jul 2, 2025

Roll Flutter from 2773c0c8e15e to c6f9e801b2e4 (118 revisions) flutter/packages#9549

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

6e807b0

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll mentioned this pull request Jul 2, 2025

Roll Flutter from 2773c0c8e15e to 59ba3087e40d (119 revisions) flutter/packages#9550

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 2, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

c660795

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll mentioned this pull request Jul 3, 2025

Roll Flutter from 2773c0c8e15e to 2f2baae82073 (133 revisions) flutter/packages#9553

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

3755a31

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll mentioned this pull request Jul 3, 2025

Roll Flutter from 2773c0c8e15e to 58f0988f49f6 (134 revisions) flutter/packages#9554

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

680fce6

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll mentioned this pull request Jul 3, 2025

Roll Flutter from 2773c0c8e15e to 4b387d0a0bf9 (135 revisions) flutter/packages#9555

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

4032e9f

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll mentioned this pull request Jul 3, 2025

Roll Flutter from 2773c0c8e15e to d0d68fc0c820 (136 revisions) flutter/packages#9556

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

ceb7f29

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll mentioned this pull request Jul 3, 2025

Roll Flutter from 2773c0c8e15e to 750b87f55171 (137 revisions) flutter/packages#9557

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 3, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

8a38fd2

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll mentioned this pull request Jul 4, 2025

Roll Flutter from 2773c0c8e15e to 07073e911dd9 (141 revisions) flutter/packages#9558

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

dab92d8

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

c3dc09b

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 4, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

6b32cee

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

21af494

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

6105503

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

968268e

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

d1b10ce

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

d610a7d

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

29b24cb

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

fc6f357

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

f842b4c

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

1b0eb88

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

28dc4d3

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

21d98b0

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

a9e4ba6

…t scale modes (flutter/flutter#171406)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025

a58caa3 Focused search field hides prefix in higher accessibility tex…

5d6fe78

…t scale modes (flutter/flutter#171406)

Navigation Menu

Repository navigation

Focused search field hides prefix in higher accessibility text scale modes - #171406

Focused search field hides prefix in higher accessibility text scale modes#171406
auto-submit[bot] merged 5 commits into
flutter:masterfrom
victorsanni:remove-search-prefix

victorsanni commented Jun 30, 2025

Uh oh!

MitchellGoodwin left a comment

Uh oh!

MitchellGoodwin Jul 1, 2025

Uh oh!

victorsanni Jul 1, 2025

Uh oh!

Uh oh!

Uh oh!

chunhtai left a comment

Uh oh!

chunhtai Jul 1, 2025

Uh oh!

chunhtai Jul 1, 2025

Uh oh!

victorsanni Jul 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

victorsanni commented Jun 30, 2025

Flutter

Native

Uh oh!

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Uh oh!

MitchellGoodwin Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

victorsanni Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

chunhtai Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

victorsanni Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants