New optimized general convex path shadow algorithm by flar · Pull Request #178370 · flutter/flutter

flar · 2025-11-12T11:52:54Z

Convex paths will now use an optimized mesh-based algorithm to render shadows. The algorithm is based on the code in SkShadowTessellator.

Fixes #170764

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

…ex-path-shadows

flutter-dashboard · 2025-11-20T03:23:40Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #178370 at sha 4b0cb0a

flar · 2025-11-20T03:31:26Z

There are a lot of new goldens, but also some failures towards the end. It looks like the new code doesn't mesh with the Inner/Outer styles very well, but there are also a lot of blurs that are cleaner with the new code (perhaps they have 1 less MSAA resolve now?).

flar · 2025-11-20T05:25:39Z

It looks like the new Blur contents overrides Render instead of SetPassInfo. I need to check if it is bypassing some of the setup in the parent class.

gaaclarke

I'll hold off reviewing until the goldens are good. Ping me when you're ready.

…figurations

flutter-dashboard · 2025-11-21T00:54:24Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #178370 at sha 125a7df

…ex-path-shadows

flar · 2025-11-22T00:49:40Z

Updating to head as a possible de-flake because the "smiley face android engine test" does not look related and doesn't reproduce locally.

flutter-dashboard · 2025-11-22T01:53:27Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #178370 at sha cf7266c

flar · 2025-11-22T03:16:25Z

The new goldens all make sense to me so this is ready for review now.

…lutter#178370)

Roll Flutter from 6ff7f30 to 60d8165 (32 revisions) flutter/flutter@6ff7f30...60d8165 2025-12-29 [email protected] Roll Fuchsia Linux SDK from xn1U9DUFEpB4f6vG-... to DdllqZRZYriOd7Q8v... (flutter/flutter#180356) 2025-12-28 [email protected] Roll Dart SDK from 17d51009282c to df175c998021 (1 revision) (flutter/flutter#180349) 2025-12-28 [email protected] Roll Dart SDK from d4a92c2c69bf to 17d51009282c (1 revision) (flutter/flutter#180346) 2025-12-28 [email protected] Roll Fuchsia Linux SDK from jVkEEUxyGeemuu2HE... to xn1U9DUFEpB4f6vG-... (flutter/flutter#180343) 2025-12-27 [email protected] Roll Dart SDK from 3b84125003a1 to d4a92c2c69bf (1 revision) (flutter/flutter#180331) 2025-12-27 [email protected] Roll Skia from e6e535aec613 to c29a475066f5 (1 revision) (flutter/flutter#180322) 2025-12-27 [email protected] Make sure that a WidgetsApp doesn't crash in 0x0 environment (flutter/flutter#180224) 2025-12-27 [email protected] Make sure that an AnimatedSize doesn't crash in 0x0 environment (flutter/flutter#180174) 2025-12-27 [email protected] Make sure that an AnimatedGrid doesn't crash in 0x0 environment (flutter/flutter#180159) 2025-12-27 [email protected] Make sure that an AnimatedCrossFade does not crash in 0x0 environment (flutter/flutter#180088) 2025-12-27 [email protected] Make sure that an AnimatedList doesn't crash in 0x0 environment (flutter/flutter#180123) 2025-12-26 [email protected] Roll Fuchsia Linux SDK from mZlbuHta7S71Quawk... to jVkEEUxyGeemuu2HE... (flutter/flutter#180317) 2025-12-26 [email protected] Roll Dart SDK from 6b2c3716be54 to 3b84125003a1 (1 revision) (flutter/flutter#180316) 2025-12-26 [email protected] Roll Dart SDK from 18f6751c5ccc to 6b2c3716be54 (1 revision) (flutter/flutter#180252) 2025-12-26 [email protected] Roll Skia from 07c59737d265 to e6e535aec613 (1 revision) (flutter/flutter#180303) 2025-12-25 [email protected] Roll Fuchsia Linux SDK from 2q71ydbnIhmBUiNOF... to mZlbuHta7S71Quawk... (flutter/flutter#180290) 2025-12-25 [email protected] Roll Skia from 6d0a1b03e9c7 to 07c59737d265 (1 revision) (flutter/flutter#180289) 2025-12-25 [email protected] Roll Skia from 2b5d93b62a3f to 6d0a1b03e9c7 (1 revision) (flutter/flutter#180279) 2025-12-25 [email protected] Roll Skia from 3544942c9d42 to 2b5d93b62a3f (1 revision) (flutter/flutter#180276) 2025-12-24 [email protected] Roll Fuchsia Linux SDK from 5EgkVbjGVZmCFPdtR... to 2q71ydbnIhmBUiNOF... (flutter/flutter#180274) 2025-12-24 [email protected] Roll Packages from 5e3a766 to 2164da9 (4 revisions) (flutter/flutter#180271) 2025-12-24 [email protected] Roll Skia from 988a48f7a944 to 3544942c9d42 (1 revision) (flutter/flutter#180267) 2025-12-24 [email protected] Marks Mac_arm64_mokey native_assets_android to be unflaky (flutter/flutter#180263) 2025-12-24 [email protected] Roll Skia from 51a05ce05880 to 988a48f7a944 (1 revision) (flutter/flutter#180256) 2025-12-24 [email protected] fix: exclude semantics for disabled dates (flutter/flutter#178981) 2025-12-24 [email protected] Roll Skia from 7fe9b93153f8 to 51a05ce05880 (1 revision) (flutter/flutter#180253) 2025-12-24 [email protected] Enhance documentation for sortable column behavior (flutter/flutter#180011) 2025-12-24 [email protected] Roll Skia from a0f18947bc1b to 7fe9b93153f8 (4 revisions) (flutter/flutter#180247) 2025-12-23 [email protected] Roll Skia from bdb147ae3040 to a0f18947bc1b (2 revisions) (flutter/flutter#180241) 2025-12-23 [email protected] Roll Dart SDK from 94b05f717ba3 to 18f6751c5ccc (1 revision) (flutter/flutter#180236) 2025-12-23 [email protected] docs: clarify dropdown menu text clearing (flutter/flutter#179676) 2025-12-23 [email protected] New optimized general convex path shadow algorithm (flutter/flutter#178370) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...

…lutter#178370)

Roll Flutter from 6ff7f30 to 60d8165 (32 revisions) flutter/flutter@6ff7f30...60d8165 2025-12-29 [email protected] Roll Fuchsia Linux SDK from xn1U9DUFEpB4f6vG-... to DdllqZRZYriOd7Q8v... (flutter/flutter#180356) 2025-12-28 [email protected] Roll Dart SDK from 17d51009282c to df175c998021 (1 revision) (flutter/flutter#180349) 2025-12-28 [email protected] Roll Dart SDK from d4a92c2c69bf to 17d51009282c (1 revision) (flutter/flutter#180346) 2025-12-28 [email protected] Roll Fuchsia Linux SDK from jVkEEUxyGeemuu2HE... to xn1U9DUFEpB4f6vG-... (flutter/flutter#180343) 2025-12-27 [email protected] Roll Dart SDK from 3b84125003a1 to d4a92c2c69bf (1 revision) (flutter/flutter#180331) 2025-12-27 [email protected] Roll Skia from e6e535aec613 to c29a475066f5 (1 revision) (flutter/flutter#180322) 2025-12-27 [email protected] Make sure that a WidgetsApp doesn't crash in 0x0 environment (flutter/flutter#180224) 2025-12-27 [email protected] Make sure that an AnimatedSize doesn't crash in 0x0 environment (flutter/flutter#180174) 2025-12-27 [email protected] Make sure that an AnimatedGrid doesn't crash in 0x0 environment (flutter/flutter#180159) 2025-12-27 [email protected] Make sure that an AnimatedCrossFade does not crash in 0x0 environment (flutter/flutter#180088) 2025-12-27 [email protected] Make sure that an AnimatedList doesn't crash in 0x0 environment (flutter/flutter#180123) 2025-12-26 [email protected] Roll Fuchsia Linux SDK from mZlbuHta7S71Quawk... to jVkEEUxyGeemuu2HE... (flutter/flutter#180317) 2025-12-26 [email protected] Roll Dart SDK from 6b2c3716be54 to 3b84125003a1 (1 revision) (flutter/flutter#180316) 2025-12-26 [email protected] Roll Dart SDK from 18f6751c5ccc to 6b2c3716be54 (1 revision) (flutter/flutter#180252) 2025-12-26 [email protected] Roll Skia from 07c59737d265 to e6e535aec613 (1 revision) (flutter/flutter#180303) 2025-12-25 [email protected] Roll Fuchsia Linux SDK from 2q71ydbnIhmBUiNOF... to mZlbuHta7S71Quawk... (flutter/flutter#180290) 2025-12-25 [email protected] Roll Skia from 6d0a1b03e9c7 to 07c59737d265 (1 revision) (flutter/flutter#180289) 2025-12-25 [email protected] Roll Skia from 2b5d93b62a3f to 6d0a1b03e9c7 (1 revision) (flutter/flutter#180279) 2025-12-25 [email protected] Roll Skia from 3544942c9d42 to 2b5d93b62a3f (1 revision) (flutter/flutter#180276) 2025-12-24 [email protected] Roll Fuchsia Linux SDK from 5EgkVbjGVZmCFPdtR... to 2q71ydbnIhmBUiNOF... (flutter/flutter#180274) 2025-12-24 [email protected] Roll Packages from 5e3a766 to 2164da9 (4 revisions) (flutter/flutter#180271) 2025-12-24 [email protected] Roll Skia from 988a48f7a944 to 3544942c9d42 (1 revision) (flutter/flutter#180267) 2025-12-24 [email protected] Marks Mac_arm64_mokey native_assets_android to be unflaky (flutter/flutter#180263) 2025-12-24 [email protected] Roll Skia from 51a05ce05880 to 988a48f7a944 (1 revision) (flutter/flutter#180256) 2025-12-24 [email protected] fix: exclude semantics for disabled dates (flutter/flutter#178981) 2025-12-24 [email protected] Roll Skia from 7fe9b93153f8 to 51a05ce05880 (1 revision) (flutter/flutter#180253) 2025-12-24 [email protected] Enhance documentation for sortable column behavior (flutter/flutter#180011) 2025-12-24 [email protected] Roll Skia from a0f18947bc1b to 7fe9b93153f8 (4 revisions) (flutter/flutter#180247) 2025-12-23 [email protected] Roll Skia from bdb147ae3040 to a0f18947bc1b (2 revisions) (flutter/flutter#180241) 2025-12-23 [email protected] Roll Dart SDK from 94b05f717ba3 to 18f6751c5ccc (1 revision) (flutter/flutter#180236) 2025-12-23 [email protected] docs: clarify dropdown menu text clearing (flutter/flutter#179676) 2025-12-23 [email protected] New optimized general convex path shadow algorithm (flutter/flutter#178370) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...

New optimized general convex path shadow algorithm

de58e71

github-actions Bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Nov 12, 2025

Merge branch 'master' of github.com:flutter/flutter into general-conv…

a6a502c

…ex-path-shadows

flar commented Nov 12, 2025

View reviewed changes

Comment thread engine/src/flutter/impeller/toolkit/interop/impeller_unittests.cc Outdated

flar added 10 commits November 12, 2025 12:25

more consistent types in new shaders and functions

78668f6

restore inadvertently commented out interop test

20d98c2

mallioc

b1d6bf0

fix nop-blur detection

5215326

fix comment

6d95550

adjust shadow radius to match other algorithms

2cd0547

adjust comments

96ec924

remove Skia shadow mesh hook used for debugging

1411caa

improve value and coverage of the playground tests

0ed0a2b

Merge branch 'master' of github.com:flutter/flutter into general-conv…

4b0cb0a

…ex-path-shadows

flar marked this pull request as ready for review November 20, 2025 03:20

flar requested review from chinmaygarde and gaaclarke November 20, 2025 03:21

flutter-dashboard Bot added the will affect goldens Changes to golden files label Nov 20, 2025

gaaclarke reviewed Nov 20, 2025

View reviewed changes

flar added 2 commits November 20, 2025 14:13

fix Inner/Outer mask blurs with new general convex shadow rendering

7c43ad3

switch to local coordinates for compatibility with various entity con…

125a7df

…figurations

Merge branch 'master' of github.com:flutter/flutter into general-conv…

cf7266c

…ex-path-shadows

engine-flutter-autoroll mentioned this pull request Dec 24, 2025

Roll Flutter from 6ff7f300473f to f6144ff9ff84 (11 revisions) flutter/packages#10679

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 24, 2025

b568f33 New optimized general convex path shadow algorithm (flutter/f…

f6d030d

…lutter#178370)

engine-flutter-autoroll mentioned this pull request Dec 24, 2025

Roll Flutter from 6ff7f300473f to 4220b8a6cb7b (12 revisions) flutter/packages#10680

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 24, 2025

b568f33 New optimized general convex path shadow algorithm (flutter/f…

560d6b9

…lutter#178370)

engine-flutter-autoroll mentioned this pull request Dec 24, 2025

Roll Flutter from 6ff7f300473f to e255e010da37 (13 revisions) flutter/packages#10681

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 25, 2025

b568f33 New optimized general convex path shadow algorithm (flutter/f…

bda8cd5

…lutter#178370)

engine-flutter-autoroll mentioned this pull request Dec 25, 2025

Roll Flutter from 6ff7f300473f to 404ba9de3bc4 (15 revisions) flutter/packages#10682

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 25, 2025

b568f33 New optimized general convex path shadow algorithm (flutter/f…

cfc23f9

…lutter#178370)

engine-flutter-autoroll mentioned this pull request Dec 25, 2025

Roll Flutter from 6ff7f300473f to 404ba9de3bc4 (15 revisions) flutter/packages#10684

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 26, 2025

b568f33 New optimized general convex path shadow algorithm (flutter/f…

77f591b

…lutter#178370)

engine-flutter-autoroll mentioned this pull request Dec 26, 2025

Roll Flutter from 6ff7f300473f to 096892ed81e8 (18 revisions) flutter/packages#10685

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 26, 2025

b568f33 New optimized general convex path shadow algorithm (flutter/f…

fbfe366

…lutter#178370)

engine-flutter-autoroll mentioned this pull request Dec 26, 2025

Roll Flutter from 6ff7f300473f to 9ef3835ff659 (19 revisions) flutter/packages#10686

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 27, 2025

b568f33 New optimized general convex path shadow algorithm (flutter/f…

3994ced

…lutter#178370)

engine-flutter-autoroll mentioned this pull request Dec 27, 2025

Roll Flutter from 6ff7f300473f to 8455b1576e2b (28 revisions) flutter/packages#10687

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 27, 2025

b568f33 New optimized general convex path shadow algorithm (flutter/f…

b51a142

…lutter#178370)

engine-flutter-autoroll mentioned this pull request Dec 27, 2025

Roll Flutter from 6ff7f300473f to 8455b1576e2b (28 revisions) flutter/packages#10689

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 28, 2025

b568f33 New optimized general convex path shadow algorithm (flutter/f…

d21dab3

…lutter#178370)

engine-flutter-autoroll mentioned this pull request Dec 28, 2025

Roll Flutter from 6ff7f300473f to c637545f6e5b (31 revisions) flutter/packages#10690

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 28, 2025

b568f33 New optimized general convex path shadow algorithm (flutter/f…

6b0538a

…lutter#178370)

engine-flutter-autoroll mentioned this pull request Dec 28, 2025

Roll Flutter from 6ff7f300473f to c637545f6e5b (31 revisions) flutter/packages#10691

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 29, 2025

b568f33 New optimized general convex path shadow algorithm (flutter/f…

495431a

…lutter#178370)

engine-flutter-autoroll mentioned this pull request Dec 29, 2025

Roll Flutter from 6ff7f300473f to 60d8165b11e2 (32 revisions) flutter/packages#10694

Merged

flar mentioned this pull request Jan 23, 2026

[impeller] Poor performance with non-symmetrical shadows on older Android devices. #162312

Closed

1 task done

Piinks mentioned this pull request Jan 24, 2026

Flutter Notable Commits - 2025 #161460

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026

b568f33 New optimized general convex path shadow algorithm (flutter/f…

cd6e02b

…lutter#178370)

flar mentioned this pull request Mar 2, 2026

[Shadows] Flutter 3.41.1: ShapeDecoration shadow becomes inconsistent under Transform.rotateY when custom PathBuilderBorder includes an out-of-bounds point #182659

Closed

Navigation Menu

Repository navigation

New optimized general convex path shadow algorithm - #178370

New optimized general convex path shadow algorithm#178370
auto-submit[bot] merged 28 commits into
flutter:masterfrom
flar:general-convex-path-shadows

flar commented Nov 12, 2025

Uh oh!

Uh oh!

flutter-dashboard Bot commented Nov 20, 2025

Uh oh!

flar commented Nov 20, 2025

Uh oh!

flar commented Nov 20, 2025

Uh oh!

gaaclarke left a comment

Uh oh!

flutter-dashboard Bot commented Nov 21, 2025

Uh oh!

flar commented Nov 22, 2025

Uh oh!

flutter-dashboard Bot commented Nov 22, 2025

Uh oh!

flar commented Nov 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

flar commented Nov 12, 2025

Pre-launch Checklist

Uh oh!

Uh oh!

flutter-dashboard Bot commented Nov 20, 2025

Uh oh!

flar commented Nov 20, 2025

Uh oh!

flar commented Nov 20, 2025

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard Bot commented Nov 21, 2025

Uh oh!

flar commented Nov 22, 2025

Uh oh!

flutter-dashboard Bot commented Nov 22, 2025

Uh oh!

flar commented Nov 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants