fix: exclude semantics for disabled dates by rkishan516 · Pull Request #178981 · flutter/flutter

rkishan516 · 2025-11-23T05:42:22Z

Changes

Exclude semantics for disabled dates directly in CupertinoDatePicker

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

gemini-code-assist

Code Review

This pull request introduces a fix to exclude semantics for disabled dates in CupertinoDatePicker. The changes involve wrapping disabled date/time items with the ExcludeSemantics widget across various picker builders. This is complemented by a modification in _RenderCupertinoPickerSemantics to correctly handle items with empty labels, preventing accessibility actions from navigating to disabled items. A new widget test has been added to verify that disabled dates are indeed excluded from semantics, ensuring that accessibility tools like screen readers do not announce or interact with them. The implementation is consistent and well-tested, effectively addressing the issue.

chunhtai · 2025-11-24T19:35:27Z

    }
-    config.value = indexedChildren[_currentIndex]!.label;
+    final String currentLabel = indexedChildren[_currentIndex]!.label;
+    // If the current item has an empty label (e.g., wrapped with ExcludeSemantics),


if this is wrapped in ExcludeSemantics how does this method get called in the first place?

Hey @chunhtai,

If we look at assembleSemanticsNode in picker.dart:553:

The method iterates over all child semantics nodes via scrollable.visitChildren

It builds indexedChildren map using each node's indexInParent

Nodes wrapped with ExcludeSemantics are still present in this iteration - they just have an empty label

So the SemanticsNode for a disabled date still exists and gets added to indexedChildren, but its label property is empty.

I see, it is the ListWheelChildBuilderDelegate that wrap all the children with indexedSemantics even for those who ExcludedSemantics which is not ideal, but fixing this will probably need to modify the API which probably not worth it. This is good then

chunhtai · 2025-11-24T19:37:33Z

+    }
+    config.value = currentLabel;
    final SemanticsNode? previousChild = indexedChildren[_currentIndex - 1];
    final SemanticsNode? nextChild = indexedChildren[_currentIndex + 1];


same here, for the ExludesSemantics, they shouldn't be in the in indexedChildren I think? is the ExludesSemantics wrapped in the wrong level?

dkwingsmt · 2025-12-17T19:16:04Z

What is the status of this PR? (from triage)

rkishan516 · 2025-12-18T03:21:09Z

What is the status of this PR? (from triage)

Waiting for another review after #178981 (comment)

chunhtai

LGTM

chunhtai · 2025-12-18T21:07:34Z

    }
-    config.value = indexedChildren[_currentIndex]!.label;
+    final String currentLabel = indexedChildren[_currentIndex]!.label;
+    // If the current item has an empty label (e.g., wrapped with ExcludeSemantics),


I see, it is the ListWheelChildBuilderDelegate that wrap all the children with indexedSemantics even for those who ExcludedSemantics which is not ideal, but fixing this will probably need to modify the API which probably not worth it. This is good then

victorsanni · 2025-12-24T02:31:18Z

+    // The semantics system requires that if "value" is empty, "increasedValue"
+    // and "decreasedValue" must also be empty, and no increase/decrease actions
+    // should be set.
+    if (currentLabel.isEmpty) {


can we also add a test for this if-block?

Sure, will add and push.

…8981)

Roll Flutter from 6ff7f30 to 60d8165 (32 revisions) flutter/flutter@6ff7f30...60d8165 2025-12-29 [email protected] Roll Fuchsia Linux SDK from xn1U9DUFEpB4f6vG-... to DdllqZRZYriOd7Q8v... (flutter/flutter#180356) 2025-12-28 [email protected] Roll Dart SDK from 17d51009282c to df175c998021 (1 revision) (flutter/flutter#180349) 2025-12-28 [email protected] Roll Dart SDK from d4a92c2c69bf to 17d51009282c (1 revision) (flutter/flutter#180346) 2025-12-28 [email protected] Roll Fuchsia Linux SDK from jVkEEUxyGeemuu2HE... to xn1U9DUFEpB4f6vG-... (flutter/flutter#180343) 2025-12-27 [email protected] Roll Dart SDK from 3b84125003a1 to d4a92c2c69bf (1 revision) (flutter/flutter#180331) 2025-12-27 [email protected] Roll Skia from e6e535aec613 to c29a475066f5 (1 revision) (flutter/flutter#180322) 2025-12-27 [email protected] Make sure that a WidgetsApp doesn't crash in 0x0 environment (flutter/flutter#180224) 2025-12-27 [email protected] Make sure that an AnimatedSize doesn't crash in 0x0 environment (flutter/flutter#180174) 2025-12-27 [email protected] Make sure that an AnimatedGrid doesn't crash in 0x0 environment (flutter/flutter#180159) 2025-12-27 [email protected] Make sure that an AnimatedCrossFade does not crash in 0x0 environment (flutter/flutter#180088) 2025-12-27 [email protected] Make sure that an AnimatedList doesn't crash in 0x0 environment (flutter/flutter#180123) 2025-12-26 [email protected] Roll Fuchsia Linux SDK from mZlbuHta7S71Quawk... to jVkEEUxyGeemuu2HE... (flutter/flutter#180317) 2025-12-26 [email protected] Roll Dart SDK from 6b2c3716be54 to 3b84125003a1 (1 revision) (flutter/flutter#180316) 2025-12-26 [email protected] Roll Dart SDK from 18f6751c5ccc to 6b2c3716be54 (1 revision) (flutter/flutter#180252) 2025-12-26 [email protected] Roll Skia from 07c59737d265 to e6e535aec613 (1 revision) (flutter/flutter#180303) 2025-12-25 [email protected] Roll Fuchsia Linux SDK from 2q71ydbnIhmBUiNOF... to mZlbuHta7S71Quawk... (flutter/flutter#180290) 2025-12-25 [email protected] Roll Skia from 6d0a1b03e9c7 to 07c59737d265 (1 revision) (flutter/flutter#180289) 2025-12-25 [email protected] Roll Skia from 2b5d93b62a3f to 6d0a1b03e9c7 (1 revision) (flutter/flutter#180279) 2025-12-25 [email protected] Roll Skia from 3544942c9d42 to 2b5d93b62a3f (1 revision) (flutter/flutter#180276) 2025-12-24 [email protected] Roll Fuchsia Linux SDK from 5EgkVbjGVZmCFPdtR... to 2q71ydbnIhmBUiNOF... (flutter/flutter#180274) 2025-12-24 [email protected] Roll Packages from 5e3a766 to 2164da9 (4 revisions) (flutter/flutter#180271) 2025-12-24 [email protected] Roll Skia from 988a48f7a944 to 3544942c9d42 (1 revision) (flutter/flutter#180267) 2025-12-24 [email protected] Marks Mac_arm64_mokey native_assets_android to be unflaky (flutter/flutter#180263) 2025-12-24 [email protected] Roll Skia from 51a05ce05880 to 988a48f7a944 (1 revision) (flutter/flutter#180256) 2025-12-24 [email protected] fix: exclude semantics for disabled dates (flutter/flutter#178981) 2025-12-24 [email protected] Roll Skia from 7fe9b93153f8 to 51a05ce05880 (1 revision) (flutter/flutter#180253) 2025-12-24 [email protected] Enhance documentation for sortable column behavior (flutter/flutter#180011) 2025-12-24 [email protected] Roll Skia from a0f18947bc1b to 7fe9b93153f8 (4 revisions) (flutter/flutter#180247) 2025-12-23 [email protected] Roll Skia from bdb147ae3040 to a0f18947bc1b (2 revisions) (flutter/flutter#180241) 2025-12-23 [email protected] Roll Dart SDK from 94b05f717ba3 to 18f6751c5ccc (1 revision) (flutter/flutter#180236) 2025-12-23 [email protected] docs: clarify dropdown menu text clearing (flutter/flutter#179676) 2025-12-23 [email protected] New optimized general convex path shadow algorithm (flutter/flutter#178370) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...

…8981)

Roll Flutter from 6ff7f30 to 60d8165 (32 revisions) flutter/flutter@6ff7f30...60d8165 2025-12-29 [email protected] Roll Fuchsia Linux SDK from xn1U9DUFEpB4f6vG-... to DdllqZRZYriOd7Q8v... (flutter/flutter#180356) 2025-12-28 [email protected] Roll Dart SDK from 17d51009282c to df175c998021 (1 revision) (flutter/flutter#180349) 2025-12-28 [email protected] Roll Dart SDK from d4a92c2c69bf to 17d51009282c (1 revision) (flutter/flutter#180346) 2025-12-28 [email protected] Roll Fuchsia Linux SDK from jVkEEUxyGeemuu2HE... to xn1U9DUFEpB4f6vG-... (flutter/flutter#180343) 2025-12-27 [email protected] Roll Dart SDK from 3b84125003a1 to d4a92c2c69bf (1 revision) (flutter/flutter#180331) 2025-12-27 [email protected] Roll Skia from e6e535aec613 to c29a475066f5 (1 revision) (flutter/flutter#180322) 2025-12-27 [email protected] Make sure that a WidgetsApp doesn't crash in 0x0 environment (flutter/flutter#180224) 2025-12-27 [email protected] Make sure that an AnimatedSize doesn't crash in 0x0 environment (flutter/flutter#180174) 2025-12-27 [email protected] Make sure that an AnimatedGrid doesn't crash in 0x0 environment (flutter/flutter#180159) 2025-12-27 [email protected] Make sure that an AnimatedCrossFade does not crash in 0x0 environment (flutter/flutter#180088) 2025-12-27 [email protected] Make sure that an AnimatedList doesn't crash in 0x0 environment (flutter/flutter#180123) 2025-12-26 [email protected] Roll Fuchsia Linux SDK from mZlbuHta7S71Quawk... to jVkEEUxyGeemuu2HE... (flutter/flutter#180317) 2025-12-26 [email protected] Roll Dart SDK from 6b2c3716be54 to 3b84125003a1 (1 revision) (flutter/flutter#180316) 2025-12-26 [email protected] Roll Dart SDK from 18f6751c5ccc to 6b2c3716be54 (1 revision) (flutter/flutter#180252) 2025-12-26 [email protected] Roll Skia from 07c59737d265 to e6e535aec613 (1 revision) (flutter/flutter#180303) 2025-12-25 [email protected] Roll Fuchsia Linux SDK from 2q71ydbnIhmBUiNOF... to mZlbuHta7S71Quawk... (flutter/flutter#180290) 2025-12-25 [email protected] Roll Skia from 6d0a1b03e9c7 to 07c59737d265 (1 revision) (flutter/flutter#180289) 2025-12-25 [email protected] Roll Skia from 2b5d93b62a3f to 6d0a1b03e9c7 (1 revision) (flutter/flutter#180279) 2025-12-25 [email protected] Roll Skia from 3544942c9d42 to 2b5d93b62a3f (1 revision) (flutter/flutter#180276) 2025-12-24 [email protected] Roll Fuchsia Linux SDK from 5EgkVbjGVZmCFPdtR... to 2q71ydbnIhmBUiNOF... (flutter/flutter#180274) 2025-12-24 [email protected] Roll Packages from 5e3a766 to 2164da9 (4 revisions) (flutter/flutter#180271) 2025-12-24 [email protected] Roll Skia from 988a48f7a944 to 3544942c9d42 (1 revision) (flutter/flutter#180267) 2025-12-24 [email protected] Marks Mac_arm64_mokey native_assets_android to be unflaky (flutter/flutter#180263) 2025-12-24 [email protected] Roll Skia from 51a05ce05880 to 988a48f7a944 (1 revision) (flutter/flutter#180256) 2025-12-24 [email protected] fix: exclude semantics for disabled dates (flutter/flutter#178981) 2025-12-24 [email protected] Roll Skia from 7fe9b93153f8 to 51a05ce05880 (1 revision) (flutter/flutter#180253) 2025-12-24 [email protected] Enhance documentation for sortable column behavior (flutter/flutter#180011) 2025-12-24 [email protected] Roll Skia from a0f18947bc1b to 7fe9b93153f8 (4 revisions) (flutter/flutter#180247) 2025-12-23 [email protected] Roll Skia from bdb147ae3040 to a0f18947bc1b (2 revisions) (flutter/flutter#180241) 2025-12-23 [email protected] Roll Dart SDK from 94b05f717ba3 to 18f6751c5ccc (1 revision) (flutter/flutter#180236) 2025-12-23 [email protected] docs: clarify dropdown menu text clearing (flutter/flutter#179676) 2025-12-23 [email protected] New optimized general convex path shadow algorithm (flutter/flutter#178370) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...

rkishan516 requested a review from chunhtai November 23, 2025 05:42

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages labels Nov 23, 2025

gemini-code-assist Bot reviewed Nov 23, 2025

View reviewed changes

rkishan516 force-pushed the cupertino-date-picker-semantics branch from ed4797a to 5273ad3 Compare November 23, 2025 06:18

chunhtai reviewed Nov 24, 2025

View reviewed changes

victorsanni self-requested a review November 24, 2025 19:40

chunhtai self-requested a review December 17, 2025 19:37

chunhtai approved these changes Dec 18, 2025

View reviewed changes

chunhtai requested a review from hannah-hyj December 18, 2025 21:08

victorsanni reviewed Dec 24, 2025

View reviewed changes

fix: exclude semantics for disabled dates

cfffdba

rkishan516 force-pushed the cupertino-date-picker-semantics branch from 5273ad3 to 6e86c0c Compare December 24, 2025 03:02

test: add test for empty label as per feedback

c6f64ae

rkishan516 force-pushed the cupertino-date-picker-semantics branch from 6e86c0c to c6f64ae Compare December 24, 2025 03:39

victorsanni approved these changes Dec 24, 2025

View reviewed changes

Comment thread packages/flutter/test/cupertino/picker_test.dart Outdated

Comment thread packages/flutter/test/cupertino/picker_test.dart

docs: update docs and linting issues

4665283

rkishan516 added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 24, 2025

auto-submit Bot added this pull request to the merge queue Dec 24, 2025

Merged via the queue into flutter:master with commit e5be1a3 Dec 24, 2025
71 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 24, 2025

engine-flutter-autoroll mentioned this pull request Dec 24, 2025

Roll Flutter from 6ff7f300473f to f6144ff9ff84 (11 revisions) flutter/packages#10679

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 24, 2025

e5be1a3 fix: exclude semantics for disabled dates (flutter/flutter#17…

55d0afc

…8981)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 24, 2025

e5be1a3 fix: exclude semantics for disabled dates (flutter/flutter#17…

a1eb671

…8981)

engine-flutter-autoroll mentioned this pull request Dec 24, 2025

Roll Flutter from 6ff7f300473f to 4220b8a6cb7b (12 revisions) flutter/packages#10680

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 24, 2025

e5be1a3 fix: exclude semantics for disabled dates (flutter/flutter#17…

1f9774f

…8981)

engine-flutter-autoroll mentioned this pull request Dec 24, 2025

Roll Flutter from 6ff7f300473f to e255e010da37 (13 revisions) flutter/packages#10681

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 25, 2025

e5be1a3 fix: exclude semantics for disabled dates (flutter/flutter#17…

0bc8d4f

…8981)

engine-flutter-autoroll mentioned this pull request Dec 25, 2025

Roll Flutter from 6ff7f300473f to 404ba9de3bc4 (15 revisions) flutter/packages#10682

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 25, 2025

e5be1a3 fix: exclude semantics for disabled dates (flutter/flutter#17…

a7ecb91

…8981)

engine-flutter-autoroll mentioned this pull request Dec 25, 2025

Roll Flutter from 6ff7f300473f to 404ba9de3bc4 (15 revisions) flutter/packages#10684

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 26, 2025

e5be1a3 fix: exclude semantics for disabled dates (flutter/flutter#17…

21c6268

…8981)

engine-flutter-autoroll mentioned this pull request Dec 26, 2025

Roll Flutter from 6ff7f300473f to 096892ed81e8 (18 revisions) flutter/packages#10685

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 26, 2025

e5be1a3 fix: exclude semantics for disabled dates (flutter/flutter#17…

bfa9cde

…8981)

engine-flutter-autoroll mentioned this pull request Dec 26, 2025

Roll Flutter from 6ff7f300473f to 9ef3835ff659 (19 revisions) flutter/packages#10686

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 27, 2025

e5be1a3 fix: exclude semantics for disabled dates (flutter/flutter#17…

198c14f

…8981)

engine-flutter-autoroll mentioned this pull request Dec 27, 2025

Roll Flutter from 6ff7f300473f to 8455b1576e2b (28 revisions) flutter/packages#10687

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 27, 2025

e5be1a3 fix: exclude semantics for disabled dates (flutter/flutter#17…

5edab73

…8981)

engine-flutter-autoroll mentioned this pull request Dec 27, 2025

Roll Flutter from 6ff7f300473f to 8455b1576e2b (28 revisions) flutter/packages#10689

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 28, 2025

e5be1a3 fix: exclude semantics for disabled dates (flutter/flutter#17…

ebec071

…8981)

engine-flutter-autoroll mentioned this pull request Dec 28, 2025

Roll Flutter from 6ff7f300473f to c637545f6e5b (31 revisions) flutter/packages#10690

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 28, 2025

e5be1a3 fix: exclude semantics for disabled dates (flutter/flutter#17…

621002a

…8981)

engine-flutter-autoroll mentioned this pull request Dec 28, 2025

Roll Flutter from 6ff7f300473f to c637545f6e5b (31 revisions) flutter/packages#10691

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 29, 2025

e5be1a3 fix: exclude semantics for disabled dates (flutter/flutter#17…

4de5f75

…8981)

engine-flutter-autoroll mentioned this pull request Dec 29, 2025

Roll Flutter from 6ff7f300473f to 60d8165b11e2 (32 revisions) flutter/packages#10694

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2026

e5be1a3 fix: exclude semantics for disabled dates (flutter/flutter#17…

1412ed1

…8981)

rkishan516 deleted the cupertino-date-picker-semantics branch February 20, 2026 03:03

Navigation Menu

Repository navigation

fix: exclude semantics for disabled dates - #178981

fix: exclude semantics for disabled dates#178981
auto-submit[bot] merged 3 commits into
flutter:masterfrom
rkishan516:cupertino-date-picker-semantics

rkishan516 commented Nov 23, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

chunhtai Nov 24, 2025

Uh oh!

rkishan516 Nov 25, 2025 •

edited

Loading

Uh oh!

chunhtai Dec 18, 2025

Uh oh!

chunhtai Nov 24, 2025

Uh oh!

dkwingsmt commented Dec 17, 2025

Uh oh!

rkishan516 commented Dec 18, 2025

Uh oh!

chunhtai left a comment

Uh oh!

chunhtai Dec 18, 2025

Uh oh!

victorsanni Dec 24, 2025

Uh oh!

rkishan516 Dec 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

rkishan516 commented Nov 23, 2025

Changes

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

chunhtai Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

rkishan516 Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

chunhtai Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt commented Dec 17, 2025

Uh oh!

rkishan516 commented Dec 18, 2025

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

victorsanni Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

rkishan516 Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rkishan516 Nov 25, 2025 •

edited

Loading