Skip to content

Skip flutter widget-preview test that times out frequently - #184988

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
loic-sharma:disable_flaky_widget_preview_test
Apr 14, 2026
Merged

auto-submit[bot] merged 1 commit into
flutter:masterfrom
loic-sharma:disable_flaky_widget_preview_test

Conversation

@loic-sharma

@loic-sharma loic-sharma commented Apr 13, 2026 •

Copy link
Copy Markdown
Member

Temporarily skip this test. It is currently timing out often, causing the tree to be closed.

I'd consider reviewing this change with whitespace changes hidden: https://github.com/flutter/flutter/pull/184988/changes?w=1

Part of: #184985

@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request skips the 'doesn't crash on flutter clean' integration test in widget_preview_smoke_test.dart. Feedback suggests awaiting asynchronous operations within the stream listener to avoid race conditions and providing the skip reason as a string for improved test reporting.

Comment on lines +182 to +200
dtdConnection.onEvent(WidgetPreviewDtdServices.kWidgetPreviewScaffoldStreamRoot).listen((
DTDEvent event,
) {
expect(event.stream, WidgetPreviewDtdServices.kWidgetPreviewScaffoldStreamRoot);
expect(event.kind, 'Connected');
if (firstConnection) {
firstConnection = false;
runFlutterClean(tempDir);
dtdConnection.call(
WidgetPreviewDtdServices.kWidgetPreviewServiceRoot,
WidgetPreviewDtdServices.kHotRestartPreviewer,
);
return;
}
// The second `Connected` event should come after the previewer is hot restarted after
// we perform the `flutter clean`. This event won't be sent again if the previewer has
// crashed.
completer.complete();
});

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The asynchronous operations runFlutterClean and dtdConnection.call are not being awaited inside the stream listener. This can lead to race conditions where the hot restart is triggered before the clean operation completes, or the test finishes before the DTD call is processed. This might be contributing to the flakiness and timeouts observed in this test.

Suggested change
dtdConnection.onEvent(WidgetPreviewDtdServices.kWidgetPreviewScaffoldStreamRoot).listen((
DTDEvent event,
) {
expect(event.stream, WidgetPreviewDtdServices.kWidgetPreviewScaffoldStreamRoot);
expect(event.kind, 'Connected');
if (firstConnection) {
firstConnection = false;
runFlutterClean(tempDir);
dtdConnection.call(
WidgetPreviewDtdServices.kWidgetPreviewServiceRoot,
WidgetPreviewDtdServices.kHotRestartPreviewer,
);
return;
}
// The second `Connected` event should come after the previewer is hot restarted after
// we perform the `flutter clean`. This event won't be sent again if the previewer has
// crashed.
completer.complete();
});
dtdConnection.onEvent(WidgetPreviewDtdServices.kWidgetPreviewScaffoldStreamRoot).listen((
DTDEvent event,
) async {
expect(event.stream, WidgetPreviewDtdServices.kWidgetPreviewScaffoldStreamRoot);
expect(event.kind, 'Connected');
if (firstConnection) {
firstConnection = false;
await runFlutterClean(tempDir);
await dtdConnection.call(
WidgetPreviewDtdServices.kWidgetPreviewServiceRoot,
WidgetPreviewDtdServices.kHotRestartPreviewer,
);
return;
}
// The second `Connected` event should come after the previewer is hot restarted after
// we perform the `flutter clean`. This event won't be sent again if the previewer has
// crashed.
completer.complete();
});

@loic-sharma
loic-sharma requested a review from bkonyi April 13, 2026 19:19
@loic-sharma

Copy link
Copy Markdown
Member Author

Closing in favor of #184991

@loic-sharma loic-sharma reopened this Apr 14, 2026
@fluttergithubbot

Copy link
Copy Markdown
Contributor

An existing Git SHA, be4c8249f2a712db29cfb0d339ea04627e953937, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

@loic-sharma loic-sharma added emergency Jump the queue; land PR in front of all others; only use for emergencies CICD Run CI/CD labels Apr 14, 2026
@flutter-dashboard

Copy link
Copy Markdown

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Apr 14, 2026
Merged via the queue into flutter:master with commit 44aede4 Apr 14, 2026
166 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2026
master-wayne7 pushed a commit to master-wayne7/flutter that referenced this pull request Apr 15, 2026
…84988)

Temporarily skip this test. It is currently timing out often, causing
the tree to be closed.

I'd consider reviewing this change with whitespace changes hidden:
https://github.com/flutter/flutter/pull/184988/changes?w=1

Part of: flutter#184985
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Apr 16, 2026
Roll Flutter from c1b14e92dcfb to 31f1802cb859 (46 revisions)

flutter/flutter@c1b14e9...31f1802

2026-04-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#185083)" (flutter/flutter#185145)
2026-04-16 [email protected] Add oval drawing support to the SDF uber shader (flutter/flutter#184903)
2026-04-16 [email protected] Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#185083)
2026-04-16 [email protected] Roll Skia from 2c49b3f9c3c2 to 391cdbe3ffe9 (2 revisions) (flutter/flutter#185138)
2026-04-16 [email protected] Roll Dart SDK from 4ee990654146 to fbddcbe0cd96 (1 revision) (flutter/flutter#185137)
2026-04-16 [email protected] Roll Skia from f4e3cd2c2159 to 2c49b3f9c3c2 (14 revisions) (flutter/flutter#185131)
2026-04-16 [email protected] Roll Dart SDK from 87b7c87e7207 to 4ee990654146 (5 revisions) (flutter/flutter#185108)
2026-04-15 [email protected] Use the `flutteractionsbot` token to push the release branch. (flutter/flutter#184833)
2026-04-15 [email protected] Allow period characters in iOS and macOS framework names (flutter/flutter#184335)
2026-04-15 [email protected] Fix SliverResizingHeader semantic focus (flutter/flutter#179690)
2026-04-15 [email protected] ignore avoid_type_to_string lint rule in flutter_tools (flutter/flutter#184766)
2026-04-15 [email protected] Roll Skia from bda7232e6772 to f4e3cd2c2159 (4 revisions) (flutter/flutter#185063)
2026-04-15 [email protected] Add initial AI guidance for issues (flutter/flutter#184885)
2026-04-15 [email protected] Roll Fuchsia Linux SDK from rB8LAuZL_DwHMssTU... to IdBT8fSMYrYSip65j... (flutter/flutter#185064)
2026-04-15 [email protected] Fix an ordering dependency in the services/system_chrome_test.dart test suite (flutter/flutter#185086)
2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ios][platform_view]Reland hitTest approach (with a few 2026 update) (#183484)" (flutter/flutter#185082)
2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#179810)" (flutter/flutter#185067)
2026-04-15 [email protected] Agent rule: Dart editing (flutter/flutter#185045)
2026-04-15 [email protected] [ios][platform_view]Reland hitTest approach (with a few 2026 update) (flutter/flutter#183484)
2026-04-15 [email protected] Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#179810)
2026-04-15 [email protected] Roll Dart SDK from ee5afcef0596 to 87b7c87e7207 (4 revisions) (flutter/flutter#185060)
2026-04-15 [email protected] Roll Skia from 4c382df6a25a to bda7232e6772 (7 revisions) (flutter/flutter#185057)
2026-04-15 [email protected] Remove material import from toggleable_test.dart + draggable_test.dart + obscured_animated_image_test.dart + sliver_constraints_test.dart (flutter/flutter#181774)
2026-04-15 [email protected] refactor: Remove material imports from Widget tests  (flutter/flutter#184877)
2026-04-14 [email protected] Adds missing `await`s on forgotten cases (flutter/flutter#183466)
2026-04-14 [email protected] Use an if-element in a collection literal instead of a conditional expression (flutter/flutter#184830)
2026-04-14 [email protected] update popular issues documentation (flutter/flutter#183196)
2026-04-14 [email protected] [Android] Add integration test for setting engine flags via the manifest (flutter/flutter#182241)
2026-04-14 [email protected] [fuchsia] Ask for both ambient-replace and VMEX to allow for a softer transition. (flutter/flutter#185042)
2026-04-14 [email protected] Make `multiple_windows` follow repo analyzer rules (flutter/flutter#184753)
2026-04-14 [email protected] Ignore incoming deprecated_web_configuration lint (flutter/flutter#184130)
2026-04-14 [email protected] [AGP 9] Update AGP Error (flutter/flutter#185043)
2026-04-14 [email protected] Move widget_preview_scaffold into pub workspace (flutter/flutter#182627)
2026-04-14 [email protected] Fix gles interactive tests (flutter/flutter#181389)
2026-04-14 [email protected] Update customer tests.version (flutter/flutter#185044)
2026-04-14 [email protected] [SKILL] upgrade-browser (flutter/flutter#184894)
2026-04-14 [email protected] [ci] Split up integration.shard dart_data_asset_test.dart (flutter/flutter#185021)
2026-04-14 [email protected] Hold startup lock until after `pub get` to prevent races (flutter/flutter#184294)
2026-04-14 6226493[email protected] Add `--include-example` flag to `flutter clean` for package example projects (flutter/flutter#183455)
2026-04-14 [email protected] Disable multi-pack-index when calling flutter from Xcode (flutter/flutter#184998)
2026-04-14 [email protected] Fix icon tree shaking when building for desktop (flutter/flutter#184249)
2026-04-14 [email protected] Fix killing wrong xcrun command (flutter/flutter#184831)
2026-04-14 [email protected] Allow Xcode build configuration to not contain flavor name (flutter/flutter#183398)
2026-04-14 [email protected] [web] Async rendering for benchmarks (flutter/flutter#184677)
2026-04-14 [email protected] [ci] Split up integration.shard native_assets_test.dart (flutter/flutter#185020)
2026-04-14 [email protected] Skip flutter widget-preview test that times out frequently (flutter/flutter#184988)
...
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…r#11518)

Roll Flutter from c1b14e92dcfb to 31f1802cb859 (46 revisions)

flutter/flutter@c1b14e9...31f1802

2026-04-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#185083)" (flutter/flutter#185145)
2026-04-16 [email protected] Add oval drawing support to the SDF uber shader (flutter/flutter#184903)
2026-04-16 [email protected] Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#185083)
2026-04-16 [email protected] Roll Skia from 2c49b3f9c3c2 to 391cdbe3ffe9 (2 revisions) (flutter/flutter#185138)
2026-04-16 [email protected] Roll Dart SDK from 4ee990654146 to fbddcbe0cd96 (1 revision) (flutter/flutter#185137)
2026-04-16 [email protected] Roll Skia from f4e3cd2c2159 to 2c49b3f9c3c2 (14 revisions) (flutter/flutter#185131)
2026-04-16 [email protected] Roll Dart SDK from 87b7c87e7207 to 4ee990654146 (5 revisions) (flutter/flutter#185108)
2026-04-15 [email protected] Use the `flutteractionsbot` token to push the release branch. (flutter/flutter#184833)
2026-04-15 [email protected] Allow period characters in iOS and macOS framework names (flutter/flutter#184335)
2026-04-15 [email protected] Fix SliverResizingHeader semantic focus (flutter/flutter#179690)
2026-04-15 [email protected] ignore avoid_type_to_string lint rule in flutter_tools (flutter/flutter#184766)
2026-04-15 [email protected] Roll Skia from bda7232e6772 to f4e3cd2c2159 (4 revisions) (flutter/flutter#185063)
2026-04-15 [email protected] Add initial AI guidance for issues (flutter/flutter#184885)
2026-04-15 [email protected] Roll Fuchsia Linux SDK from rB8LAuZL_DwHMssTU... to IdBT8fSMYrYSip65j... (flutter/flutter#185064)
2026-04-15 [email protected] Fix an ordering dependency in the services/system_chrome_test.dart test suite (flutter/flutter#185086)
2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ios][platform_view]Reland hitTest approach (with a few 2026 update) (#183484)" (flutter/flutter#185082)
2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#179810)" (flutter/flutter#185067)
2026-04-15 [email protected] Agent rule: Dart editing (flutter/flutter#185045)
2026-04-15 [email protected] [ios][platform_view]Reland hitTest approach (with a few 2026 update) (flutter/flutter#183484)
2026-04-15 [email protected] Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#179810)
2026-04-15 [email protected] Roll Dart SDK from ee5afcef0596 to 87b7c87e7207 (4 revisions) (flutter/flutter#185060)
2026-04-15 [email protected] Roll Skia from 4c382df6a25a to bda7232e6772 (7 revisions) (flutter/flutter#185057)
2026-04-15 [email protected] Remove material import from toggleable_test.dart + draggable_test.dart + obscured_animated_image_test.dart + sliver_constraints_test.dart (flutter/flutter#181774)
2026-04-15 [email protected] refactor: Remove material imports from Widget tests  (flutter/flutter#184877)
2026-04-14 [email protected] Adds missing `await`s on forgotten cases (flutter/flutter#183466)
2026-04-14 [email protected] Use an if-element in a collection literal instead of a conditional expression (flutter/flutter#184830)
2026-04-14 [email protected] update popular issues documentation (flutter/flutter#183196)
2026-04-14 [email protected] [Android] Add integration test for setting engine flags via the manifest (flutter/flutter#182241)
2026-04-14 [email protected] [fuchsia] Ask for both ambient-replace and VMEX to allow for a softer transition. (flutter/flutter#185042)
2026-04-14 [email protected] Make `multiple_windows` follow repo analyzer rules (flutter/flutter#184753)
2026-04-14 [email protected] Ignore incoming deprecated_web_configuration lint (flutter/flutter#184130)
2026-04-14 [email protected] [AGP 9] Update AGP Error (flutter/flutter#185043)
2026-04-14 [email protected] Move widget_preview_scaffold into pub workspace (flutter/flutter#182627)
2026-04-14 [email protected] Fix gles interactive tests (flutter/flutter#181389)
2026-04-14 [email protected] Update customer tests.version (flutter/flutter#185044)
2026-04-14 [email protected] [SKILL] upgrade-browser (flutter/flutter#184894)
2026-04-14 [email protected] [ci] Split up integration.shard dart_data_asset_test.dart (flutter/flutter#185021)
2026-04-14 [email protected] Hold startup lock until after `pub get` to prevent races (flutter/flutter#184294)
2026-04-14 6226493[email protected] Add `--include-example` flag to `flutter clean` for package example projects (flutter/flutter#183455)
2026-04-14 [email protected] Disable multi-pack-index when calling flutter from Xcode (flutter/flutter#184998)
2026-04-14 [email protected] Fix icon tree shaking when building for desktop (flutter/flutter#184249)
2026-04-14 [email protected] Fix killing wrong xcrun command (flutter/flutter#184831)
2026-04-14 [email protected] Allow Xcode build configuration to not contain flavor name (flutter/flutter#183398)
2026-04-14 [email protected] [web] Async rendering for benchmarks (flutter/flutter#184677)
2026-04-14 [email protected] [ci] Split up integration.shard native_assets_test.dart (flutter/flutter#185020)
2026-04-14 [email protected] Skip flutter widget-preview test that times out frequently (flutter/flutter#184988)
...
Istiak-Ahmed78 pushed a commit to Istiak-Ahmed78/packages that referenced this pull request Jun 19, 2026
…r#11518)

Roll Flutter from c1b14e92dcfb to 31f1802cb859 (46 revisions)

flutter/flutter@c1b14e9...31f1802

2026-04-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#185083)" (flutter/flutter#185145)
2026-04-16 [email protected] Add oval drawing support to the SDF uber shader (flutter/flutter#184903)
2026-04-16 [email protected] Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#185083)
2026-04-16 [email protected] Roll Skia from 2c49b3f9c3c2 to 391cdbe3ffe9 (2 revisions) (flutter/flutter#185138)
2026-04-16 [email protected] Roll Dart SDK from 4ee990654146 to fbddcbe0cd96 (1 revision) (flutter/flutter#185137)
2026-04-16 [email protected] Roll Skia from f4e3cd2c2159 to 2c49b3f9c3c2 (14 revisions) (flutter/flutter#185131)
2026-04-16 [email protected] Roll Dart SDK from 87b7c87e7207 to 4ee990654146 (5 revisions) (flutter/flutter#185108)
2026-04-15 [email protected] Use the `flutteractionsbot` token to push the release branch. (flutter/flutter#184833)
2026-04-15 [email protected] Allow period characters in iOS and macOS framework names (flutter/flutter#184335)
2026-04-15 [email protected] Fix SliverResizingHeader semantic focus (flutter/flutter#179690)
2026-04-15 [email protected] ignore avoid_type_to_string lint rule in flutter_tools (flutter/flutter#184766)
2026-04-15 [email protected] Roll Skia from bda7232e6772 to f4e3cd2c2159 (4 revisions) (flutter/flutter#185063)
2026-04-15 [email protected] Add initial AI guidance for issues (flutter/flutter#184885)
2026-04-15 [email protected] Roll Fuchsia Linux SDK from rB8LAuZL_DwHMssTU... to IdBT8fSMYrYSip65j... (flutter/flutter#185064)
2026-04-15 [email protected] Fix an ordering dependency in the services/system_chrome_test.dart test suite (flutter/flutter#185086)
2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ios][platform_view]Reland hitTest approach (with a few 2026 update) (#183484)" (flutter/flutter#185082)
2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#179810)" (flutter/flutter#185067)
2026-04-15 [email protected] Agent rule: Dart editing (flutter/flutter#185045)
2026-04-15 [email protected] [ios][platform_view]Reland hitTest approach (with a few 2026 update) (flutter/flutter#183484)
2026-04-15 [email protected] Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#179810)
2026-04-15 [email protected] Roll Dart SDK from ee5afcef0596 to 87b7c87e7207 (4 revisions) (flutter/flutter#185060)
2026-04-15 [email protected] Roll Skia from 4c382df6a25a to bda7232e6772 (7 revisions) (flutter/flutter#185057)
2026-04-15 [email protected] Remove material import from toggleable_test.dart + draggable_test.dart + obscured_animated_image_test.dart + sliver_constraints_test.dart (flutter/flutter#181774)
2026-04-15 [email protected] refactor: Remove material imports from Widget tests  (flutter/flutter#184877)
2026-04-14 [email protected] Adds missing `await`s on forgotten cases (flutter/flutter#183466)
2026-04-14 [email protected] Use an if-element in a collection literal instead of a conditional expression (flutter/flutter#184830)
2026-04-14 [email protected] update popular issues documentation (flutter/flutter#183196)
2026-04-14 [email protected] [Android] Add integration test for setting engine flags via the manifest (flutter/flutter#182241)
2026-04-14 [email protected] [fuchsia] Ask for both ambient-replace and VMEX to allow for a softer transition. (flutter/flutter#185042)
2026-04-14 [email protected] Make `multiple_windows` follow repo analyzer rules (flutter/flutter#184753)
2026-04-14 [email protected] Ignore incoming deprecated_web_configuration lint (flutter/flutter#184130)
2026-04-14 [email protected] [AGP 9] Update AGP Error (flutter/flutter#185043)
2026-04-14 [email protected] Move widget_preview_scaffold into pub workspace (flutter/flutter#182627)
2026-04-14 [email protected] Fix gles interactive tests (flutter/flutter#181389)
2026-04-14 [email protected] Update customer tests.version (flutter/flutter#185044)
2026-04-14 [email protected] [SKILL] upgrade-browser (flutter/flutter#184894)
2026-04-14 [email protected] [ci] Split up integration.shard dart_data_asset_test.dart (flutter/flutter#185021)
2026-04-14 [email protected] Hold startup lock until after `pub get` to prevent races (flutter/flutter#184294)
2026-04-14 6226493[email protected] Add `--include-example` flag to `flutter clean` for package example projects (flutter/flutter#183455)
2026-04-14 [email protected] Disable multi-pack-index when calling flutter from Xcode (flutter/flutter#184998)
2026-04-14 [email protected] Fix icon tree shaking when building for desktop (flutter/flutter#184249)
2026-04-14 [email protected] Fix killing wrong xcrun command (flutter/flutter#184831)
2026-04-14 [email protected] Allow Xcode build configuration to not contain flavor name (flutter/flutter#183398)
2026-04-14 [email protected] [web] Async rendering for benchmarks (flutter/flutter#184677)
2026-04-14 [email protected] [ci] Split up integration.shard native_assets_test.dart (flutter/flutter#185020)
2026-04-14 [email protected] Skip flutter widget-preview test that times out frequently (flutter/flutter#184988)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD emergency Jump the queue; land PR in front of all others; only use for emergencies tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants