Skip to content

[ci] Split up integration.shard native_assets_test.dart - #185020

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
dcharkes:split-integration-test-native-assets
Apr 14, 2026
Merged

auto-submit[bot] merged 2 commits into
flutter:masterfrom
dcharkes:split-integration-test-native-assets

Conversation

@dcharkes

Copy link
Copy Markdown
Contributor

Bug:

Splits up test.

Manually split up by copy-pasting the file removing the other tests and moving the shared methods to packages/flutter_tools/test/integration.shard/isolated/native_assets_test_utils.dart

(Avoided using agents here to avoid having to review if the tests are still testing what they are supposed to test.)

The new way to run all the relevant tests:

flutter_tools $ GIT_CONFIG_PARAMETERS="'core.multiPackIndex=false'" flutter test test/integration.shard/isolated/native_assets*test.dart --concurrency=1

@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 14, 2026
@dcharkes dcharkes added CICD Run CI/CD and removed tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 14, 2026
@dcharkes
dcharkes marked this pull request as ready for review April 14, 2026 10:46
@dcharkes
dcharkes requested review from bkonyi and goderbauer April 14, 2026 10:47

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the native assets integration tests by splitting a single large test file into multiple specialized files for build, run, and test scenarios, while moving shared logic to a utility file. Feedback points out an unused import, the need to restrict a CI tag to the APK subcommand, and opportunities to reduce code duplication by naming and sharing a string extension. It is also recommended to use the flutterBin variable instead of hardcoded strings for consistency.

expectCCompilerIsConfigured(exampleDirectory);
});
},
tags: <String>['flutter-build-apk'],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The flutter-build-apk tag is applied to all build subcommands in this loop. It should be restricted to only the 'apk' subcommand to ensure correct CI sharding and avoid running non-Android tests on the APK shard.

        tags: <String>[if (buildSubcommand == 'apk') 'flutter-build-apk'],

import 'package:file/file.dart';

import '../../src/common.dart';
import '../test_utils.dart' show fileSystem, platform;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Import flutterBin to use it in the _addIntegrationTest function instead of the hardcoded 'flutter' string, ensuring the test uses the correct Flutter binary from the repository.

import '../test_utils.dart' show fileSystem, flutterBin, platform;


void _addIntegrationTest(Uri exampleDirectory, String packageName) {
final ProcessResult result = processManager.runSync(<String>[
'flutter',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use flutterBin instead of the hardcoded 'flutter' string to ensure the test uses the specific Flutter binary intended for the integration test environment.

    flutterBin,

@github-actions github-actions Bot added tool Affects the "flutter" command-line tool. See also t: labels. and removed CICD Run CI/CD labels Apr 14, 2026
@dcharkes dcharkes added the CICD Run CI/CD label Apr 14, 2026
@dcharkes dcharkes added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Apr 14, 2026
Merged via the queue into flutter:master with commit 654ae67 Apr 14, 2026
159 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2026
master-wayne7 pushed a commit to master-wayne7/flutter that referenced this pull request Apr 15, 2026
Bug:

* flutter#185013

Splits up test.

Manually split up by copy-pasting the file removing the other tests and
moving the shared methods to
packages/flutter_tools/test/integration.shard/isolated/native_assets_test_utils.dart

(Avoided using agents here to avoid having to review if the tests are
still testing what they are supposed to test.)

The new way to run all the relevant tests:

```
flutter_tools $ GIT_CONFIG_PARAMETERS="'core.multiPackIndex=false'" flutter test test/integration.shard/isolated/native_assets*test.dart --concurrency=1
```
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Apr 16, 2026
Roll Flutter from c1b14e92dcfb to 31f1802cb859 (46 revisions)

flutter/flutter@c1b14e9...31f1802

2026-04-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#185083)" (flutter/flutter#185145)
2026-04-16 [email protected] Add oval drawing support to the SDF uber shader (flutter/flutter#184903)
2026-04-16 [email protected] Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#185083)
2026-04-16 [email protected] Roll Skia from 2c49b3f9c3c2 to 391cdbe3ffe9 (2 revisions) (flutter/flutter#185138)
2026-04-16 [email protected] Roll Dart SDK from 4ee990654146 to fbddcbe0cd96 (1 revision) (flutter/flutter#185137)
2026-04-16 [email protected] Roll Skia from f4e3cd2c2159 to 2c49b3f9c3c2 (14 revisions) (flutter/flutter#185131)
2026-04-16 [email protected] Roll Dart SDK from 87b7c87e7207 to 4ee990654146 (5 revisions) (flutter/flutter#185108)
2026-04-15 [email protected] Use the `flutteractionsbot` token to push the release branch. (flutter/flutter#184833)
2026-04-15 [email protected] Allow period characters in iOS and macOS framework names (flutter/flutter#184335)
2026-04-15 [email protected] Fix SliverResizingHeader semantic focus (flutter/flutter#179690)
2026-04-15 [email protected] ignore avoid_type_to_string lint rule in flutter_tools (flutter/flutter#184766)
2026-04-15 [email protected] Roll Skia from bda7232e6772 to f4e3cd2c2159 (4 revisions) (flutter/flutter#185063)
2026-04-15 [email protected] Add initial AI guidance for issues (flutter/flutter#184885)
2026-04-15 [email protected] Roll Fuchsia Linux SDK from rB8LAuZL_DwHMssTU... to IdBT8fSMYrYSip65j... (flutter/flutter#185064)
2026-04-15 [email protected] Fix an ordering dependency in the services/system_chrome_test.dart test suite (flutter/flutter#185086)
2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ios][platform_view]Reland hitTest approach (with a few 2026 update) (#183484)" (flutter/flutter#185082)
2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#179810)" (flutter/flutter#185067)
2026-04-15 [email protected] Agent rule: Dart editing (flutter/flutter#185045)
2026-04-15 [email protected] [ios][platform_view]Reland hitTest approach (with a few 2026 update) (flutter/flutter#183484)
2026-04-15 [email protected] Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#179810)
2026-04-15 [email protected] Roll Dart SDK from ee5afcef0596 to 87b7c87e7207 (4 revisions) (flutter/flutter#185060)
2026-04-15 [email protected] Roll Skia from 4c382df6a25a to bda7232e6772 (7 revisions) (flutter/flutter#185057)
2026-04-15 [email protected] Remove material import from toggleable_test.dart + draggable_test.dart + obscured_animated_image_test.dart + sliver_constraints_test.dart (flutter/flutter#181774)
2026-04-15 [email protected] refactor: Remove material imports from Widget tests  (flutter/flutter#184877)
2026-04-14 [email protected] Adds missing `await`s on forgotten cases (flutter/flutter#183466)
2026-04-14 [email protected] Use an if-element in a collection literal instead of a conditional expression (flutter/flutter#184830)
2026-04-14 [email protected] update popular issues documentation (flutter/flutter#183196)
2026-04-14 [email protected] [Android] Add integration test for setting engine flags via the manifest (flutter/flutter#182241)
2026-04-14 [email protected] [fuchsia] Ask for both ambient-replace and VMEX to allow for a softer transition. (flutter/flutter#185042)
2026-04-14 [email protected] Make `multiple_windows` follow repo analyzer rules (flutter/flutter#184753)
2026-04-14 [email protected] Ignore incoming deprecated_web_configuration lint (flutter/flutter#184130)
2026-04-14 [email protected] [AGP 9] Update AGP Error (flutter/flutter#185043)
2026-04-14 [email protected] Move widget_preview_scaffold into pub workspace (flutter/flutter#182627)
2026-04-14 [email protected] Fix gles interactive tests (flutter/flutter#181389)
2026-04-14 [email protected] Update customer tests.version (flutter/flutter#185044)
2026-04-14 [email protected] [SKILL] upgrade-browser (flutter/flutter#184894)
2026-04-14 [email protected] [ci] Split up integration.shard dart_data_asset_test.dart (flutter/flutter#185021)
2026-04-14 [email protected] Hold startup lock until after `pub get` to prevent races (flutter/flutter#184294)
2026-04-14 6226493[email protected] Add `--include-example` flag to `flutter clean` for package example projects (flutter/flutter#183455)
2026-04-14 [email protected] Disable multi-pack-index when calling flutter from Xcode (flutter/flutter#184998)
2026-04-14 [email protected] Fix icon tree shaking when building for desktop (flutter/flutter#184249)
2026-04-14 [email protected] Fix killing wrong xcrun command (flutter/flutter#184831)
2026-04-14 [email protected] Allow Xcode build configuration to not contain flavor name (flutter/flutter#183398)
2026-04-14 [email protected] [web] Async rendering for benchmarks (flutter/flutter#184677)
2026-04-14 [email protected] [ci] Split up integration.shard native_assets_test.dart (flutter/flutter#185020)
2026-04-14 [email protected] Skip flutter widget-preview test that times out frequently (flutter/flutter#184988)
...
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…r#11518)

Roll Flutter from c1b14e92dcfb to 31f1802cb859 (46 revisions)

flutter/flutter@c1b14e9...31f1802

2026-04-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#185083)" (flutter/flutter#185145)
2026-04-16 [email protected] Add oval drawing support to the SDF uber shader (flutter/flutter#184903)
2026-04-16 [email protected] Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#185083)
2026-04-16 [email protected] Roll Skia from 2c49b3f9c3c2 to 391cdbe3ffe9 (2 revisions) (flutter/flutter#185138)
2026-04-16 [email protected] Roll Dart SDK from 4ee990654146 to fbddcbe0cd96 (1 revision) (flutter/flutter#185137)
2026-04-16 [email protected] Roll Skia from f4e3cd2c2159 to 2c49b3f9c3c2 (14 revisions) (flutter/flutter#185131)
2026-04-16 [email protected] Roll Dart SDK from 87b7c87e7207 to 4ee990654146 (5 revisions) (flutter/flutter#185108)
2026-04-15 [email protected] Use the `flutteractionsbot` token to push the release branch. (flutter/flutter#184833)
2026-04-15 [email protected] Allow period characters in iOS and macOS framework names (flutter/flutter#184335)
2026-04-15 [email protected] Fix SliverResizingHeader semantic focus (flutter/flutter#179690)
2026-04-15 [email protected] ignore avoid_type_to_string lint rule in flutter_tools (flutter/flutter#184766)
2026-04-15 [email protected] Roll Skia from bda7232e6772 to f4e3cd2c2159 (4 revisions) (flutter/flutter#185063)
2026-04-15 [email protected] Add initial AI guidance for issues (flutter/flutter#184885)
2026-04-15 [email protected] Roll Fuchsia Linux SDK from rB8LAuZL_DwHMssTU... to IdBT8fSMYrYSip65j... (flutter/flutter#185064)
2026-04-15 [email protected] Fix an ordering dependency in the services/system_chrome_test.dart test suite (flutter/flutter#185086)
2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ios][platform_view]Reland hitTest approach (with a few 2026 update) (#183484)" (flutter/flutter#185082)
2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#179810)" (flutter/flutter#185067)
2026-04-15 [email protected] Agent rule: Dart editing (flutter/flutter#185045)
2026-04-15 [email protected] [ios][platform_view]Reland hitTest approach (with a few 2026 update) (flutter/flutter#183484)
2026-04-15 [email protected] Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#179810)
2026-04-15 [email protected] Roll Dart SDK from ee5afcef0596 to 87b7c87e7207 (4 revisions) (flutter/flutter#185060)
2026-04-15 [email protected] Roll Skia from 4c382df6a25a to bda7232e6772 (7 revisions) (flutter/flutter#185057)
2026-04-15 [email protected] Remove material import from toggleable_test.dart + draggable_test.dart + obscured_animated_image_test.dart + sliver_constraints_test.dart (flutter/flutter#181774)
2026-04-15 [email protected] refactor: Remove material imports from Widget tests  (flutter/flutter#184877)
2026-04-14 [email protected] Adds missing `await`s on forgotten cases (flutter/flutter#183466)
2026-04-14 [email protected] Use an if-element in a collection literal instead of a conditional expression (flutter/flutter#184830)
2026-04-14 [email protected] update popular issues documentation (flutter/flutter#183196)
2026-04-14 [email protected] [Android] Add integration test for setting engine flags via the manifest (flutter/flutter#182241)
2026-04-14 [email protected] [fuchsia] Ask for both ambient-replace and VMEX to allow for a softer transition. (flutter/flutter#185042)
2026-04-14 [email protected] Make `multiple_windows` follow repo analyzer rules (flutter/flutter#184753)
2026-04-14 [email protected] Ignore incoming deprecated_web_configuration lint (flutter/flutter#184130)
2026-04-14 [email protected] [AGP 9] Update AGP Error (flutter/flutter#185043)
2026-04-14 [email protected] Move widget_preview_scaffold into pub workspace (flutter/flutter#182627)
2026-04-14 [email protected] Fix gles interactive tests (flutter/flutter#181389)
2026-04-14 [email protected] Update customer tests.version (flutter/flutter#185044)
2026-04-14 [email protected] [SKILL] upgrade-browser (flutter/flutter#184894)
2026-04-14 [email protected] [ci] Split up integration.shard dart_data_asset_test.dart (flutter/flutter#185021)
2026-04-14 [email protected] Hold startup lock until after `pub get` to prevent races (flutter/flutter#184294)
2026-04-14 6226493[email protected] Add `--include-example` flag to `flutter clean` for package example projects (flutter/flutter#183455)
2026-04-14 [email protected] Disable multi-pack-index when calling flutter from Xcode (flutter/flutter#184998)
2026-04-14 [email protected] Fix icon tree shaking when building for desktop (flutter/flutter#184249)
2026-04-14 [email protected] Fix killing wrong xcrun command (flutter/flutter#184831)
2026-04-14 [email protected] Allow Xcode build configuration to not contain flavor name (flutter/flutter#183398)
2026-04-14 [email protected] [web] Async rendering for benchmarks (flutter/flutter#184677)
2026-04-14 [email protected] [ci] Split up integration.shard native_assets_test.dart (flutter/flutter#185020)
2026-04-14 [email protected] Skip flutter widget-preview test that times out frequently (flutter/flutter#184988)
...
Istiak-Ahmed78 pushed a commit to Istiak-Ahmed78/packages that referenced this pull request Jun 19, 2026
…r#11518)

Roll Flutter from c1b14e92dcfb to 31f1802cb859 (46 revisions)

flutter/flutter@c1b14e9...31f1802

2026-04-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#185083)" (flutter/flutter#185145)
2026-04-16 [email protected] Add oval drawing support to the SDF uber shader (flutter/flutter#184903)
2026-04-16 [email protected] Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#185083)
2026-04-16 [email protected] Roll Skia from 2c49b3f9c3c2 to 391cdbe3ffe9 (2 revisions) (flutter/flutter#185138)
2026-04-16 [email protected] Roll Dart SDK from 4ee990654146 to fbddcbe0cd96 (1 revision) (flutter/flutter#185137)
2026-04-16 [email protected] Roll Skia from f4e3cd2c2159 to 2c49b3f9c3c2 (14 revisions) (flutter/flutter#185131)
2026-04-16 [email protected] Roll Dart SDK from 87b7c87e7207 to 4ee990654146 (5 revisions) (flutter/flutter#185108)
2026-04-15 [email protected] Use the `flutteractionsbot` token to push the release branch. (flutter/flutter#184833)
2026-04-15 [email protected] Allow period characters in iOS and macOS framework names (flutter/flutter#184335)
2026-04-15 [email protected] Fix SliverResizingHeader semantic focus (flutter/flutter#179690)
2026-04-15 [email protected] ignore avoid_type_to_string lint rule in flutter_tools (flutter/flutter#184766)
2026-04-15 [email protected] Roll Skia from bda7232e6772 to f4e3cd2c2159 (4 revisions) (flutter/flutter#185063)
2026-04-15 [email protected] Add initial AI guidance for issues (flutter/flutter#184885)
2026-04-15 [email protected] Roll Fuchsia Linux SDK from rB8LAuZL_DwHMssTU... to IdBT8fSMYrYSip65j... (flutter/flutter#185064)
2026-04-15 [email protected] Fix an ordering dependency in the services/system_chrome_test.dart test suite (flutter/flutter#185086)
2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ios][platform_view]Reland hitTest approach (with a few 2026 update) (#183484)" (flutter/flutter#185082)
2026-04-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (#179810)" (flutter/flutter#185067)
2026-04-15 [email protected] Agent rule: Dart editing (flutter/flutter#185045)
2026-04-15 [email protected] [ios][platform_view]Reland hitTest approach (with a few 2026 update) (flutter/flutter#183484)
2026-04-15 [email protected] Run all flutter/flutter macOS tests using Xcode 26 and iOS 26 simulator (flutter/flutter#179810)
2026-04-15 [email protected] Roll Dart SDK from ee5afcef0596 to 87b7c87e7207 (4 revisions) (flutter/flutter#185060)
2026-04-15 [email protected] Roll Skia from 4c382df6a25a to bda7232e6772 (7 revisions) (flutter/flutter#185057)
2026-04-15 [email protected] Remove material import from toggleable_test.dart + draggable_test.dart + obscured_animated_image_test.dart + sliver_constraints_test.dart (flutter/flutter#181774)
2026-04-15 [email protected] refactor: Remove material imports from Widget tests  (flutter/flutter#184877)
2026-04-14 [email protected] Adds missing `await`s on forgotten cases (flutter/flutter#183466)
2026-04-14 [email protected] Use an if-element in a collection literal instead of a conditional expression (flutter/flutter#184830)
2026-04-14 [email protected] update popular issues documentation (flutter/flutter#183196)
2026-04-14 [email protected] [Android] Add integration test for setting engine flags via the manifest (flutter/flutter#182241)
2026-04-14 [email protected] [fuchsia] Ask for both ambient-replace and VMEX to allow for a softer transition. (flutter/flutter#185042)
2026-04-14 [email protected] Make `multiple_windows` follow repo analyzer rules (flutter/flutter#184753)
2026-04-14 [email protected] Ignore incoming deprecated_web_configuration lint (flutter/flutter#184130)
2026-04-14 [email protected] [AGP 9] Update AGP Error (flutter/flutter#185043)
2026-04-14 [email protected] Move widget_preview_scaffold into pub workspace (flutter/flutter#182627)
2026-04-14 [email protected] Fix gles interactive tests (flutter/flutter#181389)
2026-04-14 [email protected] Update customer tests.version (flutter/flutter#185044)
2026-04-14 [email protected] [SKILL] upgrade-browser (flutter/flutter#184894)
2026-04-14 [email protected] [ci] Split up integration.shard dart_data_asset_test.dart (flutter/flutter#185021)
2026-04-14 [email protected] Hold startup lock until after `pub get` to prevent races (flutter/flutter#184294)
2026-04-14 6226493[email protected] Add `--include-example` flag to `flutter clean` for package example projects (flutter/flutter#183455)
2026-04-14 [email protected] Disable multi-pack-index when calling flutter from Xcode (flutter/flutter#184998)
2026-04-14 [email protected] Fix icon tree shaking when building for desktop (flutter/flutter#184249)
2026-04-14 [email protected] Fix killing wrong xcrun command (flutter/flutter#184831)
2026-04-14 [email protected] Allow Xcode build configuration to not contain flavor name (flutter/flutter#183398)
2026-04-14 [email protected] [web] Async rendering for benchmarks (flutter/flutter#184677)
2026-04-14 [email protected] [ci] Split up integration.shard native_assets_test.dart (flutter/flutter#185020)
2026-04-14 [email protected] Skip flutter widget-preview test that times out frequently (flutter/flutter#184988)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants