Repository navigation
Fix aot_snapshot_size_* benchmarks - #18520
Merged
Merged
Conversation
... and make sure they fail if they can't report the size.
jason-simmons
approved these changes
Jun 15, 2018
srawlins
added a commit
to srawlins/flutter
that referenced
this pull request
Jun 16, 2018
* master: Add minimum height and width box constraints to input decoration icons (flutter#18480) Fix aot_snapshot_size_* benchmarks (flutter#18520) Revert "Remove race conditions involving finding available ports (flutter#18488)" (flutter#18521)
jonahwilliams
pushed a commit
that referenced
this pull request
Jun 16, 2018
This reverts commit 2a19dae.
Contributor
|
Thanks! |
goderbauer
added
framework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... and make sure they fail if they can't report the size.
This was broken in d1cc8b6#r29384579. /cc @Hixie