Repository navigation
Remove race conditions involving finding available ports - #18488
Conversation
|
(sent breaking change announcement) |
47ce3cc to
6b2cd72
Compare
There was a problem hiding this comment.
(might not be a big deal since we control the devicelab and can just say that it's hard coded to be IPv4....)
There was a problem hiding this comment.
I've fixed the places that mention 127.0.0.1 explicitly to extract the port in an ipv6-compatible manner but I haven't gone further down the yak shave of making devicelab ipv6-safe.
There was a problem hiding this comment.
we don't guarantee that. We could audit all the call sites to make sure that the callers all check the range on the port, but as of right now we're depending on adb to do that.
There was a problem hiding this comment.
Are we sure this will always succeed given correct user input?
There was a problem hiding this comment.
If not, then let's throw a ProcessException instead, where we can include the stderr, exitCode, etc.
There was a problem hiding this comment.
It's too bad that this is called --debug-port here and --observatory-port in flutter screenshot...
There was a problem hiding this comment.
yeah. i'll leave that to another yak shave.
There was a problem hiding this comment.
I filed libimobiledevice/libimobiledevice#674 for iproxy to support hostPort==0
There was a problem hiding this comment.
oh thanks. i had looked into doing that (or even submitting a patch) but got confused about which project it corresponded to and then forgot.
6b2cd72 to
e15c299
Compare
e15c299 to
63971d0
Compare
* master: Remove race conditions involving finding available ports (flutter#18488) Skip painting hidden children of a sliver list (flutter#18465) Fixed some typos (flutter#18516) update Tristate checkbox semantics to consider indeterminate as "unchecked" (flutter#18297) Add flutter tool support for creating app-specific VM snapshots. (flutter#18417) mention Text.rich on RichText (flutter#18434) invert children for real (flutter#18489) Fix clipping for SliverLists (flutter#18410) Keep TextFields visible when keyboard comes up (flutter#18291) Update all packages (flutter#18506) Prepare for upgrading video player in Gallery to newest version (flutter#18501) Update Android dependencies (flutter#18499) Enable running with prebuilt test-only apk (flutter#18453) Revert "Update all packages (flutter#18471)" (flutter#18492) Add some more dart doc to RepaintBoundary (flutter#17183) Update all packages (flutter#18471) Clean up output of "flutter run --release" (flutter#18380) Ensure errors launching emulators are exposed to the daemon (flutter#18446) Check video widget is mounted on call to setState (flutter#18467) Fixed concurrent list modification in vmservice.dart
* master: Add minimum height and width box constraints to input decoration icons (flutter#18480) Fix aot_snapshot_size_* benchmarks (flutter#18520) Revert "Remove race conditions involving finding available ports (flutter#18488)" (flutter#18521)
)" This reverts commit 7750872.
This is an attempt to reland flutter#18488 with less breakage on macOS.
This is an attempt to reland #18488 with less breakage on macOS.
4 participants
No description provided.