Repository navigation
Add flutter tool support for creating app-specific VM snapshots. - #18417
Conversation
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
Overall looks good. Just a few comments.
Please add tests for the JIT snapshots -- see the similar AOT tests for an example.
There was a problem hiding this comment.
Kill this line of the comment since this is Android-specific; the other two are good as-is.
There was a problem hiding this comment.
Pass --ios in the invocation in xcode_backend.sh.
There was a problem hiding this comment.
Check if you need to pass the mode in the invocation in xcode_backend.sh.
There was a problem hiding this comment.
These should be indented by 2 (the old ones look wrong to me).
There was a problem hiding this comment.
Is the comment correct here (that this is the kernel compile depfile)?
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
Looks like some rebasing is required :( Sorry about the delay on the review.
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
Looks like some rebasing is required :( Sorry about the delay on the review.
* master: Remove race conditions involving finding available ports (flutter#18488) Skip painting hidden children of a sliver list (flutter#18465) Fixed some typos (flutter#18516) update Tristate checkbox semantics to consider indeterminate as "unchecked" (flutter#18297) Add flutter tool support for creating app-specific VM snapshots. (flutter#18417) mention Text.rich on RichText (flutter#18434) invert children for real (flutter#18489) Fix clipping for SliverLists (flutter#18410) Keep TextFields visible when keyboard comes up (flutter#18291) Update all packages (flutter#18506) Prepare for upgrading video player in Gallery to newest version (flutter#18501) Update Android dependencies (flutter#18499) Enable running with prebuilt test-only apk (flutter#18453) Revert "Update all packages (flutter#18471)" (flutter#18492) Add some more dart doc to RepaintBoundary (flutter#17183) Update all packages (flutter#18471) Clean up output of "flutter run --release" (flutter#18380) Ensure errors launching emulators are exposed to the daemon (flutter#18446) Check video widget is mounted on call to setState (flutter#18467) Fixed concurrent list modification in vmservice.dart
3 participants
No description provided.