Repository navigation
Ensure errors launching emulators are exposed to the daemon - #18446
Conversation
|
BTW, this was checked in when the tree was red. Please avoid checking anything in when the tree is red except for attempts to fix the tree, because it makes it much harder to detect, and later identify, additional failures introduced while the previous failure was ongoing. If you suspect a flaky result, please re-run the test rather than checking in while red. If that isn't possible, at a minimum please note the situation in the PR when landing it. Thanks! |
|
@Hixie Apologies; I thought the failure was from a (maybe-flakey - though that seems like a bad assumption now) devicelab test and I thought (perhaps incorrectly) that they couldn't be restarted so I thought since this PR was otherwise green it'd force another build. I will hold off in future :-) |
|
We can restart devicelab builds. Ping me or @cbracken if you think that needs to be done. |
* master: Remove race conditions involving finding available ports (flutter#18488) Skip painting hidden children of a sliver list (flutter#18465) Fixed some typos (flutter#18516) update Tristate checkbox semantics to consider indeterminate as "unchecked" (flutter#18297) Add flutter tool support for creating app-specific VM snapshots. (flutter#18417) mention Text.rich on RichText (flutter#18434) invert children for real (flutter#18489) Fix clipping for SliverLists (flutter#18410) Keep TextFields visible when keyboard comes up (flutter#18291) Update all packages (flutter#18506) Prepare for upgrading video player in Gallery to newest version (flutter#18501) Update Android dependencies (flutter#18499) Enable running with prebuilt test-only apk (flutter#18453) Revert "Update all packages (flutter#18471)" (flutter#18492) Add some more dart doc to RepaintBoundary (flutter#17183) Update all packages (flutter#18471) Clean up output of "flutter run --release" (flutter#18380) Ensure errors launching emulators are exposed to the daemon (flutter#18446) Check video widget is mounted on call to setState (flutter#18467) Fixed concurrent list modification in vmservice.dart
4 participants
The original emulator code used
printErrorwhen an error occurred launching an emulator. This worked fine from the CLI but in the daemon it means the response came back successful and then we got alogMessagewith the error. This means editors believed the launch worked (Dart Code ends up sitting around waiting for an emulator to connect) and there was an unrelated error.This code pushes the
printErrorup to the command so that the daemon error handling code will return the error correctly.