Skip to content

Prepare for upgrading video player in Gallery to newest version - #18501

Merged
mravn-google merged 2 commits into
flutter:masterfrom
mravn-google:upgrade_video_player_dep
Jun 15, 2018
Merged

mravn-google merged 2 commits into
flutter:masterfrom
mravn-google:upgrade_video_player_dep

Conversation

@mravn-google

@mravn-google mravn-google commented Jun 15, 2018 •

Copy link
Copy Markdown
Contributor

Version 0.6.0 of video_player plugin uses ExoPlayer instead of MediaPlayer on Android. The new dependency on ExoPlayer Java packages necessitates down-grading the Android test dependencies of flutter_gallery for compatibility with ExoPlayer transitive deps. Not down-grading caused the build error and roll-back of #18471

@mravn-google

Copy link
Copy Markdown
Contributor Author

cc @DanTup

@mravn-google
mravn-google requested a review from szakarias June 15, 2018 12:26
@mravn-google mravn-google changed the title Upgrade video player in Gallery to newest version Prepare for upgrading video player in Gallery to newest version Jun 15, 2018
@mravn-google
mravn-google force-pushed the upgrade_video_player_dep branch from d4c19a4 to 7eac6f9 Compare June 15, 2018 12:35

@szakarias szakarias left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mravn-google
mravn-google merged commit 7fa4637 into flutter:master Jun 15, 2018
@mravn-google
mravn-google deleted the upgrade_video_player_dep branch June 15, 2018 13:34
srawlins added a commit to srawlins/flutter that referenced this pull request Jun 15, 2018
* master:
  Remove race conditions involving finding available ports (flutter#18488)
  Skip painting hidden children of a sliver list (flutter#18465)
  Fixed some typos (flutter#18516)
  update Tristate checkbox semantics to consider indeterminate as "unchecked" (flutter#18297)
  Add flutter tool support for creating app-specific VM snapshots. (flutter#18417)
  mention Text.rich on RichText (flutter#18434)
  invert children for real (flutter#18489)
  Fix clipping for SliverLists (flutter#18410)
  Keep TextFields visible when keyboard comes up (flutter#18291)
  Update all packages (flutter#18506)
  Prepare for upgrading video player in Gallery to newest version (flutter#18501)
  Update Android dependencies (flutter#18499)
  Enable running with prebuilt test-only apk (flutter#18453)
  Revert "Update all packages (flutter#18471)" (flutter#18492)
  Add some more dart doc to RepaintBoundary (flutter#17183)
  Update all packages (flutter#18471)
  Clean up output of "flutter run --release" (flutter#18380)
  Ensure errors launching emulators are exposed to the daemon (flutter#18446)
  Check video widget is mounted on call to setState (flutter#18467)
  Fixed concurrent list modification in vmservice.dart
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants