Remove no-shuffle tag from dropdown_test.dart by ValentinVignal · Pull Request #186398 · flutter/flutter

ValentinVignal · 2026-05-12T09:50:38Z

It seems, the tests were already fixed, when I run with the seed 456 or 1408669812

flutter test test/material/dropdown_test.dart --test-randomize-ordering-seed=1408669812   
Building flutter tool...
Resolving dependencies... (1.0s)
Downloading packages... 
Got dependencies.
Resolving dependencies in `/Users/valentinvignal/Projects/flutter`... 
Downloading packages... 
  _fe_analyzer_shared 95.0.0 (100.0.0 available)
  adaptive_breakpoints 0.1.7 (discontinued)
  analyzer 10.1.0 (13.0.0 available)
  archive 3.6.1 (4.0.9 available)
  cli_util 0.4.2 (0.5.1 available)
  dart_style 3.1.7 (3.1.9 available)
  device_info 2.0.3 (discontinued replaced by device_info_plus)
  devtools_shared 12.1.0 (13.0.1 available)
  gcloud 0.8.19 (0.9.0 available)
  google_fonts 6.3.3 (8.1.0 available)
  googleapis 14.0.0 (16.0.0 available)
  googleapis_auth 2.3.0 (2.3.1 available)
  isolate 2.1.1 (discontinued)
  js 0.7.2 (discontinued)
  native_toolchain_c 0.17.6 (0.18.0 available)
  pedantic 1.11.1 (discontinued replaced by lints)
  video_player_avfoundation 2.9.5 (2.9.6 available)
  xml 6.6.1 (7.0.1 available)
Got dependencies in `/Users/valentinvignal/Projects/flutter`!
5 packages are discontinued.
13 packages have newer versions incompatible with dependency constraints.
Try `flutter pub outdated` for more information.
Shuffling test order with --test-randomize-ordering-seed=1408669812
00:32 +123: All tests passed!

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

gemini-code-assist

Code Review

This pull request removes the 'no-shuffle' tag and the associated TODO comment from the dropdown_test.dart file, which previously indicated issues with test state leaks or dependencies. I have no feedback to provide.

QuncCccccc

LGTM! Thanks. I verified flutter test --test-randomize-ordering-seed=456 packages/flutter/test/material/dropdown_test.dart pass now!

QuncCccccc · 2026-05-13T20:02:34Z

Might need to run dart format packages/flutter/test/material/dropdown_test.dart to fix linux analyze.

QuncCccccc

LGTM. Thanks:)

dkwingsmt · 2026-05-20T18:29:32Z

Thanks for your contribution! This PR has reached completion, however we're not able to merge this PR for the moment due to the Material/Cupertino code freeze (#184093). As soon as the decoupling is complete, we will post a way to port this PR to the new packages to land. In the meantime, I'll convert this PR to a draft and apply a label so that we can quickly find it when the freeze is lifted.

Piinks · 2026-06-24T20:09:07Z

I've marked this PR as not ready to port to flutter/packages yet.
We'll provide instructions to move this change over to material_ui/cupertino_ui once ready to receive PRs. Thank you!

ValentinVignal · 2026-08-21T06:34:12Z

Ported to material_ui: flutter/packages#12528

Part of flutter/flutter#85160 Ported from flutter/flutter#186398 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

ValentinVignal · 2026-09-04T01:44:19Z

If we want to remove the no-shuffle tag from the repository, we'd need to remove it from the tests currently using it. Re-opening

(cc @justinmc )

fluttergithubbot · 2026-09-04T01:44:23Z

An existing Git SHA, 07cee3908a16c6e2b3970f4e8d16bfae999d3818, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

github-actions · 2026-09-04T01:44:29Z

This pull request contains changes to Material or Cupertino, which are currently frozen in this repository.

Changes should be made in material_ui and/or cupertino_ui in the flutter/packages repository.

Please refer to #188444 for instructions.

gemini-code-assist

Code Review

This pull request removes the 'no-shuffle' tag and its associated comments from the dropdown_test.dart file, allowing the tests to run with randomized ordering. Additionally, it reformats the 'Conflicting scrollbars are not applied by ScrollBehavior to Dropdown' widget test. There are no review comments, and I have no additional feedback to provide.

flutter/flutter@63170e9...b444e78 2026-09-08 [email protected] Clean up lint errors in workflows (flutter/flutter#191987) 2026-09-08 [email protected] Remove no-shuffle tag from dropdown_test.dart (flutter/flutter#186398) 2026-09-08 [email protected] Remove no-shuffle from scrollbar test (flutter/flutter#186656) 2026-09-08 [email protected] [tool] Let --local-engine reach the build system again (flutter/flutter#192361) 2026-09-08 [email protected] [flutter_tools] Safely remove web loading indicator on dart-app-ready (flutter/flutter#192233) 2026-09-08 [email protected] [Linux] Don't clear the OpenGL context when a frame has been drawn (flutter/flutter#192137) 2026-09-08 [email protected] ci: update dartdoc from 9.0.6 to 9.0.9 (flutter/flutter#192405) 2026-09-07 [email protected] Add itemExtentBuilder support to ListView.separated (flutter/flutter#191157) 2026-09-07 [email protected] Roll Skia from e1437642d259 to b3fa80a0e168 (5 revisions) (flutter/flutter#192362) 2026-09-07 [email protected] Roll Skia from 2df865d9d369 to e1437642d259 (1 revision) (flutter/flutter#192360) 2026-09-07 [email protected] Roll Skia from c7aa5512d148 to 2df865d9d369 (2 revisions) (flutter/flutter#192357) 2026-09-06 [email protected] Roll Skia from db200e27a634 to c7aa5512d148 (2 revisions) (flutter/flutter#192351) 2026-09-06 [email protected] Roll Fuchsia Linux SDK from _IgixhH4vEgdz9Oqn... to p8hHkUi8uWT9R3N4z... (flutter/flutter#192349) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#12791) flutter/flutter@63170e9...b444e78 2026-09-08 [email protected] Clean up lint errors in workflows (flutter/flutter#191987) 2026-09-08 [email protected] Remove no-shuffle tag from dropdown_test.dart (flutter/flutter#186398) 2026-09-08 [email protected] Remove no-shuffle from scrollbar test (flutter/flutter#186656) 2026-09-08 [email protected] [tool] Let --local-engine reach the build system again (flutter/flutter#192361) 2026-09-08 [email protected] [flutter_tools] Safely remove web loading indicator on dart-app-ready (flutter/flutter#192233) 2026-09-08 [email protected] [Linux] Don't clear the OpenGL context when a frame has been drawn (flutter/flutter#192137) 2026-09-08 [email protected] ci: update dartdoc from 9.0.6 to 9.0.9 (flutter/flutter#192405) 2026-09-07 [email protected] Add itemExtentBuilder support to ListView.separated (flutter/flutter#191157) 2026-09-07 [email protected] Roll Skia from e1437642d259 to b3fa80a0e168 (5 revisions) (flutter/flutter#192362) 2026-09-07 [email protected] Roll Skia from 2df865d9d369 to e1437642d259 (1 revision) (flutter/flutter#192360) 2026-09-07 [email protected] Roll Skia from c7aa5512d148 to 2df865d9d369 (2 revisions) (flutter/flutter#192357) 2026-09-06 [email protected] Roll Skia from db200e27a634 to c7aa5512d148 (2 revisions) (flutter/flutter#192351) 2026-09-06 [email protected] Roll Fuchsia Linux SDK from _IgixhH4vEgdz9Oqn... to p8hHkUi8uWT9R3N4z... (flutter/flutter#192349) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter-dashboard Bot added the CICD Run CI/CD label May 12, 2026

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels May 12, 2026

gemini-code-assist Bot reviewed May 12, 2026

View reviewed changes

dkwingsmt requested a review from QuncCccccc May 13, 2026 18:15

QuncCccccc previously approved these changes May 13, 2026

View reviewed changes

ValentinVignal dismissed QuncCccccc’s stale review via dbeef1c May 15, 2026 04:27

ValentinVignal force-pushed the flutter/test/remove-no-shuffle-from-dropdown-test branch from 777cdf1 to dbeef1c Compare May 15, 2026 04:27

github-actions Bot removed the CICD Run CI/CD label May 15, 2026

ValentinVignal requested a review from QuncCccccc May 16, 2026 06:49

ValentinVignal force-pushed the flutter/test/remove-no-shuffle-from-dropdown-test branch from dbeef1c to 07cee39 Compare May 16, 2026 06:50

flutter-dashboard Bot added the CICD Run CI/CD label May 16, 2026

QuncCccccc approved these changes May 18, 2026

View reviewed changes

dkwingsmt marked this pull request as draft May 20, 2026 18:29

dkwingsmt added the waiting for code freeze This PR is waiting for a code freeze to resolve. label May 20, 2026

Piinks added the Decoupling: Not ready to port yet Instructions will be provided when this is ready to move to flutter/packages. label Jun 24, 2026

ValentinVignal mentioned this pull request Aug 21, 2026

[material_ui] Remove no-shuffle from dropdown test flutter/packages#12528

Merged

11 tasks done

ValentinVignal closed this Aug 21, 2026

ValentinVignal reopened this Sep 4, 2026

ValentinVignal force-pushed the flutter/test/remove-no-shuffle-from-dropdown-test branch from 07cee39 to d65e462 Compare September 4, 2026 01:44

ValentinVignal marked this pull request as ready for review September 4, 2026 01:44

gemini-code-assist Bot reviewed Sep 4, 2026

View reviewed changes

ValentinVignal added 2 commits September 8, 2026 11:16

Remove no-shuffle from dropdown_test

8444b87

Format

900a5ff

Piinks force-pushed the flutter/test/remove-no-shuffle-from-dropdown-test branch from d65e462 to 900a5ff Compare September 8, 2026 16:16

auto-submit Bot added this pull request to the merge queue Sep 8, 2026

Merged via the queue into flutter:master with commit 3238b12 Sep 8, 2026
28 of 29 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 8, 2026

engine-flutter-autoroll mentioned this pull request Sep 8, 2026

Roll Flutter from 63170e984e19 to b444e7897e24 (13 revisions) flutter/packages#12791

Merged

Navigation Menu

Repository navigation

Remove no-shuffle tag from dropdown_test.dart - #186398

Remove no-shuffle tag from dropdown_test.dart#186398
auto-submit[bot] merged 2 commits into
flutter:masterfrom
ValentinVignal:flutter/test/remove-no-shuffle-from-dropdown-test

ValentinVignal commented May 12, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

QuncCccccc left a comment

Uh oh!

QuncCccccc commented May 13, 2026

Uh oh!

QuncCccccc left a comment

Uh oh!

dkwingsmt commented May 20, 2026

Uh oh!

Piinks commented Jun 24, 2026

Uh oh!

ValentinVignal commented Aug 21, 2026

Uh oh!

ValentinVignal commented Sep 4, 2026 •

edited

Loading

Uh oh!

fluttergithubbot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

ValentinVignal commented May 12, 2026

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc commented May 13, 2026

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

dkwingsmt commented May 20, 2026

Uh oh!

Piinks commented Jun 24, 2026

Uh oh!

ValentinVignal commented Aug 21, 2026

Uh oh!

ValentinVignal commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fluttergithubbot commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ValentinVignal commented Sep 4, 2026 •

edited

Loading