Skip to content

[material_ui] Remove no-shuffle from dropdown test - #12528

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
ValentinVignal:material-ui/test/remove-no-shuffle-from-dropdown-test
Aug 21, 2026
Merged

auto-submit[bot] merged 1 commit into
flutter:mainfrom
ValentinVignal:material-ui/test/remove-no-shuffle-from-dropdown-test

Conversation

@ValentinVignal

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#85160

Ported from flutter/flutter#186398

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 21, 2026
@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Aug 21, 2026
@ValentinVignal

Copy link
Copy Markdown
Contributor Author

This doesn't need a pending changelog file since it only affects a test

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the 'no-shuffle' tag and its associated explanatory comments from the 'packages/material_ui/test/dropdown_test.dart' test file, allowing the test to be run with randomized ordering. There are no review comments, and I have no feedback to provide.

@QuncCccccc QuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you:)

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 21, 2026
@auto-submit
auto-submit Bot merged commit 16fe084 into flutter:main Aug 21, 2026
12 checks passed
pull Bot pushed a commit to fucheng-guo-sun/flutter that referenced this pull request Aug 24, 2026
…r#191578)

flutter/packages@252bb33...df2ba94

2026-08-24 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.json:json from 20260719 to 20260814 in
/packages/in_app_purchase/in_app_purchase_android/example/android/app
(flutter/packages#12570)
2026-08-22 [email protected] Roll Flutter from
c243752 to 65c9a8d (195 revisions) (flutter/packages#12554)
2026-08-21 [email protected] [pigeon] add modern concurrency support
(flutter/packages#12382)
2026-08-21 [email protected]
[material_ui] Remove no-shuffle in scrollbar test
(flutter/packages#12527)
2026-08-21 [email protected]
[material_ui] Remove no-shuffle from dropdown test
(flutter/packages#12528)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants