Repository navigation
Clarify route transition animations - #186552
Merged
auto-submit[bot] merged 1 commit intoMay 28, 2026
Merged
auto-submit[bot] merged 1 commit into
auto-submit[bot] merged 1 commit into
Conversation
github-actions
Bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the documentation for PageRouteBuilder and RouteTransitionsBuilder by detailing the roles of the animation and secondaryAnimation parameters in route transitions and coordination. The review feedback recommends using square brackets for parameter references to ensure consistency with Flutter documentation standards and suggests providing more specific details regarding transition coordination methods.
mvincentong
force-pushed
the
docs-route-transition-animations
branch
from
May 15, 2026 00:47
4548e6c to
6e2f225
Compare
victorsanni
approved these changes
May 28, 2026
victorsanni
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/186552, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
victorsanni
force-pushed
the
docs-route-transition-animations
branch
from
May 28, 2026 20:24
6e2f225 to
4469c9d
Compare
flutter-dashboard
Bot
removed
the
autosubmit
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 29, 2026
flutter/flutter@e70534d...b05a9d7 2026-05-29 [email protected] Roll Skia from 47155534833e to d9d6b440c4e7 (1 revision) (flutter/flutter#187301) 2026-05-29 [email protected] Roll Skia from f93ed13d77fb to 47155534833e (4 revisions) (flutter/flutter#187291) 2026-05-29 [email protected] [web_ui] Optimize skwasm text layout and path decoding to eliminate dynamic boxing churn under Wasm (flutter/flutter#186978) 2026-05-29 [email protected] Roll Fuchsia Linux SDK from SBpmmPxqx3lAvGojE... to jMR_VXQi07kAk8vbR... (flutter/flutter#187279) 2026-05-29 [email protected] Remove Material import from sliver tree rendering test (flutter/flutter#187000) 2026-05-29 [email protected] [Impeller] Remove the y_coord_scale Y-flip plumbing (flutter/flutter#187224) 2026-05-29 [email protected] Add/remove overlay child RenderObject from the tree in `attach`/`detach` (flutter/flutter#186564) 2026-05-29 [email protected] Roll Skia from fcfe5975c945 to f93ed13d77fb (4 revisions) (flutter/flutter#187273) 2026-05-28 [email protected] Handle complex RSE rendering in the uber SDF pipeline (flutter/flutter#186434) 2026-05-28 [email protected] Roll Dart SDK from 082191101fcc to 683322426411 (2 revisions) (flutter/flutter#187270) 2026-05-28 [email protected] Clarify route transition animations (flutter/flutter#186552) 2026-05-28 [email protected] document that the default Key is null and explain proper usage in list diffing (flutter/flutter#185197) 2026-05-28 [email protected] [flutter_tools] Use super parameters in missed spots (flutter/flutter#186197) 2026-05-28 [email protected] docs: Document MediaQueryData.alwaysUse24HourFormat on macOS, Windows, Linux, web (#160664) (flutter/flutter#186642) 2026-05-28 [email protected] Roll Skia from 5493e4c144cd to fcfe5975c945 (3 revisions) (flutter/flutter#187256) 2026-05-28 [email protected] Shares opengles golden context (flutter/flutter#187243) 2026-05-28 [email protected] Update the Curl CIPD package in .ci.yaml to version 8.20.0 (flutter/flutter#187133) 2026-05-28 [email protected] Improve SizedBox's docs (flutter/flutter#187208) 2026-05-28 [email protected] [Impeller] Support instanced rendering across all backends (flutter/flutter#186653) 2026-05-28 [email protected] [Android] Reset system UI visibility flags when setting edge-to-edge mode (flutter/flutter#187207) 2026-05-28 [email protected] Roll Skia from a38708fb7926 to 5493e4c144cd (7 revisions) (flutter/flutter#187241) 2026-05-28 [email protected] Turned on impeller by default on macos (flutter/flutter#186546) 2026-05-28 [email protected] Clarify lazy scroll extent docs (flutter/flutter#186864) 2026-05-28 [email protected] [web] Fix WebParagraph locales test (flutter/flutter#186813) 2026-05-28 [email protected] Roll Packages from 4b424d7 to 10cbdc5 (3 revisions) (flutter/flutter#187238) 2026-05-28 [email protected] Roll Dart SDK from f3db7b7d9801 to 082191101fcc (8 revisions) (flutter/flutter#187235) 2026-05-28 [email protected] Roll Skia from 32acea791248 to a38708fb7926 (1 revision) (flutter/flutter#187221) 2026-05-28 [email protected] [Flutter GPU] Add r32Float and remove Apple-only XR pixel formats (flutter/flutter#187069) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…r#11803) flutter/flutter@e70534d...b05a9d7 2026-05-29 [email protected] Roll Skia from 47155534833e to d9d6b440c4e7 (1 revision) (flutter/flutter#187301) 2026-05-29 [email protected] Roll Skia from f93ed13d77fb to 47155534833e (4 revisions) (flutter/flutter#187291) 2026-05-29 [email protected] [web_ui] Optimize skwasm text layout and path decoding to eliminate dynamic boxing churn under Wasm (flutter/flutter#186978) 2026-05-29 [email protected] Roll Fuchsia Linux SDK from SBpmmPxqx3lAvGojE... to jMR_VXQi07kAk8vbR... (flutter/flutter#187279) 2026-05-29 [email protected] Remove Material import from sliver tree rendering test (flutter/flutter#187000) 2026-05-29 [email protected] [Impeller] Remove the y_coord_scale Y-flip plumbing (flutter/flutter#187224) 2026-05-29 [email protected] Add/remove overlay child RenderObject from the tree in `attach`/`detach` (flutter/flutter#186564) 2026-05-29 [email protected] Roll Skia from fcfe5975c945 to f93ed13d77fb (4 revisions) (flutter/flutter#187273) 2026-05-28 [email protected] Handle complex RSE rendering in the uber SDF pipeline (flutter/flutter#186434) 2026-05-28 [email protected] Roll Dart SDK from 082191101fcc to 683322426411 (2 revisions) (flutter/flutter#187270) 2026-05-28 [email protected] Clarify route transition animations (flutter/flutter#186552) 2026-05-28 [email protected] document that the default Key is null and explain proper usage in list diffing (flutter/flutter#185197) 2026-05-28 [email protected] [flutter_tools] Use super parameters in missed spots (flutter/flutter#186197) 2026-05-28 [email protected] docs: Document MediaQueryData.alwaysUse24HourFormat on macOS, Windows, Linux, web (#160664) (flutter/flutter#186642) 2026-05-28 [email protected] Roll Skia from 5493e4c144cd to fcfe5975c945 (3 revisions) (flutter/flutter#187256) 2026-05-28 [email protected] Shares opengles golden context (flutter/flutter#187243) 2026-05-28 [email protected] Update the Curl CIPD package in .ci.yaml to version 8.20.0 (flutter/flutter#187133) 2026-05-28 [email protected] Improve SizedBox's docs (flutter/flutter#187208) 2026-05-28 [email protected] [Impeller] Support instanced rendering across all backends (flutter/flutter#186653) 2026-05-28 [email protected] [Android] Reset system UI visibility flags when setting edge-to-edge mode (flutter/flutter#187207) 2026-05-28 [email protected] Roll Skia from a38708fb7926 to 5493e4c144cd (7 revisions) (flutter/flutter#187241) 2026-05-28 [email protected] Turned on impeller by default on macos (flutter/flutter#186546) 2026-05-28 [email protected] Clarify lazy scroll extent docs (flutter/flutter#186864) 2026-05-28 [email protected] [web] Fix WebParagraph locales test (flutter/flutter#186813) 2026-05-28 [email protected] Roll Packages from 4b424d7 to 10cbdc5 (3 revisions) (flutter/flutter#187238) 2026-05-28 [email protected] Roll Dart SDK from f3db7b7d9801 to 082191101fcc (8 revisions) (flutter/flutter#187235) 2026-05-28 [email protected] Roll Skia from 32acea791248 to a38708fb7926 (1 revision) (flutter/flutter#187221) 2026-05-28 [email protected] [Flutter GPU] Add r32Float and remove Apple-only XR pixel formats (flutter/flutter#187069) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
via-guy
pushed a commit
to via-guy/flutter
that referenced
this pull request
Jun 26, 2026
Issue: fixes flutter#23206 The `PageRouteBuilder` and `RouteTransitionsBuilder` docs pointed readers to `ModalRoute.buildTransitions`, but the callback docs themselves did not explain the practical difference between the primary `animation` and `secondaryAnimation` parameters. Fix: Clarify that `animation` drives the route's own push/pop transition, while `secondaryAnimation` lets the route coordinate with a route pushed above it. The docs now also mention that `secondaryAnimation` only runs when the adjacent routes allow transition coordination through `canTransitionTo`/`canTransitionFrom`. Tests: - `./bin/dart format --output=none --set-exit-if-changed packages/flutter/lib/src/widgets/routes.dart packages/flutter/lib/src/widgets/pages.dart` - `./bin/flutter analyze packages/flutter/lib/src/widgets/routes.dart packages/flutter/lib/src/widgets/pages.dart` - `git diff --check` Risk: Docs-only change in two route API comments. No runtime behavior changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: fixes #23206
The
PageRouteBuilderandRouteTransitionsBuilderdocs pointed readers toModalRoute.buildTransitions, but the callback docs themselves did not explain the practical difference between the primaryanimationandsecondaryAnimationparameters.Fix:
Clarify that
animationdrives the route's own push/pop transition, whilesecondaryAnimationlets the route coordinate with a route pushed above it. The docs now also mention thatsecondaryAnimationonly runs when the adjacent routes allow transition coordination throughcanTransitionTo/canTransitionFrom.Tests:
./bin/dart format --output=none --set-exit-if-changed packages/flutter/lib/src/widgets/routes.dart packages/flutter/lib/src/widgets/pages.dart./bin/flutter analyze packages/flutter/lib/src/widgets/routes.dart packages/flutter/lib/src/widgets/pages.dartgit diff --checkRisk:
Docs-only change in two route API comments. No runtime behavior changes.