Repository navigation
Conversation
The routes_transition_test suite exercises MaterialApp, MaterialPageRoute, Scaffold, TextButton, and Material page transition builders throughout the file. Move the test from packages/flutter/test/widgets to packages/flutter/test/material so the widgets test directory no longer carries a material-specific test. Part of flutter#177414
github-actions
Bot
added
framework
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
Superseded by #186620 after renaming the contributor branch. |
kevmoo
added a commit
to kevmoo/flutter
that referenced
this pull request
Sep 22, 2026
- Checks Firefox versions under 147 and forces fallback to JS for dart2wasm (flutter#186619) - Fixes loader.js where wasmAllowList configs were only checked for skwasm rather than all dart2wasm builds - Adds fallbacks_test.dart coverage for explicit wasmAllowList opt-in when WasmGC capabilities are missing
kevmoo
added a commit
to kevmoo/flutter
that referenced
this pull request
Sep 24, 2026
- Checks Firefox versions under 147 and forces fallback to JS for dart2wasm (flutter#186619) - Fixes loader.js where wasmAllowList configs were only checked for skwasm rather than all dart2wasm builds - Adds fallbacks_test.dart coverage for explicit wasmAllowList opt-in when WasmGC capabilities are missing
9 tasks done
jesswrd
pushed a commit
to jesswrd/flutter
that referenced
this pull request
Oct 2, 2026
…y checks (flutter#193667) Adds a regression test in `fallbacks_test.dart` (`firefox-fallbacks` suite) verifying the `Firefox < 147` version gate added in flutter#193180 (and its precedence over `_flutter.supportsDart2Wasm` in flutter#193271): 1. **Firefox 146 (`< 147`)**: Even when `wasmAllowList: { gecko: true }` is configured, `_flutter.supportsDart2Wasm` is `true`, and `WebAssembly.validate` returns `true`, `FlutterLoader.load` rejects `dart2wasm` builds before invoking `WebAssembly.validate` (`validateCalls == 0`). 2. **Firefox 147 (`>= 147`)**: Passes the Firefox version gate and proceeds to evaluate `WebAssembly.validate` (`validateCalls > 0`). Related to flutter#143603 and flutter#186619 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #177414
Moves
routes_transition_testfrom widgets to material because the entire test suite has direct Material dependencies.Tests:
./bin/flutter test packages/flutter/test/material/routes_transition_test.dart