Android_hardware_smoke_test: clean up golden copy in CI - #189948

Since baseDir in _SkiaGoldComparator defaults to the directory of the running script (which is test_driver/), passing 'test_driver/goldens' as localOutputDir will resolve to test_driver/test_driver/goldens. This will cause the goldens to be written to the wrong directory, meaning they won't be packaged into the APK and won't be cleaned up properly. It should be set to 'goldens' instead.

baseDir is parsed without a trailing slash, causing URI resolution to strip the last directory segment (test_driver). To make the behavior match developer intuition, I have updated baseDir assignment to use Uri.directory which guarantees a trailing slash. Now we can pass goldens.

To ensure cross-platform compatibility (especially on Windows), we should normalize any potential backslashes in localOutputDir to forward slashes before resolving, as standard URI resolution does not treat backslashes as directory separators. Additionally, using uri.pathSegments.last is a cleaner and more platform-independent way to extract the filename from a URI than path.basename(uri.path).

    if (localOutputDir != null) {
      final String fileName = uri.pathSegments.last;
      final String normalizedOutputDir = localOutputDir!.replaceAll('\\', '/');
      return io.File.fromUri(baseDir.resolve('$normalizedOutputDir/$fileName'));
    }

Done

Using io.Platform.script.path can lead to issues on Windows because it returns a URI path (e.g., /C:/foo/bar), whereas path.dirname and Uri.directory expect a platform-native path. Using io.Platform.script.toFilePath() ensures a correct platform-native path is used.

  }) : baseDir = baseDir ?? Uri.directory(path.dirname(io.Platform.script.toFilePath()));

done

Using path.join with baseDir.toFilePath() is more robust and idiomatic than manual string replacement and URI resolution. It automatically handles platform-specific path separators and avoids potential issues with leading/trailing slashes in localOutputDir.

    if (localOutputDir != null) {
      final String fileName = uri.pathSegments.last;
      return io.File(path.join(baseDir.toFilePath(), localOutputDir!, fileName));
    }

done

done. I always felt the ternary operator was a little cryptic, I like this switch semantic a lot better

oops, that string needed to be final