Skip to content

ci: verify_binaries_pre_codesigned part 2 - #190078

Merged
auto-submit[bot] merged 1 commit into
masterfrom
verify_binaries_duex
Jul 27, 2026
Merged

auto-submit[bot] merged 1 commit into
masterfrom
verify_binaries_duex

Conversation

@jtmcdole

@jtmcdole jtmcdole commented Jul 27, 2026 •

Copy link
Copy Markdown
Member

macos runners don't let you touch /opt!

fixes: #189995

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 27, 2026
@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Jul 27, 2026
@jtmcdole

Copy link
Copy Markdown
Member Author

waiting for tests to complete before reverting deps.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the composite Flutter setup action to use a temporary runner directory for the PUB_CACHE environment variable and cache path, replacing the hardcoded /opt/pub-cache path. Feedback suggests using the GitHub context ${{ runner.temp }} instead of the environment variable $RUNNER_TEMP to ensure cross-platform consistency and avoid path translation discrepancies.

Comment thread .github/actions/composite-flutter-setup/action.yml
macos runners don't let you touch /opt!
@jtmcdole
jtmcdole force-pushed the verify_binaries_duex branch from 263de3b to 0d2fe69 Compare July 27, 2026 17:18
@github-actions github-actions Bot removed the engine flutter/engine related. See also e: labels. label Jul 27, 2026
@jtmcdole
jtmcdole requested a review from zanderso July 27, 2026 17:19
@jtmcdole

Copy link
Copy Markdown
Member Author

@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 27, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Jul 27, 2026
Merged via the queue into master with commit 8747e2f Jul 27, 2026
26 checks passed
@auto-submit
auto-submit Bot deleted the verify_binaries_duex branch July 27, 2026 20:01
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 27, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jul 28, 2026
flutter/flutter@9988960...0f02463

2026-07-28 [email protected] Roll Fuchsia Test Scripts from E8hJ1AfK8CtGtaES0... to 1frGe_KltAJKkeyPg... (flutter/flutter#190134)
2026-07-28 [email protected] iOS: Reject merged-platform-ui-thread=mergeAfterLaunch (flutter/flutter#190051)
2026-07-28 [email protected] iOS: Migrate TaskRunner tests to Swift Testing (flutter/flutter#190055)
2026-07-28 [email protected] Run Mac golden tests on ARM bots (flutter/flutter#189465)
2026-07-28 [email protected] iOS,macOS: Rename Swift test files to end in Tests.swift (flutter/flutter#190063)
2026-07-28 [email protected] Fix hcpp cliprect being behind by 1 frame when scrolling (flutter/flutter#189946)
2026-07-28 [email protected] Roll Fuchsia Linux SDK from vpboK5fPPIoFteqRq... to OZkZC_2CZ_G5rbMIS... (flutter/flutter#190115)
2026-07-27 [email protected] Add Ishaq Hassan to AUTHORS (flutter/flutter#190064)
2026-07-27 [email protected] [wimp] fixes ubo padding size issue (flutter/flutter#189958)
2026-07-27 [email protected] Roll pub packages (flutter/flutter#189872)
2026-07-27 [email protected] Move tool host_cross_arch tests into different shards (flutter/flutter#189470)
2026-07-27 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 6.2.0 to 7.0.0 in the all-github-actions group (flutter/flutter#190099)
2026-07-27 [email protected] [ios]do not nuke user input path when running uiscene integration test (flutter/flutter#186436)
2026-07-27 [email protected] ci: verify_binaries_pre_codesigned part 2 (flutter/flutter#190078)
2026-07-27 [email protected] Roll Abseil to ff6e8ce3e932 (flutter/flutter#189998)
2026-07-27 [email protected] Android_hardware_smoke_test: clean up golden copy in CI (flutter/flutter#189948)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can verify_binaries_pre_codesigned run in a workflow and on PRs

2 participants