Skip to content

Fix DeleteSurrounding splitting UTF-16 surrogate pairs - #190514

Merged
auto-submit[bot] merged 8 commits into
flutter:masterfrom
Vi-debug:fix-delete-surrounding-surrogate-pairs
Sep 3, 2026
Merged

Fix DeleteSurrounding splitting UTF-16 surrogate pairs#190514
auto-submit[bot] merged 8 commits into
flutter:masterfrom
Vi-debug:fix-delete-surrounding-surrogate-pairs

Conversation

@Vi-debug

@Vi-debug Vi-debug commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

DeleteSurrounding(offset, count) deletes count code points, but text_ is UTF-16, where a code point is 1 or 2 units. So the loop that walks the deletion range has to ask, at each step, "is the unit I'm about to step over a lead surrogate?" — and advance by 2 if so, 1 otherwise.

The old code asked that question about the wrong position:

end += IsLeadingSurrogate(text_.at(start)) ? 2 : 1;

start never moves inside the loop, so every iteration re-tested the same unit — the one the range began at — instead of the unit end currently sits on. The fix is to test the moving cursor:

end += IsLeadingSurrogate(text_.at(end)) ? 2 : 1;

Concretely, for "a😀" (units: a, D83D, DE00) deleting 2 code points from 0:

  old new
step 1 tests a → end = 1 tests a → end = 1
step 2 tests a again → end = 2 tests D83D → end = 3
erase [0,2) — cuts the pair in half, leaves orphaned DE00 [0,3) — whole pair

That orphan is what killed the process: the next GetText() runs fml::Utf16ToUtf8, a lone surrogate is invalid UTF-16, and with the engine built -fno-exceptions the resulting range_error becomes an abort instead of a throw. The mirror-image case — non-BMP first, BMP after — over-advanced instead, silently deleting extra characters.

The second half of the fix is the loop guard, end != max_pos → end < max_pos. Now that steps can be 2 wide, end can jump over max_pos rather than landing on it — a pair straddling the end of a composing range does this. With !=, the guard would then never be satisfied and the loop would keep reading past the end of the range, walking text_.at() off the string and aborting the same way. < stops it. The same reasoning applies to the start loop above it, which advances by the same 1-or-2 rule.

Fixes #190046

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@Vi-debug
Fix DeleteSurrounding splitting UTF-16 surrogate pairs
d31df22 
TextInputModel::DeleteSurrounding advanced the end of the deletion range
by inspecting the character at start on every iteration instead of the
one at end. When a later code point in the range was non-BMP, end landed
inside a surrogate pair and the erase left a lone surrogate in text_,
aborting the process on the next UTF-16 to UTF-8 conversion.

Fixes flutter#190046
@github-actions github-actions Bot added a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. labels Aug 4, 2026
@Vi-debug
Vi-debug marked this pull request as ready for review August 4, 2026 07:36
@Vi-debug Vi-debug mentioned this pull request Aug 4, 2026
Closed
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 4, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a bug in TextInputModel::DeleteSurrounding where deleting across non-BMP code points could leave a lone surrogate behind, corrupting the text. The fix ensures that the character at the position being advanced past is checked rather than the starting position, and updates loop bounds checks from inequality to less-than comparisons. Additionally, several unit tests are added to verify deleting surrounding wide characters under various scenarios. There are no review comments, so I have no feedback to provide.

@Vi-debug
Vi-debug force-pushed the fix-delete-surrounding-surrogate-pairs branch from d31df22 to d14198e Compare August 5, 2026 08:51
@Vi-debug
Fix DeleteSurrounding splitting UTF-16 surrogate pairs
6581a11 
TextInputModel::DeleteSurrounding advanced the end of the deletion range
by inspecting the character at start on every iteration instead of the
one at end. When a later code point in the range was non-BMP, end landed
inside a surrogate pair and the erase left a lone surrogate in text_,
aborting the process on the next UTF-16 to UTF-8 conversion.

Fixes flutter#190046
@Vi-debug
Vi-debug force-pushed the fix-delete-surrounding-surrogate-pairs branch from d14198e to 6581a11 Compare August 6, 2026 02:28
@LongCatIsLooong LongCatIsLooong added the team-macos Owned by the macOS platform team label Aug 6, 2026
@github-actions github-actions Bot removed the team-macos Owned by the macOS platform team label Aug 7, 2026
@Vi-debug

Vi-debug commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Hi @LongCatIsLooong I update the branch with master and "team-macos" disappear. Could you add it again?

Renzo-Olivares
Renzo-Olivares reviewed Aug 18, 2026
View reviewed changes

@Renzo-Olivares Renzo-Olivares left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vi-debug thank you for the contribution! Left a few small comments but overall the change looks good to me.

Comment thread engine/src/flutter/shell/platform/common/text_input_model.cc Outdated

@Renzo-Olivares Renzo-Olivares Aug 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the change in guard in the forward loop, also apply similarly for the backwards loop since we can move in steps of 2 potentially skipping the exact start of the range?

@Vi-debug Vi-debug Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I fixed it. Thanks for noticing

Comment thread engine/src/flutter/shell/platform/common/text_input_model_unittests.cc
EXPECT_STREQ(model->GetText().c_str(), "ABCE");
}

// Regression test for https://github.com/flutter/flutter/issues/190046.

@Renzo-Olivares Renzo-Olivares Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add regression tests for the guard changes. The test should fail with the old guard and pass with the new guard.

@Vi-debug Vi-debug Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two regression tests isolating just the guard changes DeleteSurroundingGuardStopsAtComposingEnd for the forward guard and DeleteSurroundingGuardStopsAtComposingStart for the backward guard fixed

@Renzo-Olivares Renzo-Olivares added the waiting for response The Flutter team cannot make further progress on this issue until the original reporter responds label Aug 18, 2026
@Vi-debug
Fix backward-walk guard skipping past editable range start
1f44032 
DeleteSurrounding's backward loop compared start == editable_range().start()
to detect reaching the start of the range, but a 2-wide step across a
surrogate pair can land start before that position instead of exactly on it
-- the same hazard just fixed for the forward end != max_pos guard. Use <=
instead, and add regression tests isolating both guard changes.

Addresses review feedback from Renzo-Olivares on flutter#190514.
@Vi-debug
Merge remote-tracking branch 'fork/fix-delete-surrounding-surrogate-p…
ac542d0 
…airs' into fix-delete-surrounding-surrogate-pairs

# Conflicts:
#	engine/src/flutter/shell/platform/common/text_input_model_unittests.cc
@github-actions github-actions Bot removed the waiting for response The Flutter team cannot make further progress on this issue until the original reporter responds label Aug 18, 2026
@Vi-debug
Vi-debug marked this pull request as draft August 26, 2026 04:23
@Vi-debug
Vi-debug marked this pull request as ready for review August 27, 2026 04:39
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 27, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates TextInputModel::DeleteSurrounding to correctly handle surrogate pairs and boundary conditions when deleting surrounding text, preventing lone surrogates and out-of-bounds errors, and adds corresponding regression tests. Feedback points out a potential issue where start can become negative when stepping backward across surrogate pairs, leading to an out-of-bounds read, and suggests clamping start to 0.

Comment thread engine/src/flutter/shell/platform/common/text_input_model.cc
Renzo-Olivares
Renzo-Olivares reviewed Aug 27, 2026
View reviewed changes
Comment thread engine/src/flutter/shell/platform/common/text_input_model_unittests.cc
Renzo-Olivares
Renzo-Olivares reviewed Aug 27, 2026
View reviewed changes
Comment thread engine/src/flutter/shell/platform/common/text_input_model_unittests.cc
@Renzo-Olivares Renzo-Olivares added the waiting for response The Flutter team cannot make further progress on this issue until the original reporter responds label Aug 27, 2026
Vi-debug added a commit to Vi-debug/flutter that referenced this pull request Aug 28, 2026
@Vi-debug @claude
Fix composing range underflow/staleness in DeleteSurrounding
8376a33 
Adding the selection()/composing_range() assertions Renzo-Olivares
requested on flutter#190514 exposed two bugs in how DeleteSurrounding adjusted
composing_range_: shifting only the end by deleted_length underflowed
(size_t) whenever a surrogate pair pushed the deletion past the stored
end, and the start was never adjusted when the deletion began before
it, leaving a stale bound. Clamp both bounds against the deleted span
instead of shifting only the end.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_012gKRyXkFH3AkJb1Xiqyfvo
@Vi-debug
Fix composing range underflow/staleness in DeleteSurrounding
059661a 
Adding the selection()/composing_range() assertions Renzo-Olivares
requested on flutter#190514 exposed two bugs in how DeleteSurrounding adjusted
composing_range_: shifting only the end by deleted_length underflowed
(size_t) whenever a surrogate pair pushed the deletion past the stored
end, and the start was never adjusted when the deletion began before
it, leaving a stale bound. Clamp both bounds against the deleted span
instead of shifting only the end.
@Vi-debug
Vi-debug force-pushed the fix-delete-surrounding-surrogate-pairs branch from 8376a33 to 059661a Compare August 28, 2026 01:41
@github-actions github-actions Bot removed the waiting for response The Flutter team cannot make further progress on this issue until the original reporter responds label Aug 28, 2026
@LongCatIsLooong LongCatIsLooong added the CICD Run CI/CD label Aug 28, 2026
LongCatIsLooong
LongCatIsLooong previously approved these changes Aug 28, 2026
View reviewed changes

@LongCatIsLooong LongCatIsLooong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry forgot to press the submit review button. LGTM with a comment nit.

Comment thread engine/src/flutter/shell/platform/common/text_input_model.cc Outdated
@LongCatIsLooong

LongCatIsLooong commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Could you also sync this to head since ci.yaml validation is failing.

@LongCatIsLooong

LongCatIsLooong commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Also /cc @cbracken, I think the PR I mentioned in #191868 (comment)

@flutter-dashboard flutter-dashboard Bot removed the CICD Run CI/CD label Aug 29, 2026
@Vi-debug

Vi-debug commented Aug 29, 2026

Copy link
Copy Markdown
Contributor Author

Updated PR. Waiting for @LongCatIsLooong check again

@LongCatIsLooong LongCatIsLooong added the CICD Run CI/CD label Aug 31, 2026
Renzo-Olivares
Renzo-Olivares approved these changes Sep 1, 2026
View reviewed changes

@Renzo-Olivares Renzo-Olivares left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vi-debug

Vi-debug commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

@LongCatIsLooong Pls help me trigger merge for this PR

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 3, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Sep 3, 2026
Merged via the queue into flutter:master with commit 37ad6a3 Sep 3, 2026
28 of 29 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 3, 2026
This was referenced Sep 4, 2026
Closed
Closed
Closed
Closed
Closed
Merged
@justinmc justinmc mentioned this pull request Sep 4, 2026
Open
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Sep 4, 2026
@engine-flutter-autoroll
Manual roll Flutter from 70797e15325e to 5a6cfa7f3d26 (52 revisions) (#…
a929c2f 
…12760)

Manual roll Flutter from 70797e15325e to 5a6cfa7f3d26 (52 revisions)

Manual roll requested by [email protected]

flutter/flutter@70797e1...5a6cfa7

2026-09-04 [email protected] [tool] Migrate ScreenshotCommand to modular dependency injection (flutter/flutter#190767)
2026-09-04 [email protected] Roll Skia from 8fce167bdded to 93ac1e630d1d (3 revisions) (flutter/flutter#192306)
2026-09-04 [email protected] Add iOS Universal Link integration test (Simulator) (flutter/flutter#191443)
2026-09-04 [email protected] [AGP 9.1.0 Migration #5] Delete getLegacyAndroidExtension and migrate NDK fallback to public DSL (flutter/flutter#192116)
2026-09-04 [email protected] Reland "[tool_tests] Remove bringup from Windows tool_tests_commands_2_2" (#191732) (flutter/flutter#191802)
2026-09-04 [email protected] [flutter_tools] Fix unhandled DebugAdapterException on early process termination (flutter/flutter#192294)
2026-09-04 [email protected] Roll Packages from f9b3954 to 9af9c60 (4 revisions) (flutter/flutter#192292)
2026-09-04 [email protected] Roll Skia from 2e3f7e07eee6 to 8fce167bdded (5 revisions) (flutter/flutter#192283)
2026-09-04 [email protected] Roll Fuchsia Linux SDK from GTZNkoIR_WegRPWgL... to FgDQeF6jb1dVRVh3K... (flutter/flutter#192276)
2026-09-04 [email protected] Roll Skia from b6b00df360e5 to 2e3f7e07eee6 (2 revisions) (flutter/flutter#192275)
2026-09-04 [email protected] [iOS] TextField should support typing accented words with external keyboard (flutter/flutter#191062)
2026-09-04 [email protected] Roll Skia from 1f68c0b16f17 to b6b00df360e5 (7 revisions) (flutter/flutter#192269)
2026-09-04 [email protected] [flutter_tools] add typed enum and defaulted option descriptors (flutter/flutter#191760)
2026-09-04 [email protected] Roll Dart SDK from c2edc382a4f8 to 5501d02b583d (1 revision) (flutter/flutter#192263)
2026-09-04 [email protected] [Linux] Use fences to synchronize frames between OpenGL contexts (flutter/flutter#192098)
2026-09-03 [email protected] Defer semantics geometry updates for blocked branches (flutter/flutter#192146)
2026-09-03 [email protected] Roll Skia from 8d3e197531c6 to 1f68c0b16f17 (8 revisions) (flutter/flutter#192244)
2026-09-03 [email protected] Fix DeleteSurrounding splitting UTF-16 surrogate pairs (flutter/flutter#190514)
2026-09-03 [email protected] Remove no-shuffle from progress indicator test (flutter/flutter#186655)
2026-09-03 [email protected] [material] Remove unused parameters from constructors of generic test class (flutter/flutter#191764)
2026-09-03 [email protected] Handle linear and radial gradients in UberSDF (re-implement after fix) (flutter/flutter#192124)
2026-09-03 [email protected] Roll Dart SDK from fcbfb64f42a1 to c2edc382a4f8 (2 revisions) (flutter/flutter#192240)
2026-09-03 [email protected] Fix parsing of --enable-hcpp-and-surface-control switch and add --no-enable-hcpp tests (flutter/flutter#192202)
2026-09-03 [email protected] Fix issue where shapes rendered with gradient+blur+rotation end up incorrectly cut off (flutter/flutter#192136)
2026-09-03 [email protected] Fix sibling nodes crash under MergeSemantics (flutter/flutter#191587)
2026-09-03 [email protected] Makes backdrop groups operate on the union. (flutter/flutter#191838)
2026-09-03 [email protected] Roll Skia from 008936396810 to 8d3e197531c6 (1 revision) (flutter/flutter#192236)
2026-09-03 [email protected] [docs] Remove superseded AI rules for Flutter (flutter/flutter#192185)
2026-09-03 [email protected] Collect analytics about SwiftPM errors and warnings (flutter/flutter#191746)
2026-09-03 [email protected] Roll Packages from 18fe786 to f9b3954 (7 revisions) (flutter/flutter#192235)
2026-09-03 [email protected] [Linux] Remove frame sharing between OpenGL contexts (flutter/flutter#192150)
2026-09-03 [email protected] Roll Dart SDK from cf79067a1e44 to fcbfb64f42a1 (1 revision) (flutter/flutter#192228)
2026-09-03 [email protected] Roll Skia from 731fe9af4c0b to 008936396810 (3 revisions) (flutter/flutter#192225)
2026-09-03 [email protected] Roll Dart SDK from 700ab60bfe53 to cf79067a1e44 (2 revisions) (flutter/flutter#192219)
2026-09-03 [email protected] Roll Skia from 823f82e18177 to 731fe9af4c0b (5 revisions) (flutter/flutter#192217)
2026-09-03 [email protected] Fixes OverlayPortal semantics bounds corruption (flutter/flutter#192139)
2026-09-03 [email protected] Roll Fuchsia Linux SDK from idslm9FikVLy2K_A-... to GTZNkoIR_WegRPWgL... (flutter/flutter#192215)
2026-09-03 [email protected] Roll Fuchsia Test Scripts from u_fSMsPU22VvUsvSo... to VObjlh3xw2P9sEbC_... (flutter/flutter#192212)
2026-09-03 [email protected] Roll Skia from ae22da2e8308 to 823f82e18177 (13 revisions) (flutter/flutter#192209)
2026-09-02 [email protected] Expose skipTraversal in FocusableActionDetector (flutter/flutter#191308)
2026-09-02 [email protected] Add `IsProgram` mock method to `MockGLESImpl`, use it in `BufferBindingsGLESTest` (flutter/flutter#192196)
2026-09-02 [email protected] Fix nested scroll view fling crash (flutter/flutter#191130)
2026-09-02 [email protected] Fix TabBarView/PageView edge auto-scroll during mouse text selection (flutter/flutter#189544)
2026-09-02 [email protected] Bypass gamma correction when alpha >= 1.0 (flutter/flutter#192193)
...
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
@engine-flutter-autoroll @victorsanni
Manual roll Flutter from 70797e15325e to 5a6cfa7f3d26 (52 revisions) (f…
84e4c44 
…lutter#12760)

Manual roll Flutter from 70797e15325e to 5a6cfa7f3d26 (52 revisions)

Manual roll requested by [email protected]

flutter/flutter@70797e1...5a6cfa7

2026-09-04 [email protected] [tool] Migrate ScreenshotCommand to modular dependency injection (flutter/flutter#190767)
2026-09-04 [email protected] Roll Skia from 8fce167bdded to 93ac1e630d1d (3 revisions) (flutter/flutter#192306)
2026-09-04 [email protected] Add iOS Universal Link integration test (Simulator) (flutter/flutter#191443)
2026-09-04 [email protected] [AGP 9.1.0 Migration flutter#5] Delete getLegacyAndroidExtension and migrate NDK fallback to public DSL (flutter/flutter#192116)
2026-09-04 [email protected] Reland "[tool_tests] Remove bringup from Windows tool_tests_commands_2_2" (#191732) (flutter/flutter#191802)
2026-09-04 [email protected] [flutter_tools] Fix unhandled DebugAdapterException on early process termination (flutter/flutter#192294)
2026-09-04 [email protected] Roll Packages from f9b3954 to 9af9c60 (4 revisions) (flutter/flutter#192292)
2026-09-04 [email protected] Roll Skia from 2e3f7e07eee6 to 8fce167bdded (5 revisions) (flutter/flutter#192283)
2026-09-04 [email protected] Roll Fuchsia Linux SDK from GTZNkoIR_WegRPWgL... to FgDQeF6jb1dVRVh3K... (flutter/flutter#192276)
2026-09-04 [email protected] Roll Skia from b6b00df360e5 to 2e3f7e07eee6 (2 revisions) (flutter/flutter#192275)
2026-09-04 [email protected] [iOS] TextField should support typing accented words with external keyboard (flutter/flutter#191062)
2026-09-04 [email protected] Roll Skia from 1f68c0b16f17 to b6b00df360e5 (7 revisions) (flutter/flutter#192269)
2026-09-04 [email protected] [flutter_tools] add typed enum and defaulted option descriptors (flutter/flutter#191760)
2026-09-04 [email protected] Roll Dart SDK from c2edc382a4f8 to 5501d02b583d (1 revision) (flutter/flutter#192263)
2026-09-04 [email protected] [Linux] Use fences to synchronize frames between OpenGL contexts (flutter/flutter#192098)
2026-09-03 [email protected] Defer semantics geometry updates for blocked branches (flutter/flutter#192146)
2026-09-03 [email protected] Roll Skia from 8d3e197531c6 to 1f68c0b16f17 (8 revisions) (flutter/flutter#192244)
2026-09-03 [email protected] Fix DeleteSurrounding splitting UTF-16 surrogate pairs (flutter/flutter#190514)
2026-09-03 [email protected] Remove no-shuffle from progress indicator test (flutter/flutter#186655)
2026-09-03 [email protected] [material] Remove unused parameters from constructors of generic test class (flutter/flutter#191764)
2026-09-03 [email protected] Handle linear and radial gradients in UberSDF (re-implement after fix) (flutter/flutter#192124)
2026-09-03 [email protected] Roll Dart SDK from fcbfb64f42a1 to c2edc382a4f8 (2 revisions) (flutter/flutter#192240)
2026-09-03 [email protected] Fix parsing of --enable-hcpp-and-surface-control switch and add --no-enable-hcpp tests (flutter/flutter#192202)
2026-09-03 [email protected] Fix issue where shapes rendered with gradient+blur+rotation end up incorrectly cut off (flutter/flutter#192136)
2026-09-03 [email protected] Fix sibling nodes crash under MergeSemantics (flutter/flutter#191587)
2026-09-03 [email protected] Makes backdrop groups operate on the union. (flutter/flutter#191838)
2026-09-03 [email protected] Roll Skia from 008936396810 to 8d3e197531c6 (1 revision) (flutter/flutter#192236)
2026-09-03 [email protected] [docs] Remove superseded AI rules for Flutter (flutter/flutter#192185)
2026-09-03 [email protected] Collect analytics about SwiftPM errors and warnings (flutter/flutter#191746)
2026-09-03 [email protected] Roll Packages from 18fe786 to f9b3954 (7 revisions) (flutter/flutter#192235)
2026-09-03 [email protected] [Linux] Remove frame sharing between OpenGL contexts (flutter/flutter#192150)
2026-09-03 [email protected] Roll Dart SDK from cf79067a1e44 to fcbfb64f42a1 (1 revision) (flutter/flutter#192228)
2026-09-03 [email protected] Roll Skia from 731fe9af4c0b to 008936396810 (3 revisions) (flutter/flutter#192225)
2026-09-03 [email protected] Roll Dart SDK from 700ab60bfe53 to cf79067a1e44 (2 revisions) (flutter/flutter#192219)
2026-09-03 [email protected] Roll Skia from 823f82e18177 to 731fe9af4c0b (5 revisions) (flutter/flutter#192217)
2026-09-03 [email protected] Fixes OverlayPortal semantics bounds corruption (flutter/flutter#192139)
2026-09-03 [email protected] Roll Fuchsia Linux SDK from idslm9FikVLy2K_A-... to GTZNkoIR_WegRPWgL... (flutter/flutter#192215)
2026-09-03 [email protected] Roll Fuchsia Test Scripts from u_fSMsPU22VvUsvSo... to VObjlh3xw2P9sEbC_... (flutter/flutter#192212)
2026-09-03 [email protected] Roll Skia from ae22da2e8308 to 823f82e18177 (13 revisions) (flutter/flutter#192209)
2026-09-02 [email protected] Expose skipTraversal in FocusableActionDetector (flutter/flutter#191308)
2026-09-02 [email protected] Add `IsProgram` mock method to `MockGLESImpl`, use it in `BufferBindingsGLESTest` (flutter/flutter#192196)
2026-09-02 [email protected] Fix nested scroll view fling crash (flutter/flutter#191130)
2026-09-02 [email protected] Fix TabBarView/PageView edge auto-scroll during mouse text selection (flutter/flutter#189544)
2026-09-02 [email protected] Bypass gamma correction when alpha >= 1.0 (flutter/flutter#192193)
...
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
@engine-flutter-autoroll @victorsanni
Manual roll Flutter from 70797e15325e to 5a6cfa7f3d26 (52 revisions) (f…
899882f 
…lutter#12760)

Manual roll Flutter from 70797e15325e to 5a6cfa7f3d26 (52 revisions)

Manual roll requested by [email protected]

flutter/flutter@70797e1...5a6cfa7

2026-09-04 [email protected] [tool] Migrate ScreenshotCommand to modular dependency injection (flutter/flutter#190767)
2026-09-04 [email protected] Roll Skia from 8fce167bdded to 93ac1e630d1d (3 revisions) (flutter/flutter#192306)
2026-09-04 [email protected] Add iOS Universal Link integration test (Simulator) (flutter/flutter#191443)
2026-09-04 [email protected] [AGP 9.1.0 Migration flutter#5] Delete getLegacyAndroidExtension and migrate NDK fallback to public DSL (flutter/flutter#192116)
2026-09-04 [email protected] Reland "[tool_tests] Remove bringup from Windows tool_tests_commands_2_2" (#191732) (flutter/flutter#191802)
2026-09-04 [email protected] [flutter_tools] Fix unhandled DebugAdapterException on early process termination (flutter/flutter#192294)
2026-09-04 [email protected] Roll Packages from f9b3954 to 9af9c60 (4 revisions) (flutter/flutter#192292)
2026-09-04 [email protected] Roll Skia from 2e3f7e07eee6 to 8fce167bdded (5 revisions) (flutter/flutter#192283)
2026-09-04 [email protected] Roll Fuchsia Linux SDK from GTZNkoIR_WegRPWgL... to FgDQeF6jb1dVRVh3K... (flutter/flutter#192276)
2026-09-04 [email protected] Roll Skia from b6b00df360e5 to 2e3f7e07eee6 (2 revisions) (flutter/flutter#192275)
2026-09-04 [email protected] [iOS] TextField should support typing accented words with external keyboard (flutter/flutter#191062)
2026-09-04 [email protected] Roll Skia from 1f68c0b16f17 to b6b00df360e5 (7 revisions) (flutter/flutter#192269)
2026-09-04 [email protected] [flutter_tools] add typed enum and defaulted option descriptors (flutter/flutter#191760)
2026-09-04 [email protected] Roll Dart SDK from c2edc382a4f8 to 5501d02b583d (1 revision) (flutter/flutter#192263)
2026-09-04 [email protected] [Linux] Use fences to synchronize frames between OpenGL contexts (flutter/flutter#192098)
2026-09-03 [email protected] Defer semantics geometry updates for blocked branches (flutter/flutter#192146)
2026-09-03 [email protected] Roll Skia from 8d3e197531c6 to 1f68c0b16f17 (8 revisions) (flutter/flutter#192244)
2026-09-03 [email protected] Fix DeleteSurrounding splitting UTF-16 surrogate pairs (flutter/flutter#190514)
2026-09-03 [email protected] Remove no-shuffle from progress indicator test (flutter/flutter#186655)
2026-09-03 [email protected] [material] Remove unused parameters from constructors of generic test class (flutter/flutter#191764)
2026-09-03 [email protected] Handle linear and radial gradients in UberSDF (re-implement after fix) (flutter/flutter#192124)
2026-09-03 [email protected] Roll Dart SDK from fcbfb64f42a1 to c2edc382a4f8 (2 revisions) (flutter/flutter#192240)
2026-09-03 [email protected] Fix parsing of --enable-hcpp-and-surface-control switch and add --no-enable-hcpp tests (flutter/flutter#192202)
2026-09-03 [email protected] Fix issue where shapes rendered with gradient+blur+rotation end up incorrectly cut off (flutter/flutter#192136)
2026-09-03 [email protected] Fix sibling nodes crash under MergeSemantics (flutter/flutter#191587)
2026-09-03 [email protected] Makes backdrop groups operate on the union. (flutter/flutter#191838)
2026-09-03 [email protected] Roll Skia from 008936396810 to 8d3e197531c6 (1 revision) (flutter/flutter#192236)
2026-09-03 [email protected] [docs] Remove superseded AI rules for Flutter (flutter/flutter#192185)
2026-09-03 [email protected] Collect analytics about SwiftPM errors and warnings (flutter/flutter#191746)
2026-09-03 [email protected] Roll Packages from 18fe786 to f9b3954 (7 revisions) (flutter/flutter#192235)
2026-09-03 [email protected] [Linux] Remove frame sharing between OpenGL contexts (flutter/flutter#192150)
2026-09-03 [email protected] Roll Dart SDK from cf79067a1e44 to fcbfb64f42a1 (1 revision) (flutter/flutter#192228)
2026-09-03 [email protected] Roll Skia from 731fe9af4c0b to 008936396810 (3 revisions) (flutter/flutter#192225)
2026-09-03 [email protected] Roll Dart SDK from 700ab60bfe53 to cf79067a1e44 (2 revisions) (flutter/flutter#192219)
2026-09-03 [email protected] Roll Skia from 823f82e18177 to 731fe9af4c0b (5 revisions) (flutter/flutter#192217)
2026-09-03 [email protected] Fixes OverlayPortal semantics bounds corruption (flutter/flutter#192139)
2026-09-03 [email protected] Roll Fuchsia Linux SDK from idslm9FikVLy2K_A-... to GTZNkoIR_WegRPWgL... (flutter/flutter#192215)
2026-09-03 [email protected] Roll Fuchsia Test Scripts from u_fSMsPU22VvUsvSo... to VObjlh3xw2P9sEbC_... (flutter/flutter#192212)
2026-09-03 [email protected] Roll Skia from ae22da2e8308 to 823f82e18177 (13 revisions) (flutter/flutter#192209)
2026-09-02 [email protected] Expose skipTraversal in FocusableActionDetector (flutter/flutter#191308)
2026-09-02 [email protected] Add `IsProgram` mock method to `MockGLESImpl`, use it in `BufferBindingsGLESTest` (flutter/flutter#192196)
2026-09-02 [email protected] Fix nested scroll view fling crash (flutter/flutter#191130)
2026-09-02 [email protected] Fix TabBarView/PageView edge auto-scroll during mouse text selection (flutter/flutter#189544)
2026-09-02 [email protected] Bypass gamma correction when alpha >= 1.0 (flutter/flutter#192193)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes
@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems CICD Run CI/CD engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Linux] App aborts with wstring_convert: to_bytes error when typing with an IME — TextInputModel::DeleteSurrounding splits UTF-16 surrogate pairs

4 participants

@Vi-debug @LongCatIsLooong @Renzo-Olivares @justinmc