Repository navigation
Fix Wasm build cache mismatch in ResidentWebRunner and browser 404 fallbacks - #190786
Merged
Merged
Conversation
github-actions
Bot
added
the
tool
kevmoo
commented
Aug 8, 2026
kevmoo
changed the title
kevmoo
marked this pull request as ready for review
August 8, 2026 20:38
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates ReleaseAssetServer to return a 404 status for missing static web assets (such as .wasm, .mjs, .js, assets/, and canvaskit/) instead of falling back to index.html, and ensures index.html exists before serving it. It also refactors ResidentWebRunner to use default compiler options for WasmCompilerConfig to maintain cache key parity, and adds corresponding tests. Feedback suggests optimizing and robustifying the path matching logic in ReleaseAssetServer to avoid fragile pattern matching on split path segments and reduce string allocations.
Contributor
Author
|
Sorry. Need to investigate the default here. |
ResidentWebRunner explicitly hardcoded WasmCompilerConfig optimizationLevel and stripWasm values, preventing dynamic defaulting and creating cache key mismatches with `flutter build web --wasm` which lead to duplicated recompilations. Additionally, ReleaseAssetServer returned index.html (200 OK) for missing static assets instead of 404 Not Found, causing browser Wasm instantiation syntax errors. * Delete explicit optimizationLevel and stripWasm values in ResidentWebRunner _compilerConfig. * Update ReleaseAssetServer to return 404 Not Found for missing static file requests (.wasm, .mjs, .js, assets/, canvaskit/) using URL path segment pattern matching while preserving SPA index.html fallback for client-side navigation routes. * Update unit tests in resident_web_runner_test to verify dynamic cache-equivalent defaults. * Add unit tests in web_asset_server_test verifying 404 responses for missing assets and 200 responses for SPA navigation routes.
kevmoo
marked this pull request as ready for review
September 4, 2026 22:51
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the release asset server to return a 404 Not Found for missing static assets (such as those under assets/ or canvaskit/, and files ending in .wasm, .mjs, or .js) and simplifies WasmCompilerConfig instantiation in ResidentWebRunner. Feedback points out that exact match checks for assets and canvaskit will break client-side SPA routing by returning a 404 instead of falling back to index.html. Additionally, the feedback suggests expanding the list of checked static file extensions to include common types like .css and .json to avoid console errors, and adding tests to cover these routing fallbacks.
mdebbar
previously approved these changes
Sep 10, 2026
mdebbar
approved these changes
Sep 10, 2026
auto-submit
Bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/190786, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Sep 11, 2026
This was referenced Sep 12, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 12, 2026
Roll Flutter from 63b9518f16bc to 2553f89be1ef (62 revisions) flutter/flutter@63b9518...2553f89 2026-09-12 [email protected] Roll clang to 07d67299a15ce03b053736e2d31a668ee0576987 (flutter/flutter#192607) 2026-09-12 [email protected] Roll Dart SDK from b24b352c29db to 7863887acbfb (3 revisions) (flutter/flutter#192665) 2026-09-12 [email protected] fix(tree): et format --all (flutter/flutter#192669) 2026-09-12 [email protected] Support activity-alias in Android launcher activity detection (flutter/flutter#187251) 2026-09-12 [email protected] fix: regenerate gradle lockfiles for external_textures integration test (flutter/flutter#192657) 2026-09-12 [email protected] Roll Skia from 51aa02b2c195 to e5e96533b732 (4 revisions) (flutter/flutter#192646) 2026-09-12 [email protected] [WebParagraph] Fix text pixelation, glyph clipping, and snapping offsets to avoid subpixel raster caching (flutter/flutter#191736) 2026-09-12 [email protected] fix(tests): Add ruby dep to Mac windowing_test (flutter/flutter#192656) 2026-09-12 [email protected] Remove some `unawaited_futures` outdated ignores (flutter/flutter#192026) 2026-09-11 [email protected] Bump Dart to 3.13, reformat, re-enable formatting check (flutter/flutter#192649) 2026-09-11 [email protected] [android] Isolate API-34 high contrast listener in AccessibilityBridge behind Api34Impl (flutter/flutter#192502) 2026-09-11 [email protected] Update style guide for Dart 3.13 (flutter/flutter#192639) 2026-09-11 [email protected] ci(bringups): remove bringup from these tests (flutter/flutter#192637) 2026-09-11 [email protected] Unmark new_gallery_windows_impeller__transition_perf as bringup (flutter/flutter#192633) 2026-09-11 [email protected] Unmark new_gallery_windows_skia__transition_perf as bringup (flutter/flutter#192635) 2026-09-11 [email protected] Roll Skia from f446aec4ce9e to 51aa02b2c195 (2 revisions) (flutter/flutter#192631) 2026-09-11 [email protected] fix(ci): mac verify binaries still racing (flutter/flutter#192634) 2026-09-11 [email protected] Roll Packages from 8a35b16 to 9caa77c (8 revisions) (flutter/flutter#192630) 2026-09-11 [email protected] Roll Dart SDK from a76fee2722e0 to b24b352c29db (2 revisions) (flutter/flutter#192627) 2026-09-11 [email protected] [tool] Migrate PackagesCommand and Pub to modular dependency injection (flutter/flutter#192460) 2026-09-11 [email protected] [tool] Migrate Darwin framework commands to modular dependency injection (flutter/flutter#192252) 2026-09-11 [email protected] [tool] Migrate Upgrade, Downgrade, and UpdatePackages commands to modular dependency injection (flutter/flutter#190787) 2026-09-11 [email protected] Roll Skia from b3fa80a0e168 to f446aec4ce9e (55 revisions) (flutter/flutter#192620) 2026-09-11 [email protected] Roll Dart SDK from d20d59cfa664 to a76fee2722e0 (2 revisions) (flutter/flutter#192616) 2026-09-11 [email protected] remove deeplink integration tests from bringup (flutter/flutter#192459) 2026-09-11 [email protected] Revert: [devicelab] Clean up Chrome profile directories and trap abort signals in web benchmarks (flutter/flutter#192615) 2026-09-11 [email protected] Roll Fuchsia Linux SDK from C0j8F-_Iy-OQZ6YyI... to m69nfK-wnHaMTe8P9... (flutter/flutter#192608) 2026-09-11 [email protected] Fix Wasm build cache mismatch in ResidentWebRunner and browser 404 fallbacks (flutter/flutter#190786) 2026-09-11 [email protected] Roll Dart SDK from 3ce3116bc9ec to d20d59cfa664 (1 revision) (flutter/flutter#192588) 2026-09-11 [email protected] [Linux] Keep the frame at the top of a resizing subsurface (flutter/flutter#192408) 2026-09-10 [email protected] [devicelab] Clean up Chrome profile directories and trap abort signals in web benchmarks (flutter/flutter#192584) 2026-09-10 [email protected] [web] Keep ImageSource alive until Picture disposal (flutter/flutter#192516) 2026-09-10 [email protected] Remove the accessibility evaluations feature flag (flutter/flutter#192266) 2026-09-10 [email protected] Promote Windows gradient benchmark tests to non-bringup (flutter/flutter#192581) 2026-09-10 [email protected] Remove commented out export in `text_input.dart` since the dart compiler has the correct behavior now (flutter/flutter#191539) 2026-09-10 [email protected] [flutter_tools] Do not mistake server-initiated requests for responses to client requests in AnalysisServer (flutter/flutter#192546) 2026-09-10 [email protected] Roll Packages from 36e088a to 8a35b16 (12 revisions) (flutter/flutter#192550) 2026-09-10 [email protected] Roll pub packages (flutter/flutter#192517) 2026-09-10 [email protected] feat(web): support --web-content-hash for entrypoint files (flutter/flutter#190153) 2026-09-10 [email protected] [web] Stop iOS auto-zoom by sizing semantic inputs at 16px (flutter/flutter#192328) 2026-09-10 [email protected] Roll Dart SDK from 0d55b7a6a9ee to 3ce3116bc9ec (2 revisions) (flutter/flutter#192534) 2026-09-10 [email protected] Update more enum instances comparison to use equality == since dart has the correct behavior now (flutter/flutter#191788) 2026-09-10 [email protected] Fix specify_nonobvious_local_variable_types lints in luci_resultdb_test.dart (flutter/flutter#192543) 2026-09-10 [email protected] Roll ICU from 8cc91d9b6ab9 to 6ebb40c59477 (1 revision) (flutter/flutter#192527) 2026-09-10 [email protected] [Linux] Make the framebuffer depth/stencil buffer optional (flutter/flutter#192156) 2026-09-10 [email protected] [Linux] Cancel input when events stop being delivered (flutter/flutter#192277) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves unnecessary Wasm recompilations during
flutter runby removing hardcoded compiler variables that mismatched withflutter build, and ensures missing web assets correctly return HTTP 404s to prevent browser instantiation crashes.Specifically:
optimizationLevelandstripWasmdefaults inResidentWebRunner'sWasmCompilerConfig. This allows it to gracefully inherit dynamic defaults downstream, achieving cache key parity withflutter build web --wasm.ReleaseAssetServerto properly return404 Not Foundfor missing static file requests (.wasm,.mjs,.js,assets/,canvaskit/) instead of servingindex.html. This prevents obscureWebAssembly.instantiatesyntax errors in the browser when caching or compilation pipelines fail to produce an artifact.Related to #67053.