Repository navigation
[tool] Migrate TestCompiler and WebTestCompiler to modular dependency injection - #192923
Merged
Merged
Conversation
bkonyi
added
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors TestCompiler and WebTestCompiler to accept a ToolContext parameter, facilitating dependency injection and improving testability by reducing reliance on global variables. The review feedback suggests simplifying the WebTestCompiler constructor by making artifacts nullable to eliminate the custom sentinel class, avoiding redundant fallback context evaluations in TestCompiler by handling nullable contexts internally within _computeTestFilePath, and making the _FallbackToolContext constructor const.
Comment on lines
+149
to
+154
| static String _computeTestFilePath( | ||
| ToolContext toolContext, | ||
| FlutterProject? flutterProject, | ||
| BuildInfo buildInfo, | ||
| ) { | ||
| final ToolContext(:Config config, :FileSystem fs) = toolContext; |
Contributor
There was a problem hiding this comment.
Update _computeTestFilePath to accept a nullable ToolContext? and fall back to const _FallbackToolContext() internally. This simplifies the call site in the constructor.
Suggested change
| static String _computeTestFilePath( | |
| ToolContext toolContext, | |
| FlutterProject? flutterProject, | |
| BuildInfo buildInfo, | |
| ) { | |
| final ToolContext(:Config config, :FileSystem fs) = toolContext; | |
| static String _computeTestFilePath( | |
| ToolContext? toolContext, | |
| FlutterProject? flutterProject, | |
| BuildInfo buildInfo, | |
| ) { | |
| final ToolContext context = toolContext ?? const _FallbackToolContext(); | |
| final ToolContext(:Config config, :FileSystem fs) = context; |
This was referenced Sep 17, 2026
dcharkes
previously approved these changes
Sep 17, 2026
| fileSystem: fs, | ||
| shutdownHooks: shutdownHooks, | ||
| config: config, | ||
| targetPlatform: TargetPlatform.tester, |
Contributor
There was a problem hiding this comment.
spurious change because AI does not know shorthands?
Contributor
Author
There was a problem hiding this comment.
It does know about it, but chose to ignore it. Switch this back to use a dot shorthand.
dcharkes
approved these changes
Sep 17, 2026
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Sep 18, 2026
pull Bot
pushed a commit
to fucheng-guo-sun/flutter
that referenced
this pull request
Sep 25, 2026
…tter#192924) ## Description This pull request migrates `CoverageCollector` in `flutter_tools` to modular dependency injection using `ToolContext`. This is Layer 21b in the modular dependency injection migration for the testing subsystem (stacked on Layer 21a [flutter#192923](flutter#192923)). ### Fork Compare Link * Compare: bkonyi/flutter@master...di/21b-coverage-collector Part of [flutter#188471](flutter#188471). ## Tests * `test/general.shard/coverage_collector_test.dart`
DanTup
pushed a commit
to DanTup/flutter
that referenced
this pull request
Sep 28, 2026
…tter#192924) ## Description This pull request migrates `CoverageCollector` in `flutter_tools` to modular dependency injection using `ToolContext`. This is Layer 21b in the modular dependency injection migration for the testing subsystem (stacked on Layer 21a [flutter#192923](flutter#192923)). ### Fork Compare Link * Compare: bkonyi/flutter@master...di/21b-coverage-collector Part of [flutter#188471](flutter#188471). ## Tests * `test/general.shard/coverage_collector_test.dart`
DanTup
pushed a commit
to DanTup/flutter
that referenced
this pull request
Sep 28, 2026
…tter#192924) ## Description This pull request migrates `CoverageCollector` in `flutter_tools` to modular dependency injection using `ToolContext`. This is Layer 21b in the modular dependency injection migration for the testing subsystem (stacked on Layer 21a [flutter#192923](flutter#192923)). ### Fork Compare Link * Compare: bkonyi/flutter@master...di/21b-coverage-collector Part of [flutter#188471](flutter#188471). ## Tests * `test/general.shard/coverage_collector_test.dart`
pull Bot
pushed a commit
to TheRakeshPurohit/flutter
that referenced
this pull request
Sep 30, 2026
…injection (flutter#190789) ## Description This pull request migrates `TestCommand`, `FlutterTestRunner`, `FlutterPlatform`, `FlutterWebPlatform`, and `TestGoldenComparator` to modular dependency injection using `ToolContext`. This is Layer 21c in the modular dependency injection migration for the testing subsystem (Layer 21a [flutter#192923](flutter#192923) and Layer 21b [flutter#192924](flutter#192924) have merged into `master`). ### Fork Compare Link * Compare: bkonyi/flutter@master...di/21-testing-subsystem Part of [flutter#188471](flutter#188471). ## Tests * `test/commands.shard/hermetic/test_test.dart` * `test/general.shard/flutter_platform_test.dart` * `test/commands.shard/hermetic/flutter_web_platform_test.dart` * `test/general.shard/test/test_golden_comparator_test.dart` * `test/integration.shard/test_golden_comparator_test.dart`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request migrates
TestCompilerandWebTestCompilerinflutter_toolsto modular dependency injection usingToolContext.This is Layer 21a in the modular dependency injection migration for the testing subsystem.
Fork Compare Link
Tests
test/general.shard/test/test_compiler_test.darttest/general.shard/test/web_test_compiler_test.dart