Repository navigation
[tool] Migrate CoverageCollector to modular dependency injection - #192924
Merged
auto-submit[bot] merged 15 commits intoSep 25, 2026
Merged
Conversation
bkonyi
added
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors test-related classes, including CoverageCollector, TestCompiler, TestGoldenComparator, and WebTestCompiler, to accept a ToolContext parameter, reducing direct dependencies on global variables and improving test isolation. Corresponding tests are updated to inject fake or delegating tool contexts. The review feedback suggests simplifying the WebTestCompiler constructor by making the artifacts parameter nullable, and optimizing _FallbackToolContext in TestCompiler by making its constructor const to allow compile-time constant instantiation.
…in test compilers
…lector # Conflicts: # packages/flutter_tools/lib/src/test/test_compiler.dart
bkonyi
changed the title
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
dcharkes
approved these changes
Sep 21, 2026
bkonyi
added
autosubmit
bkonyi
added
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
This was referenced Sep 26, 2026
DanTup
pushed a commit
to DanTup/flutter
that referenced
this pull request
Sep 28, 2026
…tter#192924) ## Description This pull request migrates `CoverageCollector` in `flutter_tools` to modular dependency injection using `ToolContext`. This is Layer 21b in the modular dependency injection migration for the testing subsystem (stacked on Layer 21a [flutter#192923](flutter#192923)). ### Fork Compare Link * Compare: bkonyi/flutter@master...di/21b-coverage-collector Part of [flutter#188471](flutter#188471). ## Tests * `test/general.shard/coverage_collector_test.dart`
This was referenced Sep 28, 2026
DanTup
pushed a commit
to DanTup/flutter
that referenced
this pull request
Sep 28, 2026
…tter#192924) ## Description This pull request migrates `CoverageCollector` in `flutter_tools` to modular dependency injection using `ToolContext`. This is Layer 21b in the modular dependency injection migration for the testing subsystem (stacked on Layer 21a [flutter#192923](flutter#192923)). ### Fork Compare Link * Compare: bkonyi/flutter@master...di/21b-coverage-collector Part of [flutter#188471](flutter#188471). ## Tests * `test/general.shard/coverage_collector_test.dart`
This was referenced Sep 28, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 29, 2026
…#13060) Manual roll Flutter from 4fcd90be0045 to c5a061b18fa2 (222 revisions) Manual roll requested by [email protected] flutter/flutter@4fcd90b...c5a061b 2026-09-28 [email protected] [cross imports] navigator_test.dart (flutter/flutter#190954) 2026-09-28 [email protected] Revert: Reland: Only render views that need to be rendered (flutter/flutter#193360) 2026-09-28 [email protected] ci(bringup): android_intent_security_test is green (flutter/flutter#193469) 2026-09-28 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#193020) 2026-09-28 [email protected] Roll Fuchsia Linux SDK from ukukV5lEkKabtOATk... to QdgqP02_cYpRQQQNN... (flutter/flutter#193454) 2026-09-28 [email protected] Roll pub packages (flutter/flutter#193460) 2026-09-28 [email protected] Un-nest sceneBuildDuration and windowRenderDuration in web SceneBuilderRecorder (flutter/flutter#193260) 2026-09-28 [email protected] Fix unresolved doc comment references in dev/integration_tests and dev/benchmarks (flutter/flutter#193433) 2026-09-28 [email protected] Roll Packages from e55e7ac to ba0364a (9 revisions) (flutter/flutter#193450) 2026-09-28 [email protected] [tool] Require explicit dependency injection for FlutterDevice and FlutterDevice.create (flutter/flutter#192830) 2026-09-28 [email protected] Roll pub packages (flutter/flutter#193442) 2026-09-28 [email protected] [flutter_tools] Include data assets from hooks when pubspec.yaml is empty (flutter/flutter#193434) 2026-09-28 [email protected] Roll pub packages (flutter/flutter#193438) 2026-09-28 [email protected] Fix unresolved doc comment references in Material and Cupertino (flutter/flutter#193283) 2026-09-28 [email protected] Fix doc references to Material and Cupertino in the widgets library and its tests (flutter/flutter#193334) 2026-09-26 [email protected] wasm: enforce WasmGC opt-in capability checks and Firefox < 147 guard (flutter/flutter#193180) 2026-09-26 [email protected] [Android] Refuse external setters of engine entrypoint and cached engine arguments via `Intent`s (flutter/flutter#190249) 2026-09-26 [email protected] [web] Unskip TextPainter.getWordBoundary test (flutter/flutter#193378) 2026-09-26 [email protected] Specify non-obvious types in pattern variable declarations (flutter/flutter#192632) 2026-09-26 [email protected] Removes feedback loop from advanced filters without offscreen msaa and framebufferfetch (flutter/flutter#193306) 2026-09-26 [email protected] [web] Unskip 8 passing image tests in painting and rendering (flutter/flutter#193377) 2026-09-26 [email protected] Revert: Allow resetting test invariants in `addTearDown` (flutter/flutter#193383) 2026-09-25 [email protected] [tool] Migrate CoverageCollector to modular dependency injection (flutter/flutter#192924) 2026-09-25 [email protected] Fix more unresolved doc comment references (flutter/flutter#193336) 2026-09-25 [email protected] Allow resetting test invariants in `addTearDown` (flutter/flutter#192082) 2026-09-25 [email protected] [a11y] Add a semantics role for slider (flutter/flutter#193324) 2026-09-25 [email protected] Fix plugin tests after Pigeon plugin template changes (flutter/flutter#193302) 2026-09-25 [email protected] [Android 17] Bump Standard Test Apps in flutter/flutter to AGP 9.3.1 (flutter/flutter#193263) 2026-09-25 [email protected] SSBO-based gradients in UberSDF (flutter/flutter#192962) 2026-09-25 [email protected] [Linux] Handle FlView being destroyed before rendering is complete. (flutter/flutter#193268) 2026-09-25 [email protected] [flutter_tools] Handle Windows reserved characters in test target path (flutter/flutter#191900) 2026-09-25 [email protected] docs(tools): nit: say hook/build.dart in CMake native assets comment (flutter/flutter#192205) 2026-09-25 [email protected] [web] Enable Firefox Skwasm UI CI suites, configure COI configs, and fail fast on loader rejections (flutter/flutter#193187) 2026-09-25 [email protected] [Android 17] Bumped Engine Dependencies to 9.3.1 (flutter/flutter#193265) 2026-09-25 [email protected] [web] Omit group role on menu scrollables and assign region role to named routes (flutter/flutter#192965) 2026-09-25 [email protected] Roll Skia from 8eedeed98e79 to f441ca223b2b (5 revisions) (flutter/flutter#193353) 2026-09-25 [email protected] Roll Fuchsia Linux SDK from EbPpoJW-Lnsu-8dyZ... to ukukV5lEkKabtOATk... (flutter/flutter#193326) 2026-09-25 [email protected] Roll Packages from 431ea69 to e55e7ac (6 revisions) (flutter/flutter#193351) 2026-09-25 [email protected] Support DynamicLibrary.codeAsset in Flutter (flutter/flutter#188947) 2026-09-25 [email protected] Roll Dart SDK from 75d9e87d4e3d to 0e7642b85457 (1 revision) (flutter/flutter#193346) 2026-09-25 [email protected] Exclude iOS PRs from macOS link (flutter/flutter#193315) 2026-09-25 [email protected] Roll Skia from 6357608543ec to 8eedeed98e79 (4 revisions) (flutter/flutter#193341) 2026-09-25 [email protected] Roll Dart SDK from d3aedb186aab to 75d9e87d4e3d (3 revisions) (flutter/flutter#193335) 2026-09-25 [email protected] Cache the paint offset adjusted line metrics in TextPainter (flutter/flutter#191223) ...
pull Bot
pushed a commit
to TheRakeshPurohit/flutter
that referenced
this pull request
Sep 30, 2026
…injection (flutter#190789) ## Description This pull request migrates `TestCommand`, `FlutterTestRunner`, `FlutterPlatform`, `FlutterWebPlatform`, and `TestGoldenComparator` to modular dependency injection using `ToolContext`. This is Layer 21c in the modular dependency injection migration for the testing subsystem (Layer 21a [flutter#192923](flutter#192923) and Layer 21b [flutter#192924](flutter#192924) have merged into `master`). ### Fork Compare Link * Compare: bkonyi/flutter@master...di/21-testing-subsystem Part of [flutter#188471](flutter#188471). ## Tests * `test/commands.shard/hermetic/test_test.dart` * `test/general.shard/flutter_platform_test.dart` * `test/commands.shard/hermetic/flutter_web_platform_test.dart` * `test/general.shard/test/test_golden_comparator_test.dart` * `test/integration.shard/test_golden_comparator_test.dart`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request migrates
CoverageCollectorinflutter_toolsto modular dependency injection usingToolContext.This is Layer 21b in the modular dependency injection migration for the testing subsystem (stacked on Layer 21a #192923).
Fork Compare Link
Part of #188471.
Tests
test/general.shard/coverage_collector_test.dart