Repository navigation
[web] Unskip 8 passing image tests in painting and rendering - #193377
Merged
auto-submit[bot] merged 2 commits intoSep 26, 2026
Merged
auto-submit[bot] merged 2 commits into
auto-submit[bot] merged 2 commits into
Conversation
These tests were skipped on web (`skip: kIsWeb`) and now pass on Chrome, both with the default compiler and with `--wasm`: - painting/decoration_test.dart: `DecorationImage with null textDirection configuration should throw Error` (flutter#87364), plus 2 `DecorationImagePainter` image handle tests (flutter#87442). - painting/image_cache_test.dart: 2 image cache disposal tests (flutter#87442). - rendering/image_test.dart: 3 `RenderImage` disposal tests (flutter#87442). Also drops the `package:flutter/foundation.dart` import, which was only used for `kIsWeb`.
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the skip: kIsWeb parameter from several tests in decoration_test.dart, image_cache_test.dart, and image_test.dart, enabling these tests to run on the web platform. It also removes an unused import of package:flutter/foundation.dart from image_test.dart. There are no review comments, and I have no feedback to provide.
mdebbar
previously approved these changes
Sep 25, 2026
Contributor
There was a problem hiding this comment.
Unused import of package:flutter/foundation.dart
mdebbar
approved these changes
Sep 26, 2026
This was referenced Sep 26, 2026
DanTup
pushed a commit
to DanTup/flutter
that referenced
this pull request
Sep 28, 2026
…#193377) Unskips 8 tests across 3 framework test files that were skipped on web (`skip: kIsWeb`) and now pass on Chrome, both with the default compiler and with `--wasm`: - `packages/flutter/test/painting/decoration_test.dart` (3 skips removed): - Unskips `DecorationImage with null textDirection configuration should throw Error`, skipped for flutter#87364 (diagnostic numbers printing differently on web). - Unskips `DecorationImagePainter releases the placeholder once the image loads` and `DecorationImagePainter disposes of image when disposed`, skipped for flutter#87442 (`Image.debugGetOpenHandleStackTraces()` on web). - `packages/flutter/test/painting/image_cache_test.dart` (2 skips removed): - Unskips `Image is obtained and disposed of properly for cache` and its `when listener is still active` variant, skipped for flutter#87442. - `packages/flutter/test/rendering/image_test.dart` (3 skips removed): - Unskips `RenderImage disposes its image`, `RenderImage does not dispose its image if setting the same image twice`, and `Render image disposes its image when it is disposed`, skipped for flutter#87442. - Removes the `package:flutter/foundation.dart` import, which was only used for `kIsWeb`. Other web skips still reference both issues (`widgets/image_test.dart` for flutter#87442 and `material/app_bar_theme_test.dart` for flutter#87364), so this PR doesn't fully resolve either one. Related issues: - flutter#87364 - flutter#87442 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This was referenced Sep 28, 2026
DanTup
pushed a commit
to DanTup/flutter
that referenced
this pull request
Sep 28, 2026
…#193377) Unskips 8 tests across 3 framework test files that were skipped on web (`skip: kIsWeb`) and now pass on Chrome, both with the default compiler and with `--wasm`: - `packages/flutter/test/painting/decoration_test.dart` (3 skips removed): - Unskips `DecorationImage with null textDirection configuration should throw Error`, skipped for flutter#87364 (diagnostic numbers printing differently on web). - Unskips `DecorationImagePainter releases the placeholder once the image loads` and `DecorationImagePainter disposes of image when disposed`, skipped for flutter#87442 (`Image.debugGetOpenHandleStackTraces()` on web). - `packages/flutter/test/painting/image_cache_test.dart` (2 skips removed): - Unskips `Image is obtained and disposed of properly for cache` and its `when listener is still active` variant, skipped for flutter#87442. - `packages/flutter/test/rendering/image_test.dart` (3 skips removed): - Unskips `RenderImage disposes its image`, `RenderImage does not dispose its image if setting the same image twice`, and `Render image disposes its image when it is disposed`, skipped for flutter#87442. - Removes the `package:flutter/foundation.dart` import, which was only used for `kIsWeb`. Other web skips still reference both issues (`widgets/image_test.dart` for flutter#87442 and `material/app_bar_theme_test.dart` for flutter#87364), so this PR doesn't fully resolve either one. Related issues: - flutter#87364 - flutter#87442 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This was referenced Sep 28, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 29, 2026
…#13060) Manual roll Flutter from 4fcd90be0045 to c5a061b18fa2 (222 revisions) Manual roll requested by [email protected] flutter/flutter@4fcd90b...c5a061b 2026-09-28 [email protected] [cross imports] navigator_test.dart (flutter/flutter#190954) 2026-09-28 [email protected] Revert: Reland: Only render views that need to be rendered (flutter/flutter#193360) 2026-09-28 [email protected] ci(bringup): android_intent_security_test is green (flutter/flutter#193469) 2026-09-28 [email protected] Sync CHANGELOG.md from stable (flutter/flutter#193020) 2026-09-28 [email protected] Roll Fuchsia Linux SDK from ukukV5lEkKabtOATk... to QdgqP02_cYpRQQQNN... (flutter/flutter#193454) 2026-09-28 [email protected] Roll pub packages (flutter/flutter#193460) 2026-09-28 [email protected] Un-nest sceneBuildDuration and windowRenderDuration in web SceneBuilderRecorder (flutter/flutter#193260) 2026-09-28 [email protected] Fix unresolved doc comment references in dev/integration_tests and dev/benchmarks (flutter/flutter#193433) 2026-09-28 [email protected] Roll Packages from e55e7ac to ba0364a (9 revisions) (flutter/flutter#193450) 2026-09-28 [email protected] [tool] Require explicit dependency injection for FlutterDevice and FlutterDevice.create (flutter/flutter#192830) 2026-09-28 [email protected] Roll pub packages (flutter/flutter#193442) 2026-09-28 [email protected] [flutter_tools] Include data assets from hooks when pubspec.yaml is empty (flutter/flutter#193434) 2026-09-28 [email protected] Roll pub packages (flutter/flutter#193438) 2026-09-28 [email protected] Fix unresolved doc comment references in Material and Cupertino (flutter/flutter#193283) 2026-09-28 [email protected] Fix doc references to Material and Cupertino in the widgets library and its tests (flutter/flutter#193334) 2026-09-26 [email protected] wasm: enforce WasmGC opt-in capability checks and Firefox < 147 guard (flutter/flutter#193180) 2026-09-26 [email protected] [Android] Refuse external setters of engine entrypoint and cached engine arguments via `Intent`s (flutter/flutter#190249) 2026-09-26 [email protected] [web] Unskip TextPainter.getWordBoundary test (flutter/flutter#193378) 2026-09-26 [email protected] Specify non-obvious types in pattern variable declarations (flutter/flutter#192632) 2026-09-26 [email protected] Removes feedback loop from advanced filters without offscreen msaa and framebufferfetch (flutter/flutter#193306) 2026-09-26 [email protected] [web] Unskip 8 passing image tests in painting and rendering (flutter/flutter#193377) 2026-09-26 [email protected] Revert: Allow resetting test invariants in `addTearDown` (flutter/flutter#193383) 2026-09-25 [email protected] [tool] Migrate CoverageCollector to modular dependency injection (flutter/flutter#192924) 2026-09-25 [email protected] Fix more unresolved doc comment references (flutter/flutter#193336) 2026-09-25 [email protected] Allow resetting test invariants in `addTearDown` (flutter/flutter#192082) 2026-09-25 [email protected] [a11y] Add a semantics role for slider (flutter/flutter#193324) 2026-09-25 [email protected] Fix plugin tests after Pigeon plugin template changes (flutter/flutter#193302) 2026-09-25 [email protected] [Android 17] Bump Standard Test Apps in flutter/flutter to AGP 9.3.1 (flutter/flutter#193263) 2026-09-25 [email protected] SSBO-based gradients in UberSDF (flutter/flutter#192962) 2026-09-25 [email protected] [Linux] Handle FlView being destroyed before rendering is complete. (flutter/flutter#193268) 2026-09-25 [email protected] [flutter_tools] Handle Windows reserved characters in test target path (flutter/flutter#191900) 2026-09-25 [email protected] docs(tools): nit: say hook/build.dart in CMake native assets comment (flutter/flutter#192205) 2026-09-25 [email protected] [web] Enable Firefox Skwasm UI CI suites, configure COI configs, and fail fast on loader rejections (flutter/flutter#193187) 2026-09-25 [email protected] [Android 17] Bumped Engine Dependencies to 9.3.1 (flutter/flutter#193265) 2026-09-25 [email protected] [web] Omit group role on menu scrollables and assign region role to named routes (flutter/flutter#192965) 2026-09-25 [email protected] Roll Skia from 8eedeed98e79 to f441ca223b2b (5 revisions) (flutter/flutter#193353) 2026-09-25 [email protected] Roll Fuchsia Linux SDK from EbPpoJW-Lnsu-8dyZ... to ukukV5lEkKabtOATk... (flutter/flutter#193326) 2026-09-25 [email protected] Roll Packages from 431ea69 to e55e7ac (6 revisions) (flutter/flutter#193351) 2026-09-25 [email protected] Support DynamicLibrary.codeAsset in Flutter (flutter/flutter#188947) 2026-09-25 [email protected] Roll Dart SDK from 75d9e87d4e3d to 0e7642b85457 (1 revision) (flutter/flutter#193346) 2026-09-25 [email protected] Exclude iOS PRs from macOS link (flutter/flutter#193315) 2026-09-25 [email protected] Roll Skia from 6357608543ec to 8eedeed98e79 (4 revisions) (flutter/flutter#193341) 2026-09-25 [email protected] Roll Dart SDK from d3aedb186aab to 75d9e87d4e3d (3 revisions) (flutter/flutter#193335) 2026-09-25 [email protected] Cache the paint offset adjusted line metrics in TextPainter (flutter/flutter#191223) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unskips 8 tests across 3 framework test files that were skipped on web (
skip: kIsWeb) and now pass on Chrome, both with the default compiler and with--wasm:packages/flutter/test/painting/decoration_test.dart(3 skips removed):DecorationImage with null textDirection configuration should throw Error, skipped for Figure out a way to make diagnostic numbers print the same when running on the web. #87364 (diagnostic numbers printing differently on web).DecorationImagePainter releases the placeholder once the image loadsandDecorationImagePainter disposes of image when disposed, skipped for Image.debugGetOpenHandleStackTraces() not supported on the web. #87442 (Image.debugGetOpenHandleStackTraces()on web).packages/flutter/test/painting/image_cache_test.dart(2 skips removed):Image is obtained and disposed of properly for cacheand itswhen listener is still activevariant, skipped for Image.debugGetOpenHandleStackTraces() not supported on the web. #87442.packages/flutter/test/rendering/image_test.dart(3 skips removed):RenderImage disposes its image,RenderImage does not dispose its image if setting the same image twice, andRender image disposes its image when it is disposed, skipped for Image.debugGetOpenHandleStackTraces() not supported on the web. #87442.package:flutter/foundation.dartimport, which was only used forkIsWeb.Other web skips still reference both issues (
widgets/image_test.dartfor #87442 andmaterial/app_bar_theme_test.dartfor #87364), so this PR doesn't fully resolve either one.Related issues:
Pre-launch Checklist
///).