[web] Unskip 6 passing framework tests across painting and widgets by harryterkelsen · Pull Request #193171 · flutter/flutter

harryterkelsen · 2026-09-22T19:12:56Z

Unskips 6 tests across 3 core framework test files that were previously skipped on the web (skip: isBrowser / skip: kIsWeb) due to issues that have since been resolved (such as the removal of the HTML renderer and support for Path.combine and ImageFilter in CanvasKit/Skwasm):

packages/flutter/test/painting/notched_shapes_test.dart: Unskips 1 Path.combine test (Path.combine not implemented in the HTML backend #44572 — closed)
packages/flutter/test/painting/system_fonts_test.dart: Unskips 3 CupertinoDatePicker system font tests (Fix cupertino tests and enable them on CI in Web mode #41920 — closed)
packages/flutter/test/widgets/image_filter_test.dart: Unskips 2 ImageFilter.dilate / ImageFilter.erode golden tests (ImageFilter.dilate/ImageFilter.erode not supported on the web. #101874 — closed; verified 99.0%–100% pixel match locally on Chrome against the Linux Skia Gold baseline)

(Note: The cupertino and material test unskips originally included in this PR have been reverted here and split out to cupertino_ui and material_ui in flutter/packages per #188444.)

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

…ainting, and widgets Unskips 17 tests across 7 test files that were previously skipped on web (`skip: isBrowser` / `skip: kIsWeb`) due to issues that have since been resolved (such as HTML renderer removal and StrutStyle/ImageFilter support): - `test/cupertino/adaptive_text_selection_toolbar_test.dart`: Unskips 3 tests (flutter#108382, closed) - `test/cupertino/text_field_test.dart`: Unskips 3 strut style tests (flutter#32243, closed) - `test/material/bottom_app_bar_test.dart`: Unskips 2 custom shape golden tests (flutter#44572, closed; verified 99.8% pixel match against Linux Skia Gold baseline) - `test/material/text_field_test.dart`: Unskips 3 strut style tests (flutter#32243, closed) - `test/painting/notched_shapes_test.dart`: Unskips 1 Path.combine test (flutter#44572, closed) - `test/painting/system_fonts_test.dart`: Unskips 3 CupertinoDatePicker system font tests (flutter#41920, closed) - `test/widgets/image_filter_test.dart`: Unskips 2 ImageFilter.dilate/erode golden tests (flutter#101874, closed; verified 99.0%-100% pixel match against Linux Skia Gold baseline) TAG=agy CONV=2b17fd22-3b50-437d-bf9a-4077924956f1

gemini-code-assist

Code Review

This pull request removes the skip: isBrowser and skip: kIsWeb conditions, along with related TODO comments, from multiple test files across the Cupertino, Material, painting, and widgets packages, enabling these tests to run on web platforms. There are no review comments, and I have no feedback to provide.

github-actions · 2026-09-22T19:32:31Z

This pull request contains changes to Material or Cupertino, which are currently frozen in this repository.

Changes should be made in material_ui and/or cupertino_ui in the flutter/packages repository.

Please refer to #188444 for instructions.

Removing the trailing `skip:` argument lets `dart format` collapse these `testWidgets(...)` calls back into the standard trailing-closure style. TAG=agy CONV=2ef6722f-0cc3-4e2c-bfe0-769079846fee

The previous formatting commit was produced with a stale Dart SDK from an older checkout, which reflowed untouched code (e.g. the `FormatEditUpdateCallback` typedef) into the wrong style. This re-formats with the SDK matching this branch's engine hash, so the diff is now limited to the unskipped tests. TAG=agy CONV=2ef6722f-0cc3-4e2c-bfe0-769079846fee

flutter-dashboard · 2026-09-22T21:28:38Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #193171 at sha b11f6d0

…utter/packages`)

…toolbar_test and text_field_test (#12984) Unskips 5 tests across 2 `cupertino_ui` test files that were previously skipped on the web (`skip: isBrowser`) due to issues that have since been resolved (removal of the HTML renderer and support for `StrutStyle` in CanvasKit/Skwasm): - `packages/cupertino_ui/test/adaptive_text_selection_toolbar_test.dart`: Unskips 3 tests (flutter/flutter#108382 — closed) - `packages/cupertino_ui/test/text_field_test.dart`: Unskips 2 strut style tests (flutter/flutter#32243 — closed) Split out from flutter/flutter#193171 per flutter/flutter#188444. ## Pre-Review Checklist

auto-submit · 2026-09-22T22:52:08Z

autosubmit label was removed for flutter/flutter/193171, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

…ext_field_test (#12983) Unskips 5 tests across 2 `material_ui` test files that were previously skipped on the web (`skip: isBrowser`) due to issues that have since been resolved (support for `Path.combine` custom shapes and `StrutStyle` in CanvasKit/Skwasm): - `packages/material_ui/test/bottom_app_bar_test.dart`: Unskips 2 custom shape golden tests (flutter/flutter#44572 — closed; verified 99.8% pixel match locally on Chrome against the Linux Skia Gold baseline) - `packages/material_ui/test/text_field_test.dart`: Unskips 3 strut style tests (flutter/flutter#32243 — closed) Split out from flutter/flutter#193171 per flutter/flutter#188444. ## Pre-Review Checklist

auto-submit · 2026-09-23T18:25:18Z

autosubmit label was removed for flutter/flutter/193171, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

flutter-dashboard · 2026-09-23T19:22:16Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #193171 at sha eccaa09

…toolbar_test and text_field_test (flutter#12984) Unskips 5 tests across 2 `cupertino_ui` test files that were previously skipped on the web (`skip: isBrowser`) due to issues that have since been resolved (removal of the HTML renderer and support for `StrutStyle` in CanvasKit/Skwasm): - `packages/cupertino_ui/test/adaptive_text_selection_toolbar_test.dart`: Unskips 3 tests (flutter/flutter#108382 — closed) - `packages/cupertino_ui/test/text_field_test.dart`: Unskips 2 strut style tests (flutter/flutter#32243 — closed) Split out from flutter/flutter#193171 per flutter/flutter#188444. ## Pre-Review Checklist

…ext_field_test (flutter#12983) Unskips 5 tests across 2 `material_ui` test files that were previously skipped on the web (`skip: isBrowser`) due to issues that have since been resolved (support for `Path.combine` custom shapes and `StrutStyle` in CanvasKit/Skwasm): - `packages/material_ui/test/bottom_app_bar_test.dart`: Unskips 2 custom shape golden tests (flutter/flutter#44572 — closed; verified 99.8% pixel match locally on Chrome against the Linux Skia Gold baseline) - `packages/material_ui/test/text_field_test.dart`: Unskips 3 strut style tests (flutter/flutter#32243 — closed) Split out from flutter/flutter#193171 per flutter/flutter#188444. ## Pre-Review Checklist

flutter-dashboard Bot added the CICD Run CI/CD label Sep 22, 2026

gemini-code-assist Bot reviewed Sep 22, 2026

View reviewed changes

github-actions Bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages f: cupertino labels Sep 22, 2026

harryterkelsen added 2 commits September 22, 2026 13:47

Run dart format on the unskipped tests

d9bfeb8

Removing the trailing `skip:` argument lets `dart format` collapse these `testWidgets(...)` calls back into the standard trailing-closure style. TAG=agy CONV=2ef6722f-0cc3-4e2c-bfe0-769079846fee

flutter-dashboard Bot added the will affect goldens Changes to golden files label Sep 22, 2026

Revert frozen cupertino and material test changes (porting to `fl…

a765a03

…utter/packages`)

harryterkelsen changed the title ~~[web] Unskip 17 passing framework tests across cupertino, material, painting, and widgets~~ [web] Unskip 6 passing framework tests across painting and widgets Sep 22, 2026

This was referenced Sep 22, 2026

[material_ui] Unskip 5 passing web tests in bottom_app_bar_test and text_field_test flutter/packages#12983

Merged

[cupertino_ui] Unskip 5 passing web tests in adaptive_text_selection_toolbar_test and text_field_test flutter/packages#12984

Merged

github-actions Bot removed a: text input Entering text in a text field or keyboard related problems p: material_ui material_ui package in flutter/packages f: cupertino labels Sep 22, 2026

mdebbar approved these changes Sep 22, 2026

View reviewed changes

harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 22, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 22, 2026

harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2026

auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2026

Merge branch 'master' into unskip-web-tests-batch-1

eccaa09

harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2026

auto-submit Bot added this pull request to the merge queue Sep 23, 2026

Merged via the queue into flutter:master with commit 743740a Sep 23, 2026
23 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2026

engine-flutter-autoroll mentioned this pull request Sep 25, 2026

Roll Flutter from 4fcd90be0045 to adce6d64da8a (181 revisions) flutter/packages#13013

Closed

Navigation Menu

Repository navigation

[web] Unskip 6 passing framework tests across painting and widgets - #193171

[web] Unskip 6 passing framework tests across painting and widgets#193171
auto-submit[bot] merged 5 commits into
flutter:masterfrom
harryterkelsen:unskip-web-tests-batch-1

harryterkelsen commented Sep 22, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

github-actions Bot commented Sep 22, 2026

Uh oh!

flutter-dashboard Bot commented Sep 22, 2026

Uh oh!

auto-submit Bot commented Sep 22, 2026

Uh oh!

auto-submit Bot commented Sep 23, 2026

Uh oh!

flutter-dashboard Bot commented Sep 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

harryterkelsen commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

github-actions Bot commented Sep 22, 2026

Uh oh!

flutter-dashboard Bot commented Sep 22, 2026

Uh oh!

auto-submit Bot commented Sep 22, 2026

Uh oh!

auto-submit Bot commented Sep 23, 2026

Uh oh!

flutter-dashboard Bot commented Sep 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

harryterkelsen commented Sep 22, 2026 •

edited

Loading