Skip to content

Cleanup DDC SDK build targets - #193193

Merged
auto-submit[bot] merged 12 commits into
flutter:masterfrom
nshahan:new-build-targets
Sep 28, 2026
Merged

Cleanup DDC SDK build targets#193193
auto-submit[bot] merged 12 commits into
flutter:masterfrom
nshahan:new-build-targets

Conversation

@nshahan

@nshahan nshahan commented Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Replace the two existing DDC sdk.js build targets:

flutter/web_sdk:flutter_dartdevc_canvaskit_kernel_sdk_amd
flutter/web_sdk:flutter_dartdevc_canvaskit_kernel_sdk_ddcLibraryBundle

with new variants:

flutter/web_sdk:flutter_ddc_canary_sdk
flutter/web_sdk:flutter_ddc_stable_sdk

This removes the dart_sdk.js artifact built with the AMD module system flags. It is no longer supported and inaccessible from the flutter_tools CLI. Other PRs are in flight to delete the remaining test references to this module system that are no longer running.

This also prepares for the eventual flip of the DDC --canary flag default back to false. We are now building a dart_sdk.js artifact with the flag disabled.

Issue: #142060

Pre-launch Checklist

@nshahan nshahan added the CICD Run CI/CD label Sep 23, 2026
@github-actions github-actions Bot added tool Affects the "flutter" command-line tool. See also t: labels. engine flutter/engine related. See also e: labels. platform-web Web applications specifically team-web Owned by Web platform team labels Sep 23, 2026
@nshahan
nshahan marked this pull request as ready for review September 23, 2026 23:53
@nshahan
nshahan requested review from bkonyi and mdebbar September 23, 2026 23:53
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Sep 23, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Flutter Web SDK build configuration and tools to replace the AMD and DDC library bundle configurations with stable and canary DDC SDK configurations. The review feedback identifies critical issues where stable builds are incorrectly mapped to JS SDK or canary sourcemap artifacts instead of stable sourcemaps in _resolveDartSdkJsMapFile and _getSdkMapFile. Additionally, assertions requiring canaryFeatures for DDC module formats need to be removed as they will cause stable DDC builds to fail.

Comment thread packages/flutter_tools/lib/src/isolated/web_asset_server.dart Outdated
Comment thread packages/flutter_tools/lib/src/test/flutter_web_platform.dart
Comment thread packages/flutter_tools/lib/src/test/flutter_web_platform.dart Outdated
mdebbar
mdebbar reviewed Sep 24, 2026
View reviewed changes
Comment thread packages/flutter_tools/lib/src/isolated/web_asset_server.dart Outdated
Comment thread packages/flutter_tools/lib/src/test/flutter_web_platform.dart Outdated
Comment thread packages/flutter_tools/lib/src/web/compile.dart Outdated
@nshahan nshahan changed the title WIP creating new DDC SDK build targets Cleanup DDC SDK build targets Sep 24, 2026
@nshahan nshahan added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2026
@auto-submit

auto-submit Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/193193, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2026
@nshahan nshahan added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 25, 2026
@auto-submit

auto-submit Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/193193, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 25, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 25, 2026
@auto-submit

auto-submit Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/193193, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@nshahan nshahan added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 25, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 26, 2026
@auto-submit

auto-submit Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/193193, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@nshahan nshahan added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 28, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 28, 2026
@auto-submit

auto-submit Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/193193, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@nshahan nshahan mentioned this pull request Sep 28, 2026
Closed
1 of 4 tasks
@nshahan nshahan added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 28, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Sep 28, 2026
Merged via the queue into flutter:master with commit 929df56 Sep 28, 2026
29 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 28, 2026
This was referenced Sep 29, 2026
Closed
Closed
Merged
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Sep 29, 2026
@engine-flutter-autoroll
Roll Flutter from c5a061b18fa2 to 55b8f88e855f (8 revisions) (#13066)
105b077 
flutter/flutter@c5a061b...55b8f88

2026-09-29 [email protected] [Android 17] Added Android 17 device to Firebase tests (flutter/flutter#193251)
2026-09-29 [email protected] [engine] Fix remaining `unawaited_futures` lints (flutter/flutter#193508)
2026-09-29 [email protected] shell: Rename first-frame tests AddFirstFrameCallback* (flutter/flutter#193418)
2026-09-28 [email protected] Enable `unawaited_futures` lint across the Flutter repository (flutter/flutter#193125)
2026-09-28 [email protected] Upgrade flutter/flutter to Roblectric 4.17 (flutter/flutter#193369)
2026-09-28 [email protected] [engine] Decode animation frames with alpha after an opaque first frame (flutter/flutter#193113)
2026-09-28 [email protected] Allow macOS tests to use macOS 15 or 26 (flutter/flutter#193317)
2026-09-28 [email protected] Cleanup DDC SDK build targets (flutter/flutter#193193)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@sigurdm sigurdm mentioned this pull request Oct 8, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdebbar mdebbar mdebbar approved these changes
@bkonyi bkonyi bkonyi approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels. platform-web Web applications specifically team-web Owned by Web platform team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nshahan @mdebbar @bkonyi